singhpk234 commented on code in PR #6378:
URL: https://github.com/apache/iceberg/pull/6378#discussion_r1042869209
##
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java:
##
@@ -225,25 +225,40 @@ public void close() {
LOG.info("Closing commit s
hililiwei commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042990145
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -104,11 +105,38 @@ public static Schema convert(Schema baseSchema,
TableSchem
hililiwei commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042986024
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implemen
hililiwei commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042976674
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implemen
hililiwei commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042975474
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -104,11 +105,38 @@ public static Schema convert(Schema baseSchema,
TableSchem
ajantha-bhat commented on code in PR #6376:
URL: https://github.com/apache/iceberg/pull/6376#discussion_r1042957469
##
docs/spark-procedures.md:
##
@@ -493,6 +493,39 @@ CALL spark_catalog.system.add_files(
)
```
+### `register_table`
+
+Creates a catalog entry for a metadata
ajantha-bhat commented on code in PR #6376:
URL: https://github.com/apache/iceberg/pull/6376#discussion_r1042956811
##
docs/spark-procedures.md:
##
@@ -493,6 +493,39 @@ CALL spark_catalog.system.add_files(
)
```
+### `register_table`
+
+Creates a catalog entry for a metadata
ajantha-bhat commented on PR #6380:
URL: https://github.com/apache/iceberg/pull/6380#issuecomment-1342089959
There won't be any release from the 0.14.x branch. So, this backport is not
really required.
Keeping the fix in the master branch is enough. The next 1.2.0 release will
be fro
ajantha-bhat commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1342088608
There won't be any release from the 1.0.x branch. So, this backport is not
really required.
Keeping the fix in the master branch is enough. The next 1.2.0 release will
be from
rajarshisarkar commented on PR #6376:
URL: https://github.com/apache/iceberg/pull/6376#issuecomment-1342084915
@RussellSpitzer @ajantha-bhat I have made the changes. Please review once
you get time.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
hililiwei commented on issue #6320:
URL: https://github.com/apache/iceberg/issues/6320#issuecomment-1342084322
+1 on documenting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
rajarshisarkar commented on code in PR #6376:
URL: https://github.com/apache/iceberg/pull/6376#discussion_r1042948979
##
docs/spark-procedures.md:
##
@@ -493,6 +493,37 @@ CALL spark_catalog.system.add_files(
)
```
+### `register_table`
+
+Creates a catalog entry for a metada
stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042936150
##
docs/flink-getting-started.md:
##
@@ -683,7 +683,58 @@ env.execute("Test Iceberg DataStream");
OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the
stevenzwu commented on PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#issuecomment-1342074689
@hililiwei I think we are very close now. thanks for patiently addressing my
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042945771
##
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##
@@ -427,25 +386,25 @@ public Builder maxPlanningSnapshotCount(int
newMaxPlann
stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042944268
##
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkReadOptions.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042942293
##
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkReadOptions.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042938535
##
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkConfParser.java:
##
@@ -21,20 +21,23 @@
import java.util.List;
import java.util.Map;
import java.u
stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042936150
##
docs/flink-getting-started.md:
##
@@ -683,7 +683,58 @@ env.execute("Test Iceberg DataStream");
OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the
stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042929386
##
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##
@@ -335,8 +365,30 @@ public Builder exposeLocality(boolean
newExposeLocalit
szehon-ho commented on code in PR #6365:
URL: https://github.com/apache/iceberg/pull/6365#discussion_r1042897403
##
core/src/main/java/org/apache/iceberg/PositionDeletesTable.java:
##
@@ -0,0 +1,366 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
hililiwei commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042860307
##
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##
@@ -335,8 +365,30 @@ public Builder exposeLocality(boolean
newExposeLocalit
hililiwei commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042859375
##
docs/flink-getting-started.md:
##
@@ -683,7 +683,58 @@ env.execute("Test Iceberg DataStream");
OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the
hililiwei commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042859883
##
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSourceConfig.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation
hililiwei commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042859375
##
docs/flink-getting-started.md:
##
@@ -683,7 +683,58 @@ env.execute("Test Iceberg DataStream");
OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the
SHuixo commented on issue #6307:
URL: https://github.com/apache/iceberg/issues/6307#issuecomment-1341883623
@luoyuxia In the past two days, the above maven project code has been
repackaged, iceberg is still using version 0.14.1, the results of the run are
very different from the previous a
yegangy0718 opened a new pull request, #6382:
URL: https://github.com/apache/iceberg/pull/6382
This PR is created as part of issue
https://github.com/apache/iceberg/issues/6303 and project
https://github.com/apache/iceberg/projects/27
In this PR, we focus on
bin packing based on
rdblue commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341825580
Looks like @RussellSpitzer, @szehon-ho, and @aokolnychyi are looking at this
and have noted the issues with v1 tables.
I think that this is risky because not all v1 readers will use
github-actions[bot] closed issue #4743:
flink1.14.4+iceberg0.13.1+hive-metastore3.1.2+minio（S3） error！
URL: https://github.com/apache/iceberg/issues/4743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on issue #4192:
URL: https://github.com/apache/iceberg/issues/4192#issuecomment-1341784906
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #4743:
URL: https://github.com/apache/iceberg/issues/4743#issuecomment-1341784868
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #4862: Webpage breaks at medium width
URL: https://github.com/apache/iceberg/issues/4862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on issue #4862:
URL: https://github.com/apache/iceberg/issues/4862#issuecomment-1341784828
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #5004:
URL: https://github.com/apache/iceberg/issues/5004#issuecomment-1341784764
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042799420
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/data/StructRowData.java:
##
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042794568
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -177,14 +177,17 @@ public CloseableIterable rows() {
Set readableMetricsIds =
TypeUtil.g
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042794414
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -177,14 +177,17 @@ public CloseableIterable rows() {
Set readableMetricsIds =
TypeUtil.g
ayushtkn commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341771756
Went through the discussion, One good thing is it has lastPartitionId, and
it is used for next allocations, so that should prevent any old table breaking
due to this change.
I cou
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042792168
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -104,11 +105,38 @@ public static Schema convert(Schema baseSchema,
TableSchem
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042787664
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -104,11 +105,38 @@ public static Schema convert(Schema baseSchema,
TableSchem
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042779986
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -104,11 +105,38 @@ public static Schema convert(Schema baseSchema,
TableSchem
haizhou-zhao commented on PR #6324:
URL: https://github.com/apache/iceberg/pull/6324#issuecomment-1341735907
Hey folks, comments from last round of review all taken and implemented.
Specifically, on one comment:
@gaborkaszab @szehon-ho I removed support for changing ownership for ta
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042777490
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -295,6 +299,161 @@ private static void assertEquals(
}
}
+ public stati
szehon-ho commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042776458
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implemen
szehon-ho commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042775511
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -177,14 +177,17 @@ public CloseableIterable rows() {
Set readableMetricsIds =
TypeUtil.g
szehon-ho commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341722542
And some in depth discussion : https://github.com/apache/iceberg/issues/280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042762795
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##
@@ -140,15 +142,25 @@ public Catalog catalog() {
return icebergCatalog;
}
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042762795
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##
@@ -140,15 +142,25 @@ public Catalog catalog() {
return icebergCatalog;
}
szehon-ho commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341718987
Nice catch, didnt realize it would throw an exception if its not sequential.
Hm Im not 100% sure atm why we need to throw an exception in this case versus
start id assignment from last
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042761243
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implemen
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042762795
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##
@@ -140,15 +142,25 @@ public Catalog catalog() {
return icebergCatalog;
}
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042761243
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implemen
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042759545
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implemen
rdblue merged PR #6308:
URL: https://github.com/apache/iceberg/pull/6308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
rdblue commented on PR #6308:
URL: https://github.com/apache/iceberg/pull/6308#issuecomment-1341648673
Thanks, @Fokko!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042723978
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -177,14 +177,17 @@ public CloseableIterable rows() {
Set readableMetricsIds =
TypeUtil.g
stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042716897
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implemen
sunchao commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042716054
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042710634
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042708006
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042708006
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
sunchao commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042705070
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
shardulm94 commented on PR #6327:
URL: https://github.com/apache/iceberg/pull/6327#issuecomment-1341617676
@aokolnychyi Mind taking a look as well? This PR paves the way to fix
https://github.com/apache/iceberg/issues/3192
--
This is an automated message from the Apache Git Service.
To re
RussellSpitzer commented on PR #6378:
URL: https://github.com/apache/iceberg/pull/6378#issuecomment-1341617685
@singhpk234 could you please take a look as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
InvisibleProgrammer commented on issue #6381:
URL: https://github.com/apache/iceberg/issues/6381#issuecomment-1341615361
Yes, it is enough to put the site into the left half of an average MacBook
screen.
--
This is an automated message from the Apache Git Service.
To respond to the messa
RussellSpitzer commented on issue #6381:
URL: https://github.com/apache/iceberg/issues/6381#issuecomment-1341612566
I just noticed this, and the width doesn't have to be that small to get it
to vanish, like 140 characters by my eyeball estimate?
--
This is an automated message from the Ap
RussellSpitzer commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042691741
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Fou
sunchao commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042689202
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
sunchao commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042685029
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
RussellSpitzer commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042682299
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Fou
sunchao commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042680221
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
RussellSpitzer commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341588733
Yeah I think the hasSequential code needs to be modified. Otherwise I can
have a table whose first spec id is 1000 before this patch, then after this
patch I try to add another fie
InvisibleProgrammer opened a new issue, #6381:
URL: https://github.com/apache/iceberg/issues/6381
### Feature Request / Improvement
The side menu completely disappears at small width. I put some screen shots
here as an example.
https://user-images.githubusercontent.com/1486749/206
ayushtkn commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341587366
Thanx folks, Just thinking about the sequentialId check, why it needs to
rely on the start id, Does changing that check like that help
```
static boolean hasSequentialIds(Partitio
gaborkaszab commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341585151
I also checked if PartitionSpec.hasSequentialIds() could cause any issues
with existing tables. The first use that you linked seems to be the case when
we re-write the table metadata
RussellSpitzer commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042670413
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Fou
InvisibleProgrammer commented on PR #6337:
URL: https://github.com/apache/iceberg/pull/6337#issuecomment-1341580364
Hi, @pvary
Ports to:
- 1.0.x: https://github.com/apache/iceberg/pull/6379
- 0.14.x: https://github.com/apache/iceberg/pull/6380
--
This is an automated
InvisibleProgrammer commented on PR #6380:
URL: https://github.com/apache/iceberg/pull/6380#issuecomment-1341579026
0.14.x port of https://github.com/apache/iceberg/pull/6337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
InvisibleProgrammer commented on PR #6379:
URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1341578681
1.0.x port of https://github.com/apache/iceberg/pull/6337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
InvisibleProgrammer opened a new pull request, #6380:
URL: https://github.com/apache/iceberg/pull/6380
Docs: Update Iceberg Hive documentation
(cherry picked from commit 5b1505378414295476a73e07aca65fdb1a29da7d)
--
This is an automated message from the Apache Git Service.
To respon
sunchao commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042667583
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042664536
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042664536
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
RussellSpitzer commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042661088
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Fou
sunchao commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042659356
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
InvisibleProgrammer opened a new pull request, #6379:
URL: https://github.com/apache/iceberg/pull/6379
Docs: Update Iceberg Hive documentation - 1.0.x
(cherry picked from commit 5b1505378414295476a73e07aca65fdb1a29da7d)
--
This is an automated message from the Apache Git Service.
T
RussellSpitzer commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341567681
The area I'm worried about now, is
https://github.com/apache/iceberg/blob/29187353e18a0ec477f638a00353340f24fb704e/api/src/main/java/org/apache/iceberg/PartitionSpec.java#L602-L
aokolnychyi commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341564011
I'd be really careful with this change. Even though the spec may not mention
it directly, that was always our assumption. I will need to take a closer look
in a bit.
--
This is an
RussellSpitzer commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341558435
Double checking the relevant part of the spec and we never actually demand
that partition id's start at 1000. So I think we are in the clear hear from a
backwards compatibility sta
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042649365
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042649365
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
TuroczyX commented on PR #6369:
URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341545626
@szehon-ho https://www.youtube.com/watch?v=rR4n-0KYeKQ about the LGTM :)
Just for fun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
TuroczyX commented on issue #6368:
URL: https://github.com/apache/iceberg/issues/6368#issuecomment-1341544917
Thanks for the update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042644906
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042644545
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042644217
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -215,11 +225,12 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
* t
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042643130
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042635649
##
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042632953
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkPartitioningAwareScan.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Software Foun
aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042631790
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##
@@ -42,4 +42,9 @@ private SparkSQLProperties() {}
// Controls whether to c
1 - 100 of 193 matches
Mail list logo
