ayushtkn commented on PR #6369: URL: https://github.com/apache/iceberg/pull/6369#issuecomment-1341771756
Went through the discussion, One good thing is it has lastPartitionId, and it is used for next allocations, so that should prevent any old table breaking due to this change. I couldn't figure out from where 1000 came in, it looks like `just like that`, And I don't feel if sequential is required, it should specifically start from the 'startId' either 1K or 10K The reason for sequential isn't mentioned over there, I need to explore a bit more around that area, but there was a test which was checking the allocation should start from startId not just sequential also(Why?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
