stevenzwu commented on code in PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#discussion_r1042945771
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -427,25 +386,25 @@ public Builder maxPlanningSnapshotCount(int
newMaxPlanningSnapshotCount) {
return this;
}
- public Builder fromProperties(Map<String, String> properties) {
- Configuration config = new Configuration();
- properties.forEach(config::setString);
-
- return this.useSnapshotId(config.get(SNAPSHOT_ID))
- .caseSensitive(config.get(CASE_SENSITIVE))
- .asOfTimestamp(config.get(AS_OF_TIMESTAMP))
- .startingStrategy(config.get(STARTING_STRATEGY))
- .startSnapshotTimestamp(config.get(START_SNAPSHOT_TIMESTAMP))
- .startSnapshotId(config.get(START_SNAPSHOT_ID))
- .endSnapshotId(config.get(END_SNAPSHOT_ID))
- .splitSize(config.get(SPLIT_SIZE))
- .splitLookback(config.get(SPLIT_LOOKBACK))
- .splitOpenFileCost(config.get(SPLIT_FILE_OPEN_COST))
- .streaming(config.get(STREAMING))
- .monitorInterval(config.get(MONITOR_INTERVAL))
- .nameMapping(properties.get(DEFAULT_NAME_MAPPING))
- .includeColumnStats(config.get(INCLUDE_COLUMN_STATS))
- .maxPlanningSnapshotCount(config.get(MAX_PLANNING_SNAPSHOT_COUNT));
+ public Builder fromProperties(
Review Comment:
what about `resolveConfig`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
