hililiwei commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1042986024
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -223,34 +225,28 @@ ManifestFile manifest() {
static class ContentFileStructWithMetrics implements StructLike {
private final StructLike fileAsStruct;
private final MetricsUtil.ReadableMetricsStruct readableMetrics;
- private final int expectedSize;
+ private final int position;
ContentFileStructWithMetrics(
- int expectedSize,
- StructLike fileAsStruct,
- MetricsUtil.ReadableMetricsStruct readableMetrics) {
+ int position, StructLike fileAsStruct,
MetricsUtil.ReadableMetricsStruct readableMetrics) {
this.fileAsStruct = fileAsStruct;
this.readableMetrics = readableMetrics;
- this.expectedSize = expectedSize;
+ this.position = position;
}
@Override
public int size() {
- return expectedSize;
+ return position;
}
@Override
public <T> T get(int pos, Class<T> javaClass) {
- int lastExpectedIndex = expectedSize - 1;
- if (pos < lastExpectedIndex) {
+ if (pos < position) {
return fileAsStruct.get(pos, javaClass);
- } else if (pos == lastExpectedIndex) {
+ } else if (pos == position) {
return javaClass.cast(readableMetrics);
} else {
- throw new IllegalArgumentException(
Review Comment:
When pos is over the size limit, `fileAsStruct.get` method will throw an
exception, we do not need to add Preconditions check, refer to the
implementation of other `get` methods, I think this is the general way of it,
unless we want to return a specific value, such as `null`, if it is over the
limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
