Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-11 Thread Fabian Groffen
On 11-09-2013 10:51:22 +0200, Gilles Dartiguelongue wrote: > > > shouldn't that be EROOT ? > > > > and ED in that case too > > Do we still use that in EAPI > 3 ? EROOT = ROOT + EPREFIX ED = D + EPREFIX Unless I misunderstand your question, that means "yes, we do" to me. Fabian -- Fabian Gro

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-10 Thread Gilles Dartiguelongue
Le mardi 10 septembre 2013 à 17:10 +0200, Fabian Groffen a écrit : > On 10-09-2013 06:22:38 -0400, Ian Stakenvicius wrote: > > > pkg_preinst() { > > >gnome2_gdk_pixbuf_savelist > > > + > > > + # Make sure loaders.cache belongs to gdk-pixbuf alone > > > + local cache="usr/$(get_l

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-10 Thread Fabian Groffen
On 10-09-2013 06:22:38 -0400, Ian Stakenvicius wrote: > > pkg_preinst() { > >gnome2_gdk_pixbuf_savelist > > + > > + # Make sure loaders.cache belongs to gdk-pixbuf alone > > + local cache="usr/$(get_libdir)/${PN}-2.0/2.10.0/loaders.cache" > > + > > + if [[ -e ${ROOT}${cach

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-10 Thread Ian Stakenvicius
On 2013-09-09, at 7:31 PM, Alex Xu wrote: > On 09/09/13 08:29 PM, Gilles Dartiguelongue wrote: >> >> Index: gdk-pixbuf-2.28.2.ebuild >> === >> RCS file: >> /var/cvsroot/gentoo-x86/x11-libs/gdk-pixb

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-09 Thread Alex Xu
On 09/09/13 08:29 PM, Gilles Dartiguelongue wrote: > > Index: gdk-pixbuf-2.28.2.ebuild > === > RCS file: > /var/cvsroot/gentoo-x86/x11-libs/gdk-pixbuf/gdk-pixbuf-2.28.2.ebuild,v > retriev

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-09 Thread hasufell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/10/2013 02:29 AM, Gilles Dartiguelongue wrote: > As a follow up to this discussion, I came with the attached patch. > It appears to work ok for regular merges and binpkg merges with > FEATURES="collision-protect". > > Per my reading of PMS it d

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-09 Thread Gilles Dartiguelongue
As a follow up to this discussion, I came with the attached patch. It appears to work ok for regular merges and binpkg merges with FEATURES="collision-protect". Per my reading of PMS it does not appear to violate anything so I guess it is ok. -- Gilles Dartiguelongue Gentoo Index: gdk-pi

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Michał Górny
Dnia 2013-09-04, o godz. 22:19:30 Gilles Dartiguelongue napisał(a): > Le mercredi 04 septembre 2013 à 15:48 -0400, Ian Stakenvicius a écrit : > > On 04/09/13 03:44 PM, Gilles Dartiguelongue wrote: > > > Le mercredi 04 septembre 2013 à 15:23 -0400, Ian Stakenvicius a > > > écrit : [snip] > > >> >

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/09/13 03:44 PM, Gilles Dartiguelongue wrote: > Le mercredi 04 septembre 2013 à 15:23 -0400, Ian Stakenvicius a > écrit : [snip] >> >> By gdk-pixbuf.cache , you mean the 'loaders.cache' file that the >> eclass is now continuously updating? Wh

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/09/13 03:48 PM, Ian Stakenvicius wrote: > No, it still does collide that first time if > FEATURES="collision-protect" is enabled. In fact, I do not > believe there is (by design) any way for this ebuild to 'take > ownership' of a file it doe

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Gilles Dartiguelongue
Le mercredi 04 septembre 2013 à 15:23 -0400, Ian Stakenvicius a écrit : > On 04/09/13 02:57 PM, Gilles Dartiguelongue wrote: [snip] > > Is there any other solution or is there any other point that would > > move the balance from one solution to another ? > > > > This solution would also be applied

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/09/13 04:19 PM, Gilles Dartiguelongue wrote: > Le mercredi 04 septembre 2013 à 15:48 -0400, Ian Stakenvicius a > écrit : >> >> You had FEATURES="collision-protect" enabled" or the default >> FEATURES="protect-owned" ? > > the default, but s

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Gilles Dartiguelongue
Le mercredi 04 septembre 2013 à 15:48 -0400, Ian Stakenvicius a écrit : > On 04/09/13 03:44 PM, Gilles Dartiguelongue wrote: > > Le mercredi 04 septembre 2013 à 15:23 -0400, Ian Stakenvicius a > > écrit : [snip] > >> > >> By gdk-pixbuf.cache , you mean the 'loaders.cache' file that the > >> eclas

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Zac Medico
On 09/04/2013 12:44 PM, Gilles Dartiguelongue wrote: > Le mercredi 04 septembre 2013 à 15:23 -0400, Ian Stakenvicius a écrit : >> If you want to do that *and* maintain whatever is currently in that >> file, you can use the trick sys-apps/openrc used to do: in >> pkg_preinst, copy the system file (

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Michał Górny
Dnia 2013-09-04, o godz. 20:57:41 Gilles Dartiguelongue napisał(a): > One last point to handle, how to migrate gdk-pixbuf.cache so that it is > owned by the ebuild ? > > I've discussed this with Michał and it seems two options are possible. > > 1. rm the file on the filesystem in pkg_preinst in

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/09/13 02:57 PM, Gilles Dartiguelongue wrote: > One last point to handle, how to migrate gdk-pixbuf.cache so that > it is owned by the ebuild ? > > I've discussed this with Michał and it seems two options are > possible. > > 1. rm the file on

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-04 Thread Gilles Dartiguelongue
One last point to handle, how to migrate gdk-pixbuf.cache so that it is owned by the ebuild ? I've discussed this with Michał and it seems two options are possible. 1. rm the file on the filesystem in pkg_preinst in gdk-pixbuf ebuild pros: - works immediately without fiddling with profiles (see

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-01 Thread Gilles Dartiguelongue
Updated diffs + gdk-pixbuf handling. Tested with success locally. -- Gilles Dartiguelongue Gentoo Index: gnome2.eclass === RCS file: /var/cvsroot/gentoo-x86/eclass/gnome2.eclass,v retrieving revision 1.122 diff -u -B -r1.122 gnome2

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-01 Thread Michał Górny
Dnia 2013-09-01, o godz. 13:29:27 Gilles Dartiguelongue napisał(a): > > Le samedi 31 août 2013 à 18:44 +0200, Gilles Dartiguelongue a écrit : > > Le samedi 31 août 2013 à 16:49 +0200, Michał Górny a écrit : > > > Dnia 2013-08-31, o godz. 15:00:43 > > > Gilles Dartiguelongue napisał(a): > > > >

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-09-01 Thread Gilles Dartiguelongue
Le samedi 31 août 2013 à 18:44 +0200, Gilles Dartiguelongue a écrit : > Le samedi 31 août 2013 à 16:49 +0200, Michał Górny a écrit : > > Dnia 2013-08-31, o godz. 15:00:43 > > Gilles Dartiguelongue napisał(a): > > > > > Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit : > > > > > +

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-08-31 Thread Gilles Dartiguelongue
Le samedi 31 août 2013 à 16:49 +0200, Michał Górny a écrit : > Dnia 2013-08-31, o godz. 15:00:43 > Gilles Dartiguelongue napisał(a): > > > Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit : > > > > + cat "${tmp_file}" > > > > > "${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loa

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-08-31 Thread Michał Górny
Dnia 2013-08-31, o godz. 15:00:43 Gilles Dartiguelongue napisał(a): > Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit : > > > + cat "${tmp_file}" > > > > "${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache" > > > > Why not mv or cp? Also you need '|| die' here since 'cat'

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-08-31 Thread Alex Xu
On 31/08/13 09:00 AM, Gilles Dartiguelongue wrote: >> > And please ensure to remove it in pkg_postrm() when last version >> > of gdk-pixbuf is unmerged. > I am not clear on this last sentence. Could you reformulate it please ? Ensure that the loaders.cache file is removed correctly when all versio

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-08-31 Thread Gilles Dartiguelongue
Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit : > Dnia 2013-08-31, o godz. 13:07:41 > Gilles Dartiguelongue napisał(a): > > > +# @FUNCTION: gnome2_gdk_pixbuf_savelist > > +# @DESCRIPTION: > > +# Find if there is any gdk-pixbuf loader to install and save the list in > > +# GNOME2_ECLA

Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-08-31 Thread Michał Górny
Dnia 2013-08-31, o godz. 13:07:41 Gilles Dartiguelongue napisał(a): > +# @FUNCTION: gnome2_gdk_pixbuf_savelist > +# @DESCRIPTION: > +# Find if there is any gdk-pixbuf loader to install and save the list in > +# GNOME2_ECLASS_GDK_PIXBUF_LOADERS variable. > +# This function should be called from pk

[gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update

2013-08-31 Thread Gilles Dartiguelongue
As described here: https://bugs.gentoo.org/show_bug.cgi?id=483128 This is a very lightweight patch to support the few packages that provide gdk pixbuf loaders. The ones I know of are: gdk-pixbuf itself, librsvg and libopenraw and emul-gtklibs but more could be missing simply because they do not r