RFA; MN10300: Fix AM33 clzsi2 pattern

of leading zeros. The attached patch fixes both of these problems and shaves about 200 unexpected failures off the gcc testsuite for the AM33 or AM33_2 multilibs. OK to apply ? Cheers Nick gcc/ChangeLog 2011-06-25 Nick Clifton * config/mn10300/mn10300.md (clzsi2): Remove

Re: RFA; MN10300: Fix AM33 clzsi2 pattern

K to apply ? Cheers Nick gcc/ChangeLog 2011-06-26 Nick Clifton * mn10300.md (clzsi2): Use XOR after BSCH to convert bit position of highest bit set into a count of the high zero bits. Index: gcc/config/mn10300/mn10300.md ===

Commit: Add support for V850 variants to libgcc

Hi Guys, I am checking in the patch below to add support for V850 variant architectures to the libgcc/config.host file. Cheers Nick libgcc/ChangeLog 2011-06-28 Nick Clifton * config.host: Recognize all V850 variants. Index: libgcc/config.host

MN10330: Do not use linker relaxation and incremental linking together

obvious fix for the problem. Tested without regressions on an mn10300-elf toolchain. Cheers Nick gcc/ChangeLog 2011-06-28 Nick Clifton * config/mn10300/mn10300.h (LINK_SPEC): Do not use linker relaxation when performing an incremental link. Index: gcc/config/mn10300

Commit: Define __v850e__ when compiling for the V850E.

Hi Guys, I am applying the following patch to the V850 backend. It adds a preprocessor definition of the symbol __v850e__ when compiling for the V850E architecture variant. Cheers Nick gcc/ChangeLog 2011-06-30 Nick Clifton * config/v850/v850.h (CPP_SPEC): Define __v850e__

Re: RFA: patch to fix broken FRV target

Hi Vladimir, 2011-07-19 Vladimir Makarov * config/frv/frv.c (frv_register_move_cost): Define explicitly costs for subclasses of GR_REGS. Approved - please apply. Cheers Nick

tic6c-elf toolchain fails to build in FSF mainline

his please ? Cheers Nick

Commit: 4.5: Fix typo in rx.c

Hi Guys, I am applying the patch below to the 4.5 branch to fix a typo in the code to check the setpsw builtin. Cheers Nick gcc/ChangeLog 2011-07-29 Nick Clifton * config/rx/rx.c (rx_expand_builtin): Fix typo checking the setpsw builtin. Index: gcc/config/rx/rx.c

RX: Do not use SMOVF insn to move blocks of volatile memory.

when volatile pointers are involved. In this case gcc will be forced to use another method to copy the data, most likely a loop of byte loads and stores. Cheers Nick PS. I am not applying the patch to the 4.6 branch since it is already present there. gcc/ChangeLog 2011-04-13 Nick Cl

Re: [PATCH] use build_function_type_list in the frv backend

Hi Nathan, * config/frv/frv.c (frv_init_builtins): Delete `endlink' variable. Call builtin_function_type_list instead of builtin_function_type. (UNARY, BINARY, TRINARY, QUAD): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH] use build_function_type_list in the iq2000 backend

Hi Nathan, * config/iq2000/i2000.c (iq2000_init_builtins): Call build_function_type_list instead of build_function_type. Delete `endlink' variable. Approved - please apply. Cheers Nick

Re: [PATCH] use build_function_type_list in the stormy16 backend

Hi Nathan, * config/stormy16/stormy16 (xstormy16_init_builtins): Call build_function_type_list instead of build_function_type. Rearrange initialization of `args' to do so. Approved - please apply. Cheers Nick

Re: Ping^3 Re: Target header etc. cleanup patch

mes [(int) COUNT_OF_GHS_SECTION_KINDS]; +extern tree GHS_default_section_names [(int) COUNT_OF_GHS_SECTION_KINDS]; +extern tree GHS_current_section_names [(int) COUNT_OF_GHS_SECTION_KINDS]; Approved. Cheers Nick

Commit: Fix MCore REGNO_REG_CLASS macro

Hi Guys, I am applying the patch below to fix the REGNO_REG_CLASS macro for the MCore backend so that it will not try to index beyond the end of the regno_reg_class array. This was causing a segmentation fault whilst building the MCore toolchain. Cheers Nick gcc/ChangeLog 2011-04-27

Commit: FRV: Remove duplicate register classes

Hi Guys, I am applying the patch below to remove the duplicate register classes from the FRV backend. This was causing problems with the IRA initialization code. Cheers Nick gcc/ChangeLog 2011-04-27 Nick Clifton * config/frv/frv.h (enum reg_class): Delete EVEN_ACC_REGS

Commit: RX: Fix some gcc testsuite failures

/pack.c Cheers Nick gcc/testsuite/ChangeLog 2011-04-27 Nick Clifton * gcc.dg/20020312-2.c: Add definition for RX. * lib/target-supports.exp (add_options_for_ieee): Use -mnofpu option with RX targets. * gcc.target/rx/pack.c: Replace C++ style // comments with

Re: PING: ARM definition of array_mode_supported_p

Hi Richard, Ping for the ARM-specific parts of this patch: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01752.html ARM part approved. Cheers Nick

Re: Ping^4 Re: Target header etc. cleanup patch

ve no objections to removing the use of Cstar, it was just a syntactic shorthand, and not a very nice one at that. If you do not get a response from Jeff or Alex you might like to ping rth, as he has been actively reviewing my recent MN10300 patches. Cheers Nick

Re: RFA: MN10300: Add support for SETLB and Lcc instructions

panning multiple blocks could be supported, but I would like to leave that for a future patch rather than trying to get it all working now. Cheers Nick mn10300.setlb.patch.4 Description: Unix manual page

RX: Add jump and loop alignment

stalls whilst the instruction fetch stage fills the pipeline. Cheers Nick gcc/ChangeLog 2011-05-10 DJ Delorie * config/rx/rx.h (JUMP_ALIGN, LABEL_ALIGN, LOOP_ALIGN): Define. (LABEL_ALIGN_AFTER_BARRIER): Pass label to rx_align_for_label * config/rx/rx.c

RX: Adjust memory_move_cost

Hi Guys, I am applying the patch below to improve the rx_memory_move_cost function in the RX backend. This patch is already in the 4.5 branch and mainline, but was omitted from the 4.6 branch. Cheers Nick gcc/ChangeLog 2011-05-10 Nick Clifton * config/rx/rx.c

RX: 4.6 branch: Obvious fixes

Hi Guys, I am applying the patch below to the RX backend on the 4.6 branch. It fixes several small, obvious bugs, as described in the changelog. Cheers Nick gcc/ChangeLog 2011-05-12 Nick Clifton * config/rx/rx.h (HAVE_PRE_DECREMENT): Fix typo. * config/rx/rx.c

RX: mainline: Fix obvious bugs

Hi Guys, I am applying the patch below to fix some small, obvious problems with the RX backend in the mainline sources. Cheers Nick gcc/ChangeLog 2011-05-12 DJ Delorie Nick Clifton * config/rx/rx.h (HAVE_PRE_DECREMENT): Fix typo. * config/rx/rx.c

RX: Add TARGET_BUILTIN_DECL

Hi Guys, I am checking in this patch, created by DJ Delorie, to add TARGET_BUILTIN_DECL to the RX backend. Cheers Nick gcc/ChangeLog 2011-05-12 DJ Delorie (rx_builtins): New arrays - holds builtin functions. (ADD_RX_BUILTIN1, ADD_RX_BUILTIN2, ADD_RX_BUILTIN3): Install

RX: Fix thinkos in previous tidy up

Hi Guys, When I applied my RX tidy up patch yesterday I forgot to rebuild the toolchain and thus missed a couple of thinkos with my rename of the rx_legitimate_constant_p function. I therefore applying the patch below to fix this problem. Cheers Nick gcc/ChangeLog 2011-05-13 Nick

Commit: RX: Add peepholes for move followed by compare

the two instructions with a single addition instruction. The addition does not actually do anything since the value being added is zero, but as a side effect it moves the register and performs the comparison. Cheers Nick gcc/ChangeLog 2011-05-17 Kazuhio Inaoka Nick Clifton

Commit: RX: Add peepholes to remove redundant extensions

lowed by a register to register extension. The peepholes match these cases and delete the unnecessary extension where possible. Cheers Nick gcc/ChangeLog 2011-05-17 Nick Clifton * config/rx/rx.md: Add peephole to remove redundant extensions after loads. Index: gcc/conf

Commit: RX: Fix predicates for restricted memory patterns

replacing memory_operand with rx_restricted_mem_operand. Cheers Nick gcc/ChangeLog 2011-05-17 Nick Clifton * config/rx/rx.md (bitset_in_memory): Use rx_restricted_mem_operand. (bitinvert_in_memory): Likewise. (bitclr_in_memory): Likewise. Index: gcc/config/rx

Commit: RX: Include cost of register moving in the cost of register loading.

secondary cost. Cheers Nick gcc/ChangeLog 2011-05-17 Nick Clifton * config/rx/rx.c (rx_memory_move_cost): Include cost of register moves. Index: gcc/config/rx/rx.c === --- gcc/config/rx/rx.c (revision 173815) +++ gcc

RFA: MN10300: Add TLS support

Hi Richard, Hi Jeff, Hi Alex, Here is another MN10300 patch. This ones adds support for TLS. I must confess that I did not actually write this code - DJ did - but I have been asked to submit it upstream, so here goes: OK to apply ? Cheers Nick gcc/ChangeLog 2011-05-17 DJ Delorie

Re: [4.7] Avoid global state in m32r_handle_option

Hi Joseph, Tested building cc1 and xgcc for cross to m32r-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. No objections - please commit. Cheers Nick

Re: [4.7] Avoid global state in iq2000_handle_option

Hi Joseph, Tested building cc1 and xgcc for cross to iq2000-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. No objections - please commit. Cheers Nick

Re: [STORMY16] Hookize PRINT_OPERAND and TARGET_PRINT_OPERAND_ADDRESS

, xstormy16_print_operand_address): Make static. (TARGET_PRINT_OPERAND, TARGET_PRINT_OPERAND_ADDRESS): Define. Approved - please apply. Cheers Nick

Re: RFA: MN10300: Add support for SETLB and Lcc instructions

ation, but I must have gotten something wrong. Any pointers on how to fix this are greatly appreciated. Cheers Nick gcc/ChangeLog 2011-03-08 Nick Clifton * config/mn10300/mn10300.c: Include cfgloop.h. (DUMP): New macro. (mn10300_insert_setlb_lcc): New function. Inse

Re: [4.7] Avoid global state in v850_handle_option

Hi Joseph, Tested building cc1 and xgcc for cross to v850-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. No objections - please apply. 2011-03-07 Joseph Myers * config/v850/v850-opts.h: New. * config/v850/v850.c (small_memory): Replace wi

RX: Fixing latency timings for BSET and BLCR insns

Hi Guys, I am applying the attached patch to fix a typo in the timings of the BSET and BCLR instructions for the RX port. Cheers Nick gcc/ChangeLog 2011-03-10 Nick Clifton * config/rx/rx.md (bitset_in_memory, bitclr_in_memory: Fix timings. Index: gcc/config/rx/rx.md

Re: RFA/RFC: Enable both gold and ld in a single toolchain

, but I just cannot say when that will be. Sorry. Cheers Nick PS. If you want to take over the patch and push it forward, please do...

RX: 4.5 branch: Fix alignment and addressing issues.

Hi Guys, I am checking in the attached patch to fix some regressions in the RX port with regard to alignment and addressing modes. With this patch applied I have 18 fewer failures in the GCC testsuite. Cheers Nick gcc/ChangeLog 2011-03-16 Nick Clifton * config/rx/rx.h

Re: RX: 4.5 branch: Fix alignment and addressing issues.

where the optimization could take place. Hence I added the peepholes. (I admit that I did not delve deeply into *why* combine was not using my instruction pattens, I just found that the peepholes worked). Plus I reasoned that the peepholes could not hurt... Cheers Nick

RX: Adjust memory move cost

Hi Guys, I am applying the patch below to tweak the MEMORY_MOVE_COST macro for the RX port on the 4.5 branch. Writing to memory is actually faster than reading on the RX, so the cost can be reduced as shown. Cheers Nick gcc/ChangeLog 2011-03-17 Nick Clifton * config/rx/rx.h

Re: [V850] Hookize OUTPUT_ADDR_CONST_EXTRA

. (TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA): Define. Approved - please apply. Cheers Nick

Re: [ARM] PR 47553: vld1q_lane_u8 & co. don't accept lanes >= 8

. Certainly I would not object if you wanted to apply the patch to the 4.5 branch. Cheers Nick

Re: RX: 4.5 branch: Fix alignment and addressing issues.

256 (for QImode extensions) or less than (256 * 2) for HImode extensions and the extend type is zero-extend. It is 4 bytes long if ... [snip - you get the idea]. So really I think that I should be defining the ADJUST_INSN_LENGTH macro to handle these patterns. I'll look into that. Cheers Nick

Re: RX: 4.5 branch: Fix alignment and addressing issues.

pass. Darn - I feel like a complete idiot! You are right of course - the length attribute is not used at all. Adding the attribute was just habitual, I never thought to check to see if it was really needed. I'll make a patch to remove the lengths and check it in shortly. Cheers Nick

Re: RX: 4.5 branch: Fix alignment and addressing issues.

Hi Mike, And why is that a problem? You get to write arbitrarily complex C code that can depend upon insn and operands. Ah - I did not know this. I thought that you had to stick to RTL expressions in the definition of attributes. Thanks for letting me know otherwise. Cheers Nick

extend.texi: Fix grammatical problems with builtin machine function descriptions

. Checked by rebuilding the gcc documentation. OK to apply ? Cheers Nick gcc/ChangeLog 2011-03-21 Nick Clifton * doc/extend.texi (Alpha Built-in Functions, X86 Built-in Functions): Fix grammatical errors. Index: gcc/doc/extend.texi

invoke.texi: Fix minor typos

Hi Gerald, Hi Jospeh, The patch below fixes a bunch of minor typos in the invoke.texi file. I suspect that it might qualify as obvious, but I though that I ought to run it past you first. OK to apply ? Cheers Nick gcc/ChangeLog 2011-03-21 Nick Clifton * doc/invoke.texi

Fix typo on cygming.h

day, so it is best to clean up the macro definition. Tested by building an i686-pc-cygwin toolchain. Cheers Nick gcc/ChangeLog 2011-03-22 Nick Clifton * config/i386/cygming.h (SUBTARGET_OVERRIDE_OPTIONS): Remove trailing backslash from the end of the macro definition

RFA: Add MN10300 to list of targets not supporting profiling

toolchains. Cheers Nick gcc/testsuite/ChangeLog 2011-03-22 Nick Clifton * lib/target-supports.exp (check_profiling_available): Add MN10300 to the list of targets not supporting profiling. Index: gcc/testsuite/lib/target-supports.exp

Re: RFA: Add MN10300 to list of targets not supporting profiling

. I have restored alpha sorting to this particular list. Cheers Nick

Commit: RX: Add alignment for jumps, loops and labels

Hi Guys, I am applying the patch below to add alignment control for jumps, loops and labels to the RX backend. Tested without regressions on an rx-elf target. Cheers Nick gcc/ChangeLog 2011-03-24 Nick Clifton * config/rx/rx.h (LABEL_ALIGN_FOR_BARRIER): Define

Add support for DragonFlyBSD target to top level configure

Hi Guys, I am propagating the attached patch from the binutils source tree. It adds support for the DragonFlyBSD target to the top level configure script. Cheers Nick ./ChangeLog 2011-03-26 John Marino * configure.ac: Add support for *-*-dragonfly* * configure

Fix RX performance regressions on 4.6 branch

Hi Guys, I am applying the patch below to fix a couple of performance regressions for the RX toolchain on the 4.6 branch (when compared to the 4.5 branch). These include aligning jumps, loops and labels, and combining extending loads and simple arithmetic operations. Cheers Nick gcc

Re: PING^3: PR 47551: ARM patch for Neon-related spill failure

47551 * config/arm/arm.c (coproc_secondary_reload_class): Handle structure modes. Don't check neon_vector_mem_operand for vector or structure modes. gcc/testsuite/ PR target/47551 * gcc.target/arm/neon-modes-2.c: New test. Approved - please apply. Cheers Nick

RX: Sync with 4.6 branch

for the rx_max_skip_for_label function). Cheers Nick gcc/ChangeLog 2011-03-30 Nick Clifton * config/rx/rx.md: Add peepholes and patterns to combine extending loads and simple arithmetic instructions. * config/rx/rx.h (ADJUST_INSN_LENGTH): Define. * config/rx/rx

Re: Add ToLower .opt facility

heers Nick

Re: Avoid global state in rx_handle_option

x.opt (config/rx/rx-opts.h: New HeaderInclude. (mcpu=): Use Enum and specifiy rx_cpu_type with Var. (rx_cpu_types): New Enum and EnumValue entries. (mint-register=): Use Defer and use Var accordingly. No objections - please apply. Cheers Nick

RFA: MN10300: Handle MDR register in movqi/movhi pattern.

triggered until later on in the toolchain build). I would like to propose the attached small patch to fix this problem. Tested without regressions on an mn10300-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2011-04-05 Nick Clifton * config/mn10300/mn10300.md (movq

Commit: V850: Fix generation of callt helper functions for interrupt handlers

Hi Guys, I am applying the patch below to the 4.6 branch and mainline sources. It fixes a problem with the V850 backend where it would generate a CALLT instruction for a V850 variant which does not support it, when gcc was compiling an interrupt handler. Cheers Nick gcc/ChangeLog 2011

Re: Ping: Some remodelling of the ARM vld and vst patterns

neon_vst4qb): Likewise, but halve >the width of the memory access. Remove post-increment. >* config/arm/neon-testgen.ml: Allow addresses to have an alignment. > > gcc/testsuite/ >* gcc.target/arm/neon-vld3-1.c: New test. >* gcc.target/arm/neon-vst3-1.c: New test. >* gcc.target/arm/neon/v*.c: Regenerate. Approved - please apply. Cheers Nick

RFA: Deprecate the ARM simulator

Hi Guys, I recently applied a patch to the top level configure script in the binutils-gdb repository to deprecate the ARM simulator and I would like to apply a similar one to the GCC repository so that the two configure systems are kept in sync. Any objections ? Cheers Nick diff

RFA: Another Rust demangler recursion limit

Nick diff --git a/libiberty/rust-demangle.c b/libiberty/rust-demangle.c index 36afcfae278..d6daf23af27 100644 --- a/libiberty/rust-demangle.c +++ b/libiberty/rust-demangle.c @@ -1082,6 +1082,18 @@ demangle_path_maybe_open_generics (struct rust_demangler *rdm) if (rdm->errored) return o

Re: RFA: Another Rust demangler recursion limit

Hi Jeff, OK. Thanks. And yes, I wish someone else was looking at this stuff.  Rust isn't really on my radar right now... I have been toying with the idea of putting myself forward as a maintainer for the libiberty sources. I just wish that I had more free time... Cheers Nick

Re: [PATCH 14/24] libtool.m4: fix nm BSD flag detection

On 7 Aug 2023, Jeff Law uttered the following: > On 8/7/23 04:32, Arsen Arsenović via Gcc-patches wrote: >> From: Nick Alcock >> Libtool needs to get BSD-format (or MS-format) output out of the system >> nm, so that it can scan generated object files for symbol names for >

[PATCH] config: check for sighandler_t properly

Searching for sighander_t is unlikely to succeed anywhere. The attempt to #include is also not working, and fixing it shows that doing an AC_DEFINE in the body of an AC_CHECK_TYPE like that is also risky: both fixed. (The purpose of this check is opaque to me: neither libcody nor GCC ever includ

Re: [PATCH] config: check for sighandler_t properly

On 25 Jan 2021, Nathan Sidwell uttered the following: > On 1/22/21 12:19 PM, Nick Alcock wrote: >> Searching for sighander_t is unlikely to succeed anywhere. >> >> The attempt to #include is also not working, >> and fixing it shows that doing an AC_DEFINE in the body

[PATCH] ld: depend on libctf

in the build tree will be automatically used, but if one *is* present, it may take precedence and break things.) (This is a maybe- dependency, so it will work even if libctf is disabled.) ChangeLog 2021-01-26 Nick Alcock PR 27250 * Makefile.def: Add install-libctf dependency to

Re: [PATCH] config: check for sighandler_t properly

On 25 Jan 2021, Nathan Sidwell said: > I think you're right about checking though, not I'll look at it once I've dealt with this unfortunate "installing binutils leaves the system linker broken" disaster I've caused. :) -- NULL && (void)

Re: [PATCH] ld: depend on libctf

On 26 Jan 2021, Andreas Schwab outgrape: > On Jan 26 2021, Nick Alcock via Gcc-patches wrote: > >> diff --git a/Makefile.in b/Makefile.in >> index 03785200dc7..d8a94c4173d 100644 >> --- a/Makefile.in >> +++ b/Makefile.in >> @@ -565,7 +565,7 @@ S

[PATCH v2] ld: depend on libctf

in the build tree will be automatically used, but if one *is* present, it may take precedence and break things.) (This is a maybe- dependency, so it will work even if libctf is disabled.) ChangeLog 2021-01-26 Nick Alcock PR 27250 * Makefile.def: Add install-libctf dependency to

[PATCH 0/8 RFC] unbreak --with-included-gettext, and other configury stuff

: gdb-patc...@sourceware.org Cc: gcc-patc...@gnu.org Jakub Jelinek (2): (sync from gcc) intl: Allow building both with old bison and bison >= 3 [PR92008] intl: Unbreak intl build with bison 3 when no regeneration is needed [PR92008] Nick Alcock (6): intl: always picify intl: turn LIBINTL

[PATCH 3/8] intl: always picify

..@gnu.org intl/ChangeLog 2021-02-02 Nick Alcock * aclocal.m4: include picflag.m4. * configure.ac (PICFLAG): Add and substitute. * Makefile.in (PICFLAG): New. (COMPILE): Use it. * configure: Regenerate. --- intl/Makefile.in | 3 +- intl/aclocal.m4 |

[PATCH 4/8] intl: turn LIBINTL into -L / -l form

ays do the right thing for both static and shared links. Cc: gcc-patc...@gnu.org intl/ChangeLog 2021-02-04 Nick Alcock * configure.ac (LIBINTL): Transform into -L/-lintl form. * configure: Regenerate. --- intl/configure| 3 +-- intl/configure.ac | 3 +-- 2 files changed, 2

[C++ PATCH] Fix unnecessary error when top-level cv-qualifiers is dropped (PR c++/101783)

The root cause of this bug is that it considers reference with cv-qualifiers as an error by generating value for variable "bad_quals". However, this is not correct for case of typedef. Here I quote spec: "Cv-qualified references are ill-formed except when the cv-qualifiers are introduced through

[PATCH] c++: Fix unnecessary error when top-level cv-qualifiers is dropped [PR101783]

The root cause of this bug is that it considers reference with cv-qualifiers as an error by generating value for variable "bad_quals". However, this is not correct for case of typedef. Here I quote spec: "Cv-qualified references are ill-formed except when the cv-qualifiers are introduced through th

[PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]

Reference with cv-qualifiers should be ignored instead of causing an error because standard accepts cv-qualified references introduced by typedef which is ignored. Therefore, the fix prevents GCC from reporting error by not setting variable "bad_quals" in case the reference is introduced by typed

[PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402,PR102033,PR102034,PR102039,PR102044]

These bugs are considered duplicate cases of PR51851 which has been suspended since 2012, an issue known as "core1001/1322". Considering this background, it deserves a long comment to explain. Many people believed the root cause of this family of bugs is related with the nature of how and when

Fix another Rust demangling bugs (PR 105039)

Hi Guys, Attached is a proposed patch to fix another Rust demangling bug reported in PR 105039. I would like to say that this is the last time that we will see this problem for the Rust demangler, but I am not that naive... OK to apply ? Cheers Nickdiff --git a/libiberty/rust-deman

Re: [PATCH] Pass PKG_CONFIG_PATH down from top-level Makefile

Hi Simon, Ping. Patch approved - please apply. I appreciate that modifying these top level files is a bit nerve wracking, but I think that you have done a good job in this case. :-) Cheers Nick

RFA: libiberty: Fix infinite recursion in rust demangler (PRs 98886 and 99935)

"uint" type is not used. Tested with a patched version of the binutils sources on an x86-pc-linux-gnu target. Cheers Nick 2022-01-26 Nick Clifton * rust-demangle.c (struct rust_demangler): Add a recursion counter. (demangle_path): Increment/decrement the re

Re: [PATCH] msp430: Mark unused attribute

Hi Jan-Benedict, gcc/ChangeLog: * config/msp430/msp430.cc (msp430_single_op_cost): Mark unused argument. Okay for HEAD? Patch approved - please apply. (I think that this patch would also count as an "obvious" fix, but thanks for asking anyway). Cheers Nick

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

On 21 Jul 2021, Alan Modra uttered the following: > On Wed, Jul 07, 2021 at 08:03:45PM +0100, Nick Alcock via Gcc-patches wrote: >> >>> PR libctf/27482 >> >>> * libtool.m4 (LT_PATH_NM): Try BSDization flags with a user-provided >> > >> >

*PING* [PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402,PR102033,PR102034,PR102039,PR102044]

These bugs are considered duplicate cases of PR51851 which has been suspended since 2012, an issue known as "core1001/1322". Considering this background, it deserves a long comment to explain. Many people believed the root cause of this family of bugs is related with the nature of how and when

*PING* Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]

Reference with cv-qualifiers should be ignored instead of causing an error because standard accepts cv-qualified references introduced by typedef which is ignored. Therefore, the fix prevents GCC from reporting error by not setting variable "bad_quals" in case the reference is introduced by typed

Re: *PING* [PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402,PR102033,PR102034,PR102039,PR102044]

d of bugs. It happens during template function declaration stage #1 when producing template declarator. Instead of doing a later-correction-effort in PR92010, my patch tries to at least avoid dropping "const" in case of "typename" and "decltype" during template f

Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]

ment. However, I just sent email to ass...@gnu.org to request assignment. Alternatively, I am not sure if adding this "signoff" tag in submission will help? Signed-off-by: qingzhe huang Thank you again! > On 8/28/21 07:54, nick huang via Gcc-patches wrote: > > Reference with c

Re: *PING* [PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402,PR102033,PR102034,PR102039,PR102044]

>>template >>struct A >>{ >> void f(T); >>}; >> >>template >>void A::f(const T) >>{ } >> >>which is certainly questionable code, but is currently also accepted by >>clang and EDG compilers. I just found out that clang actually correctly reject this code during specialization. (https://www.g

Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]

ment. Thank you again for your patient explanation and help! On 9/26/21 21:31, nick huang via Gcc-patches wrote: > Hi Jason, > > 1. Thank you very much for your detailed comments for my patch and I really > appreciate it! Here is my revised patch: > > The root cause of

Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]

thank you for your patience and really appreciate it. On Fri, Oct 1, 2021 at 9:29 AM Jason Merrill via Gcc-patches wrote: > > On 9/30/21 14:24, nick huang wrote: > >>> You may need to run contrib/gcc-git-customization.sh to get the git > >>> gcc-verify command. > >

Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]

ht never accomplish this task. Once again appreciate your patient help! On Fri, Oct 1, 2021 at 11:46 AM Jason Merrill wrote: > > On 10/1/21 11:10, Nick Huang wrote: > >> gcc-verify still fails with this version: > >> > >>> ERR: line should start with a tab: "

[PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402, PR102033, PR102034, PR102039, PR102

Hi Jason, I made a little improvement of my fix by including template type parameter to not dropping cv-const because they are similar to dependent type which you cannot determine whether they are top-level cv-qualifier or not until instantiation. + if (processing_template_decl +

Re: [PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402, PR102033, PR102034, PR102039, PR102

Here I attach [PATCH-v2]. On Sun, Oct 3, 2021 at 7:14 AM Nick Huang wrote: > > Hi Jason, > > I made a little improvement of my fix by including template > type parameter to not dropping cv-const because they are similar to dependent > type which you cannot determine whether the

Re: [PATCH] c++: Comment out announce_function to prevent ICE [PR102426]

I am terribly sorry for my typo of wrong PR #, it should be 102624. Please ignore this email thread and I resend the patch in next email with correct subject: [PATCH] c++: Comment out announce_function to prevent ICE [PR102624] Once again my apologies for spam. On Fri, Oct 8, 2021 at 12:31 AM qin

[PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402, PR102033, PR102034, PR102039, PR102

First of all, I am sorry for my late response as I missed your email. I need to update my filter setup of gmail after switching from hotmail. >I think WILDCARD_TYPE_P is what you want, except... I will try this one. >Your patch rejects that testcase even without the specialization on >int[], whic

Re: [PATCH] c++: fix cases of core1001/1322 by not dropping cv-qualifier of function parameter of type of typename or decltype[PR101402, PR102033, PR102034, PR102039, PR102

hi Jason, IMHO, I think your patch probably finally solved this long-standing Core 1001 issue. Of course it is not up to me to say so. I just want to point out that it even solves the following case, even though it is more or less expected if concept and lambda all work expectedly. template conce

Re: Commit: Update libiberty sources

Hi H.J. My patch is needed to build binutils with LTO. I submitted a patch for GCC: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574405.html Very well. I have reappplied your patch to the mainline and 2.37 branch sources. Cheers Nick

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

Ping? On 25 Jun 2021, Nick Alcock via Binutils said this: > Libtool needs to get BSD-format (or MS-format) output out of the system > nm, so that it can scan generated object files for symbol names for > -export-symbols-regex support. Some nms need specific flags to turn on > B

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

Hi Nick, Ping? Oops. PR libctf/27482 * libtool.m4 (LT_PATH_NM): Try BSDization flags with a user-provided Changes to libtool need to be posted to the libtool project: https://www.gnu.org/software/libtool/ They have mailing lists for bug reports and patch submissions

Re: [PATCH 2/4 REVIEW] libtool.m4: fix nm BSD flag detection

On 7 Jul 2021, Nick Clifton told this: > Hi Nick, > >> Ping? > > Oops. I sent a bunch of pings out at the same time, to a bunch of different projects. You are the only person to respond, so thank you! >>> PR libctf/27482 >>> * libtool.m4 (LT_PATH_N

RFA: Libiberty: Fix stack exhaunstion demangling corrupt rust names

Hi Guys, Attached is a proposed patch to fix PR 99935 and 100968, both of which are stack exhaustion problems in libiberty's Rust demangler. The patch adds a recursion limit along the lines of the one already in place for the C++ demangler. OK to apply ? Cheers Nick diff --

<    1   2   3   4   5   6   >