Hi Richard,

Thanks for the patch review. Sorry for not responding earlier, but some other work got in the way.

I have attached a revised patch which addresses all of the points you raised except one:

+         else if (loop->header != loop->latch
+           reason = "it is not a simple do-while loop";

Why?  A loop with multiple blocks should be fine with Lcc.

The problem I found here was that I did not know how to find all of the test-and-loop-back insns if the loop spanned multiple blocks. The revised patch includes a comment saying that loops spanning multiple blocks could be supported, but I would like to leave that for a future patch rather than trying to get it all working now.

Cheers
  Nick




Attachment: mn10300.setlb.patch.4
Description: Unix manual page

Reply via email to