Re: [PATCH] gdbinit: add a new command and fix one

2019-05-30 Thread Martin Liška
On 5/29/19 8:18 PM, Segher Boessenkool wrote: > On Wed, May 29, 2019 at 10:14:58AM -0600, Jeff Law wrote: >> On 5/29/19 3:46 AM, Martin Liška wrote: >>> Hi. >>> >>> The patch is about a small change in .gdbinit file. >>> >>> Ready for trunk? >>> Martin >>> >>> gcc/ChangeLog: >>> >>> 2019-05-29 Mar

Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-30 Thread Alex Henrie
On Tue, May 28, 2019 at 1:05 PM Martin Sebor wrote: > > On 5/24/19 9:49 AM, Alex Henrie wrote: > > Then is it preferable to simply silence Wattributes in this case? > > This case being PR86407? I'd say yes. > Attribute malloc attaches only to fndecl and not its type but > doesn't affect the code

Re: [PATCH, x86, testsuite] Two tests that need to be native TLS?

2019-05-30 Thread Uros Bizjak
On Fri, May 24, 2019 at 9:43 AM Iain Sandoe wrote: > > Hi Uros, > > The following two tests fail on Darwin, which is an emulated TLS target. > ISTM that the tests really required native support, so that the right fix > is to require that. (I can skip them for Darwin, if this isn’t the right > sol

Re: [Patch] Fix ix86_expand_sse_comi_round (PR Target/89750, PR Target/86444)

2019-05-30 Thread Hongtao Liu
On Thu, May 30, 2019 at 3:23 AM Jeff Law wrote: > > On 5/9/19 10:54 PM, Hongtao Liu wrote: > > On Fri, May 10, 2019 at 3:55 AM Jeff Law wrote: > >> > >> On 5/6/19 11:38 PM, Hongtao Liu wrote: > >>> Hi Uros and GCC: > >>> This patch is to fix ix86_expand_sse_comi_round whose implementation > >>>

Re: [libgomp, testsuite] Generalize getconf _NPROCESSORS_ONLN

2019-05-30 Thread Rainer Orth
Hi Jakub, >>> > So, something similar to what your patch does, but don't substitute the >>> > actual >>> > CPU count, but a command to determine the number of CPUs? >>> >>> I'm not convinced that would work reliably: you can easily have one set >>> of commands on one machine, but a slightly diffe

Re: [libgomp, testsuite] Generalize getconf _NPROCESSORS_ONLN

2019-05-30 Thread Jakub Jelinek
On Thu, May 30, 2019 at 10:59:59AM +0200, Rainer Orth wrote: > this version does this and passed the same testing as the previous one. > Ok for mainline now? > > Thanks. > Rainer > > -- > - > Rainer Orth, Center

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Prathamesh Kulkarni
On Wed, 29 May 2019 at 18:10, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to improve initialization for fixed-length > > SVE vector and it's algorithm is described in comments for > > aarch64_sve_expand_vector_init() in the patch, with help from R

Re: [PATCH] Further C lapack workaround tweaks

2019-05-30 Thread Jakub Jelinek
Hi! On Wed, May 29, 2019 at 06:41:57PM -0700, Jerry DeLisle wrote: > Just a typo: > > > +Disallow tail call optimization when a calling routine may have omitted > character lenghts. > > s/lenghts/lengths Thanks. Found similar typo in tree-predcom.c (and in old ChangeLog entries that I'm not go

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Richard Sandiford
Prathamesh Kulkarni writes: > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > new file mode 100644 > index 000..cbfeff4a59c > --- /dev/null > +++ b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > @@ -0,0 +1,27 @@ > +/* { dg-do

[PATCH] Update documentation of implementation-defined library features

2019-05-30 Thread Jonathan Wakely
* doc/xml/manual/status_cxx2011.xml: Use for documentation of implementation-defined types for [thread.req.native]. * doc/xml/manual/status_cxx2017.xml: Update documentation of implementation-defined strings for [variant.bad.access]. Fix typo in documentati

[PATCH] Update C++20 status table

2019-05-30 Thread Jonathan Wakely
The status of P1353R0 was "Partial" because we don't define the __cpp_lib_three_way_comparison macro, but that's because we don't support the feature. So the paper can be marked as done. * doc/xml/manual/status_cxx2020.xml: Add feature-test macro for P0811R3. Change status of P135

Re: [PATCH] Further C lapack workaround tweaks

2019-05-30 Thread Marek Polacek
On Thu, May 30, 2019 at 11:37:35AM +0200, Jakub Jelinek wrote: > Hi! > > On Wed, May 29, 2019 at 06:41:57PM -0700, Jerry DeLisle wrote: > > Just a typo: > > > > > +Disallow tail call optimization when a calling routine may have omitted > > character lenghts. > > > > s/lenghts/lengths There's al

Re: [PATCH] Further C lapack workaround tweaks

2019-05-30 Thread Marek Polacek
On Thu, May 30, 2019 at 07:26:28AM -0400, Marek Polacek wrote: > On Thu, May 30, 2019 at 11:37:35AM +0200, Jakub Jelinek wrote: > > Hi! > > > > On Wed, May 29, 2019 at 06:41:57PM -0700, Jerry DeLisle wrote: > > > Just a typo: > > > > > > > +Disallow tail call optimization when a calling routine m

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-05-30 Thread Sam Tebbs
The fix has been committed as r271780. Apologies for the failure everyone. Sam On 29/05/2019 15:22, Sam Tebbs wrote: > Thanks for finding this Christoph, I had this failure a while ago but it > stopped happening so I thought all was good. I have a fix ready. > > Sam > > On 29/05/2019 12:22, Chris

[PATCH][GCC][AARCH64] Fix libstdc++ build failure after r271735

2019-05-30 Thread Sam Tebbs
Hi all, Libstdc++ has been failing to build after I committed r271735. This patch fixes the build failure by checking if the current function is a thunk before emitting the .cfi_b_key_frame directive. Committed as obvious in r271780. Apologies for the failure. 2019-05-30  Sam Tebbs      * aa

Re: [PATCH][AArch64] Make use of FADDP in simple reductions

2019-05-30 Thread Sudakshina Das
Hi Elen Thank you for doing this. You will need a maintainer's approval but I would like to add a couple of comments. Please find them inline. On 08/05/2019 14:36, Elen Kalda wrote: > Hi, > > This patch adds a pattern to support the FADDP (scalar) instruction. > > Before the patch, the C code

[patch][aarch64]: add support for fabd in sve

2019-05-30 Thread Sylvia Taylor
Greetings, This patch adds support in SVE to combine: - fsub and fabs into fabd fsubz0.s, z0.s, z1.s fabsz0.s, p1/m, z0.s --- fabdz0.s, p1/m, z0.s, z1.s Bootstrapped and tested on aarch64-none-linux-gnu. Ok for trunk? If yes, I don't have commit rights, so if someone can please comm

[patch][aarch64]: add usra and ssra combine patterns

2019-05-30 Thread Sylvia Taylor
Greetings, This patch adds support to combine: 1) ushr and add into usra, example: ushrv0.16b, v0.16b, 2 add v0.16b, v0.16b, v2.16b --- usrav2.16b, v0.16b, 2 2) sshr and add into ssra, example: sshrv1.16b, v1.16b, 2 add v1.16b, v1.16b, v3.16b --- ssrav3.16b, v1.16b, 2

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Prathamesh Kulkarni
On Thu, 30 May 2019 at 15:10, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > > b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > > new file mode 100644 > > index 000..cbfeff4a59c > > --- /dev/null > > +++ b/gcc/te

Re: [PATCH] warn on returning alloca and VLA (PR 71924, 90549)

2019-05-30 Thread Martin Sebor
On 5/29/19 11:45 AM, Jeff Law wrote: On 5/22/19 3:34 PM, Martin Sebor wrote: -Wreturn-local-addr detects a subset of instances of returning the address of a local object from a function but the warning doesn't try to handle alloca or VLAs, or some non-trivial cases of ordinary automatic variable

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-30 Thread Jeff Law
On 5/30/19 12:57 AM, Jiufu Guo wrote: > Richard Biener writes: > >> On May 29, 2019 10:21:46 PM GMT+02:00, Jeff Law wrote: >>> On 5/24/19 6:45 AM, Richard Biener wrote: >>> [ Aggressive snipping ] >>> As said in my first review I'd just check whether for the edge we want to thread thro

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-30 Thread Jeff Law
On 5/30/19 12:44 AM, Richard Biener wrote: > On May 29, 2019 10:21:46 PM GMT+02:00, Jeff Law wrote: >> On 5/24/19 6:45 AM, Richard Biener wrote: >> [ Aggressive snipping ] >> >>> As said in my first review I'd just check whether for the >>> edge we want to thread through the definition comes from

[wwwdocs] Add sized-deallocation functions to discussion of new/delete

2019-05-30 Thread Jonathan Wakely
Committed to CVS. Index: htdocs/gcc-9/porting_to.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-9/porting_to.html,v retrieving revision 1.5 diff -u -r1.5 porting_to.html --- htdocs/gcc-9/porting_to.html 13 May 2019 11:57:03 - 1.5

Re: [PATCH V2] A jump threading opportunity for condition branch

2019-05-30 Thread Jiufu Guo
Jeff Law writes: > On 5/29/19 6:36 AM, Richard Biener wrote: >> On Tue, 28 May 2019, Jiufu Guo wrote: >> >>> Hi, >>> >>> This patch implements a new opportunity of jump threading for PR77820. >>> In this optimization, conditional jumps are merged with unconditional >>> jump. And then moving CMP

Re: [PATCH v2] rs6000: Add undocumented switch -mprefixed-addr

2019-05-30 Thread Segher Boessenkool
On Wed, May 29, 2019 at 07:09:47PM -0500, Bill Schmidt wrote: > Here's another version of the -mprefixed-addr patch. I've attempted to > address > Segher's comments, other than the suggestion to merge > OPTION_MASK_P8_FUSION_SIGN > into OPTION_MASK_P8_FUSION, which I think is too big a rat's nes

Re: [PATCH] warn on returning alloca and VLA (PR 71924, 90549)

2019-05-30 Thread Jeff Law
On 5/30/19 8:52 AM, Martin Sebor wrote: > On 5/29/19 11:45 AM, Jeff Law wrote: >> On 5/22/19 3:34 PM, Martin Sebor wrote: >>> -Wreturn-local-addr detects a subset of instances of returning >>> the address of a local object from a function but the warning >>> doesn't try to handle alloca or VLAs, or

Make aliasing_component_refs_p to work harder when same_type_for_tbaa returns -1

2019-05-30 Thread Jan Hubicka
Hi, this patch makes aliasing_component_refs_p to not give up at the first -1 returned by types_same_for_tbaa_p and continue searching for pairs of types we know to be the same. This affects disambiguations as follows: With patch: refs_may_alias_p: 3013678 disambiguations, 3314059 queries ref

Re: [PATCH V2] A jump threading opportunity for condition branch

2019-05-30 Thread Jeff Law
On 5/28/19 7:53 AM, Jiufu Guo wrote: > Hi, > > This patch implements a new opportunity of jump threading for PR77820. > In this optimization, conditional jumps are merged with unconditional > jump. And then moving CMP result to GPR is eliminated. > > This version is based on the proposal of Richa

Re: [PATCH] warn on returning alloca and VLA (PR 71924, 90549)

2019-05-30 Thread Martin Sebor
On 5/30/19 9:13 AM, Jeff Law wrote: On 5/30/19 8:52 AM, Martin Sebor wrote: On 5/29/19 11:45 AM, Jeff Law wrote: On 5/22/19 3:34 PM, Martin Sebor wrote: -Wreturn-local-addr detects a subset of instances of returning the address of a local object from a function but the warning doesn't try to h

Re: [libstdc++,doc] doc/xml/manual/support.xml - link adjustment and simplification

2019-05-30 Thread Jonathan Wakely
On 28/05/19 17:24 +0100, Jonathan Wakely wrote: On 26/05/19 19:46 +0200, Gerald Pfeifer wrote: The links adjustment I would just have committed right away, but I'd also like to suggest swe simplify the section: the following paragraph doesn't really add much, but duplicates the external link. T

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Richard Sandiford
Prathamesh Kulkarni writes: > On Thu, 30 May 2019 at 15:10, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/init_1.c >> > b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c >> > new file mode 100644 >> > index 000..cbfeff4

Re: [PATCH] rs6000: Add undocumented switch -mprefixed-addr

2019-05-30 Thread Michael Meissner
On Wed, May 29, 2019 at 03:26:27PM -0500, Bill Schmidt wrote: > On 5/29/19 8:16 AM, Segher Boessenkool wrote: > > Hi! > > > > On Wed, May 29, 2019 at 07:42:38AM -0500, Bill Schmidt wrote: > >>* rs6000-cpus.def (OTHER_FUSION_MASKS): New #define. > >>(ISA_FUTURE_MASKS_SERVER): Add OPTION_MASK

Re: [PATCH] warn on returning alloca and VLA (PR 71924, 90549)

2019-05-30 Thread Jeff Law
On 5/30/19 9:34 AM, Martin Sebor wrote: >>> If the alias oracle can be used to give the same results without >>> excessive false positives then I think it would be fine to make >>> use of it.  Is that something you consider a prerequisite for >>> this change or should I look into it as a followup?

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-30 Thread Martin Jambor
Hi, On Wed, May 29 2019, Jan Hubicka wrote: >> > but we do not optimize it. I.e. optimized dump has: >> > >> > test () >> > { >> > struct bar * barptr.0_1; >> > struct foo * fooptr.1_2; >> > int _6; >> > >> >[local count: 1073741824]: >> > barptr.0_1 = barptr; >> > barptr.0_1->val2 =

[PATCH][Preprocessor]patch to fix PR 90581

2019-05-30 Thread Qing Zhao
Hi, PR 90581 (provide an option to adjust the maximum depth of nested #include) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 is to add a new cpp option -fmax-inlcude-depth to set the maximum depth of nested #include. '-fmax-include-depth=DEPTH' Set the maximum depth of the nested inc

Re: Simplify more EXACT_DIV_EXPR comparisons

2019-05-30 Thread Jeff Law
On 5/29/19 3:27 PM, Marc Glisse wrote: > On Mon, 20 May 2019, Richard Biener wrote: > >> On Mon, May 20, 2019 at 10:16 AM Marc Glisse >> wrote: >>> >>> On Mon, 20 May 2019, Richard Biener wrote: >>> On Sun, May 19, 2019 at 6:16 PM Marc Glisse wrote: > > Hello, > > 2 pie

Re: [PATCH] PR libstdc++/71579 assert that type traits are not misused with an incomplete type

2019-05-30 Thread Jonathan Wakely
On 30/05/19 09:06 +0300, Antony Polukhin wrote: чт, 9 мая 2019 г. в 00:10, Jonathan Wakely : On 06/05/19 14:19 +0300, Antony Polukhin wrote: >@@ -924,14 +984,25 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > template > struct is_default_constructible > : public __is_default_constructible_safe<

[PATCH] Fix alignment option parser (PR90684)

2019-05-30 Thread Wilco Dijkstra
Fix the alignment option parser to always allow up to 4 alignments. Now -falign-functions=16:8:8:8 no longer reports an error. OK for commit (and backport to GCC9)? ChangeLog: 2019-05-30 Wilco Dijkstra PR driver/90684 * gcc/opts.c (parse_and_check_align_values): Allow 4 align

[patch, doc, fortran] Document some trans* stuff

2019-05-30 Thread Thomas Koenig
Hello world, I thought I would add a little bit of documentation about what trans-* is doing, in the hope that it may be useful. The scalarizer could also use some documentation, but at least we have the wiki article there. Tested with "make", "make dvi" and "make pdf". OK for trunk? Regards

Re: [PATCH] warn on returning alloca and VLA (PR 71924, 90549)

2019-05-30 Thread Jason Merrill
On Thu, May 30, 2019 at 12:16 PM Jeff Law wrote: > > On 5/30/19 9:34 AM, Martin Sebor wrote: > > >>> If the alias oracle can be used to give the same results without > >>> excessive false positives then I think it would be fine to make > >>> use of it. Is that something you consider a prerequisit

Go patch committed: intrinsify sync/atomic functions

2019-05-30 Thread Ian Lance Taylor
This Go frontend patch by Cherry Zhang intrinsifies the sync/atomic functions. It also makes sure not to intrinsify calls in go or defer statements. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

Re: [patch, doc, fortran] Document some trans* stuff

2019-05-30 Thread Steve Kargl
On Thu, May 30, 2019 at 06:47:16PM +0200, Thomas Koenig wrote: > + > +It is possible to > +@itemize @bullet > +@item Add an expression to the end of a block using > + @code{gfc_add_expr_to_block} > +@item Add an expression to the bebinning of a block using s/bebinning/beginning > + @co

Re: [patch][aarch64]: add support for fabd in sve

2019-05-30 Thread Richard Sandiford
Sylvia Taylor writes: > Greetings, > > This patch adds support in SVE to combine: > - fsub and fabs into fabd > > fsubz0.s, z0.s, z1.s > fabsz0.s, p1/m, z0.s > --- > fabdz0.s, p1/m, z0.s, z1.s > > Bootstrapped and tested on aarch64-none-linux-gnu. > > Ok for trunk? If yes, I don't have

Fwd: CFV: "C++ programming in GNU" interest group (possibly including coding standard development)

2019-05-30 Thread James Youngman
Dear GCC developers, I'm looking into creating a C++ coding standard for GNU programs. See below for the CFV (which you therefore might have already read by being on the other list; if so, sorry for the duplication). I'd be particularly interested in the question of whether the coding standards f

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Andreas Schwab
On Mai 21 2019, Jim Wilson wrote: > On Sun, May 19, 2019 at 5:22 AM Andreas Schwab wrote: >> ../../../libgo/go/runtime/mbitmap.go: In function >> ‘runtime.setMarked.runtime.markBits’: >> ../../../libgo/go/runtime/mbitmap.go:291:9: internal compiler error: >> Segmentation fault >> 291 | atom

Re: [patch, doc, fortran] Document some trans* stuff

2019-05-30 Thread Thomas Koenig
Hi Steve, Thomas, with the above fixes, I think this a great addition to manual. OK to commit. Committed with your fixes (sometimes I think my fingers are going blind :-) as r271786. Best regards Thomas

C++ PATCH to fix typo in cp-tree.h

2019-05-30 Thread Marek Polacek
Noticed this is -> if typo. Applying to trunk as obvious. 2019-05-30 Marek Polacek * cp-tree.h (TYPE_HAS_NONTRIVIAL_DESTRUCTOR): Fix a typo. diff --git gcc/cp/cp-tree.h gcc/cp/cp-tree.h index 7a74fd4fac5..edd59d5f000 100644 --- gcc/cp/cp-tree.h +++ gcc/cp/cp-tree.h @@ -4295,7 +4295,7

Re: CFV: "C++ programming in GNU" interest group (possibly including coding standard development)

2019-05-30 Thread Mike Stump
On May 30, 2019, at 10:55 AM, James Youngman wrote: > I'm looking into creating a C++ coding standard for GNU programs. So, parts of how we do C++ isn't really relevant to a larger community. We at times cater to a C legacy and in a pure C++ project, there may be no need to do this. ChangeLog

Re: [PATCH][Preprocessor]patch to fix PR 90581

2019-05-30 Thread Bernhard Reutner-Fischer
On 30 May 2019 18:23:43 CEST, Qing Zhao wrote: >Hi, > >PR 90581 (provide an option to adjust the maximum depth of nested >#include) >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 > >is to add a new cpp option -fmax-inlcude-depth Typo inl vs inc. Why isn't this a param? Wouldn't a param ease

Re: [PATCH] rs6000: Add basic support for prefixed and PC-relative addresses

2019-05-30 Thread Segher Boessenkool
On Wed, May 29, 2019 at 10:49:35PM -0500, Bill Schmidt wrote: > * config/rs6000/predicates.md (pcrel_address): New > define_predicate. Please put that on one line? > + if (LABEL_REF_P (x)) > + output_asm_label (x); > + else > + output_addr_const (file, x); Why does

Re: [PATCH] rs6000: Add target supports for "future" system

2019-05-30 Thread Segher Boessenkool
On Wed, May 29, 2019 at 10:52:38PM -0500, Bill Schmidt wrote: > * lib/target-supports.exp (check_powerpc_future_hw_available): > New. That fits on one line just fine? > +# Return 1 if this is a PowerPC target supporting -mfuture. > +# Limit this to 64-bit linux systems for now until o

Re: [PATCH] rs6000: Update test cases to use powerpc_future_ok

2019-05-30 Thread Segher Boessenkool
Hi! On Wed, May 29, 2019 at 10:54:58PM -0500, Bill Schmidt wrote: > 2019-05-29 Bill Schmidt > Michael Meissner > > * gcc.target/powerpc/cpu-future.c: Require powerpc_future_ok. > * gcc.target/powerpc/localentry-1.c: Likewise. > * gcc.target/powerpc/localentry-dire

Re: [PATCH] PR71482: Add -Wglobal-constructors

2019-05-30 Thread Marek Polacek
On Tue, May 28, 2019 at 09:30:56PM +, Sean Gillespie wrote: > This adds a new warning, -Wglobal-constructors, that warns whenever a > decl requires a global constructor or destructor. This new warning fires > whenever a thread_local or global variable is declared whose type has a > non-trivial

Re: [PATCH] rs6000: Add basic support for prefixed and PC-relative addresses

2019-05-30 Thread Bill Schmidt
On 5/30/19 2:20 PM, Segher Boessenkool wrote: > On Wed, May 29, 2019 at 10:49:35PM -0500, Bill Schmidt wrote: >> * config/rs6000/predicates.md (pcrel_address): New >> define_predicate. > Please put that on one line? OK.  Emacs in ChangeLog and Fill modes seems to set a line length somewh

Re: [v3 PATCH] basic_string spurious use of a default constructible allocator - LWG2788

2019-05-30 Thread Jonathan Wakely
On 27/05/19 11:53 +0100, Nina Dinka Ranns wrote: Tested on Linux x86_64 basic_string spurious use of a default constructible allocator - LWG2788 2019-05-27 Nina Dinka Ranns basic_string spurious use of a default constructible allocator - LWG2788 * bits/basic_string.tcc: (

Re: [PATCH] PR libstdc++/85494 use rdseed and rand_s in std::random_device

2019-05-30 Thread Jonathan Wakely
On 29/05/19 23:03 +0100, Jonathan Wakely wrote: On 29/05/19 15:45 +0100, Jonathan Wakely wrote: Add support for additional sources of randomness to std::random_device, to allow using RDSEED for Intel CPUs and rand_s for Windows. When supported these can be selected using the tokens "rdseed" and

Re: [PATCH] A jump threading opportunity for condition branch

2019-05-30 Thread Jeff Law
On 5/30/19 12:41 AM, Richard Biener wrote: > On May 29, 2019 10:18:01 PM GMT+02:00, Jeff Law wrote: >> On 5/23/19 6:11 AM, Richard Biener wrote: >>> On Thu, 23 May 2019, Jiufu Guo wrote: >>> Hi, Richard Biener writes: > On Tue, 21 May 2019, Jiufu Guo wrote: >> >> +

Re: [PATCH][Preprocessor]patch to fix PR 90581

2019-05-30 Thread Qing Zhao
> On May 30, 2019, at 2:13 PM, Bernhard Reutner-Fischer > wrote: > > On 30 May 2019 18:23:43 CEST, Qing Zhao wrote: >> Hi, >> >> PR 90581 (provide an option to adjust the maximum depth of nested >> #include) >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 >> >> is to add a new cpp opt

Re: [PATCH] rs6000: Add basic support for prefixed and PC-relative addresses

2019-05-30 Thread Segher Boessenkool
On Thu, May 30, 2019 at 02:43:49PM -0500, Bill Schmidt wrote: > On 5/30/19 2:20 PM, Segher Boessenkool wrote: > > On Wed, May 29, 2019 at 10:49:35PM -0500, Bill Schmidt wrote: > >>* config/rs6000/predicates.md (pcrel_address): New > >>define_predicate. > > Please put that on one line? > >

Re: [PATCH][Preprocessor]patch to fix PR 90581

2019-05-30 Thread David Malcolm
On Thu, 2019-05-30 at 15:17 -0500, Qing Zhao wrote: > > On May 30, 2019, at 2:13 PM, Bernhard Reutner-Fischer > gmail.com> wrote: > > > > On 30 May 2019 18:23:43 CEST, Qing Zhao > > wrote: > > > Hi, > > > > > > PR 90581 (provide an option to adjust the maximum depth of nested > > > #include) >

Re: [PATCH][Preprocessor]patch to fix PR 90581

2019-05-30 Thread Qing Zhao
> On May 30, 2019, at 3:38 PM, David Malcolm wrote: > > On Thu, 2019-05-30 at 15:17 -0500, Qing Zhao wrote: >>> On May 30, 2019, at 2:13 PM, Bernhard Reutner-Fischer >> gmail.com> wrote: >>> >>> On 30 May 2019 18:23:43 CEST, Qing Zhao >>> wrote: Hi, PR 90581 (provide an option

Re: [PATCH][Preprocessor]patch to fix PR 90581

2019-05-30 Thread David Malcolm
On Thu, 2019-05-30 at 11:23 -0500, Qing Zhao wrote: > Hi, > > PR 90581 (provide an option to adjust the maximum depth of nested > #include) > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 > > is to add a new cpp option -fmax-inlcude-depth to set the maximum > depth of nested #include. > > '

Re: [gofrontend-dev] Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Jim Wilson
On Wed, May 22, 2019 at 6:41 PM Ian Lance Taylor wrote: > Jim, you can go ahead and commit that patch with a ChangeLog entry. > (The files in go/gcc but not in go/gcc/gofrontend) are under normal > GCC rules.) Thanks. OK. Committed. I did an x86_64-linux go build and check to make sure I didn'

Re: [gofrontend-dev] Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Jim Wilson
On Wed, May 22, 2019 at 6:36 PM Cherry Zhang wrote: > Jim, thank you for the fix! The patch looks good to me. Maybe we should also > apply this to __atomic_add_fetch_4 and __atomic_add_fetch_8? Sorry about the delay, I caught a virus last week and am behind on everything. For 64-bit RISC-V thos

[PATCH] libiberty: Don't use VLAs if __STDC_NO_VLA__ is non-zero

2019-05-30 Thread Michael Forney
VLAs are optional in C11, and an implementation that does not support them will define __STDC_NO_VLA__ to 1. 2019-05-30 Michael Forney * cp-demangle.c: Don't define CP_DYNAMIC_ARRAYS if __STDC_NO_VLA__ is non-zero. --- libiberty/cp-demangle.c | 4 ++-- 1 file changed, 2 insert

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Jim Wilson
On Thu, May 30, 2019 at 11:11 AM Andreas Schwab wrote: > Here are the test results: > http://gcc.gnu.org/ml/gcc-testresults/2019-05/msg02903.html I tried running RISC-V go checks on my system. I see 7 unexpected failures for gcc check-go, 6 unexpected failures for check-gotools, and 1 unexpected

Re: [PATCH][Preprocessor]patch to fix PR 90581

2019-05-30 Thread Qing Zhao
> On May 30, 2019, at 3:46 PM, David Malcolm wrote: > > On Thu, 2019-05-30 at 11:23 -0500, Qing Zhao wrote: >> Hi, >> >> PR 90581 (provide an option to adjust the maximum depth of nested >> #include) >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 >> >> is to add a new cpp option -fmax-

[PATCH,libstdc++] C++-20 costexpr and

2019-05-30 Thread Ed Smith-Rowland via gcc-patches
Greetings, I was not quite able to finish this in for gcc9 but here is the patch for: ?? Implement C++20 p0202 - Add Constexpr Modifiers to Functions ??in and Headers. ??Implement C++20 p1023 - constexpr comparison operators for std::array. I believe I have answered peoples conc

[committed] Optimize lastprivate conditional in worksharing constructs nested in parallel constructs

2019-05-30 Thread Jakub Jelinek
Hi! The following patch implements an optimization. For orphaned worksharing constructs we need to ask the runtime library to allocate some memory in the first thread that encounters the construct, but if it is nested inside of a parallel construct, we can allocate the memory on the stack of the

[PATCH] Fix ICE in ssa_create_duplicates (PR tree-optimization/90671)

2019-05-30 Thread Jakub Jelinek
Hi! The following testcase ICEs on the trunk, because both gsi_split_seq_after and gsi_insert_seq_after have assertions that the split is not after gsi_end_p iterator or insertion is not after such an iterator. My understanding of Alex' change is that it wants to hide any added debug stmts tempor

Re: [PATCH] PR71482: Add -Wglobal-constructors

2019-05-30 Thread Sean Gillespie
Thank you for the review! On Thu, May 30, 2019 at 12:38 PM Marek Polacek wrote: > > Thanks for the patch! Do you have a copyright assignment on file? Unsure > if this patch is small enough not to need it. > Also unsure, though I assumed that this patch was small enough to not need one. I'll go

Re: [PATCH] rs6000: Add basic support for prefixed and PC-relative addresses

2019-05-30 Thread Michael Meissner
On Thu, May 30, 2019 at 02:43:49PM -0500, Bill Schmidt wrote: > On 5/30/19 2:20 PM, Segher Boessenkool wrote: > > On Wed, May 29, 2019 at 10:49:35PM -0500, Bill Schmidt wrote: > >>* config/rs6000/predicates.md (pcrel_address): New > >>define_predicate. > > Please put that on one line? > >

Re: [PATCH] warn on returning alloca and VLA (PR 71924, 90549)

2019-05-30 Thread Martin Sebor
On 5/30/19 10:15 AM, Jeff Law wrote: On 5/30/19 9:34 AM, Martin Sebor wrote: If the alias oracle can be used to give the same results without excessive false positives then I think it would be fine to make use of it.  Is that something you consider a prerequisite for this change or should I loo

Re: [PATCH] PR71482: Add -Wglobal-constructors

2019-05-30 Thread Martin Sebor
On 5/28/19 3:30 PM, Sean Gillespie wrote: This adds a new warning, -Wglobal-constructors, that warns whenever a decl requires a global constructor or destructor. This new warning fires whenever a thread_local or global variable is declared whose type has a non-trivial constructor or destructor. W

Re: [PATCH V2] A jump threading opportunity for condition branch

2019-05-30 Thread Jeff Law
On 5/30/19 9:03 AM, Jiufu Guo wrote: > Jeff Law writes: > >> On 5/29/19 6:36 AM, Richard Biener wrote: >>> On Tue, 28 May 2019, Jiufu Guo wrote: >>> Hi, This patch implements a new opportunity of jump threading for PR77820. In this optimization, conditional jumps are merged wi

Re: [PATCH] fix more -Wformat-diag issues

2019-05-30 Thread Jeff Law
On 5/22/19 10:34 AM, Martin Sebor wrote: > Incorporating the feedback I got on the -Wformat-diag checker > provided an opportunity to tighten up existing and implement > a small number of few additional rules based on GCC Coding > Conventions (https://gcc.gnu.org/codingconventions.html). > The chec

Re: value_range_base::{non_zero_p, set_zero, set_non_zero}

2019-05-30 Thread Jeff Law
On 5/30/19 12:58 AM, Aldy Hernandez wrote: > Hi. > > We have zero_p in the API, but we don't have non_zero_p.  Instead we use > a non-API function range_is_nonnull.  I've fixed this. > > I have also gotten rid of the duplicity of using the non-API > range_is_null in favor of value_range_base::zer

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-30 Thread Joseph Myers
On Wed, 29 May 2019, Segher Boessenkool wrote: > On Wed, May 29, 2019 at 12:53:30AM +, Joseph Myers wrote: > > On Fri, 24 May 2019, Segher Boessenkool wrote: > > > > > IMO the best we can do is use what we already have: what CVS or SVN used > > > as the committer identity. *That* info is *co

Re: [PATCH] warn on returning alloca and VLA (PR 71924, 90549)

2019-05-30 Thread Jeff Law
On 5/30/19 11:23 AM, Jason Merrill wrote: > On Thu, May 30, 2019 at 12:16 PM Jeff Law wrote: >> >> On 5/30/19 9:34 AM, Martin Sebor wrote: >> > If the alias oracle can be used to give the same results without > excessive false positives then I think it would be fine to make > use of it

Re: [PATCH] RX: Add rx-*-linux target

2019-05-30 Thread Jeff Law
On 5/29/19 12:27 PM, Jeff Law wrote: > On 5/23/19 6:05 AM, Yoshinori Sato wrote: >> I ported linux kernel to Renesas RX. >> >> rx-*-elf target output a binary different from the standard ELF. >> It has the same format as the Renesas compiler. >> >> But the linux kernel requires the standard ELF for

Re: value_range_base::{non_zero_p, set_zero, set_non_zero}

2019-05-30 Thread Martin Sebor
On 5/30/19 12:58 AM, Aldy Hernandez wrote: Hi. We have zero_p in the API, but we don't have non_zero_p.  Instead we use a non-API function range_is_nonnull.  I've fixed this. I have also gotten rid of the duplicity of using the non-API range_is_null in favor of value_range_base::zero_p().

Re: undefined behavior in value_range::equiv_add()?

2019-05-30 Thread Jeff Law
On 5/29/19 10:20 AM, Aldy Hernandez wrote: > On 5/29/19 12:12 PM, Jeff Law wrote: >> On 5/29/19 9:58 AM, Aldy Hernandez wrote: >>> On 5/29/19 9:24 AM, Richard Biener wrote: On Wed, May 29, 2019 at 2:18 PM Aldy Hernandez wrote: > > As per the API, and the original documentation to

Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-30 Thread Joseph Myers
On Thu, 30 May 2019, Alex Henrie wrote: > At this point I think I'm convinced that any attribute that applies to > a function should also be allowed on a function pointer without any > warnings. We can start by turning off the warnings for the "fndecl" > attributes and then clean up the other attr

Re: CFV: "C++ programming in GNU" interest group (possibly including coding standard development)

2019-05-30 Thread Joseph Myers
On Thu, 30 May 2019, Mike Stump wrote: > On May 30, 2019, at 10:55 AM, James Youngman wrote: > > I'm looking into creating a C++ coding standard for GNU programs. > > So, parts of how we do C++ isn't really relevant to a larger community. > We at times cater to a C legacy and in a pure C++ pro

Re: value_range_base::{non_zero_p, set_zero, set_non_zero}

2019-05-30 Thread Joseph Myers
On Thu, 30 May 2019, Martin Sebor wrote: > This, of course, is in contrast to things like bit-field and > built-in where the convention calls for the hyphen but where For both bit-field and nonzero what we do in documentation is consistent with the C standard, even if code is less consistent. (

Re: [PATCH,libstdc++] C++-20 costexpr and

2019-05-30 Thread Ed Smith-Rowland via gcc-patches
On 5/30/19 5:05 PM, Ed Smith-Rowland via libstdc++ wrote: Greetings, I was not quite able to finish this in for gcc9 but here is the patch for: ?? Implement C++20 p0202 - Add Constexpr Modifiers to Functions ??in and Headers. ??Implement C++20 p1023 - constexpr comparison oper

Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-30 Thread Alex Henrie
On Thu, May 30, 2019 at 6:59 PM Joseph Myers wrote: > > On Thu, 30 May 2019, Alex Henrie wrote: > > > At this point I think I'm convinced that any attribute that applies to > > a function should also be allowed on a function pointer without any > > warnings. We can start by turning off the warning

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-30 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Tue, 28 May 2019 at 20:44, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > [...] > > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > > index b3fae5b..c15b8a2 100644 > > --- a/gcc/tree-vect-loop-manip.c > > +++ b/gcc/tr

Re: [PATCH] PR libstdc++/71579 assert that type traits are not misused with an incomplete type

2019-05-30 Thread Antony Polukhin
On Thu, May 30, 2019, 19:38 Jonathan Wakely wrote: <...> > I've attached a relative diff, to be applied on top of yours, with my > suggested tweaks. Do you see any issues with it? > > (If you're happy with those tweaks I can go ahead and apply this, > there's no need for an updated patch from you