On Thu, May 30, 2019 at 02:43:49PM -0500, Bill Schmidt wrote: > On 5/30/19 2:20 PM, Segher Boessenkool wrote: > > On Wed, May 29, 2019 at 10:49:35PM -0500, Bill Schmidt wrote: > >> * config/rs6000/predicates.md (pcrel_address): New > >> define_predicate. > > Please put that on one line? > > OK. Emacs in ChangeLog and Fill modes seems to set a line length > somewhat less than 79. I generally follow what it tells me, but I can > fix this.
This would be just 76 ;-) > >> + if (offset) > >> + fprintf (file, "%s" HOST_WIDE_INT_PRINT_DEC, (offset > 0) ? "+" : "", > >> + offset); > > Maybe > > > > if (offset) > > fprintf (file, "%+" PRId64, offset); > > > > (but there really should be a HOST_WIDE_INT_PRINT_DEC_PLUS or similar for > > that then. Oh well). > > Will have a look. Very many things in GCC do this, but it's so inelegant :-) It's fine to commit it like this, as I said. But it annoys me every time I see it :-) Segher
