On Wed, May 22, 2019 at 6:36 PM Cherry Zhang <cherr...@google.com> wrote: > Jim, thank you for the fix! The patch looks good to me. Maybe we should also > apply this to __atomic_add_fetch_4 and __atomic_add_fetch_8?
Sorry about the delay, I caught a virus last week and am behind on everything. For 64-bit RISC-V those are open coded and hence not a problems. All of the major targets open code everything except RISC-V which needs a library call for the 1 and 2 byte atomics, though this is on our list of things to fix. We just haven't gotten around to it yet. For 32-bit RISC-V, the 8-byte atomic would require a library call, but 32-bit riscv-linux isn't formally supported, as the glibc patches are not upstream yet, so this isn't a practical problem yet. Anyways, yes, in theory, we should be handling these two also, but there probably aren't any well supported targets that will fail if they are missing. Jim
