Re: [Patch, Fortran, OOP] PR 63733: [4.8/4.9/5 Regression] wrong resolution for OPERATOR generics

2015-01-12 Thread Paul Richard Thomas
Dear Janus, Since it is a regression, by all means update the branches. We usually, propose delaying a bit but I am not convinced that this is effective for this kind of bug fix - usually, further problems take a long time to emerge. Thus, I would recommend that you get on with it. Thanks Paul

Re: [PATCH] fix visium build

2015-01-12 Thread Richard Biener
On Fri, 9 Jan 2015, Prathamesh Kulkarni wrote: > Hi, > The tree.h and tree-core.h flattening patch: > (https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00467.html > broke visium build. The attached patch fixes that. > Built on visium-elf. > OK to commit ? Ok. Thanks, Richard.

Re: [PATCH] ipa-icf.c: Fix issues generated by original latest commit

2015-01-12 Thread Richard Biener
On Sat, Jan 10, 2015 at 10:03 AM, Chen Gang S wrote: > The related commit is "275e275 IPA ICF: target and optimization flags > comparison.". For sem_function::equals_private(), fix the typo issue, > and for target_opts_for_fn(), fix access NULL issue. > > For cross compiling h8300, it will cause t

Re: [testsuite] PATCH: Correct target selector in gcc.target/i386/nop-mcount.c

2015-01-12 Thread Uros Bizjak
On Mon, Jan 12, 2015 at 1:31 AM, H.J. Lu wrote: > nonpic in target selector in gcc.target/i386/nop-mcount.c is ignored > since {} is misplaced. This patch properly places {} in target selector. > Tested on Linux/x86. OK for trunk? > > Thanks. > > H.J. > --- > gcc/testsuite/gcc.target/i386/nop-m

Re: [match-and-simplify] Remove printing "for expression"

2015-01-12 Thread Richard Biener
On Sat, 10 Jan 2015, Prathamesh Kulkarni wrote: > On 8 January 2015 at 17:52, Richard Biener wrote: > > On Sun, 21 Dec 2014, Prathamesh Kulkarni wrote: > > > >> Hi, > >> I removed printing "for expression:" from print_matches. I think it > >> is out of place tvim here and we call print_matches af

Re: PATCH: PR bootstrap/64561: [5 Regression] HAVE_LD_PIE_COPYRELOC is defined to 1 for broken linker

2015-01-12 Thread Uros Bizjak
On Mon, Jan 12, 2015 at 2:48 AM, H.J. Lu wrote: > Hi, > > This patch updates Linux/x86-64 linker test for PIE with copy reloc. > Tested with broken and working linkers on Linux/x86-64. OK to install? > > Thanks. > > > H.J. > --- > 2015-01-12 H.J. Lu > > PR bootstrap/64561 > * c

Re: [PATCH, testsuite] fix ggcplug.c test-case

2015-01-12 Thread Richard Biener
On Sun, 11 Jan 2015, Prathamesh Kulkarni wrote: > Hi, > The test-case plugin/ggcplug.c was failing due to flattening of tree.h > and tree-core.h. > Test-case was incorrect because it included gcc-plugin.h after tree.h whereas > gcc-plugin.h should be the first header to be included by plugins. No

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-12 Thread Richard Biener
On Sun, Jan 11, 2015 at 1:39 PM, Bernd Edlinger wrote: > Hi Richard, > > On Fri, 9 Jan 2015 17:19:57, Richard Biener wrote: >> >> >> Yes. As said, you generally need to run folding results through >> force_gimple_operand. >> >> Richard. >> > > > I have now used force_gimple_operand instead of spe

Re: [PATCH] ipa-icf.c: Fix issues generated by original latest commit

2015-01-12 Thread Martin Liška
On 01/12/2015 09:51 AM, Richard Biener wrote: On Sat, Jan 10, 2015 at 10:03 AM, Chen Gang S wrote: The related commit is "275e275 IPA ICF: target and optimization flags comparison.". For sem_function::equals_private(), fix the typo issue, and for target_opts_for_fn(), fix access NULL issue. Fo

Re: [PATCH, testsuite] fix ggcplug.c test-case

2015-01-12 Thread Prathamesh Kulkarni
On 12 January 2015 at 14:19, Richard Biener wrote: > On Sun, 11 Jan 2015, Prathamesh Kulkarni wrote: > >> Hi, >> The test-case plugin/ggcplug.c was failing due to flattening of tree.h >> and tree-core.h. >> Test-case was incorrect because it included gcc-plugin.h after tree.h whereas >> gcc-plugin

PR ipa/63470 (zero sized call_stmt)

2015-01-12 Thread Jan Hubicka
Hi, this ICE is caused by double updating in ipa-prop that reduces call stmt size once when it becomes speculative and again when it is turned to direct. Fixed by the following patch that makes updating to happen while duplication so ipa-prop needs to care only about case it turned real indirect c

Re: [PATCH] Fix undefined label problem after crossjumping (PR rtl-optimization/64536)

2015-01-12 Thread Richard Biener
On Fri, 9 Jan 2015, Jakub Jelinek wrote: > On Fri, Jan 09, 2015 at 03:10:16PM +0100, Richard Biener wrote: > > Well, you have until the end of next week ;) For GIMPLE this is > > a switch with all cases going to the same basic-block, right? > > I think we optimize that in cleanup_control_expr_gra

Re: [PATCH, testsuite] fix ggcplug.c test-case

2015-01-12 Thread Richard Biener
On Mon, 12 Jan 2015, Prathamesh Kulkarni wrote: > On 12 January 2015 at 14:19, Richard Biener wrote: > > On Sun, 11 Jan 2015, Prathamesh Kulkarni wrote: > > > >> Hi, > >> The test-case plugin/ggcplug.c was failing due to flattening of tree.h > >> and tree-core.h. > >> Test-case was incorrect beca

Re: [PATCH] Fix enum operands exchange in ipa-inline.c

2015-01-12 Thread Richard Biener
On Mon, Jan 12, 2015 at 7:58 AM, Hurugalawadi, Naveen wrote: > Hi, > > Sorry, Had forgot the ChangeLog. Ok, but please properly wrap the long lines, put '? gimple_...' on a new one. Thanks, Richard. > ChangeLog > 2015-01-12 Naveen H.S > > * ipa-inline.c (inline_small_functions): Swap

[PATCH] IPA ICF: handle correctly indirect_calls

2015-01-12 Thread Martin Liška
Hello. Following patch is needed to pass LTO compilation for chromium. IPA ICF verifies polymorphic types for functions that have any function call. I forgot to handle indirect_calls. Patch can bootstrap on x86_64-linux-pc and new regression is seen. Ready for trunk? Thanks, Martin >From d0f7f

Simplify badness metrics in inliner, take 2

2015-01-12 Thread Jan Hubicka
Hi, this is variant of my earlier patch I comited. It solves issues with -fprofile-use and various roundoff errors that triggered sanity checks (partly by disabling them). Bootstrapped/regtested x86_64-linux. Honza PR ipa/63967 PR ipa/64425 * ipa-inline.c (compute_uninli

[PATCH, autofdo] Some code cleanup

2015-01-12 Thread Yangfei (Felix)
Hi, The attached patch does some code cleanup for auto-profile.c: fix typos and remove some unnecessary MAX/MIN checks plus some "else". OK for the trunk? Index: gcc/auto-profile.c === --- gcc/auto-profile.c (revision 219297)

[match-and-simplify] Merge from trunk

2015-01-12 Thread Richard Biener
Committed. 2015-01-12 Richard Biener Merge from trunk r218478 through r219383.

Re: [PATCH] Fix enum operands exchange in ipa-inline.c

2015-01-12 Thread Hurugalawadi, Naveen
Hi Richard, Thanks for the quick review and comments. Please find attached the modified patch as per your suggestion. Thanks, Naveen From: Richard Biener Sent: Monday, January 12, 2015 2:48 PM To: Hurugalawadi, Naveen Cc: gcc-patches@gcc.gnu.org Subject:

[gomp4] Merge trunk r219425 (2015-01-10) into gomp-4_0-branch

2015-01-12 Thread Thomas Schwinge
Hi! In r219453, I have committed a merge from trunk r219425 (2015-01-10) into gomp-4_0-branch. Grüße, Thomas pgphl0a_xYFFn.pgp Description: PGP signature

Re: [PATCH] IPA ICF: handle correctly indirect_calls

2015-01-12 Thread Richard Biener
On Mon, Jan 12, 2015 at 10:29 AM, Martin Liška wrote: > Hello. > > Following patch is needed to pass LTO compilation for chromium. IPA ICF > verifies polymorphic types > for functions that have any function call. I forgot to handle > indirect_calls. > > Patch can bootstrap on x86_64-linux-pc and n

Re: [PATCH] Fix enum operands exchange in ipa-inline.c

2015-01-12 Thread Richard Biener
On Mon, Jan 12, 2015 at 10:36 AM, Hurugalawadi, Naveen wrote: > Hi Richard, > > Thanks for the quick review and comments. > > Please find attached the modified patch as per your suggestion. Ok. Richard. > Thanks, > Naveen > > From: Richard Biener > Sent

Re: Simplify badness metrics in inliner, take 2

2015-01-12 Thread Markus Trippelsdorf
On 2015.01.12 at 10:30 +0100, Jan Hubicka wrote: > this is variant of my earlier patch I comited. It solves issues with > -fprofile-use > and various roundoff errors that triggered sanity checks (partly by disabling > them). The new assert triggers during Firefox LTO build on ppc64: (final libx

[wwwdocs, patch] Update Fortran part of gcc-5/changes.html

2015-01-12 Thread Tobias Burnus
Hi all, hi Gerald, sync the changes from https://gcc.gnu.org/wiki/GFortran/News#GCC5 for the today's added compatibilty section and Janne's locale addition. If there are no objects or comments, I will commit it this evening Tobias, who is really behind reading fortran@gcc emails. Index: changes.

[PATCH]: Fix for PR ipa/64550

2015-01-12 Thread Martin Liška
Hello. Following patch is fix for PR ipa/64550 which can bootstrap on x86_64-linux-pc. Explanation for the patch is described here: [1]. I hope this is correct fix for such cases? Thanks, Martin [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64550 From bef79e6e5e0d7d8e555e9241ffcfb88a92552e1

Re: [PATCH, testsuite] fix ggcplug.c test-case

2015-01-12 Thread Prathamesh Kulkarni
On 12 January 2015 at 14:36, Richard Biener wrote: > On Mon, 12 Jan 2015, Prathamesh Kulkarni wrote: > >> On 12 January 2015 at 14:19, Richard Biener wrote: >> > On Sun, 11 Jan 2015, Prathamesh Kulkarni wrote: >> > >> >> Hi, >> >> The test-case plugin/ggcplug.c was failing due to flattening of tr

Re: [PATCH]: Fix for PR ipa/64550

2015-01-12 Thread Richard Biener
On Mon, 12 Jan 2015, Martin Liška wrote: > Hello. > > Following patch is fix for PR ipa/64550 which can bootstrap on > x86_64-linux-pc. > Explanation for the patch is described here: [1]. > > I hope this is correct fix for such cases? Ah, using TREE_THIS_VOLATILE on the result of ao_ref_base is

Re: [PATCH, testsuite] fix ggcplug.c test-case

2015-01-12 Thread Richard Biener
On Mon, 12 Jan 2015, Prathamesh Kulkarni wrote: > On 12 January 2015 at 14:36, Richard Biener wrote: > > On Mon, 12 Jan 2015, Prathamesh Kulkarni wrote: > > > >> On 12 January 2015 at 14:19, Richard Biener wrote: > >> > On Sun, 11 Jan 2015, Prathamesh Kulkarni wrote: > >> > > >> >> Hi, > >> >> T

Re: [PATCH, i386] Remove EBX usage from asm code

2015-01-12 Thread Evgeny Stupachenko
"frame_dummy" does not use EBX in allocation now as there are enough other registers (that we don't need to save/restore). So if we do not modify "frame_dummy" EBX should stay unchanged. "frame_dummy" does not initialize EBX register at the beginning it expects that EBX is pic from glibc "frame_dum

Re: [PATCH, i386] Remove EBX usage from asm code

2015-01-12 Thread Jakub Jelinek
On Mon, Jan 12, 2015 at 01:36:05PM +0300, Evgeny Stupachenko wrote: > "frame_dummy" does not use EBX in allocation now as there are enough > other registers (that we don't need to save/restore). So if we do not > modify "frame_dummy" EBX should stay unchanged. > "frame_dummy" does not initialize EB

Re: [PATCH, testsuite] fix ggcplug.c test-case

2015-01-12 Thread Prathamesh Kulkarni
On 12 January 2015 at 15:49, Richard Biener wrote: > On Mon, 12 Jan 2015, Prathamesh Kulkarni wrote: > >> On 12 January 2015 at 14:36, Richard Biener wrote: >> > On Mon, 12 Jan 2015, Prathamesh Kulkarni wrote: >> > >> >> On 12 January 2015 at 14:19, Richard Biener wrote: >> >> > On Sun, 11 Jan 2

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-12 Thread Andreas Schwab
I'm getting this testsuite regression: FAIL: gcc.dg/plugin/ggcplug.c compilation In file included from /usr/local/gcc/gcc-20150112/gcc/testsuite/../../gcc/tree.h:23:0, from /usr/local/gcc/gcc-20150112/gcc/testsuite/gcc.dg/plugin/ggcplug.c:8: /usr/local/gcc/gcc-2015011

Re: [PATCH][ARM][cleanup] Use R0_REGNUM and R1_REGNUM instead of 0 and 1 where appropriate

2015-01-12 Thread Ramana Radhakrishnan
On Thu, Dec 11, 2014 at 9:34 AM, Kyrill Tkachov wrote: > Hi all, > > While looking in this area on other business I noticed we could be using the > names R0_REGNUM > and R1_REGNUM when creating those REG rtxs since it's a bit more descriptive > that just 0 and 1. > > Tested arm-none-eabi. > > Ok f

Re: Simplify badness metrics in inliner, take 2

2015-01-12 Thread Markus Trippelsdorf
On 2015.01.12 at 10:59 +0100, Markus Trippelsdorf wrote: > On 2015.01.12 at 10:30 +0100, Jan Hubicka wrote: > > this is variant of my earlier patch I comited. It solves issues with > > -fprofile-use > > and various roundoff errors that triggered sanity checks (partly by > > disabling them). > >

Re: [PATCH, i386] Remove EBX usage from asm code

2015-01-12 Thread Evgeny Stupachenko
Agree, I've missed the usage of the function "__register_frame_info_bases" (frame_dummy assembly had only indirect call when I miss "-pie" in compilation). There is no reference on glibc that way. Sorry for the confusion. So that is potentially buggy right now. On Mon, Jan 12, 2015 at 1:50 PM, Ja

Re: [PATCH 0/2] Offloading from dlopened libraries

2015-01-12 Thread Ilya Verbin
Hi! How about this patch? It adds a new symbol into GOMP_4.0.1 symver, so it would be nice to include it into GCC 5 release. On 14 Nov 02:53, Ilya Verbin wrote: > This patch fixes offloading from dlopened libraries, part 1 is for libgomp and > part 2 is for intelmic plugin. > > How it works: >

[PATCH] Fix PR64530

2015-01-12 Thread Richard Biener
This fixes PR64530 by fixing a mistake (oops) in the iteration over all data-ref pairs in pg_add_dependence_edges. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2015-01-12 Richard Biener PR tree-optimization/64530 * tree-loop-distribution.c (pg_add_depe

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-12 Thread Prathamesh Kulkarni
On 12 January 2015 at 16:24, Andreas Schwab wrote: > I'm getting this testsuite regression: > > FAIL: gcc.dg/plugin/ggcplug.c compilation Fixed with r219458. Thanks, Prathamesh > > In file included from > /usr/local/gcc/gcc-20150112/gcc/testsuite/../../gcc/tree.h:23:0,

[PATCH] Fix PR64357

2015-01-12 Thread Richard Biener
The following patch fixes PR64357 (or papers over some latent issue). We were not protecting a certain aspect of simple latches properly (a simple latch should belong to its loop). Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2015-01-12 Richard Biener PR middl

[PATCH] Fix PR64535 - increase emergency EH buffers via a new allocator

2015-01-12 Thread Richard Biener
This "fixes" PR64535 by changing the fixed object size emergency pool to a variable EH object size (but fixed arena size) allocator. Via combining the dependent and non-dependent EH arenas this should allow around 600 bad_alloc throws in OOM situations on x86_64-linux compared to the current 64 w

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2015-01-12 Thread Andrew Stubbs
Ping. On 23/12/14 16:46, Andrew Stubbs wrote: On 03/12/14 15:03, Andrew Stubbs wrote: The tools have always allowed us to drop down the arch to march=armv5te along with using -mfpu=neon. We are now changing command line behaviour, so an inform in terms of diagnostics to the user would be useful

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2015-01-12 Thread Ramana Radhakrishnan
Sorry about the slow response- have been on holiday and still catching up on email. On 12/01/15 13:16, Andrew Stubbs wrote: Ping. On 23/12/14 16:46, Andrew Stubbs wrote: On 03/12/14 15:03, Andrew Stubbs wrote: The tools have always allowed us to drop down the arch to march=armv5te along with

C++ PATCH for c++/64547 (constexpr fn returning void)

2015-01-12 Thread Jason Merrill
In C++14 a constexpr function doesn't need to return a value. Tested x86_64-pc-linux-gnu, applying to trunk. commit 9675a7bde41b5430197854d8c1822c8f4d95b95e Author: Jason Merrill Date: Fri Jan 9 01:46:16 2015 -0500 PR c++/64547 * constexpr.c (cxx_eval_call_expression): A call to a v

[PATCH][ARM] Fix PR target/64460: Set 'shift' attr properly on some patterns

2015-01-12 Thread Kyrill Tkachov
Hi all, In this PR we ICE when compiling with -mtune=xscale. The ICE is a segfault in xscale_sched_adjust_cost. The root cause is that xscale_sched_adjust_cost uses the value of the 'shift' insn attribute to index the recog operands. In GCC 5 the form and number of operands in those patterns w

Re: [PATCH][ARM] Fix PR target/64460: Set 'shift' attr properly on some patterns

2015-01-12 Thread Kyrill Tkachov
Now with patch attached Kyrill On 12/01/15 14:27, Kyrill Tkachov wrote: Hi all, In this PR we ICE when compiling with -mtune=xscale. The ICE is a segfault in xscale_sched_adjust_cost. The root cause is that xscale_sched_adjust_cost uses the value of the 'shift' insn attribute to index the reco

Re: [PATCH][ARM] Implement TARGET_SCHED_MACRO_FUSION_PAIR_P

2015-01-12 Thread Ramana Radhakrishnan
On Thu, Dec 4, 2014 at 9:19 AM, Kyrill Tkachov wrote: > > On 02/12/14 22:58, Ramana Radhakrishnan wrote: >> >> On Tue, Nov 11, 2014 at 11:55 AM, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> This is the arm implementation of the macro fusion hook. >>> It tries to fuse movw+movt operations toge

Re: [PATCH 7/10] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin

2015-01-12 Thread Thomas Schwinge
Hi! On Tue, 23 Sep 2014 19:19:31 +0100, Julian Brown wrote: > This patch contains the bulk of the OpenACC 2.0 runtime support, [...] > --- /dev/null > +++ b/libgomp/libgomp-plugin.c > @@ -0,0 +1,106 @@ > +/* Exported (non-hidden) functions exposing libgomp interface for plugins. > */ > +voi

[PATCH] Fix PR64404

2015-01-12 Thread Richard Biener
I am testing the following patch to fix a latent bug in the vectorizer dealing with redundant DRs. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2015-01-12 Richard Biener PR tree-optimization/64404 * tree-vect-stmts.c (vectorizable_load): Use the proper

Re: [PATCH 7/10] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin

2015-01-12 Thread Thomas Schwinge
Hi! On Tue, 23 Sep 2014 19:19:31 +0100, Julian Brown wrote: > This patch contains the bulk of the OpenACC 2.0 runtime support, [...] > --- /dev/null > +++ b/libgomp/libgomp-plugin.h > @@ -0,0 +1,57 @@ > +/* An interface to various libgomp-internal functions for use by plugins. */ ..., and in

Re: [PATCH 7/10] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin

2015-01-12 Thread Thomas Schwinge
Hi! On Mon, 12 Jan 2015 15:37:46 +0100, I wrote: > On Tue, 23 Sep 2014 19:19:31 +0100, Julian Brown > wrote: > > This patch contains the bulk of the OpenACC 2.0 runtime support, [...] > > --- /dev/null > > +++ b/libgomp/plugin-nvptx.c > > @@ -0,0 +1,1854 @@ > > +/* Plugin for NVPTX execution. >

Re: [x86, PATCH] operand reordering for commutative operations

2015-01-12 Thread Yuri Rumyantsev
Hi All, Thanks a lot for your comments. I've re-written reorder_operands as you proposed, but I'd like to know if we should apply this reordering at -O0? I will re-send the patch after testing completion. Thanks. Yuri. 2015-01-09 13:13 GMT+03:00 Richard Biener : > On Mon, Jan 5, 2015 at 9:26 PM,

Re: [x86, PATCH] operand reordering for commutative operations

2015-01-12 Thread Richard Biener
On Mon, Jan 12, 2015 at 4:00 PM, Yuri Rumyantsev wrote: > Hi All, > > Thanks a lot for your comments. > I've re-written reorder_operands as you proposed, but I'd like to know > if we should apply this reordering at -O0? No, I think we can spare those cycles there. Richard. > I will re-send the

[PATCH][Aarch64] PR64149: Remove -mlra/-mno-lra option for Aarch64.

2015-01-12 Thread Matthew Wahab
Hello, The LRA register is enabled by default for the Aarch64 backend and -mno-lra should no longer be used. This patch removes the -mlra/-mno-lra option for AArch64. Tested aarch64-none-linux-gnu with gcc-check. Matthew 2015-01-08 Matthew Wahab PR target/64149 * config/

[PATCH] Fix PR64436: broken logic to process bitwise ORs in bswap pass

2015-01-12 Thread Thomas Preud'homme
Hi all, To identify if a set of loads, shift, cast, mask (bitwise and) and bitwise OR is equivalent to a load or byteswap, the bswap pass assign a number to each byte loaded according to its significance (1 for lsb, 2 for next least significant byte, etc.) and form a symbolic number such as 0x0

[PATCH,MIPS] Add support for the R6 LSA and DLSA instructions

2015-01-12 Thread Matthew Fortune
This patch adds support for the R6 [D]LSA instructions. The support has been structured to allow MSA (when implemented) to turn on the same instructions as they are also added by the MSA ASE. I have continued to use the idea of 'ghost' options in the testsuite to indicate what features are requir

[PATCH] Fix PR64568

2015-01-12 Thread Richard Biener
The following avoids splitting TARGET_MEM_REFs by attaching REAL/IMAGPART_EXPRs around it which isn't allowed. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2014-01-12 Richard Biener PR tree-optimization/64568 * tree-ssa-forwprop.c (pass_forwprop::execu

[PATCH,MIPS] Only pass floating-point options to the assembler then

2015-01-12 Thread Matthew Fortune
The new behaviour of the GCC driver passing floating point options like -msoft-float to the assembler is essential for the new o32 ABI extensions but is a change in behaviour. In particular GCC 5 used with binutils 2.24 would require a user to fix any hand-crafted code that made use of floating-poi

[PATCH][AArch64] Use target builtin instead of __builtin_sqrt for vsqrt_f64

2015-01-12 Thread Kyrill Tkachov
Hi all, As raised in https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01237.html and discussed in that thread, using __builtin_sqrt for vsqrt_f64 may end up in a call to the library sqrt at -O0. To avoid that this patch uses a target builtin for sqrt on DF mode and uses that to implement the intr

[PATCH][test] Gate gcc.dg/aru-2.c test on profiling support

2015-01-12 Thread Kyrill Tkachov
Hi all, This recently added test adds -pg to its dg-options but not all targets support this and fail at link-time with "bin/ld: cannot find -lc_p". Looking around I see that all tests that use -pg also do a dg-require-profiling. This patch adds that. With this patch the test doesn't FAIL

[PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-01-12 Thread H.J. Lu
On Fri, Jan 09, 2015 at 01:58:45PM +0100, Richard Biener wrote: > On Tue, Dec 30, 2014 at 10:23 PM, Magnus Granberg wrote: > > fredag 14 november 2014 23.31.48 skrev Magnus Granberg: > >> måndag 10 november 2014 21.26.39 skrev Magnus Granberg: > >> > > Rainer > >> > > >> > Thanks Rainer for th

[PATCH,MIPS] Remove all excess parallel constructs

2015-01-12 Thread Matthew Fortune
I found while checking ToT test status... define_insn implicitly wraps the pattern in a parallel if there are multiple instructions. Several MIPS patterns have an explicit parallel which is mostly handled correctly but the code in 'gen_insn' does not manage to locate the clobbers inside an explici

Re: [Patch, Fortran, OOP] PR 63733: [4.8/4.9/5 Regression] wrong resolution for OPERATOR generics

2015-01-12 Thread Janus Weil
Good, I fully agree. Fortunately the patch applies cleanly to the 4.9 branch and regtests without errors. Thus I have applied it as r219475. Will do 4.8 soon. Cheers, Janus 2015-01-12 9:30 GMT+01:00 Paul Richard Thomas : > Dear Janus, > > Since it is a regression, by all means update the branch

[gomp4] Replace enum omp_clause_map_kind with enum gomp_map_kind (was: Including a file from include/ in gcc/*.h)

2015-01-12 Thread Thomas Schwinge
Hi! On Mon, 22 Dec 2014 16:13:01 +0100, I wrote: > I'm sending this again with some more people copied -- because I see > you're working on tree.h/tree-core.h flattening, or know you're familiar > with GCC plugins. ;-) Here is a question concerning both of that, where > I'd appreciate your input.

Re: [PATCH] config/h8300/h8300.c: Regress part of the original commit for fixing issue

2015-01-12 Thread Jeff Law
On 01/11/15 07:02, Chen Gang S wrote: The related commit "1a1ed14 config/h8300: Use rtx_insn" gives an extra check for rtx, which will cause building libgcc break, after regress it, it can still generate the correct assemble code. The related information is below: [root@localhost libgcc]# ca

Re: [Patch, i386] Support BMI and BMI2 targets in multiversioning

2015-01-12 Thread Uros Bizjak
Hello! >> On Wed, Dec 31, 2014 at 01:28:47PM +0100, Allan Sandfeld Jensen wrote: >> > I recently wanted to use multiversioning for BMI2 specific extensions >> > PDEP/PEXT, and noticed it wasn't there. So I wrote this patch to add it, >> > and also added AES, F16C and BMI1 for completeness. >> >> A

PATCH: PR testsuite/64427: gcc.target/i386/pr64291-1.c is invalid

2015-01-12 Thread H.J. Lu
Hi, gcc.target/i386/pr64291-1.c has 2 issues: 1. Stack variables, n and d, aren't initialized. 2. dnp[dn - 1] |= 1UL<<63; doesn't work with 32-bit long. I am checking this patch from https://gcc.gnu.org/bugzilla/attachment.cgi?id=34342 as an obvious fix. H.J. 2015-01-12 Marc Glisse

[PATCH, committed] jit: API change to gcc_jit_context_new_global

2015-01-12 Thread David Malcolm
This is an API change to one of the libgccjit.h entrypoints. Although we don't yet guarantee API stability for libgccjit, I'm loathe to break things without strong reasons. I think that in this case the reasons *are* sufficient (see below), and hence I feel that it's best to get this change in now

Re: [PATCH][AArch64] Use target builtin instead of __builtin_sqrt for vsqrt_f64

2015-01-12 Thread Andrew Pinski
On Mon, Jan 12, 2015 at 7:52 AM, Kyrill Tkachov wrote: > Hi all, > > As raised in https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01237.html and > discussed in that thread, using __builtin_sqrt for vsqrt_f64 may end up in a > call to the library sqrt at -O0. To avoid that this patch uses a target >

Re: [PATCH] config/h8300/h8300.c: Regress part of the original commit for fixing issue

2015-01-12 Thread Jeff Law
On 01/12/15 10:01, Jeff Law wrote: This indicates a violation of the type safety invariants we're adding to GCC. Simply changing the code to use rtx rather than rtx_insn is probably a step in the wrong direction. Part of the problem here is that RTX_FRAME_RELATED_P is valid on both rtx_insn and

Re: [PATCH][test] Gate gcc.dg/aru-2.c test on profiling support

2015-01-12 Thread Jeff Law
On 01/12/15 08:54, Kyrill Tkachov wrote: Hi all, This recently added test adds -pg to its dg-options but not all targets support this and fail at link-time with "bin/ld: cannot find -lc_p". Looking around I see that all tests that use -pg also do a dg-require-profiling. This patch adds that.

Re: [gomp4] Replace enum omp_clause_map_kind with enum gomp_map_kind (was: Including a file from include/ in gcc/*.h)

2015-01-12 Thread Jakub Jelinek
On Mon, Jan 12, 2015 at 05:32:14PM +0100, Thomas Schwinge wrote: > I have now committed the patch to gomp-4_0-branch in the following form. > The issues raised above remain to be resolved. > > In spirit against the tree.h header flattening, I had to keep the > #include "include/gomp-constants.h" i

Re: [PATCH, i386] Remove EBX usage from asm code

2015-01-12 Thread Jeff Law
On 01/12/15 04:56, Evgeny Stupachenko wrote: Agree, I've missed the usage of the function "__register_frame_info_bases" (frame_dummy assembly had only indirect call when I miss "-pie" in compilation). There is no reference on glibc that way. Sorry for the confusion. So that is potentially buggy r

Re: [PATCH] add option to emit more array bounds warnigs

2015-01-12 Thread Jeff Law
On 11/11/14 23:13, Martin Uecker wrote: Hi, this proposed patch adds an option "-Warray-bounds=" in addition to "-Warray-bound". "-Warray-bounds=1" corresponds to "-Warray-bound". For higher warning levels more warnings about optional accesses outside of arrays are emitted. For example, warning

Re: [testsuite] PATCH: Add check_effective_target_pie

2015-01-12 Thread Jeff Law
On 01/11/15 16:58, H.J. Lu wrote: Hi, This patch adds check_effective_target_pie to check if the current multilib generatse PIE by default. I will submit other patches to use it. OK for trunk? Thanks. H.J. --- 2015-01-11 H.J. Lu * gcc.target/i386/pie.c: New test. * lib/t

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-12 Thread Caroline Tice
On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast wrote: > A short recap again: > > Latest patch, changelog and a test program (further information about > the program in the mail): > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html > > > Approved: > * gcc/config/i386/* > * libgcc/* > * li

Re: [testsuite] PATCH: Support PIE in gcc.dg/tree-ssa/ssa-store-ccp-3.c

2015-01-12 Thread Jeff Law
On 01/11/15 17:25, H.J. Lu wrote: target nonpic is always false for -fPIE since it defines both __PIC__ and __PIE__. This patch changes gcc.dg/tree-ssa/ssa-store-ccp-3.c to make it to pass with -fPIE by excluding PIE when nonpic is true. OK to for trunk? Thanks. H.J. --- gcc/testsuite/gcc.d

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-12 Thread Jeff Law
On 01/10/15 05:51, Richard Sandiford wrote: I agree this is the kind of thing we'd need to consider if we were deciding whether it's valid to connect a (lo_sum (high x+N) x+N) to an existing (high x). But this code is handling cases where the connection has already been made and we're trying to

Re: [PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-12 Thread Mike Stump
On Jan 11, 2015, at 2:33 PM, Prathamesh Kulkarni wrote: > oops, sorry about this. We will build further flattening patches with > --enable-languages=all,go,jit,ada. > Shall that cover all the front-ends ? No objc++ is non-default: $ grep build_by_default */config-lang.in go/config-lang.in:build

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-12 Thread Jeff Law
On 01/10/15 09:35, Matthew Fortune wrote: I guess so. I took the phrasing below for (high:m exp) to mean that high only made sense when used with lo_sum. True. But one can use a single high with different lo_sum expressions when those lo_sum expressions are related. So you might have a singl

Re: [PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-12 Thread Prathamesh Kulkarni
On 13 January 2015 at 00:01, Mike Stump wrote: > On Jan 11, 2015, at 2:33 PM, Prathamesh Kulkarni > wrote: >> oops, sorry about this. We will build further flattening patches with >> --enable-languages=all,go,jit,ada. >> Shall that cover all the front-ends ? > > No objc++ is non-default: Thanks!

Re: [RFC PATCH] Handle sequence in reg_set_p

2015-01-12 Thread Jeff Law
On 01/11/15 04:40, Oleg Endo wrote: Any particular reason why the SEQUENCE handling isn't done first, then the REG_INC and CALL insn handling? I'd probably explicitly return false if we had a sequence and none of its elements returned true. There's no need to check anything on the toplevel SEQU

Re: [COMMITTED] Merge libffi with upstream

2015-01-12 Thread Uros Bizjak
Hello! > Upstream libffi has added support for Go closures (using the static chain), > and support for complex numbers. Perhaps less relevant is new support for > arc, microblaze, moxie, nios, and or1k targets. > > Without additional changes for Go, this merge has little effect. Within the > gcc

Re: [testsuite] PATCH: Add check_effective_target_pie

2015-01-12 Thread H.J. Lu
On Mon, Jan 12, 2015 at 10:09 AM, Jeff Law wrote: > On 01/11/15 16:58, H.J. Lu wrote: >> >> Hi, >> >> This patch adds check_effective_target_pie to check if the current >> multilib generatse PIE by default. I will submit other patches to use >> it. OK for trunk? >> >> Thanks. >> >> H.J. >> --- >

Re: [testsuite] PATCH: Add check_effective_target_pie

2015-01-12 Thread Jeff Law
On 01/12/15 12:29, H.J. Lu wrote: Is this an inherent restriction of -fPIE, or is it merely an implementation detail? If the latter, is that implementation detail a target issue? ie, could we have a target that supports profiling in conjunction with -fPIE? If so, then this test seems too restr

[PATCH, committed] jit-playback.c: fix missing fclose

2015-01-12 Thread David Malcolm
Reported by David Binderman within discussion of PR jit/63854. Before/after jit.sum has 7272 passes. Committed to trunk as r219487. gcc/jit/ChangeLog: * jit-playback.c (gcc::jit::playback::context::read_dump_file): Add missing fclose on error-handling path. --- gcc/jit/jit-playb

[PATCH] Fix REE for vector modes (PR rtl-optimization/64286)

2015-01-12 Thread Jakub Jelinek
Hi! As mentioned in the PR, giving up for all vector mode extensions is unnecessary, but unlike scalar integer extensions, where the low part of the extended value is the original value, for vectors this is not true, thus the old value is lost. Which means we can perform REE, but only if all uses

[PATCH] Fix VRP ICE with -Wtype-limits (PR tree-optimization/64563)

2015-01-12 Thread Jakub Jelinek
Hi! On the following testcase we ICE with -Os -Wtype-limits, as VR_UNDEFINED has NULL vr0->min and vr0->max. From what the code does I believe the code only means to handle VR_RANGE and not anything else. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2015-01-12 Jakub Jel

Re: LTO streaming of TARGET_OPTIMIZE_NODE

2015-01-12 Thread Jan Hubicka
> On 09 Jan 12:45, Jakub Jelinek wrote: > > --- gcc/cgraphunit.c.jj 2015-01-09 12:01:33.0 +0100 > > +++ gcc/cgraphunit.c2015-01-09 12:22:27.742692667 +0100 > > @@ -2108,11 +2108,14 @@ ipa_passes (void) > >if (g->have_offload) > > { > > section_name_prefix = OFF

[PATCH] Install libgcj.pc as libgcj-5.pc rather than libgcj-5.0.pc (PR libgcj/64219)

2015-01-12 Thread Jakub Jelinek
Hi! This patch changes the libgcj*.pc installed filename to match the new GCC versioning scheme. Bootstrapped/regtested on x86_64-linux and i686-linux, tested make install. -rw-r--r--. 1 jakub jakub 192 Jan 12 21:02 /tmp/blah/usr/local/lib64/pkgconfig/libgcj-5.pc -rw-r--r--. 1 jakub jakub 192 J

[PATCH] Fix up some gcc.dg/vect/ testcases with -fpic (PR testsuite/64028)

2015-01-12 Thread Jakub Jelinek
Hi! Various gcc.dg/vect/ testcases now fail on the trunk with -fpic. The problem is that they expect that the global vars bind locally and vectorizer can increase their alignment, but with -fpic that does not work, as one can interpose them. Fixed by adding dg-add-options bind_pic_locally. Boots

[PATCH] Use ldexp instead of scalbln for portability (PR other/64370)

2015-01-12 Thread Jakub Jelinek
Hi! As mentioned in the PR, HPUX doesn't have scalbln, but does have ldexp and that function is already used in gcj-dump, so supposedly it is more portable to use ldexp. Also in glibc it is defined in libc in addition to libm. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

Re: [testsuite] PATCH: Add check_effective_target_pie

2015-01-12 Thread H.J. Lu
On Mon, Jan 12, 2015 at 12:03 PM, Jeff Law wrote: > On 01/12/15 12:59, H.J. Lu wrote: >> >> I don't know if -pg will work PIE on any targets. For Linux/x86 >> the choices of crt1.o are >> >> %{!shared: %{pg|p|profile:gcrt1.o%s;pie:Scrt1.o%s;:crt1.o%s}} >> >> -shared, -pg and -pie are mutually exc

[PATCH 1/4] Core definition for APM XGene-1 and associated cost-table.

2015-01-12 Thread Philipp Tomsich
To keep this change separately buildable from the pipeline model, this patch directs the APM XGene-1 to use the generic scheduling model. --- gcc/ChangeLog-2014 | 8 +++ gcc/config/aarch64/aarch64-cores.def | 1 + gcc/config/aarch64/aarch64-tune.md | 2 +- gcc/config/aarc

[PATCH 3/4] Change the type of the prefetch-instructions to 'prefetch'.

2015-01-12 Thread Philipp Tomsich
--- gcc/config/aarch64/aarch64.md | 2 +- gcc/config/arm/types.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index 1f6b1b6..98f4f30 100644 --- a/gcc/config/aarch64/aarch64.md +++ b/gcc/config/aarch64/aar

[PATCH 2/4] Pipeline model for APM XGene-1.

2015-01-12 Thread Philipp Tomsich
--- gcc/config/aarch64/aarch64.md | 1 + gcc/config/arm/xgene1.md | 531 ++ 2 files changed, 532 insertions(+) create mode 100644 gcc/config/arm/xgene1.md diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index 12e1054..1f6b

[PATCH 0/4, AArch64, v4] APM X-Gene 1 cost-table and pipeline model

2015-01-12 Thread Philipp Tomsich
Marcus & Ramana, Attached is the updated---and hopefully final---revision of the changes to get XGene-1 properly wired up in the AArch64 and AArch64 backends. On the AArch64 side, we've only removed the URL from the credits of the xgene1.md file and the remaining content is unchanged (safe for

[PATCH 4/4] Wire X-Gene 1 up in the ARM (32bit) backend as a AArch32-capable core.

2015-01-12 Thread Philipp Tomsich
--- gcc/ChangeLog-2014| 10 ++ gcc/config/arm/arm-cores.def | 1 + gcc/config/arm/arm-tables.opt | 3 +++ gcc/config/arm/arm-tune.md| 3 ++- gcc/config/arm/arm.c | 22 ++ gcc/config/arm/arm.md | 11 +-- gcc/config/arm/bpabi.h

[PATCH] Fix up computed goto on POINTERS_EXTEND_UNSIGNED targets (PR middle-end/63974)

2015-01-12 Thread Jakub Jelinek
Hi! The 991213-3.c testcase ICEs on aarch64-linux with -mabi=ilp32 since wide-int merge. The problem is that x = convert_memory_address (Pmode, x) is used twice on a VOIDmode CONST_INT, which is wrong. For non-VOIDmode rtl the second convert_memory_address is a NOP, but for VOIDmode the second ca

[PATCH] Fix PR64461, Incorrect code on coldfire targets

2015-01-12 Thread Jeff Law
As suggested by Andreas in the PR, the simplest fix for this problem is to disable the various trunc* patterns for TARGET_COLDFIRE. That's precisely what this patch does. Built cross compilers with and without the m68k.md hunk. Verified the test failed without the m68k.mk hunk and passed w

[PATCH] Fix -mstack-arg-probe (PR target/64513)

2015-01-12 Thread Jakub Jelinek
Hi! For -mstack-arg-probe we push %rax and/or %r10 in the prologue, and mark that insn as RTX_FRAME_RELATED_P. But that means that the dwarf2 pass also considers that the %rax/%r10 registers, which are call used, to be saved in the unwind info, but they are never restored, which makes the dwarf2

  1   2   >