Hi Richard,

Thanks for the quick review and comments.

Please find attached the modified patch as per your suggestion.

Thanks,
Naveen
________________________________________
From: Richard Biener <richard.guent...@gmail.com>
Sent: Monday, January 12, 2015 2:48 PM
To: Hurugalawadi, Naveen
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix enum operands exchange in ipa-inline.c

On Mon, Jan 12, 2015 at 7:58 AM, Hurugalawadi, Naveen
<naveen.hurugalaw...@caviumnetworks.com> wrote:
> Hi,
>
> Sorry, Had forgot the ChangeLog.

Ok, but please properly wrap the long lines, put '? gimple_...' on a new
one.

Thanks,
Richard.

> ChangeLog
> 2015-01-12  Naveen H.S  <naveen.hurugalaw...@caviumnetworks.com>
>
>         * ipa-inline.c (inline_small_functions): Swap the operands in
>         enum.
>
> Thanks,
> Naveen
--- gcc/ipa-inline.c	2015-01-12 14:55:25.291575873 +0530
+++ gcc/ipa-inline.c	2015-01-12 14:56:01.795575453 +0530
@@ -1730,10 +1730,12 @@ inline_small_functions (void)
 		   " to be inlined into %s/%i in %s:%i\n"
 		   " Estimated badness is %f, frequency %.2f.\n",
 		   edge->caller->name (), edge->caller->order,
-		   edge->call_stmt ? "unknown"
-		   : gimple_filename ((const_gimple) edge->call_stmt),
-		   edge->call_stmt ? -1
-		   : gimple_lineno ((const_gimple) edge->call_stmt),
+		   edge->call_stmt
+		   ? gimple_filename ((const_gimple) edge->call_stmt)
+		   : "unknown",
+		   edge->call_stmt
+		   ? gimple_lineno ((const_gimple) edge->call_stmt)
+		   : -1,
 		   badness.to_double (),
 		   edge->frequency / (double)CGRAPH_FREQ_BASE);
 	  if (edge->count)

Reply via email to