On 12 January 2015 at 14:36, Richard Biener <rguent...@suse.de> wrote: > On Mon, 12 Jan 2015, Prathamesh Kulkarni wrote: > >> On 12 January 2015 at 14:19, Richard Biener <rguent...@suse.de> wrote: >> > On Sun, 11 Jan 2015, Prathamesh Kulkarni wrote: >> > >> >> Hi, >> >> The test-case plugin/ggcplug.c was failing due to flattening of tree.h >> >> and tree-core.h. >> >> Test-case was incorrect because it included gcc-plugin.h after tree.h >> >> whereas >> >> gcc-plugin.h should be the first header to be included by plugins. >> > >> > No, it should be definitely included _after_ config.h, system.h >> > and coretypes.h. >> gcc-plugin.h already includes these files. Shall I remove config.h, >> system.h and coretypes.h >> from ggcplug.c instead ? > > No, keep the patch simple for now - we are inconsitent in all the > testsuite plugins it seems and wasn't the idea that plugins _only_ > need to include gcc-plugin.h now? Thus I'd rather cleanup all > plugin testcases at once, with a separate patch. I thought gcc-plugin.h would contain include dependencies of all headers (to make plugins transparent to include restructuring) and if a plugin needs a particular header, it should explicitly include it. Or am I missing something ? > > Thanks, > Richard. > >> > >> > Ok with moving it after coretypes.h. Shall I commit the patch after this change since this is the only plugin test case that's failing ?
Thanks, Prathamesh >> > >> > Thanks, >> > Richard. >> >> > > -- > Richard Biener <rguent...@suse.de> > SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Jennifer Guild, > Dilip Upmanyu, Graham Norton HRB 21284 (AG Nuernberg)
