Fix coverage inaccuracy with return in C/C++

2014-11-10 Thread Eric Botcazou
We just remarked that there is a coverage inaccuracy in C/C++ for something as simple as: void foo (int i) { if (i > 1) return; bar (); } The return line is always reported as covered, even at -O0. That's because the return is used as the "representative return" for the entire functio

[PATCH][14/n] Merge from match-and-simplify, more conversion patterns

2014-11-10 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener * match.pd: Move rest of the conversion combining patterns from tree-ssa-forwprop.c. * tree-ssa-forwprop.c (combine_conversions): Remove. (pass_forwprop::execute):

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Roman Gareev
> The patch looks great. The only piece I think we missed is the > fgraphite-code-generator flag. I would propose to remove it as well in this > commit, as it does not have any effect any more. In this case, we’ll also have to change tests which use fgraphite-code-generator flag (isl-ast-gen-block

[PATCH GCC]Fix checking on MAX_PENDING_LIST_LENGTH

2014-11-10 Thread Bin Cheng
Hi, There is parameter max-pending-list-length in gcc scheduler, but the parameter is checked using greater than condition. As a result, the real max pending list length is actually "max-pending-list-length + 1". This patch fixes this by using ">=" rather than ">" comparison operator. Though it

[PATCH] Fix a few UNRESOLVEDs

2014-11-10 Thread Marek Polacek
This fixes a few UNRESOLVEDs because I forgot to skip -fno-fat-lto-objects when I introduced the tests. Ok for trunk? 2014-11-10 Marek Polacek * c-c++-common/ubsan/align-7.c: Skip for -flto -fno-fat-lto-objects. * c-c++-common/ubsan/align-8.c: Likewise. * g++.dg/ubsan/

Re: [PATCH] AIX: Filename-based shared library versioning for libgcc_s

2014-11-10 Thread Michael Haubenwallner
Am 2014-11-07 20:52, schrieb David Edelsohn: > First, please explicitly copy me on AIX or PowerPC patches sent to > gcc-patches. > > I don't have a fundamental objection to including this option, but > note that Richi, Honza and I have discovered that using AIX runtime > linking option interacts

[PATCH] Fix PR63798

2014-11-10 Thread Richard Biener
The following patch fixes a latent bug uncovered by stmt folding that expansion of FMA_EXPR didn't consider the multiplication commutative when looking for feeding negates. Bootstrap & regtest pending. Richard. 2014-11-10 Richard Biener PR middle-end/63798 * expr.c (expand_e

Re: [PATCH] Fix a few UNRESOLVEDs

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 10:41:36AM +0100, Marek Polacek wrote: > This fixes a few UNRESOLVEDs because I forgot to skip -fno-fat-lto-objects > when I introduced the tests. > > Ok for trunk? > > 2014-11-10 Marek Polacek > > * c-c++-common/ubsan/align-7.c: Skip for -flto -fno-fat-lto-objec

[PATCH] IPA ICF fallout: disable IPA ICF for a test

2014-11-10 Thread Martin Liška
Hello. In gcc.dg/tree-ssa/ldist-19.c, there's a pair of functions (one with 'char' and second with 'unsigned char'). These two functions are merged by IPA ICF on targets that where 'char' == 'unsigned char'. So that it would be easier to disable the optimization. Ready for trunk? Thanks, Mar

[PATCH][15/n] Merge from match-and-simplify, last conversion pattern

2014-11-10 Thread Richard Biener
This merges the last conversion pattern from tree-ssa-forwprop.c. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener * match.pd: Implement pattern from simplify_conversion_from_bitmask. * tree-ssa-forwprop.c (simplify_conversion_

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Richard Biener
On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu wrote: > Hi, > > r216964 disables bootstrap for libcc1 which exposed 2 things: > > 1. libcc1 isn't compiled with LTO even when GCC is configured with > "--with-build-config=bootstrap-lto". It may be intentional since > libcc1 is disabled for bootstrap. > 2.

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Richard Biener
On Sun, Nov 9, 2014 at 5:57 PM, Jack Howarth wrote: > Iain, > It doesn't look like it will be that simple. If I replace the > proposed patches with a change like... > > Index: gcc/system.h > === > --- gcc/system.h(revisio

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Tobias Grosser
On 10.11.2014 10:03, Roman Gareev wrote: The patch looks great. The only piece I think we missed is the fgraphite-code-generator flag. I would propose to remove it as well in this commit, as it does not have any effect any more. In this case, we’ll also have to change tests which use fgraphite-

Re: [PATCH] Fix PR 63748

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 2:33 AM, Patrick Palka wrote: > PR 63748 reports a false-positive uninitialized warning under the > presence of abnormal edges. The statements for which the uninitialized > warnings are emitted all look like: > > buf_117(ab) = buf_317(D)(ab); > > This PR is similar to PR

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrote: > On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu wrote: > > Hi, > > > > r216964 disables bootstrap for libcc1 which exposed 2 things: > > > > 1. libcc1 isn't compiled with LTO even when GCC is configured with > > "--with-build-config=bootstr

Re: [PATCH GCC]Fix checking on MAX_PENDING_LIST_LENGTH

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 10:16 AM, Bin Cheng wrote: > Hi, > There is parameter max-pending-list-length in gcc scheduler, but the > parameter is checked using greater than condition. As a result, the real > max pending list length is actually "max-pending-list-length + 1". This > patch fixes this

Re: [PATCH] IPA ICF fallout: disable IPA ICF for a test

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 11:51 AM, Martin Liška wrote: > Hello. > > In gcc.dg/tree-ssa/ldist-19.c, there's a pair of functions (one with 'char' > and second with 'unsigned char'). These two functions are merged by IPA ICF > on targets that where 'char' == 'unsigned char'. So that it would be easier

Re: [PATCH] Fix PR 63748

2014-11-10 Thread Eric Botcazou
> > Full bootstrap + regtesting on x86_64-unknown-linux-gnu is in progress. > > Is this patch OK if testing succeeds with no new regressions? > > ... ok. But please watch for fallout. I'd do a bootstrap with Ada enabled, the Ada compiler is the only serious user of abnormal edges in GIMPLE on L

Re: [PATCH] Fix PR63798

2014-11-10 Thread Václav Zeman
On 10 November 2014 10:55, Richard Biener wrote: > > > The following patch fixes a latent bug uncovered by stmt folding > that expansion of FMA_EXPR didn't consider the multiplication > commutative when looking for feeding negates. > > Bootstrap & regtest pending. > > Richard. > > 2014-11-10 Richa

Re: [RFC] Elimination of zext/sext - type promotion pass

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 12:29 AM, Kugan wrote: > >> Well - the best way would be to expose the target specifics to GIMPLE >> at some point in the optimization pipeline. My guess would be that it's >> appropriate after loop optimizations (but maybe before induction variable >> optimization). >> >>

[PATCH] Plug SSA stmt operand leak

2014-11-10 Thread Richard Biener
The following patch plugs a leak in SSA stmt operands. finalize_ssa_uses always frees all old operands and then allocates new ones - but in freeing the old operands it only inserts the first freed one into the freelist. The following patch makes us use the same trick as free_stmt_operands to lin

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Ilya Enkovich
2014-11-10 14:53 GMT+03:00 Richard Biener : > On Sun, Nov 9, 2014 at 5:57 PM, Jack Howarth wrote: >> Iain, >> It doesn't look like it will be that simple. If I replace the >> proposed patches with a change like... >> >> Index: gcc/system.h >> ==

Re: [PATCH 7/8] Model cache auto-prefetcher in scheduler

2014-11-10 Thread Maxim Kuvyrkov
On Oct 21, 2014, at 8:06 AM, Maxim Kuvyrkov wrote: > Hi, > > This patch adds auto-prefetcher modeling to GCC scheduler. The > auto-prefetcher model is currently enabled only for ARM Cortex-A15, since > this is the only CPU that I know of to have the hardware auto-prefetcher unit. > > The doc

Re: Fix libgomp crash without TLS (PR42616)

2014-11-10 Thread Varvara Rainchik
*Ping* 2014-10-13 14:48 GMT+04:00 Varvara Rainchik : >> Now, I wonder on which OS and why does config/tls.m4 CHECK_GCC_TLS >> actually fail? Can you figure that out? >> > > On Android check passes with --disable-tls (standard while building > gcc for Android as TLS is not supported in bionic) and

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 4:05 AM, Jakub Jelinek wrote: > On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrote: >> On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu wrote: >> > Hi, >> > >> > r216964 disables bootstrap for libcc1 which exposed 2 things: >> > >> > 1. libcc1 isn't compiled with LTO ev

[match-and-simplify] operator-lists in expression

2014-11-10 Thread Prathamesh Kulkarni
Hi, This patch adds support for operator-lists to be used in expression. I reuse operator-list as the iterator. This is not really valid since user-defined operator-lists cannot be iterator in 'for', but it was convenient to reuse operator-list as a 'for' iterator and lower_for doesn't care abou

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:32:32AM -0800, H.J. Lu wrote: > On Mon, Nov 10, 2014 at 4:05 AM, Jakub Jelinek wrote: > > On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrote: > >> On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu wrote: > >> > Hi, > >> > > >> > r216964 disables bootstrap for libcc1 w

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 2:43 PM, Jakub Jelinek wrote: > On Mon, Nov 10, 2014 at 05:32:32AM -0800, H.J. Lu wrote: >> On Mon, Nov 10, 2014 at 4:05 AM, Jakub Jelinek wrote: >> > On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrote: >> >> On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu wrote: >> >

Re: [PATCH] Fix PR 63748

2014-11-10 Thread Patrick Palka
On Mon, Nov 10, 2014 at 7:22 AM, Eric Botcazou wrote: >> > Full bootstrap + regtesting on x86_64-unknown-linux-gnu is in progress. >> > Is this patch OK if testing succeeds with no new regressions? >> >> ... ok. But please watch for fallout. > > I'd do a bootstrap with Ada enabled, the Ada compil

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-10 Thread Dominik Vogt
> I'd still like to avoid the rampant duplication if possible. One > approach would be to put most of the test in something like > nilptr_tests.go marked with "// skip". Then we can have top-level > nilptrXX.go tests with +build lines that use "// run nilptr_tests.go". I fail to see how that cou

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 02:44:55PM +0100, Richard Biener wrote: > >> > I admit I haven't tried LTO bootstrap, but from normal bootstrap logs, > >> > libcc1 is built normally using libtool using -fPIC only, and linked into > >> > libcc1.so.0.0.0 and libcc1plugin.so.0.0.0, and of course against the >

[PATCH] Fix PR63800

2014-11-10 Thread Richard Biener
This fixes PR63800 which shows that PRE eliminate() avail handling is too simplistic with the code to avoid vectorization regressions. The following patch makes it properly restore old availability. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biene

Re: [PATCH 3/4] Add libgomp plugin for Intel MIC

2014-11-10 Thread Ilya Verbin
On 06 Nov 19:25, Jakub Jelinek wrote: > Oh, one more point, if mic_lib_path is NULL, what is the point > to do the alloca/malloc and string copying? Can't you just > setenv (MIC_LD_LIBRARY_PATH_ENV, ld_lib_path, 1); > in that case early? > > Otherwise LGTM. Done. Thanks, -- Ilya --- diff

Re: Ping: FR-V rtx iterator patches

2014-11-10 Thread Nicholas Clifton
Hi Richard, Ping for these FR-V patches: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02645.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02646.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02647.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02648.html which convert callers of

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-10 Thread Ilya Verbin
On 06 Nov 18:55, Jakub Jelinek wrote: > Looks mostly good, but: > > > +# We need more things in site.exp, but automake completely controls the > > +# creation of that file; there's no way to append to it without messing up > > +# the dependancy chains. So we overrule automake. This rule is exact

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread FX
> Indeed is a system header and should not have been included from > tree-chkp.c but system.h Indeed. My knowledge of C++ is limited, but I think this additional patch to wide-int.h is the proper fix to the issue reported by Jack, no? I’m bootstrapping it right now, it already passed stage 2.

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread FX
> My knowledge of C++ is limited, but I think this additional patch to > wide-int.h is the proper fix to the issue reported by Jack, no? > I’m bootstrapping it right now, it already passed stage 2. Boostrapped succeeded on x86_64-apple-darwin14. OK to commit to trunk? string.diff Description:

Re: [testsuite,ARM] PR61153 Fix vbic and vorn tests

2014-11-10 Thread Christophe Lyon
On 30 October 2014 23:02, Christophe Lyon wrote: > On 29 October 2014 16:28, Ramana Radhakrishnan > wrote: >> On Wed, Oct 29, 2014 at 3:26 PM, Christophe Lyon >> wrote: >>> Hi, >>> >>> In PR61153, the vbic and vorn tests fail because when compiled at -O0 >>> the expected Neon instructions are no

[PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-10 Thread Joel Sherrill
2014-11-10 Joel Sherrill * src/c++98/mt_allocator.cc: Fix assumption that sizeof(void *) is equal to sizeof(size_t). The m32c breaks this assumption. --- libstdc++-v3/src/c++98/mt_allocator.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/

[match-and-simplify] Remove supposedly dead code

2014-11-10 Thread Richard Biener
"supposedly" because there are a few regressions. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener * tree-ssa-forwprop.c (simplify_conversion_from_bitmask): Remove. (associate_plusminus): Likewise. (combine_conversions)

[PATCH][16/n] Merge from match-and-simplify, simplify_mult pattern

2014-11-10 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener * match.pd: Implement pattern from simplify_mult. * tree-ssa-forwprop.c (simplify_mult): Remove. (pass_forwprop::execute): Do not call simplify_mult. Index: trunk/gcc/mat

Re: [PATCH] Reset contexts in possible_polymorphic_call_targets properly

2014-11-10 Thread Jan Hubicka
> Hi > > in a patch I work on I store ipa_polymorphic_call_contexts in a vector > and thus they do not get properly constructed, merely memset to zero. > This means that I happen to be using "know nothing" contexts which > have their outer_type set to NULL but the various flags are also > false, u

[PATCH] Fix for PR63766 (handle removed functions in do_per_function_toporder)

2014-11-10 Thread Ilya Enkovich
Hi, Here is a fix for PR63766. Currently all functions are transformed into SSA before local optimizations and it allows function to be inlined and removed before it goes through local optimzations. But this requires removal of these functions from working queue. Bootstrapped and tested on x

Re: Add the latest C++ SD-6 additions.

2014-11-10 Thread Ed Smith-Rowland
On 11/09/2014 11:45 PM, Jason Merrill wrote: On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: + //cpp_hashnode *node = 0; + //node = token->val.node.node; + //if (node) + // pfile->mi_ind_cmacro = node; Remove this commented-out code? The patch is OK. Jason Here is the committed pa

Re: [PATCH] AIX: Filename-based shared library versioning for libgcc_s

2014-11-10 Thread David Edelsohn
On Mon, Nov 10, 2014 at 4:59 AM, Michael Haubenwallner wrote: > > Am 2014-11-07 20:52, schrieb David Edelsohn: >> First, please explicitly copy me on AIX or PowerPC patches sent to >> gcc-patches. >> >> I don't have a fundamental objection to including this option, but >> note that Richi, Honza a

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-10 Thread Ian Taylor
On Mon, Nov 10, 2014 at 6:00 AM, Dominik Vogt wrote: >> I'd still like to avoid the rampant duplication if possible. One >> approach would be to put most of the test in something like >> nilptr_tests.go marked with "// skip". Then we can have top-level >> nilptrXX.go tests with +build lines that

Re: [2/6] nvptx testsuite patches: typed assembly

2014-11-10 Thread Bernd Schmidt
On 10/21/2014 05:32 PM, Bernd Schmidt wrote: On 10/21/2014 05:16 PM, Jeff Law wrote: On 10/21/14 14:15, Bernd Schmidt wrote: Since everything in ptx assembly is typed, K&R C is problematic. There are a number of testcases that call functions with the wrong number of arguments, or arguments of t

Re: The nvptx port [10/11+] Target files

2014-11-10 Thread Bernd Schmidt
On 10/30/2014 12:35 AM, Jeff Law wrote: A "nit" -- Richard S. recently removed the need to include the "enum" for "enum machine_mode". I believe he had a script to handle the mundane parts of that change. Please make sure to update the nvptx port to conform to that new convention, obviously fee

[C++ Patch] PR 63265

2014-11-10 Thread Paolo Carlini
Hi, as far as I can see this 4.9/5 regression, where we spuriously warn about the left shifts in the templates, has to do with r208183, where Jason replaced c_inhibit_evaluation_warnings fiddling in tsubst_copy_and_build with two warning_sentinels, on warn_type_limits and warn_div_by_zero. In

Re: [C++ Patch] PR 63265

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:32:49PM +0100, Paolo Carlini wrote: > PR c++/63265 > * c-family/c.opt ([Wshift-count-negative, Wshift-count-overflow]): Add. Note, c-family/ has its own ChangeLog. Jakub

Re: [PING][PATCH][AARCH64]Fix PR63424 by adding v2di3 pattern

2014-11-10 Thread Renlin Li
On 06/11/14 15:00, Renlin Li wrote: Hi all, Dose anybody have time to review this? Kind regards, Renlin Li On 31/10/14 14:51, Renlin Li wrote: Hi all, This is a patch which will fix PR63424. It implements signed/unsigned max/min pattern for V2DI mode in terms of vcondv2div2di pattern. In

[PING][PATCH]Partially fix PR61529, bound basic block frequency

2014-11-10 Thread Renlin Li
On 06/11/14 18:07, Renlin Li wrote: On 06/11/14 17:59, Teresa Johnson wrote: Thanks for fixing the test case. Can you also add the comment I suggested to the source change? Please add a comment that this is needed due to insane incoming frequencies. Sorry, I mistakenly add it to the Change

Re: [PING][PATCH]Partially fix PR61529, bound basic block frequency

2014-11-10 Thread Teresa Johnson
Hi Renlin, Looks like Jeff already approved it: >Can you add a testcase please? With a testcase, this patch is OK for the >trunk. Teresa On Mon, Nov 10, 2014 at 8:59 AM, Renlin Li wrote: > On 06/11/14 18:07, Renlin Li wrote: >> >> On 06/11/14 17:59, Teresa Johnson wrote: >>> >>> Thanks for f

Re: Add the latest C++ SD-6 additions.

2014-11-10 Thread Jason Merrill
On 11/10/2014 10:55 AM, Ed Smith-Rowland wrote: Would a 4.9 version be accepted? Sure. What do you think about defining the macros for unsupported features to 0 rather than leaving them undefined? The document doesn't seem to specify. Jason

Re: [C++ Patch] PR 63265

2014-11-10 Thread Jason Merrill
On 11/10/2014 12:16 PM, Jason Merrill wrote: I don't think we want to suppress this warning in general. The problem in this PR is that the warning code is failing to recognize that the first operand is constant false. But adding the warning options is OK. Jason

Re: [C++ Patch] PR 63265

2014-11-10 Thread Jason Merrill
I don't think we want to suppress this warning in general. The problem in this PR is that the warning code is failing to recognize that the first operand is constant false. Jason

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Jack Howarth
Also confirmed that FX's proposed string.diff patch solves both PR63699 and PR63750 on x86_64-apple-darwin13 against Xcode 6.1. On Mon, Nov 10, 2014 at 9:58 AM, FX wrote: >> My knowledge of C++ is limited, but I think this additional patch to >> wide-int.h is the proper fix to the issue reported

Re: [C++ Patch] PR 63265

2014-11-10 Thread Paolo Carlini
Hi, On 11/10/2014 06:16 PM, Jason Merrill wrote: On 11/10/2014 12:16 PM, Jason Merrill wrote: I don't think we want to suppress this warning in general. The problem in this PR is that the warning code is failing to recognize that the first operand is constant false. But adding the warning op

Re: [PATCH] AIX: Filename-based shared library versioning for libgcc_s

2014-11-10 Thread Michael Haubenwallner
Am 2014-11-10 17:06, schrieb David Edelsohn: > On Mon, Nov 10, 2014 at 4:59 AM, Michael Haubenwallner > wrote: >> >> Am 2014-11-07 20:52, schrieb David Edelsohn: >>> First, please explicitly copy me on AIX or PowerPC patches sent to >>> gcc-patches. >>> >>> I don't have a fundamental objection

Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-10 Thread Joel Sherrill
cc'ing since both lists should be included. The m32c has 24-bit pointers and 16-bit size_t. This changes pushing a pointer through a size_t to pushing it through a uintptr_t. --joel On 11/10/2014 9:36 AM, Joel Sherrill wrote: > 2014-11-10 Joel Sherrill > > * src/c++98/mt_allocator.cc: Fix

PATCH: PR tree-optimization/63778: [5 Regression] Segfault with r217178 building 416.gamess from cpu2006

2014-11-10 Thread H.J. Lu
I checked in this patch to add a testcase for PR tree-optimization/63778. H.J. --- Index: ChangeLog === --- ChangeLog (revision 217303) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2014-11-10 H.J. Lu + + PR tree-optimiza

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Mike Stump
On Nov 10, 2014, at 6:58 AM, FX wrote: >> My knowledge of C++ is limited, but I think this additional patch to >> wide-int.h is the proper fix to the issue reported by Jack, no? >> I’m bootstrapping it right now, it already passed stage 2. > > Boostrapped succeeded on x86_64-apple-darwin14. > OK

Re: [PATCH][ARM] testsuite, use arm_eabi iso arm*-*-*eabi*

2014-11-10 Thread Mike Stump
On Nov 9, 2014, at 12:33 PM, Andreas Tobler wrote: > The upcoming FreeBSD ARM target does not have eabi in the target triplet. But > it is EABI based. > Ok for trunk? Ok.

[Patch] Add -Wshift-count-negative and -Wshift-count-overflow

2014-11-10 Thread Paolo Carlini
Hi again, thus the below only adds the warnings. Would be mainline only of course. Thanks! Paolo. 2014-11-10 Paolo Carlini * doc/invoke.texi ([-Wshift-count-negative, -Wshift-count-overflow]): Add. /c-family 2014-11-10 Paolo Carlini

Re: [Patch, libstdc++/63775] Fix regex bracket expression parsing

2014-11-10 Thread Jonathan Wakely
On 09/11/14 10:17 -0800, Tim Shen wrote: __matcher._M_add_equivalence_class(_M_value); else if (_M_match_token(_ScannerT::_S_token_char_class_name)) __matcher._M_add_character_class(_M_value, false); - else if (_M_try_char()) // [a + // POSIX doesn't permit '-' as

Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-10 Thread Jonathan Wakely
On 10/11/14 12:01 -0600, Joel Sherrill wrote: cc'ing since both lists should be included. The m32c has 24-bit pointers and 16-bit size_t. This changes pushing a pointer through a size_t to pushing it through a uintptr_t. I'm OK with this change if Paolo is. If it breaks any targets without ui

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Andi Kleen
Roman Gareev writes: > Hi Tobias, > > I've attached a patch which removes using of CLooG library from > Graphite. Is it fine for trunk? Could you please also remove -Werror by default from cloog? Currently with LTO builds warnings in one of these libraries usually break the build, unless --disa

Re: __float128 typeinfo

2014-11-10 Thread Jonathan Wakely
On 09/11/14 01:41 +0100, Marc Glisse wrote: Hello, I am digging out https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00637.html It isn't completely clear if the libstdc++ part was accepted or not. I won't commit immediately (waiting on another patch), but I'd like to be ready. The libstdc++ pa

Re: [C++ PING^3] Re: [PATCH 5/5] Add illegal cilk checks to C++ front.

2014-11-10 Thread Andi Kleen
Andi Kleen writes: Ping!^3 > Andi Kleen writes: > > Ping!^2 > >> Andi Kleen writes: >> >> Ping! >> >> Can someone from the C++ side please approve this patch? >> That's the only patch not approved in this patch kit, but blocking >> the commit. >> >> -Andi >> >>> From: Andi Kleen >>> >>> Add c

[PING] Re: [PATCH] Add memory barriers to xbegin/xend/xabort

2014-11-10 Thread Andi Kleen
Andi Kleen writes: Ping! > From: Andi Kleen > > xbegin/xend/xabort were missing memory barriers. This can > lead to memory operations being moved out of transactions, which would > cause unexpected races. > > Always generate implicit memory barriers for these intrinsics. > > The compat header v

Re: [Patch] Add -Wshift-count-negative and -Wshift-count-overflow

2014-11-10 Thread Jason Merrill
OK. Jason

Re: [PR c/52952] More precise locations within format strings

2014-11-10 Thread Joseph Myers
On Sat, 8 Nov 2014, Manuel López-Ibáñez wrote: > On 7 November 2014 22:39, Joseph Myers wrote: > >> Neither Per nor Tom are active in GCC anymore. If the FE maintainers > >> do not feel comfortable reviewing line-map changes, could you nominate > >> Dodji as line-map maintainer if he is willing t

Re: [PATCH driver/36312] should refuse to overwrite input file with output file

2014-11-10 Thread Joseph Myers
On Sat, 8 Nov 2014, Manuel López-Ibáñez wrote: > This patch is a minor variant of the one approved here: > > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00246.html > > fixing the problem with linker parameters (which are stored in infiles). > > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Mike Stump
On Nov 10, 2014, at 10:10 AM, Mike Stump wrote: > I’’ve asked Jack for the header in question that makes max/min ambiguous. Ok, found it, page 903 of c++14. Also in the 97 version. We need the wi:: qualifications for wide-int with min and max. That part of the patch is Ok.

Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-10 Thread Paolo Carlini
Hi, On 11/10/2014 07:34 PM, Jonathan Wakely wrote: On 10/11/14 12:01 -0600, Joel Sherrill wrote: cc'ing since both lists should be included. The m32c has 24-bit pointers and 16-bit size_t. This changes pushing a pointer through a size_t to pushing it through a uintptr_t. I'm OK with this cha

Re: [RFC, C] add warning for unpromoted bit-field uses

2014-11-10 Thread Joseph Myers
On Sat, 8 Nov 2014, Sandra Loosemore wrote: > I thought that the point at which integral promotions are applied would be a > good place to catch this, as it excludes places where bit-fields are already > being converted by assignment or explicit cast. I think we also want to Formally of course t

[PATCH v4] warning about const multidimensional array as function parameter

2014-11-10 Thread Martin Uecker
For completeness, this version adds the missing warning if the 'const' is lost in a conditional expression with a void* on the other branch. The only code change relative to the previous version is in c/c-typeck.c in build_conditional_expr (otherwise I added the warnings to the testsuite and fix

Re: [RFC, C] add warning for unpromoted bit-field uses

2014-11-10 Thread Joseph Myers
On Sun, 9 Nov 2014, Sandra Loosemore wrote: > Hrmmm. In C, sp->a has type "3-bit unsigned integer" which is promoted to int > by the integral promotions since all values are representable as int. sp->c > has type "5-bit unsigned integer" which is likewise promoted to int. In C++, > sp->a has t

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Roman Gareev
> Sure. We should drop the flag in these test cases. > > This seems to make sense, as they now test something different and the flag > removal would reflect this. > > I personally would include this in the same patch. Would this be difficult? I don’t think that it could be difficult. I just wanted

Re: [PATCH 5/5] Add illegal cilk checks to C++ front.

2014-11-10 Thread Andi Kleen
On Sun, Nov 09, 2014 at 11:03:50PM -0600, Jason Merrill wrote: > On 10/01/2014 11:26 PM, Andi Kleen wrote: > >+ if (check_no_cilk (cond, "in a condition for a for-loop")) > > Why is this one "in" while the others are "as"? I think "in" was somewhere hard coded in the test suite and I wanted to m

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Tobias Grosser
On 10.11.2014 20:14, Roman Gareev wrote: Sure. We should drop the flag in these test cases. This seems to make sense, as they now test something different and the flag removal would reflect this. I personally would include this in the same patch. Would this be difficult? I don’t think that it

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Jack Howarth
Is the current isl 0.12.2 in infrastructure entirely sufficient to replace cloog-isl. or should the ABI compatibility changes be made to graphite to allow gcc 5.0 to be transitioned to the isl 0.14 release? Especially if any graphite changes might be made before the gcc 5.0 release that could

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 5:44 AM, Richard Biener wrote: > On Mon, Nov 10, 2014 at 2:43 PM, Jakub Jelinek wrote: >> On Mon, Nov 10, 2014 at 05:32:32AM -0800, H.J. Lu wrote: >>> On Mon, Nov 10, 2014 at 4:05 AM, Jakub Jelinek wrote: >>> > On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrot

Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-10 Thread Joel Sherrill
On 11/10/2014 1:03 PM, Paolo Carlini wrote: > Hi, > > On 11/10/2014 07:34 PM, Jonathan Wakely wrote: >> On 10/11/14 12:01 -0600, Joel Sherrill wrote: >>> cc'ing since both lists should be included. >>> >>> The m32c has 24-bit pointers and 16-bit size_t. This changes >>> pushing a pointer through a

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 6:24 AM, Jakub Jelinek wrote: > On Mon, Nov 10, 2014 at 02:44:55PM +0100, Richard Biener wrote: >> >> > I admit I haven't tried LTO bootstrap, but from normal bootstrap logs, >> >> > libcc1 is built normally using libtool using -fPIC only, and linked into >> >> > libcc1.so.

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Markus Trippelsdorf
On 2014.11.10 at 11:43 -0800, H.J. Lu wrote: > On Mon, Nov 10, 2014 at 6:24 AM, Jakub Jelinek wrote: > > On Mon, Nov 10, 2014 at 02:44:55PM +0100, Richard Biener wrote: > >> >> > I admit I haven't tried LTO bootstrap, but from normal bootstrap logs, > >> >> > libcc1 is built normally using libtool

Re: The nvptx port [10/11+] Target files

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:19:57PM +0100, Bernd Schmidt wrote: > commit 659744a99d815b168716b4460e32f6a21593e494 > Author: Bernd Schmidt > Date: Thu Nov 6 19:03:57 2014 +0100 Note, in r217301 you've committed a change to pr35468.c, not mentioned in the ChangeLog, that uses no_const_addr_space e

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 11:57 AM, Markus Trippelsdorf wrote: > On 2014.11.10 at 11:43 -0800, H.J. Lu wrote: >> On Mon, Nov 10, 2014 at 6:24 AM, Jakub Jelinek wrote: >> > On Mon, Nov 10, 2014 at 02:44:55PM +0100, Richard Biener wrote: >> >> >> > I admit I haven't tried LTO bootstrap, but from norm

[PATCH, i386]: Use std::swap

2014-11-10 Thread Uros Bizjak
Hello! std::swap was recently mentioned in gcc-patches@ mailing list, so I gave it a try. As can be seen below, a lot of code in config/i386 benefits from this conversion. Surprisingly, I didn't have to include any header on F20 linux build. So, is this patch OK as far as c++ is concerned? 2014-

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Markus Trippelsdorf
On 2014.11.10 at 12:05 -0800, H.J. Lu wrote: > On Mon, Nov 10, 2014 at 11:57 AM, Markus Trippelsdorf > wrote: > > On 2014.11.10 at 11:43 -0800, H.J. Lu wrote: > >> On Mon, Nov 10, 2014 at 6:24 AM, Jakub Jelinek wrote: > >> > On Mon, Nov 10, 2014 at 02:44:55PM +0100, Richard Biener wrote: > >> >>

Re: [7/7] nvptx testsuite patches: Return addresses

2014-11-10 Thread H.J. Lu
On Tue, Oct 21, 2014 at 8:33 AM, Jeff Law wrote: > On 10/21/14 14:29, Bernd Schmidt wrote: >> >> This tests for availability of return addresses in a number of tests. >> >> >> Bernd >> >> >> r422426.diff >> >> >> gcc/testsuite/ >> * lib/target-supports.exp (check_effective_target_r

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 12:16 PM, Markus Trippelsdorf wrote: > On 2014.11.10 at 12:05 -0800, H.J. Lu wrote: >> On Mon, Nov 10, 2014 at 11:57 AM, Markus Trippelsdorf >> wrote: >> > On 2014.11.10 at 11:43 -0800, H.J. Lu wrote: >> >> On Mon, Nov 10, 2014 at 6:24 AM, Jakub Jelinek wrote: >> >> > On

Re: [PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2014-11-10 Thread Magnus Granberg
fredag 01 augusti 2014 10.52.27 skrev Rainer Orth: > Hi Magnus, > > a couple of comments, mostly nits. > > > 2014-07-31 Magnus Granberg > > > > /gcc > > * config/gnu-user.h: Define PIE_DRIVER_SELF_SPECS for PIE > > as default and GNU_DRIVER_SELF_SPECS. > > * config/i386/gnu-u

Re: [7/7] nvptx testsuite patches: Return addresses

2014-11-10 Thread Mike Stump
On Nov 10, 2014, at 12:19 PM, H.J. Lu wrote: > I checked in this patch to revert the accidental checkin. Thanks.

Re: [x86, 6/n] Replace builtins with vector extensions

2014-11-10 Thread Uros Bizjak
On Sun, Nov 9, 2014 at 5:26 PM, Marc Glisse wrote: > Hello, > > < > and == for integer vectors of size 128. I was surprised not to find > _mm_cmplt_epi64 anywhere. Note that I can do the same for size 256, but not > 512, there is no corresponding intrinsic, there are only _mask versions that > ret

Re: The nvptx port [10/11+] Target files

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 12:04 PM, Jakub Jelinek wrote: > On Mon, Nov 10, 2014 at 05:19:57PM +0100, Bernd Schmidt wrote: >> commit 659744a99d815b168716b4460e32f6a21593e494 >> Author: Bernd Schmidt >> Date: Thu Nov 6 19:03:57 2014 +0100 > > Note, in r217301 you've committed a change to pr35468.c,

Re: The nvptx port [10/11+] Target files

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 12:04 PM, Jakub Jelinek wrote: > On Mon, Nov 10, 2014 at 05:19:57PM +0100, Bernd Schmidt wrote: >> commit 659744a99d815b168716b4460e32f6a21593e494 >> Author: Bernd Schmidt >> Date: Thu Nov 6 19:03:57 2014 +0100 > > Note, in r217301 you've committed a change to pr35468.c,

Re: The nvptx port [10/11+] Target files

2014-11-10 Thread Mike Stump
On Nov 10, 2014, at 12:37 PM, H.J. Lu wrote: > I also checked in this patch to add missing braces in > gcc.dg/pr44194-1.c. Thanks.

Re: [x86, 5/n] Replace builtins with vector extensions

2014-11-10 Thread Uros Bizjak
On Sun, Nov 9, 2014 at 4:57 PM, Marc Glisse wrote: > Hello, > > &|^ of size 256 and 512. Regtested with 6/n. > > 2014-11-10 Marc Glisse > > * config/i386/avx2intrin.h (_mm256_and_si256, _mm256_or_si256, > _mm256_xor_si256): Use vector extensions instead of builtins. > *

[PATCH] Fix some ICF gimple_call handling issues

2014-11-10 Thread Jakub Jelinek
Hi! As the following two testcases shows, there are lots of issues in ICF compare_gimple_call, in particular, it doesn't handle indirect calls properly (see the ipa-icf-31.c testcase), doesn't handle internal calls properly (see ubsan/ipa-icf-1.c), didn't check gimple_call flags at all. As discus

  1   2   >