Re: [google] Build libstdc++ exception throwing code with frame pointers (issue4348050)

2011-04-05 Thread Diego Novillo
On Mon, Apr 4, 2011 at 23:05, Paul Pluzhnikov wrote: > 2011-04-04  Paul Pluzhnikov   > >        * libstdc++-v3/src/Makefile.am  (revision 171950): Add >        -fno-omit-frame-pointer to functexcept. >        * libstdc++-v3/libsupc++/Makefile.am    (revision 171950): Add >        -fno-omit-frame-

Re: [google] Enable lightweight debug checks (issue4344067)

2011-04-05 Thread Diego Novillo
On Tue, Apr 5, 2011 at 01:26, Paul Pluzhnikov wrote: > This patch adds lightweight debug checks (if enabled by macros). > > To be applied only to google/main branch. > > Tested by buildit --run-tests. > > > > 2011-04-04  Paul Pluzhnikov   > >        * libstdc++-v3/include/ext/vstring.h    (revisio

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> as described in PR, there is a failure to copy adainclude/adalib > libraries in MSYS. The PR does not give any details as to what exact error message you are getting, at which step, and what Makefile rule/line is causing this behavior. I'm surprised by LN_S is used to link directories,this look

Re: [PATCH, Fortran] Correct declaration of frexp and friends

2011-04-05 Thread Duncan Sands
Hi Tobias, Pong. It helps to send Fortran patches also to fortran@ ... indeed :) On 30/03/11 16:43, Duncan Sands wrote: While working on the dragonegg plugin I noticed that the Fortran front-end declares frexp with the parameters the wrong way round. Instead of double frexp(double x, int *e

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Kai Tietz
2011/4/5 Arnaud Charlet : >> as described in PR, there is a failure to copy adainclude/adalib >> libraries in MSYS. > > The PR does not give any details as to what exact error message you are > getting, at which step, and what Makefile rule/line is causing this behavior. > > I'm surprised by LN_S i

Re: [PATCH] Fix VTA updating in the combiner (PR debug/48343)

2011-04-05 Thread Jakub Jelinek
On Mon, Apr 04, 2011 at 09:55:12AM +0200, Jakub Jelinek wrote: > So something like this? Now bootstrapped/regtested on x86_64-linux and i686-linux, ok? > 2011-04-04 Jakub Jelinek > > PR debug/48343 > * combine.c (combine_instructions): Add last_combined_insn, > update it if

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> Hmm, AFAICS is in Mafile.in the following line present: > > # Copy target independent sources > $(foreach f,$(ADA_INCLUDE_SRCS) $(LIBGNAT_SRCS), \ > $(LN_S) $(fsrcpfx)ada/$(f) $(RTSDIR) ;) true > > which seems to me the cause for this patch. The above loop will link/copy file

[lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Rainer Orth
As described in the PR, it seems to make more sense to avoid to use the visibility attribute on targets that don't support it rather than using it unconditionally and later (and incompletely) prune the resulting warning. The following patch does exactly that. It now needs to document the explicit

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

2011-04-05 Thread Georg-Johann Lay
Georg-Johann Lay schrieb: > Target avr now supports tail calls, so don't xfail on that. > > testsuite/ > > 2011-03-29 Georg-Johann Lay > > * gcc.dg/sibcall-3.c: Don't xfail on AVR. > * gcc.dg/sibcall-4.c: Don't xfail on AVR. > >

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Kai Tietz
2011/4/5 Arnaud Charlet : >> Hmm, AFAICS is in Mafile.in the following line present: >> >> # Copy target independent sources >>         $(foreach f,$(ADA_INCLUDE_SRCS) $(LIBGNAT_SRCS), \ >>           $(LN_S) $(fsrcpfx)ada/$(f) $(RTSDIR) ;) true >> >> which seems to me the cause for this patch. > >

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> Well, there is a bug AFAICS. Issue is that 'ln -s file dir' fails, but > 'ln -s file file1' works. See for this thread > http://lists.zerezo.com/mingw-users/msg03642.html, where this is > described. So it might be also a valid fix here to append to directory > the $f again. OK, so it's indeed a

Re: [PATCH, Fortran] Correct declaration of frexp and friends

2011-04-05 Thread Duncan Sands
Hi Tobias, I do, so that's not a problem. By the way I just noticed that the arguments to the scalbn functions also seem to be the wrong way round: here's a gcc-4.5 patch which fixes: (1) the comment for fntype[2], (2) the prototypes for the frexp family and (3) the prototypes for the scalbn f

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Kai Tietz
2011/4/5 Arnaud Charlet : >> Well, there is a bug AFAICS. Issue is that 'ln -s file dir' fails, but >> 'ln -s file file1' works. See for this thread >> http://lists.zerezo.com/mingw-users/msg03642.html, where this is >> described. So it might be also a valid fix here to append to directory >> the $

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Richard Guenther
On Tue, 5 Apr 2011, Rainer Orth wrote: > As described in the PR, it seems to make more sense to avoid to use the > visibility attribute on targets that don't support it rather than using > it unconditionally and later (and incompletely) prune the resulting > warning. > > The following patch does

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> I agree, and I read the threads about that there on mingw.org. I > don't see a good chance that it get fixed soon there. Nevertheless is > the msys-environment the only way to do a full bootstrap of native gcc > toolchain, so I would simply love to have this work-a-rounded it in > gcc. But wel

Re: [PATCH, Fortran] Correct declaration of frexp and friends

2011-04-05 Thread Tobias Burnus
Hi Ducan, On 04/05/2011 11:41 AM, Duncan Sands wrote: By the way I just noticed that the arguments to the scalbn functions also seem to be the wrong way round: here's a gcc-4.5 patch which fixes: (1) the comment for fntype[2], (2) the prototypes for the frexp family and (3) the prototypes for

Re: [PATCH] allocate combine.c:LOG_LINKS in an alloc_pool

2011-04-05 Thread Richard Guenther
On Mon, Apr 4, 2011 at 9:25 PM, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 09:01:20PM +0200, Steven Bosscher wrote: >> On Mon, Apr 4, 2011 at 8:49 PM, Nathan Froyd >> wrote: >> > This patch does just what $SUBJECT suggests.  Benefits: >> > >> > - Smaller data structures in combine; >> > - Fre

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Kai Tietz
2011/4/5 Arnaud Charlet : >> I agree, and I read the threads about that there on mingw.org.  I >> don't see a good chance that it get fixed soon there.  Nevertheless is >> the msys-environment the only way to do a full bootstrap of native gcc >> toolchain, so I would simply love to have this work-a

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> I know about that. And in fact I am use Wine for doing an native > compile. Nevertheless most users using msys for native windows. Btw > that it would work on cygwin is more theory, It's not theory, it's what e.g. we do at AdaCore so it's very much reality rather than theory. > Sorry, here I a

Re: [patch][cprop.c] Simplify find_used_regs, iterate cprop_insn

2011-04-05 Thread Richard Guenther
On Mon, Apr 4, 2011 at 9:57 PM, Steven Bosscher wrote: > Hi, > > This patch has one significant change: cprop_insn would not iterate > after a successful copy propagation, assuming the uses found with > find_used_regs remain the same. This is not true in two cases: > > * find_used_regs found multi

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Kai Tietz
2011/4/5 Arnaud Charlet : >> I know about that. And in fact I am use Wine for doing an native >> compile. Nevertheless most users using msys for native windows.  Btw >> that it would work on cygwin is more theory, > > It's not theory, it's what e.g. we do at AdaCore so it's very much > reality rath

Re: PATCH: PR middle-end/48440: [4.7 Regression] FAIL: gcc.c-torture/compile/labels-3.c

2011-04-05 Thread Richard Guenther
On Tue, Apr 5, 2011 at 8:44 AM, Paolo Bonzini wrote: Index: cgraphbuild.c === --- cgraphbuild.c.orig  2011-04-03 11:28:45.0 +0200 +++ cgraphbuild.c       2011-04-03 11:31:21.0 +0200 @@ -53,6 +5

Re: [PATCH, PR43920, 2/9] ARM specific part - test case

2011-04-05 Thread Tom de Vries
Hi Richard, On 04/01/2011 06:10 PM, Tom de Vries wrote: > On 04/01/2011 05:34 PM, Richard Earnshaw wrote: >> On Fri, 2011-04-01 at 16:47 +0200, Tom de Vries wrote: >>> Reposting, with ChangeLog. >> >> +/* { dg-options "-march=armv7-a -mthumb -Os" } */ >> >> No, use dg-require-effective-target. Th

Re: [PATCH, Fortran] Correct declaration of frexp and friends

2011-04-05 Thread Duncan Sands
Hi Tobias, here's a gcc-4.5 patch which fixes: (1) the comment for fntype[2], (2) the prototypes for the frexp family and (3) the prototypes for the scalbn family. I checked all uses of all of the function types declared here and all the rest seem to be correct. I also took a look at an example

Re: Avoid global state in rx_handle_option

2011-04-05 Thread Nick Clifton
Hi Joseph, Tested building cc1 and xgcc for cross to rx-elf. Will commit to trunk in the absence of target maintainer objections. 2011-04-04 Joseph Myers * config/rx/rx-opts.h: New. * config/rx/rx.c (rx_cpu_type): Remove. (rx_handle_option): Don't assert that global s

[PATCH] don't use TYPE_ARG_TYPES in type_generic or sentinel attribute handling

2011-04-05 Thread Nathan Froyd
The type_generic and sentinel attribute handlers for c-family, LTO, and Ada grovel through TYPE_ARG_TYPES; this patch changes them to use the standard functions prototype_p and stdarg_p instead. Less TYPE_ARG_TYPES usage is a good thing. The prototype_p check in the type_generic handlers is gross

[PATCH] move some debug routines from final.c to dbxout.c

2011-04-05 Thread Nathan Froyd
I was looking at debug_flush_symbol_queue and thought "gosh, it's inefficient if we're calling this all the time, but it only does work when we want DBX_DEBUGGING_INFO." So I looked around and saw that debug_flush_symbol_queue and friends are only called from dbxout.c. So this patch moves them th

Re: [PATCH, PR43920, 7/9] Cross-jumping - Extend search scope.

2011-04-05 Thread Tom de Vries
Hi Jeff, On 03/31/2011 08:56 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/31/11 12:43, Tom de Vries wrote: >> Allows crossjump over fallthru paths. > OK. > jeff You ok'ed patches 7/9 ( http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02258.html ) and 9/9 ( http://g

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Nathan Froyd
On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote: > > + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *, > > + last_basic_block); > nit; You're missing some whitespace here (after the VEC). This doesn't seem to be a hard-and-fast policy; all of the

[wwwdocs][patch] Document NEON default vector size change

2011-04-05 Thread Ira Rosen
Hi, As pointed out here http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02183.html the change of the default vector size has to be documented in changes.html: * htdocs/gcc-4.7/changes.html (targets): Document ARM NEON default vector size change. Index: htdocs/gcc-4.7/changes.html

Re: [PATCH] move some debug routines from final.c to dbxout.c

2011-04-05 Thread Richard Guenther
On Tue, Apr 5, 2011 at 1:36 PM, Nathan Froyd wrote: > I was looking at debug_flush_symbol_queue and thought "gosh, it's > inefficient if we're calling this all the time, but it only does work > when we want DBX_DEBUGGING_INFO."  So I looked around and saw that > debug_flush_symbol_queue and friend

Re: [wwwdocs][patch] Document NEON default vector size change

2011-04-05 Thread Gerald Pfeifer
On Tue, 5 Apr 2011, Ira Rosen wrote: >> The default vector size in auto-vectorization for NEON is now 128 >> bits. >> If for some reason vectorization fails, the vectorizer tries again with >> 64 bit vectors. 64-bit according to http://gcc.gnu.org/codingconventions.html. And perh

Re: [PATCH PING] c++-specific bits of tree-slimming patches

2011-04-05 Thread Nathan Froyd
On Thu, Mar 24, 2011 at 06:15:18AM -0700, Nathan Froyd wrote: > The C++-specific bits of these patches: > > [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00557.html > > [PATCH 07/18] generalize build_case_label to the rest of the comp

[PATCH] Fix PR48431

2011-04-05 Thread Richard Guenther
Committed. Richard. 2011-04-05 Richard Guenther PR bootstrap/48431 * lto-plugin.c (claim_file_handler): Do not declare vars in code. Index: lto-plugin/lto-plugin.c === *** lto-plugin/lto-plugin.c (revision 1

Re: [PATCH, PR43920, 2/9] ARM specific part - test case

2011-04-05 Thread Richard Earnshaw
On Tue, 2011-04-05 at 12:42 +0200, Tom de Vries wrote: > Hi Richard, > > On 04/01/2011 06:10 PM, Tom de Vries wrote: > > On 04/01/2011 05:34 PM, Richard Earnshaw wrote: > >> On Fri, 2011-04-01 at 16:47 +0200, Tom de Vries wrote: > >>> Reposting, with ChangeLog. > >> > >> +/* { dg-options "-march=

Re: [PATCH] don't use TYPE_ARG_TYPES in type_generic or sentinel attribute handling

2011-04-05 Thread Joseph S. Myers
On Tue, 5 Apr 2011, Nathan Froyd wrote: > gcc/c-family/ > * c-common.c (handle_sentinel_attribute): Don't use TYPE_ARG_TYPES. > (handle_type_generic_attribute): Likewise. The C-family changes are OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Richard Earnshaw
On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote: > > > + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *, > > > + last_basic_block); > > nit; You're missing some whitespace here (after the VEC)

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Nathan Froyd
On Tue, Apr 05, 2011 at 01:22:39PM +0100, Richard Earnshaw wrote: > On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > > > nit; You're missing some whitespace here (after the VEC). > > > > This doesn't seem to be a hard-and-fast policy; all of the VEC code I > > remember writing or looking a

Re: [cxx-mem-model] C++ atomic tests (synchronized and relaxed)

2011-04-05 Thread Aldy Hernandez
Notice the store of *after* the store to . I consider this a bug and have put this on my laundry list. Seems plausible, though I don't know the details of the x86_64 memory model well enough to be sure that it would be possible to observe this reordering. But then, if your test fails I guess it

[patch] PR48441 ICE in mark_oprs_set

2011-04-05 Thread Steven Bosscher
Hi, My recent patch to cprop.c to use DF_INSN_INFO caches exposed a latent bug in CPROP. The bug triggered on hppa-linux, but the problem is generic. The ICE looks like this: Breakpoint 3, mark_oprs_set (insn=0x76edc140) at ../../trunk/gcc/cprop.c:538 538 struct df_insn_info *insn_info

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Charles Wilson
On 4/5/2011 6:22 AM, Kai Tietz wrote: > 2011/4/5 Arnaud Charlet : >>> I know about that. And in fact I am use Wine for doing an native >>> compile. Nevertheless most users using msys for native windows. Btw >>> that it would work on cygwin is more theory, >> >> It's not theory, it's what e.g. we d

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Richard Earnshaw
On Tue, 2011-04-05 at 05:30 -0700, Nathan Froyd wrote: > On Tue, Apr 05, 2011 at 01:22:39PM +0100, Richard Earnshaw wrote: > > On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > > > > nit; You're missing some whitespace here (after the VEC). > > > > > > This doesn't seem to be a hard-and-fa

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/11 06:55, Richard Earnshaw wrote: > > On Tue, 2011-04-05 at 05:30 -0700, Nathan Froyd wrote: >> On Tue, Apr 05, 2011 at 01:22:39PM +0100, Richard Earnshaw wrote: >>> On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > nit; You're mis

[PATCH] use build_function_type_list for float128 functions

2011-04-05 Thread Nathan Froyd
When the real16/float128 bits were added to the Fortran FE, some uses of build_function_type snuck in. This patch changes them to use build_function_type_list. The patch also corrects a small bug: the types for frexp and scalbn had their argument types in the wrong order. Tested on x86_64-unknow

[PATCH] make gcse.c:modify_mem_list hold VECs instead of INSN_LISTs

2011-04-05 Thread Nathan Froyd
As promised, this patch turns modify_mem_list into an array of VECs, similar to the changes done to canon_modify_mem_list. Since I'm in the area, I took the liberty of tweaking the VEC declarations related to canon_modify_mem_list to have spaces before parens, as folks seem to think that's the rig

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> I'm one of the MSys "devs" (if you want to call the sporadic process of > updating MSys "development"). I'll take a look at implementing > ln -s file dir > as synonymous with > ln -s file dir/basename-of-file > in the next few days. Thanks, although the case we're really interested

Re: [patch libjava]: Do some fixes for windows native targets

2011-04-05 Thread Tom Tromey
> "Kai" == Kai Tietz writes: Kai> this patch fixes some issues in libjava for windows targets. It Kai> addresses for now only 32-bit target, but for JNICALL definition I Kai> introduced already logic for 64-bit windows target too as preparation. Most of this seems ok to me. Kai>* java/

Re: [patch, ARM] Make 128 bits the default vector size for NEON

2011-04-05 Thread Ramana Radhakrishnan
On 31/03/11 12:39, Ira Rosen wrote: Hi, This patch changes NEON's default vector size from 64 to 128 bits. The patch doesn't touch mvectorize-with-neon-quad, but removes the uses of TARGET_NEON_VECTORIZE_QUAD. Following Julian's suggestion I added a param preferred-vector-size for testing and d

Re: [PATCH, ARM] PR47855 Compute attr "length" for some thumb2 insns

2011-04-05 Thread Ramana Radhakrishnan
The patch was tested on arm qemu without regression, OK for install? Ok if no regressions. cheers Ramana thanks Carrot ChangeLog: 2011-04-01 Wei Guozhi PR target/47855 * config/arm/arm.md (arm_cmpsi_insn): Compute attr "length". (arm_cond_branch): Likewise.

Re: [PATCH, PR43920, 1/9] ARM specific part.

2011-04-05 Thread Tom de Vries
On 04/04/2011 02:22 PM, Rainer Orth wrote: > Richard Guenther writes: > >> On Sun, Apr 3, 2011 at 9:34 PM, Sergey Ostanevich >> wrote: >>> I would recommend to use 'nm -S a.out' that gives >>> >>> [...] >>> 004004a4 0054 T main >>> [...] >>> >>> then you can provide a name f

[wwwdocs] Move formatting for to CSS (and add some color)

2011-04-05 Thread Gerald Pfeifer
Isn't CSS nice? So much easier than doing things the classic way, even when the latter used macros. :-) Applied, and gcc.gnu.org regenerated. Gerald Index: gcc.css === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v retrieving revision

Re: [PATCH] allocate combine.c:LOG_LINKS in an obstack

2011-04-05 Thread Nathan Froyd
On Mon, Apr 04, 2011 at 02:49:54PM -0400, Nathan Froyd wrote: > This patch does just what $SUBJECT suggests. v2, now with obstacks! Tested on x86_64-unknown-linux-gnu. OK to commit? -Nathan * combine.c: Include obstack.h (struct insn_link): Define. (uid_log_links): Adju

[wwwdocs] Google's Summer of Code

2011-04-05 Thread Gerald Pfeifer
Ian made the very good point that we should highlight this a bit, and suggested some wording and link. Here we go! Gerald Index: index.html === RCS file: /cvs/gcc/wwwdocs/htdocs/index.html,v retrieving revision 1.784 diff -u -r1.784

Re: [PATCH] allocate combine.c:LOG_LINKS in an obstack

2011-04-05 Thread Richard Guenther
On Tue, Apr 5, 2011 at 3:59 PM, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 02:49:54PM -0400, Nathan Froyd wrote: >> This patch does just what $SUBJECT suggests. > > v2, now with obstacks! > > Tested on x86_64-unknown-linux-gnu.  OK to commit? Ok. Thanks, Richard. > -Nathan > >        * combi

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Charles Wilson
On 4/5/2011 9:21 AM, Arnaud Charlet wrote: >> I'm one of the MSys "devs" (if you want to call the sporadic process of >> updating MSys "development"). I'll take a look at implementing >> ln -s file dir >> as synonymous with >> ln -s file dir/basename-of-file >> in the next few days. > >

[PATCH] Fix LTO bootstrap on i686-linux (problem with two Ldebug_info0 labels; PR bootstrap/48148)

2011-04-05 Thread Jakub Jelinek
Hi! i686-linux LTO bootstrap currently fails, because in one partition we emit .Ldebug_info0 label twice. The problem is that resolve_addr for call_site support attempts to force_decl_die external function decls, and at least with LTO that in turn can attempt to create new type DIEs, in this case

Re: [PATCH] use build_function_type_list for float128 functions

2011-04-05 Thread Tobias Burnus
On 04/05/2011 03:12 PM, Nathan Froyd wrote: When the real16/float128 bits were added to the Fortran FE, some uses of build_function_type snuck in. This patch changes them to use build_function_type_list. Thanks! The patch also corrects a small bug: the types for frexp and scalbn had their ar

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Ralf Wildenhues
* Charles Wilson wrote on Tue, Apr 05, 2011 at 04:15:02PM CEST: > On 4/5/2011 9:21 AM, Arnaud Charlet wrote: > >> I'm one of the MSys "devs" (if you want to call the sporadic process of > >> updating MSys "development"). I'll take a look at implementing > >>ln -s file dir > >> as synonymous wi

[libgo, build] Avoid echo -n in gotest

2011-04-05 Thread Rainer Orth
Inspecting the Solaris 8 libgo.sum file, I was reminded that echo -n isn't portable. The autoconf manual agrees and suggests printf as a replacement. The following patch implements this. Bootstrapped on i386-pc-solaris2.8 with gas. Rainer 2011-04-05 Rainer Orth * testsuite

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Eric Botcazou
> The patch below fixes the testcase in the PR. I'll test > tonight/tomorrow, probably on mips64-elf. Ok if that passes? I get back the comparison failure with it on IA-64/Linux: Comparing stages 2 and 3 warning: gcc/cc1-checksum.o differs warning: gcc/cc1plus-checksum.o differs Bootstrap compari

Fix accidental reversion

2011-04-05 Thread Eric Botcazou
In June of last year I installed the change: 2010-06-06 Eric Botcazou * stor-layout.c (self_referential_size): Set UNKNOWN_LOCATION on the newly built CALL_EXPR. but it was accidentally reverted by: 2010-07-13 Nathan Froyd [...] (expand_parallel_call): Call build_

Re: [libgo, build] Avoid echo -n in gotest

2011-04-05 Thread Andreas Schwab
Rainer Orth writes: > diff --git a/libgo/testsuite/gotest b/libgo/testsuite/gotest > --- a/libgo/testsuite/gotest > +++ b/libgo/testsuite/gotest > @@ -231,7 +231,7 @@ mkdir _test > > case "x$gofiles" in > x) > - gofiles=$(echo -n $(ls *_test.go 2>/dev/null)) > + gofiles=$(printf "%s"

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Richard Earnshaw
On Tue, 2011-04-05 at 07:07 -0600, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/05/11 06:55, Richard Earnshaw wrote: > > > > On Tue, 2011-04-05 at 05:30 -0700, Nathan Froyd wrote: > >> On Tue, Apr 05, 2011 at 01:22:39PM +0100, Richard Earnshaw wrote: > >>> On Tue,

Re: [PATCH] allocate combine.c:LOG_LINKS in an obstack

2011-04-05 Thread Steven Bosscher
On Tue, Apr 5, 2011 at 3:59 PM, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 02:49:54PM -0400, Nathan Froyd wrote: >> This patch does just what $SUBJECT suggests. > > v2, now with obstacks! Still one TODO in doc/rtl.texi: @findex LOG_LINKS @item LOG_LINKS (@var{i}) A list (chain of @code{insn_l

Re: [PATCH] allocate combine.c:LOG_LINKS in an obstack

2011-04-05 Thread Nathan Froyd
On Tue, Apr 05, 2011 at 04:42:27PM +0200, Steven Bosscher wrote: > On Tue, Apr 5, 2011 at 3:59 PM, Nathan Froyd wrote: > > v2, now with obstacks! > > @findex LOG_LINKS > @item LOG_LINKS (@var{i}) > A list (chain of @code{insn_list} expressions) giving information about > dependencies between inst

Re: [PATCH] Fix VTA updating in the combiner (PR debug/48343)

2011-04-05 Thread Eric Botcazou
> Alternatively, perhaps all we care about is either i3, or NEXT_INSN of the > last debug_insn propagate_for_debug changed in an interesting way. Thus > propagate_for_debug could return the last DEBUG_INSN it changed, and caller > decide either that no updating of last_modified_debug_insn is neede

[wwwdocs] Fix two blunders of mine

2011-04-05 Thread Gerald Pfeifer
That'll teach me sneaking in some wwwdocs work around lunch break. Fixed thusly. Gerald Index: index.html === RCS file: /cvs/gcc/wwwdocs/htdocs/index.html,v retrieving revision 1.785 retrieving revision 1.787 diff -u -r1.785 -r1.787

Re: [PATCH] allocate combine.c:LOG_LINKS in an obstack

2011-04-05 Thread Steven Bosscher
On Tue, Apr 5, 2011 at 4:51 PM, Nathan Froyd wrote: > On Tue, Apr 05, 2011 at 04:42:27PM +0200, Steven Bosscher wrote: >> On Tue, Apr 5, 2011 at 3:59 PM, Nathan Froyd >> wrote: >> > v2, now with obstacks! >> >> @findex LOG_LINKS >> @item LOG_LINKS (@var{i}) >> A list (chain of @code{insn_list} e

Re: [PATCH, ARM] Avoid element-order-dependent operations for quad-word vectors in big-endian mode for NEON

2011-04-05 Thread Julian Brown
On Wed, 9 Feb 2011 12:11:35 + Julian Brown wrote: > On Wed, 12 Jan 2011 17:38:22 + > Julian Brown wrote: > > > This version of the patch tweaks target-supports.exp to say that > > various operations are not available in big-endian mode (removing > > some of the FAILs from the previous v

[PATCH, PR48461] define emit_use_return_register_into_block only if HAVE_return.

2011-04-05 Thread Tom de Vries
Hi, I introduced the function emit_use_return_register_into_block for PR43920, but should have guarded it with HAVE_return. The patch fixes this. Tested by doing x86_64 non-bootstrap c/fortran build. OK for trunk? Thanks, - Tom 2011-04-05 Tom de Vries PR middle-end/48461 * function.c (emi

Re: [PATCH, PR48461] define emit_use_return_register_into_block only if HAVE_return.

2011-04-05 Thread Richard Guenther
On Tue, Apr 5, 2011 at 5:50 PM, Tom de Vries wrote: > Hi, > > I introduced the function emit_use_return_register_into_block for > PR43920, but should have guarded it with HAVE_return. > The patch fixes this. > > Tested by doing x86_64 non-bootstrap c/fortran build. > > OK for trunk? Ok. Thanks,

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Bernd Schmidt
On 04/05/2011 04:32 PM, Eric Botcazou wrote: >> The patch below fixes the testcase in the PR. I'll test >> tonight/tomorrow, probably on mips64-elf. Ok if that passes? > > I get back the comparison failure with it on IA-64/Linux: Looking into it. I ran into PR48441, I assume you were using the pa

Re: [PATCH] make LABEL_DECL has its own rtx field for its associated CODE_LABEL

2011-04-05 Thread Michael Matz
Hi, On Mon, 4 Apr 2011, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 05:52:00PM +0200, Steven Bosscher wrote: > > Have you looked into maybe putting the CODE_LABEL for a LABEL_DECL in > > an on-the-side structure (hash table, whatever)? It looks like it is > > only used during expansion of SWITC

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Charles Wilson
On 4/5/2011 10:21 AM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Tue, Apr 05, 2011 at 04:15:02PM CEST: >> On 4/5/2011 9:21 AM, Arnaud Charlet wrote: I'm one of the MSys "devs" (if you want to call the sporadic process of updating MSys "development"). I'll take a look at implement

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/11 09:54, Bernd Schmidt wrote: > On 04/05/2011 04:32 PM, Eric Botcazou wrote: >>> The patch below fixes the testcase in the PR. I'll test >>> tonight/tomorrow, probably on mips64-elf. Ok if that passes? >> >> I get back the comparison failure

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Bernd Schmidt
On 04/05/2011 06:08 PM, Jeff Law wrote: > On 04/05/11 09:54, Bernd Schmidt wrote: >> On 04/05/2011 04:32 PM, Eric Botcazou wrote: The patch below fixes the testcase in the PR. I'll test tonight/tomorrow, probably on mips64-elf. Ok if that passes? >>> >>> I get back the comparison failure

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> As a side issue, it ALSO seems to me that Ada's Mafile.in is doing it > wrong, given Ralf's statements above: > > # Copy target independent sources > $(foreach f,$(ADA_INCLUDE_SRCS) $(LIBGNAT_SRCS), \ > $(LN_S) $(fsrcpfx)ada/$(f) $(RTSDIR) ;) true > > But as this isn't s

Re: [PATCH] allocate combine.c:LOG_LINKS in an obstack

2011-04-05 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/11 08:51, Nathan Froyd wrote: > On Tue, Apr 05, 2011 at 04:42:27PM +0200, Steven Bosscher wrote: >> On Tue, Apr 5, 2011 at 3:59 PM, Nathan Froyd >> wrote: >>> v2, now with obstacks! >> >> @findex LOG_LINKS >> @item LOG_LINKS (@var{i}) >> A l

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/11 10:10, Bernd Schmidt wrote: > On 04/05/2011 06:08 PM, Jeff Law wrote: >> On 04/05/11 09:54, Bernd Schmidt wrote: >>> On 04/05/2011 04:32 PM, Eric Botcazou wrote: > The patch below fixes the testcase in the PR. I'll test > tonight/to

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/11 05:44, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote: >>> + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *, >>> + last_basic_block); >> nit; You're missing some whit

Re: [PATCH] make LABEL_DECL has its own rtx field for its associated CODE_LABEL

2011-04-05 Thread Nathan Froyd
On Tue, Apr 05, 2011 at 05:55:33PM +0200, Michael Matz wrote: > I have a preference in having just one DECL_RTL field for conceptual > reasons: > > Most DECLs are actually objects (there are some prominent exceptions, but > those always would be better described with something like NAMED_ENTITY,

Re: [PATCH] make gcse.c:modify_mem_list hold VECs instead of INSN_LISTs

2011-04-05 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/11 07:20, Nathan Froyd wrote: > As promised, this patch turns modify_mem_list into an array of VECs, > similar to the changes done to canon_modify_mem_list. Since I'm in the > area, I took the liberty of tweaking the VEC declarations related

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Steve Ellcey
On Tue, 2011-04-05 at 17:54 +0200, Bernd Schmidt wrote: > On 04/05/2011 04:32 PM, Eric Botcazou wrote: > >> The patch below fixes the testcase in the PR. I'll test > >> tonight/tomorrow, probably on mips64-elf. Ok if that passes? > > > > I get back the comparison failure with it on IA-64/Linux: >

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Charles Wilson
On 4/5/2011 12:11 PM, Arnaud Charlet wrote: >> As a side issue, it ALSO seems to me that Ada's Mafile.in is doing it >> wrong, given Ralf's statements above: >> >> # Copy target independent sources >> $(foreach f,$(ADA_INCLUDE_SRCS) $(LIBGNAT_SRCS), \ >> $(LN_S) $(fsrcpfx)ada

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Arnaud Charlet
> According to 'info Autoconf --index LN_S' as quoted by Ralf, it is not > *portable* to do > $(LN_S) a_file a_dir > because it behaves differently depending on whether LN_S is "ln -s", > "ln" (or, as in this case, "cp -p"). That is certainly true. > This: > $(LN_S) $(fsrcpfx)ada/$(f)

Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts

2011-04-05 Thread Charles Wilson
On 4/5/2011 12:50 PM, Arnaud Charlet wrote: >> This: >> $(LN_S) $(fsrcpfx)ada/$(f) $(RTSDIR) >> fits that non-portable pattern > > That's wrong. The above is > > $(LN_S) /full/path/to/a_file a_dir > > which is quite different from > > $(LN_S) a_file a_dir > > and will work equally well wi

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Steve Ellcey
On Tue, 2011-04-05 at 09:41 -0700, Steve Ellcey wrote: > Hm, I just tried a bootstrap build on IA64 HP-UX using the haifa-sched.c > patch and r171988 and I got this error during stage 2: > > > /proj/opensrc_nobackup/sje/reg/src/trunk/gcc/genautomata.c: In function > 'create_ > automata': > /pro

Re: [PATCH] Fix VTA updating in the combiner (PR debug/48343)

2011-04-05 Thread Alexandre Oliva
On Apr 4, 2011, Jakub Jelinek wrote: > Alternatively, perhaps all we care about is either i3, or NEXT_INSN of > the last debug_insn propagate_for_debug changed in an interesting way. Ideally, we'd like to identify all debug users of i2dest (or whatever DEF we're removing) and propagate into the

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Mike Stump
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: > * lto.c (promote_var): Only set VISIBILITY_HIDDEN if > HAVE_GAS_HIDDEN. This looks wrong, there are more things that have visibility than those things that use GAS and have .hidden. Darwin I think is one of them. ? cygming.h seems to be

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Mike Stump
On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: > * lto.c (promote_var): Only set VISIBILITY_HIDDEN if > HAVE_GAS_HIDDEN. Oh, at a minimum, if TARGET_ASM_ASSEMBLE_VISIBILITY is set, doing this stuff I think is useful?

[Patch, Fortran] PR 18918 - Fix/Add multi-image support to UCOBOUND

2011-04-05 Thread Tobias Burnus
This patch adds multi-image support to UCOBOUND. In the -fcoarray=single case, the last dimension is just "LCOARRAY (coarray, dim=corank)". However, if there are multiple images, one has for corank-1 coarrays: "lcobound(coarray) + num_images() -1" and for multi-rank coarrays for the last dimens

Re: [PATCH] Fix VTA updating in the combiner (PR debug/48343)

2011-04-05 Thread Jakub Jelinek
On Tue, Apr 05, 2011 at 02:24:55PM -0300, Alexandre Oliva wrote: > On Apr 4, 2011, Jakub Jelinek wrote: > > > Alternatively, perhaps all we care about is either i3, or NEXT_INSN of > > the last debug_insn propagate_for_debug changed in an interesting way. > > Ideally, we'd like to identify all

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Eric Botcazou
> Looking into it. I ran into PR48441, I assume you were using the patch > from that as well? It's yesterday's tree + your 2 patches to haifa-sched.c, so without Steven's patch... at least it was supposed to be, but I screwed up, sorry about that. After having done another round of testing, let

[PATCH] use use_reg in several backends

2011-04-05 Thread Nathan Froyd
Several places in the compiler could be usefully modified to use use_reg instead of hand-building EXPR_LISTs. This patch makes such changes. Since this patch implements equivalent functionality with an existing function call, I believe it counts as obvious. Tested by building cc1 for appropriate

Re: [PATCH] don't use TYPE_ARG_TYPES in type_generic or sentinel attribute handling

2011-04-05 Thread Eric Botcazou
> gcc/ada/ > * gcc-interface/utils.c (handle_sentinel_attribute): Don't use > TYPE_ARG_TYPES > (handle_type_generic_attribute): Likewise. This code is very likely a duplicate of the one in c-common.c so Joseph's approval counts for it as well. -- Eric Botcazou

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Steve Ellcey
On Tue, 2011-04-05 at 19:48 +0200, Eric Botcazou wrote: > > Looking into it. I ran into PR48441, I assume you were using the patch > > from that as well? > > It's yesterday's tree + your 2 patches to haifa-sched.c, so without Steven's > patch... at least it was supposed to be, but I screwed up, s

Re: [PATCH] use use_reg in several backends

2011-04-05 Thread Eric Botcazou
> * config/sparc/sparc.c (sparc_legitimize_tls_address): Likewise. Fine with me, thanks. -- Eric Botcazou

Re: [PATCH] cleanup gcse.c:canon_modify_mem_list

2011-04-05 Thread Mike Stump
On Apr 5, 2011, at 5:55 AM, Richard Earnshaw wrote: > IMO, rototils are generally pointless. As a counter point, I like polish and style, in addition to beauty and flexibility. I'd rather see more style cleanups, more polish cleanups and more beautiful cleanups. I'd like to see more, not less

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-05 Thread Rainer Orth
Mike Stump writes: > On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: >> * lto.c (promote_var): Only set VISIBILITY_HIDDEN if >> HAVE_GAS_HIDDEN. > > This looks wrong, there are more things that have visibility than those > things that use GAS and have .hidden. Darwin I think is one of them

Re: Scheduler cleanups, 5/5

2011-04-05 Thread Eric Botcazou
> What are the two patches to haifa-sched.c? I have one patch to > schedule_block from > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00271.html > but that patch (alone or with the Jeff Law patch) isn't working for me > on IA64 Linux. Is there a second haifa-sched.c patch I should also > have? N

  1   2   >