On Tue, 2011-04-05 at 05:30 -0700, Nathan Froyd wrote: > On Tue, Apr 05, 2011 at 01:22:39PM +0100, Richard Earnshaw wrote: > > On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > > > > nit; You're missing some whitespace here (after the VEC). > > > > > > This doesn't seem to be a hard-and-fast policy; all of the VEC code I > > > remember writing or looking at recently has no spaces, and I checked the > > > patch in on that basis. However, running grep indicates that we have a > > > profusion of styles... > > > > I think the style guide is quite clear on this: there should be a space > > there as Jeff says. The fact that some code has crept in with other > > styles doesn't make them right, or give justification for ignoring the > > style guide. > > Would you like a patch for the hundreds of instances without spaces? > > Certainly vec.h never uses spaces; I thought this was simply The Way > Things Were. > > -Nathan >
IMO, rototils are generally pointless. If you are fixing code nearby then yes, fix the formatting issues. Otherwise, just don't exacerbate the problem, or we'll reach the point where a rototil really does become necessary. R.
