On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote: > > > + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *, > > > + last_basic_block); > > nit; You're missing some whitespace here (after the VEC). > > This doesn't seem to be a hard-and-fast policy; all of the VEC code I > remember writing or looking at recently has no spaces, and I checked the > patch in on that basis. However, running grep indicates that we have a > profusion of styles...
I think the style guide is quite clear on this: there should be a space there as Jeff says. The fact that some code has crept in with other styles doesn't make them right, or give justification for ignoring the style guide. R.
