Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-11-02 Thread Trevor Saunders
On Sat, Oct 31, 2015 at 03:02:07PM +0800, Andrew Pinski wrote: > On Fri, Oct 30, 2015 at 9:11 PM, Bernd Schmidt wrote: > > On 10/30/2015 01:47 PM, Richard Biener wrote: > >> > >> On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt > >> wrote: > > > it's not target independent code. Are

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-31 Thread Andrew Pinski
On Fri, Oct 30, 2015 at 9:11 PM, Bernd Schmidt wrote: > On 10/30/2015 01:47 PM, Richard Biener wrote: >> >> On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt >> wrote: it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantai

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 01:47 PM, Richard Biener wrote: On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt wrote: it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantained frontend / target lib that's an excessive requirement. If necessary, then y

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Trevor Saunders
On Fri, Oct 30, 2015 at 01:16:16PM +0100, Richard Biener wrote: > On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt wrote: > > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: > >> > >> -#ifdef ADJUST_FIELD_ALIGN > >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); > >> +#if defi

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt wrote: >> >> it's not target independent code. Are you suggesting to add a config/ >> to libobjc? IMHO for a not really mantained frontend / target lib that's >> an excessive requirement. > > > If necessary, then yes that would be a better solution.

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantained frontend / target lib that's an excessive requirement. If necessary, then yes that would be a better solution. Even just keeping the abstraction of the macro and putting definiti

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt wrote: > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: >> >> -#ifdef ADJUST_FIELD_ALIGN >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); >> +#if defined __arc__ || defined _AIX >> + if (TYPE_MODE (strip_array_types (TREE_TYP

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: -#ifdef ADJUST_FIELD_ALIGN - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); +#if defined __arc__ || defined _AIX + if (TYPE_MODE (strip_array_types (TREE_TYPE (type))) == DFmode) +desired_align = MIN (desired_align, 32); +#

[PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread tbsaunde+gcc
From: Trevor Saunders Not many targets define this macro in ways that do something in libojc, so it seems to make sense to just inline the few definitions that do do something. libobjc/ChangeLog: 2015-10-30 Trevor Saunders PR libobjc/24775 * encoding.c (objc_layout_structure