On Thu, 5 Dec 2019, Richard Biener wrote:
>
> After the PR92818 commit there's one function in the testcase below
> remaining not using bit-inserts. The following fixes this.
>
> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.
Committed with the following gcc.target/i386/pr92803
This libgo patch recognizes aarch64_be as arm64be. I don't know if
anything else is needed for aarch64_be support, but this at least is
required. This is for GCC PR 92810. Bootstrapped on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
Index: gcc/go/gofrontend/MERGE
===
On Wed, Dec 04, 2019 at 10:52:28PM +0100, Jan Hubicka wrote:
> * cgraphclones.c (localize_profile): New function.
> (cgraph_node::create_clone): Use it for partial profiles.
> * common.opt (fprofile-partial-training): New flag.
This FAILs everywhere, with:
Running /usr/src/gcc/gc
Hi!
Before r251949 the debug info for Fortran array descriptors looked correct,
for arrays that had GFC_TYPE_ARRAY_SPAN NULL would use for DW_AT_byte_stride
DW_OP_push_object_address DW_OP_plus_uconst offsetof (, dim[0].__stride)
DW_OP_deref DW_OP_litN DW_OP_mul (where N is the element size in byt
On Thu, Dec 05, 2019 at 10:26:34AM +, Richard Sandiford wrote:
> 2019-12-05 Richard Sandiford
>
> gcc/
> PR middle-end/92768
> * tree-core.h (OEP_BITWISE): New flag.
> * fold-const.c (operand_compare::operand_equal_p): Handle it.
> * tree-vector-builder.h (tree_vecto
On Thu, Dec 05, 2019 at 04:33:10PM -0700, Martin Sebor wrote:
> > It's hard to distinguish between this type and the previous one by name;
> > this one should probably have "map" in its name.
> >
> > > +static GTY (()) record_to_locs_t *rec2loc;
> > ...
> > > + rec2loc = new record_to_locs_t ()
If yes, since I don't think I have the time for it for GCC 10
I need to decide whether to drop just this improvement or all
of the buffer overflow checks that depend on it.
Let me know which you prefer.
As I mentioned in my previous message, I think we've got two potential
paths. We could just
On 12/4/19 4:37 PM, Jason Merrill wrote:
On 12/3/19 4:49 PM, Martin Sebor wrote:
On 8/5/19 4:30 PM, Jason Merrill wrote:
On Mon, Aug 5, 2019 at 5:50 PM Martin Sebor wrote:
On 8/5/19 1:25 PM, Jason Merrill wrote:
On 8/1/19 7:35 PM, Martin Sebor wrote:
On 8/1/19 12:09 PM, Jason Merrill wrote
On Thu, Dec 05, 2019 at 10:37:33PM +, Jonathan Wakely wrote:
> On Thu, 5 Dec 2019 at 22:19, Segher Boessenkool wrote:
> > Or you could write
> >
> > auto __c = (__builtin_memcmp(&*__first1, &*__first2, __len) <=> 0);
> > if (__c)
> > return __c;
> >
> > which is much easier to rea
On Thu, 5 Dec 2019 at 22:19, Segher Boessenkool wrote:
> Or you could write
>
> auto __c = (__builtin_memcmp(&*__first1, &*__first2, __len) <=> 0);
> if (__c)
> return __c;
>
> which is much easier to read, to my eyes anyway. And it is exactly the
> same for the compiler.
In this ca
On Thu, 2019-12-05 at 15:22 -0700, Martin Sebor wrote:
> PR middle-end/92622 - FAIL: gcc.dg/Warray-bounds-22.c on ILP32:
> missing warnings for VLA on lines 67 and 69
>
> gcc/ChangeLog:
>
> PR testsuite/92622
> * tree-vrp.c (vrp_prop::check_array_ref): Avoid using a
> variable
>
On Thu, 5 Dec 2019 at 22:19, Segher Boessenkool wrote:
>
> On Thu, Dec 05, 2019 at 08:56:35PM +, Jonathan Wakely wrote:
> > On Thu, 5 Dec 2019 at 20:07, Segher Boessenkool
> > wrote:
> > > On Thu, Dec 05, 2019 at 05:03:43PM +, Jonathan Wakely wrote:
> > > > C++17 introduces a nice feature,
I've isolated the intermittent failures of a test for a recent
enhancement to -Warray-bounds reported in PR 92622 to the use
of an offset left uninitialized by a failed call to
get_addr_base_and_unit_offset.
The attached patch makes sure the variable is only used if
the call succeeds. I will com
On Thu, Dec 05, 2019 at 08:56:35PM +, Jonathan Wakely wrote:
> On Thu, 5 Dec 2019 at 20:07, Segher Boessenkool
> wrote:
> > On Thu, Dec 05, 2019 at 05:03:43PM +, Jonathan Wakely wrote:
> > > C++17 introduces a nice feature, with rationale similar to declaring
> > > variables in a for-loop
On Thu, Dec 05, 2019 at 03:38:15PM -0500, Marek Polacek wrote:
> On Thu, Dec 05, 2019 at 02:06:50PM -0600, Segher Boessenkool wrote:
> > > When you're forced to uglify every variable with a leading __ you run
> > > out of characters pretty damn quickly.
> >
> > If using this "nice feature" forces
I've checked in this patch to fix a long-standing bug on nios2-linux-gnu
that resulted in linker errors like
../nios2-linux-gnu/bin/ld: FDE encoding in /tmp/cccfpQ2l.o(.eh_frame)
prevents .eh_frame_hdr table being created
when linking with -pie or -shared. The nios2 ABI doesn't provide the
On Thu, 5 Dec 2019 at 20:07, Segher Boessenkool
wrote:
>
> Hi!
>
> On Thu, Dec 05, 2019 at 05:03:43PM +, Jonathan Wakely wrote:
> > C++17 introduces a nice feature, with rationale similar to declaring
> > variables in a for-loop init-statement:
> >
> > if (auto var = foo(); bar(var))
>
> Simil
On Thu, Dec 5, 2019 at 11:51 AM Michael Matz wrote:
> Hello,
>
> (oh a flame bait :) )
>
> On Thu, 5 Dec 2019, Thomas Schwinge wrote:
>
> > So, I formally propose that we lift this characters per line restriction
> > from IBM punch card (80) to mainframe line printer (132).
> >
> > Tasks:
> >
> >
On Thu, Dec 05, 2019 at 02:06:50PM -0600, Segher Boessenkool wrote:
> Hi!
>
> On Thu, Dec 05, 2019 at 05:03:43PM +, Jonathan Wakely wrote:
> > C++17 introduces a nice feature, with rationale similar to declaring
> > variables in a for-loop init-statement:
> >
> > if (auto var = foo(); bar(var
On Thu, Dec 05, 2019 at 11:54:04AM -0700, Martin Sebor wrote:
> >> if (present)
> >>ptr
> >> = gfc_build_conditional_assign_expr (block,
> >> present,
> >> ptr,
On Thu, Dec 05, 2019 at 05:04:12PM +0100, Jakub Jelinek wrote:
> On Thu, Dec 05, 2019 at 04:46:45PM +0100, Thomas Schwinge wrote:
> > On 2019-12-05T16:15:15+0100, Jakub Jelinek wrote:
> > > [...] much more indented though, but you could
> > > use a temporary, like:
> > > tree nulla
On 12/5/19 1:21 PM, Richard Sandiford wrote:
+ else if (!verify_type_context (input_location, TCTX_EXCEPTIONS, type))
+return false;
+
+ else if (TYPE_REF_P (type)
+ && !verify_type_context (input_location, TCTX_EXCEPTIONS,
+ TREE_TYPE (type)))
Y
On Thu, Dec 05, 2019 at 04:44:21PM +, Michael Matz wrote:
> (oh a flame bait :) )
I will blissfully ignore that warning.
> On Thu, 5 Dec 2019, Thomas Schwinge wrote:
> I object to cluttering code in excuse for using sensible function names or
> temporaries that otherwise can help clearing up
gcc/ChangeLog:
* analyzer/analyzer-logging.h (logger): Use
DISABLE_COPY_AND_ASSIGN.
(log_scope): Likewise.
(log_user): Likewise.
---
gcc/analyzer/analyzer-logging.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/gcc/analyzer/analyzer-logging.h b/gcc/analy
gcc/ChangeLog:
* vec.h (auto_delete_vec): Use DISABLE_COPY_AND_ASSIGN.
---
gcc/vec.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/vec.h b/gcc/vec.h
index 1957739ecb56..706a6103b744 100644
--- a/gcc/vec.h
+++ b/gcc/vec.h
@@ -1559,6 +1559,9 @@ class auto_delete_vec : public aut
This patch adds DISABLE_COPY_AND_ASSIGN to various classes that had
a dtor but for which I hadn't bothered implementing the copy ctor
and assignment operator.
gcc/ChangeLog:
* analyzer/analysis-plan.h (analysis_plan): Add
DISABLE_COPY_AND_ASSIGN.
* analyzer/diagnostic-manag
gcc/ChangeLog:
* timevar.h (auto_client_timevar): Use DISABLE_COPY_AND_ASSIGN.
---
gcc/timevar.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gcc/timevar.h b/gcc/timevar.h
index c3b6233c35dd..47586f7b5847 100644
--- a/gcc/timevar.h
+++ b/gcc/timevar.h
@@ -281,8 +28
gcc/jit/ChangeLog:
* jit-logging.h (gcc::jit::logger): Use DISABLE_COPY_AND_ASSIGN.
(gcc::jit::log_scope): Likewise.
(gcc::jit::log_user): Likewise.
---
gcc/jit/jit-logging.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/gcc/jit/jit-logging.h b/gcc/jit/jit-loggi
gcc/ChangeLog:
* timevar.h (auto_timevar): Use DISABLE_COPY_AND_ASSIGN.
---
gcc/timevar.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gcc/timevar.h b/gcc/timevar.h
index d053ab795acf..c3b6233c35dd 100644
--- a/gcc/timevar.h
+++ b/gcc/timevar.h
@@ -248,9 +248,7 @@
I added DISABLE_COPY_AND_ASSIGN to various places that had a dtor
but which didn't implement a copy-ctor and assign-operator.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to branch "dmalcolm/analyzer" on the GCC git mirror.
David Malcolm (6):
Use DISABLE_COPY_AND_ASSIG
Hi!
On Thu, Dec 05, 2019 at 05:03:43PM +, Jonathan Wakely wrote:
> C++17 introduces a nice feature, with rationale similar to declaring
> variables in a for-loop init-statement:
>
> if (auto var = foo(); bar(var))
Similar to GNU C statement expressions, which are *also* only a good
idea to u
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to branch "dmalcolm/analyzer" on the GCC git mirror.
gcc/ChangeLog:
* analyzer/sm-signal.cc
(signal_delivery_edge_info_t::add_events_to_path): Add FINAL
OVERRIDE to vfunc.
---
gcc/analyzer/sm-signal.cc
On 12/5/19 2:28 PM, Marek Polacek wrote:
On Thu, Dec 05, 2019 at 01:37:45PM -0500, Jason Merrill wrote:
On 12/4/19 5:43 PM, Marek Polacek wrote:
@@ -,12 +2243,24 @@ reduced_constant_expression_p (tree t)
return false;
if (field)
{
+ retry:
On 12/5/19 1:11 PM, Marek Polacek wrote:
Richard Smith proposed adding a synonym for __is_same_as, to accomodate the
convention of exposing std::SOME_TRAIT::value as __SOME_TRAIT(A, B).
So add that alias, and also adjust the C++ printer. I didn't bother changing
the RID_ identifier.
Bootstrapp
On December 5, 2019 5:31:59 PM GMT+01:00, Michael Matz wrote:
>Hi,
>
>On Thu, 5 Dec 2019, Richard Biener wrote:
>
>> On December 5, 2019 3:35:17 PM GMT+01:00, Tom Tromey
>wrote:
>> >> "Martin" == Martin Liška writes:
>> >
>> >Martin> + /* Default constructor. */
>> >Martin> + symtab_node
On Thu, Dec 05, 2019 at 01:37:45PM -0500, Jason Merrill wrote:
> On 12/4/19 5:43 PM, Marek Polacek wrote:
> > @@ -,12 +2243,24 @@ reduced_constant_expression_p (tree t)
> > return false;
> > if (field)
> > {
> > + retry:
> > if (idx != field)
> > -
All,
As a certified Old Guy (coding in FORTRAN since 1967) my default mode is to
stop at 72 characters. It would be nice to push the max out a bit, but I’ll
most likely keep my lines (and my function and variable names!) short. As
always, brevity is the soul of wit.
And yes, please keep up t
On 12/5/19 8:46 AM, Thomas Schwinge wrote:
Hi!
;-P Jakub, thanks for furnishing me a fit occasion here:
On 2019-12-05T16:15:15+0100, Jakub Jelinek wrote:
[...] much more indented though, but you could
use a temporary, like:
tree nullarg = null_pointer_node;
I object to
On 12/4/19 5:43 PM, Marek Polacek wrote:
@@ -,12 +2243,24 @@ reduced_constant_expression_p (tree t)
return false;
if (field)
{
+ retry:
if (idx != field)
- return false;
+ {
+ /* Empty class fi
On Thu, Dec 05, 2019 at 06:21:14PM +, Richard Sandiford wrote:
> Ping.
>
> Richard Sandiford writes:
> > This patch makes the C++ frontend work with the verify_type_context hook
> > [https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00942.html]. We need
> > some new type contexts for features th
My IBM Selectric golfball electronic printer only does 90 characters on A4 in
portrait mode………(at 10 cps)
(as for my all electric TELEX Teleprinter machine !)
Is this debate for real ?! - or is this a Christmas spoof ?
External observer…..keep up the great work. :)
(while I punch out a few
Ping.
Richard Sandiford writes:
> This patch makes the C++ frontend work with the verify_type_context hook
> [https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00942.html]. We need
> some new type contexts for features that don't exist in C, but otherwise
> the patch is very similar to the C one.
>
On 12/5/19, Andrew Stubbs wrote:
> On 05/12/2019 16:17, Joseph Myers wrote:
>> Longer lines mean less space for multiple terminal / editor windows
>> side-by-side to look at different pieces of code. I don't think that's
>> an
>> improvement.
>
> Here's a data-point
>
> My 1920 pixel-wide sc
Richard Smith proposed adding a synonym for __is_same_as, to accomodate the
convention of exposing std::SOME_TRAIT::value as __SOME_TRAIT(A, B).
So add that alias, and also adjust the C++ printer. I didn't bother changing
the RID_ identifier.
Bootstrapped/regtested on x86_64-linux, ok for trunk?
On Thu, Dec 05, 2019 at 05:03:43PM +, Jonathan Wakely wrote:
> On Thu, 5 Dec 2019 at 16:44, Michael Matz wrote:
> >
> > Hello,
> >
> > (oh a flame bait :) )
> >
> > On Thu, 5 Dec 2019, Thomas Schwinge wrote:
> >
> > > So, I formally propose that we lift this characters per line restriction
> >
Hi Richard
On 05/12/2019 17:04, Richard Sandiford wrote:
> Sudakshina Das writes:
>> Hi
>>
>> While looking at vect_model_reduction_cost function, it seems Richard's
>> change in a recent commit r278611 missed an update to the following if
>> condition. Since the check for EXTRACT_LAST_REDUCTION
On 05/12/2019 16:17, Joseph Myers wrote:
Longer lines mean less space for multiple terminal / editor windows
side-by-side to look at different pieces of code. I don't think that's an
improvement.
Here's a data-point
My 1920 pixel-wide screen, in the default font, allows 239 columns; not
This libgo patch arranges for go-context.S to always be marked as
using a non-executable stack. This is not required for all targets,
but should do little harm. Bootstrapped on x86_64-pc-linux-gnu.
Committed to mainline.
Ian
Index: gcc/go/gofrontend/MERGE
On Thu, 5 Dec 2019 08:41:48 -0700
Jeff Law wrote:
> On 12/5/19 4:32 AM, Jozef Lawrynowicz wrote:
> > MSP430 RTL patterns for conditional branch instructions allow the post
> > increment addressing mode to be used for the "dest" operand of CMP
> > instructions
> > used in these patterns.
> >
> >
On Dec 5 2019, Michael Matz wrote:
(oh a flame bait :) )
Quite. I shall try not to make it too much worse, but there's another point
that needs mentioning.
I find long names hard to read, with either short or long lines, especially
when combined with variants like negotiate_twisty_little_pas
Sudakshina Das writes:
> Hi
>
> While looking at vect_model_reduction_cost function, it seems Richard's
> change in a recent commit r278611 missed an update to the following if
> condition. Since the check for EXTRACT_LAST_REDUCTION is now split
> above, the same check in the if condition will
On Thu, 5 Dec 2019 at 16:44, Michael Matz wrote:
>
> Hello,
>
> (oh a flame bait :) )
>
> On Thu, 5 Dec 2019, Thomas Schwinge wrote:
>
> > So, I formally propose that we lift this characters per line restriction
> > from IBM punch card (80) to mainframe line printer (132).
> >
> > Tasks:
> >
> >
* Paul Koning:
> That's certainly a general rule. There is a reason why books aren't
> wide, and why newspapers have columns. The eye can't deal well with
> long lines. So while 132 column lines are certainly possible with
> modern computers, it doesn't mean they are desirable.
If the line sta
On 12/5/19 6:18 AM, Wilco Dijkstra wrote:
> Hi,
>
> I have updated the documentation patch here and added relevant maintainers
> so hopefully this can go in soon:
> https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00311.html
>
> I moved the paragraph in changes.html to the C section like you sugges
Hello,
(oh a flame bait :) )
On Thu, 5 Dec 2019, Thomas Schwinge wrote:
> So, I formally propose that we lift this characters per line restriction
> from IBM punch card (80) to mainframe line printer (132).
>
> Tasks:
>
> - Discussion.
I object to cluttering code in excuse for using sensibl
On 12/5/19 9:24 AM, Paul Koning wrote:
>
>
>> On Dec 5, 2019, at 11:17 AM, Joseph Myers
>> wrote:
>>
>> On Thu, 5 Dec 2019, Thomas Schwinge wrote:
>>
>>> In the relevant session at the GNU Tools Cauldron 2019, Michael
>>> Meissner stated that even he is not using a 80 x 24 terminal
>>> anymore
Hi,
On Thu, 5 Dec 2019, Richard Biener wrote:
> On December 5, 2019 3:35:17 PM GMT+01:00, Tom Tromey wrote:
> >> "Martin" == Martin Liška writes:
> >
> >Martin> + /* Default constructor. */
> >Martin> + symtab_node (symtab_type t)
> >
> >FWIW, in gdb, we normally make single-argument con
> On Dec 5, 2019, at 11:17 AM, Joseph Myers wrote:
>
> On Thu, 5 Dec 2019, Thomas Schwinge wrote:
>
>> In the relevant session at the GNU Tools Cauldron 2019, Michael Meissner
>> stated that even he is not using a 80 x 24 terminal anymore, and that
>> should tell us something. ;-)
>>
>> So,
On 12/5/19 8:13 AM, Martin Liška wrote:
On 12/5/19 2:03 PM, Jan Hubicka wrote:
Hi.
As mentioned in the PR, there are classes in cgraph.h that are
not PODs and are initialized with ggc_alloc_cleared. So that I'm
suggesting
to use proper constructors. I added ggc_new function that can be used
a
On Thu, 5 Dec 2019, Thomas Schwinge wrote:
> In the relevant session at the GNU Tools Cauldron 2019, Michael Meissner
> stated that even he is not using a 80 x 24 terminal anymore, and that
> should tell us something. ;-)
>
> So, I formally propose that we lift this characters per line restricti
On Thu, 5 Dec 2019 at 12:43, Jonathan Wakely wrote:
>
> On 05/12/19 09:00 +0100, Christophe Lyon wrote:
> >On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely wrote:
> >>
> >> On 03/12/19 09:11 +0100, Christophe Lyon wrote:
> >> >On Mon, 16 Sep 2019 at 04:34, Tom Honermann wrote:
> >> >>
> >> >> A revi
On 12/5/19 2:44 AM, Iain Sandoe wrote:
> Segher Boessenkool wrote:
>> On Wed, Dec 04, 2019 at 03:53:30PM -0600, Peter Bergner wrote:
>>> Sure, I can add a test in gcc.target/powerpc/ that uses both a builtin
>>> and an overloaded builtin to make sure we don't ICE when DFP is disabled.
>>
>> Great,
On Thu, Dec 05, 2019 at 04:46:45PM +0100, Thomas Schwinge wrote:
> Hi!
>
> ;-P Jakub, thanks for furnishing me a fit occasion here:
>
> On 2019-12-05T16:15:15+0100, Jakub Jelinek wrote:
> > [...] much more indented though, but you could
> > use a temporary, like:
> > tree nulla
Hi!
;-P Jakub, thanks for furnishing me a fit occasion here:
On 2019-12-05T16:15:15+0100, Jakub Jelinek wrote:
> [...] much more indented though, but you could
> use a temporary, like:
> tree nullarg = null_pointer_node;
I object to cluttering the code by introducing tempora
On 12/5/19 4:32 AM, Jozef Lawrynowicz wrote:
> MSP430 RTL patterns for conditional branch instructions allow the post
> increment addressing mode to be used for the "dest" operand of CMP
> instructions
> used in these patterns.
>
> This is currently causing trunk to FTB for msp430-elf since these
On 12/5/19 2:16 AM, Martin Liška wrote:
>
>>
>> Of the ~450 packages affected I'd estimate that even with the opt-out
>> mechanism we're still going to have to fix ~100 packages immediately
>> because they don't honor the flags injection mechanisms which the
>> opt-out approach relies upon.
>
> F
Hi Richard,
On 29/11/2019 13:00, Richard Sandiford wrote:
> Hi Dennis,
>
> Sorry for the slow response.
>
> Dennis Zhang writes:
>> Hi all,
>>
>> This patch is part of a series adding support for Armv8.6-A features.
>> It enables options including -march=armv8.6-a, +i8mm and +bf16.
>> The +i8mm
On 12/5/19 4:17 PM, Martin Liška wrote:
On 12/5/19 4:12 PM, Richard Biener wrote:
Isn't there std::default_constructible? Also after your patch it's far from
obvious which api to use.
Will it work with:
struct Foo
{
Foo(int) {}
};
...
if (std::default_constructible ())
ptr = new ptr
Hi Jakub,
thanks for the review – committed as Rev. 279004.
On 12/5/19 12:46 PM, Jakub Jelinek wrote:
On Fri, Nov 29, 2019 at 01:03:13PM +0100, Tobias Burnus wrote:
--- a/gcc/fortran/trans-openmp.c
+ && TREE_TYPE (decl) != pvoid_type_node
Is it always pvoid_type_node, or could it be s
On 12/5/19 4:12 PM, Richard Biener wrote:
Isn't there std::default_constructible? Also after your patch it's far from
obvious which api to use.
Will it work with:
struct Foo
{
Foo(int) {}
};
...
if (std::default_constructible ())
ptr = new ptr T ();
?
Wouldn't we end up with a compila
On December 5, 2019 2:03:24 PM GMT+01:00, Marc Glisse
wrote:
>On Wed, 4 Dec 2019, Jakub Jelinek wrote:
>
>> --- gcc/match.pd.jj 2019-12-03 10:20:00.244913801 +0100
>> +++ gcc/match.pd 2019-12-03 13:36:01.084435697 +0100
>> @@ -2159,20 +2159,26 @@ (define_operator_list COND_TERNARY
>> /* A
On Wed, Nov 20, 2019 at 02:06:18PM +0100, Tobias Burnus wrote:
> ** Included in the attached patch are the following previously posted
> patches: [1] the trivial libgomp/oacc-mem.c change, [2] only the remaining
> single-line change in omp-low.c, [3] the trans-openmp.c changes (which had
> to be mo
On December 5, 2019 3:35:17 PM GMT+01:00, Tom Tromey wrote:
>> "Martin" == Martin Liška writes:
>
>Martin> + /* Default constructor. */
>Martin> + symtab_node (symtab_type t)
>
>FWIW, in gdb, we normally make single-argument constructors "explicit".
>This helps avoid surprises with implici
On 12/5/19 2:03 PM, Jan Hubicka wrote:
Hi.
As mentioned in the PR, there are classes in cgraph.h that are
not PODs and are initialized with ggc_alloc_cleared. So that I'm suggesting
to use proper constructors. I added ggc_new function that can be used
at different locations as well.
I'm attachi
On December 5, 2019 3:09:40 PM GMT+01:00, "Martin Liška" wrote:
>On 12/5/19 2:53 PM, Richard Biener wrote:
>> On December 5, 2019 2:03:58 PM GMT+01:00, "Martin Liška"
> wrote:
>>> On 12/5/19 1:59 PM, Richard Biener wrote:
Isn't there ggc_alloc for this? Also ggc_alloc_no_dtor in
>>> case yo
Done.
r279003.
- David
On Thu, Dec 5, 2019 at 9:33 AM Jakub Jelinek wrote:
>
> On Thu, Dec 05, 2019 at 09:25:40AM -0500, David Edelsohn wrote:
> > Sorry. I had to add tm_p.h because Jakub's earlier patch to add
> > output.h to cp-gimplify.c broke AIX.
> >
> > We certainly can add memmodel.h to
> "Martin" == Martin Liška writes:
Martin> + /* Default constructor. */
Martin> + symtab_node (symtab_type t)
FWIW, in gdb, we normally make single-argument constructors "explicit".
This helps avoid surprises with implicit conversions.
Tom
On Thu, Dec 05, 2019 at 09:25:40AM -0500, David Edelsohn wrote:
> Sorry. I had to add tm_p.h because Jakub's earlier patch to add
> output.h to cp-gimplify.c broke AIX.
>
> We certainly can add memmodel.h to cp-gimplify.c.
I'd say so. E.g. c-family/c-cppbuiltin.c which also includes output.h
inc
Hi
While looking at vect_model_reduction_cost function, it seems Richard's
change in a recent commit r278611 missed an update to the following if
condition. Since the check for EXTRACT_LAST_REDUCTION is now split
above, the same check in the if condition will never be true.
gcc/ChangeLog
2019
Sorry. I had to add tm_p.h because Jakub's earlier patch to add
output.h to cp-gimplify.c broke AIX.
We certainly can add memmodel.h to cp-gimplify.c.
Thanks, David
On Thu, Dec 5, 2019 at 8:32 AM Joseph Myers wrote:
>
> The change
>
> 2019-12-04 David Edelsohn
>
> * cp-gimplify.c: In
On 12/5/19 2:53 PM, Richard Biener wrote:
On December 5, 2019 2:03:58 PM GMT+01:00, "Martin Liška" wrote:
On 12/5/19 1:59 PM, Richard Biener wrote:
Isn't there ggc_alloc for this? Also ggc_alloc_no_dtor in
case you
want to handle finalization yourself.
No, if I see correctly it only call
> On December 5, 2019 2:03:58 PM GMT+01:00, "Martin Liška"
> wrote:
> >On 12/5/19 1:59 PM, Richard Biener wrote:
> >> Isn't there ggc_alloc for this? Also ggc_alloc_no_dtor in
> >case you
> >> want to handle finalization yourself.
> >
> >No, if I see correctly it only calls Dtor:
>
> But its o
On December 5, 2019 2:03:58 PM GMT+01:00, "Martin Liška" wrote:
>On 12/5/19 1:59 PM, Richard Biener wrote:
>> Isn't there ggc_alloc for this? Also ggc_alloc_no_dtor in
>case you
>> want to handle finalization yourself.
>
>No, if I see correctly it only calls Dtor:
But its odd to handle finaliza
On 05/12/19 13:49 +, Jonathan Wakely wrote:
This also causes two new FAILs in 23_containers/span/lwg3255.cc but
that turns out to be a bug in the test, which fails now t hat you've
fixed a bug in span. I'll fix that as well.
Here's that fix for the buggy test.
Tested powerpc64le-linux, com
On 21/11/19 19:56 -0500, JeanHeyd Meneide wrote:
Thank you for the review!
- I moved the concepts back into the class and changed them to
template aliases because class local concepts aren't a thing that
works.
+ They are not inline constexpr bools because that ICE's GCC
pretty hard, as you
The change
2019-12-04 David Edelsohn
* cp-gimplify.c: Include tm_p.h.
appears to have broken the build for SPARC. I see
In file included from ./tm_p.h:4:0,
from
/scratch/jmyers/glibc-bot/src/gcc/gcc/cp/cp-gimplify.c:38:
/scratch/jmyers/glibc-bot/src/gcc/gcc/config/
Hi,
I have updated the documentation patch here and added relevant maintainers
so hopefully this can go in soon:
https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00311.html
I moved the paragraph in changes.html to the C section like you suggested. Would
it make sense to link to the porting_to entry
Hi,
Add entries for the default change in changes.html and porting_to.html.
Passes the W3 validator.
Cheers,
Wilco
---
diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html
index
e02966460450b7aad884b2d45190b9ecd8c7a5d8..304e1e8ccd38795104156e86b92062696fa5aa8b
100644
--- a/htd
After the PR92818 commit there's one function in the testcase below
remaining not using bit-inserts. The following fixes this.
Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.
Richard.
2019-12-05 Richard Biener
PR tree-optimization/92819
* match.pd (VEC_PERM_
On 12/5/19 1:59 PM, Richard Biener wrote:
Isn't there ggc_alloc for this? Also ggc_alloc_no_dtor in case you
want to handle finalization yourself.
No, if I see correctly it only calls Dtor:
template
inline T *
ggc_alloc (ALONE_CXX_MEM_STAT_INFO)
{
if (need_finalization_p ())
return sta
On Thu, 5 Dec 2019 at 12:59, Richard Biener wrote:
>
> On Thu, 5 Dec 2019, Christophe Lyon wrote:
>
> > Hi,
> >
> >
> > On Tue, 3 Dec 2019 at 15:46, Richard Biener wrote:
> > >
> > >
> > > The PR shows I added the bail-out prematurely.
> > >
> > > Bootstrapped and tested on x86_64-unknown-linux-g
> Hi.
>
> As mentioned in the PR, there are classes in cgraph.h that are
> not PODs and are initialized with ggc_alloc_cleared. So that I'm suggesting
> to use proper constructors. I added ggc_new function that can be used
> at different locations as well.
>
> I'm attaching optimized dump file wi
On Wed, 4 Dec 2019, Jakub Jelinek wrote:
--- gcc/match.pd.jj 2019-12-03 10:20:00.244913801 +0100
+++ gcc/match.pd2019-12-03 13:36:01.084435697 +0100
@@ -2159,20 +2159,26 @@ (define_operator_list COND_TERNARY
/* A - (A +- B) -> -+ B */
/* A +- (B -+ A) -> +- B */
(si
On Thu, Dec 5, 2019 at 1:50 PM Martin Liška wrote:
>
> Hi.
>
> As mentioned in the PR, there are classes in cgraph.h that are
> not PODs and are initialized with ggc_alloc_cleared. So that I'm suggesting
> to use proper constructors. I added ggc_new function that can be used
> at different locatio
Hi.
As mentioned in the PR, there are classes in cgraph.h that are
not PODs and are initialized with ggc_alloc_cleared. So that I'm suggesting
to use proper constructors. I added ggc_new function that can be used
at different locations as well.
I'm attaching optimized dump file with how ctor exp
On Thu, 5 Dec 2019, Prathamesh Kulkarni wrote:
> On Fri, 29 Nov 2019 at 15:41, Richard Biener
> wrote:
> >
> > On Fri, Nov 22, 2019 at 12:40 PM Prathamesh Kulkarni
> > wrote:
> > >
> > > On Wed, 20 Nov 2019 at 16:54, Richard Biener wrote:
> > > >
> > > > On Wed, 20 Nov 2019, Richard Sandiford
* include/bits/stl_algobase.h (lexicographical_compare_three_way):
Define for C++20.
* testsuite/25_algorithms/lexicographical_compare_three_way/1.cc: New
test.
* testsuite/25_algorithms/lexicographical_compare_three_way/
constexpr.cc: New test.
Tes
On Thu, Dec 5, 2019 at 1:41 PM Martin Liška wrote:
>
> On 12/5/19 1:30 PM, Richard Biener wrote:
> > I wonder if the behavior shouldn't be the default? The only thing we lose
> > is failing to notice really cold calls (error paths) in programs?
>
> I would also consider enabling that by default.
On Thu, Dec 5, 2019 at 11:26 AM Richard Sandiford
wrote:
>
> This PR shows that we weren't checking for bitwise-identical values
> when trying to encode a VECTOR_CST, so -0.0 was treated the same as
> 0.0 for -fno-signed-zeros. The patch adds a new OEP flag to select
> that behaviour.
>
> Tested
On 12/5/19 1:30 PM, Richard Biener wrote:
I wonder if the behavior shouldn't be the default? The only thing we lose
is failing to notice really cold calls (error paths) in programs?
I would also consider enabling that by default.
I'm sending a language correction for the option documentation:
1 - 100 of 130 matches
Mail list logo
