On Thu, 5 Dec 2019 08:41:48 -0700
Jeff Law <l...@redhat.com> wrote:
> On 12/5/19 4:32 AM, Jozef Lawrynowicz wrote:
> > MSP430 RTL patterns for conditional branch instructions allow the post
> > increment addressing mode to be used for the "dest" operand of CMP
> > instructions
> > used in these patterns.
> >
> > This is currently causing trunk to FTB for msp430-elf since these
> > instructions
> > are being generated using an autoinc for the dest operand, and the
> > assembler is
> > rejecting them:
> >
> >> ldtoa.s:1104: Error: this addressing mode is not applicable for
> >> destination operand
> >
> > The attached patch fixes this by using the "msp430_general_dst_nonv_operand"
> > predicate instead of the "nonimmediate_operand" predicate for the offending
> > RTL
> > patterns.
> >
> > Successfully regtested for msp430-elf on trunk and committed as obvious.
> >
> Thanks. I suspect that'll bring the msp430 back to "green" state in my
> tester. I'd been meaning to bisect that, but I'm fighting multiple
> other higher priority issues right now.
It looks like it was one of the below commits that exposed the bug, since my
tester showed it occurred between r278653 and r278883 (although I didn't
actually bisect to it).
commit f8c3d03646f08238fe261286470391bb88918660
Author: bernds <bernds@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Wed Nov 27 03:31:24 2019 +0000
Allow autoinc in jumps, but only when using reload.
* auto-inc-dec.c (merge_in_block): Allow autoinc in jumps unless
LRA is enabled.
* combine.c (can_combine_p): Disallow autoinc in jumps unless LRA is
disabled.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@278756
138bc75d-0d04-0410-961f-82ee72b054a4
commit 713a306a87bce2c8ed3ab3d4d8b0ecbeaf17f91a
Author: bernds <bernds@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Sun Nov 24 13:20:55 2019 +0000
Allow combiner to create autoinc in jump insns.
* combine.c (can_combine_p): Allow autoinc in jumps.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@278656
138bc75d-0d04-0410-961f-82ee72b054a4
>
> jeff
>
