Re: Improve std::rotate usages

2018-06-07 Thread François Dumont
Gentle reminder. On 27/05/2018 19:25, François Dumont wrote: Still no chance to review it ? I'd like this one to go in before submitting other algo related patches.     * include/bits/stl_algo.h     (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag))     (__rotate(_Ite, _Ite, _Ite, bidirectiona

Re: [PATCH] add missing @opindex to Warning Options

2018-06-07 Thread Eric Gallager
On 6/7/18, Martin Sebor wrote: > A bunch of warning options are missing an @opindex entry, > usually for the negative form. I went through them all > and added them where it made sense. > > Unless there are objections I will commit the patch to > trunk next week. > > I think the patch is also app

Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

2018-06-07 Thread Peter Bergner
On 6/7/18 5:12 PM, Peter Bergner wrote: > Is this ok for trunk and the release branches where the earlier fixes > were backported to, assuming no bootstrap errors and the testsuite runs > do not show any regressions? Hold off for now. I'm seeing a TImode issue I need to debug first. Peter

[PATCH] PR fortran/86059 -- NULL() cannot be in array constructor

2018-06-07 Thread Steve Kargl
Regression tested on x86_64-*-freebsd. OK to commit. 2018-06-07 Steven G. Kargl PR fortran/86059 * array.c (match_array_cons_element): NULL() cannot be in an array constructor. 2018-06-07 Steven G. Kargl PR fortran/86059 * gfortran.dg/associate_3

Re: [PATCH][Aarch64] v2: Arithmetic overflow tests [Patch 4/4]

2018-06-07 Thread James Greenhalgh
On Wed, Jun 06, 2018 at 12:20:59PM -0500, Michael Collison wrote: > This is a respin of a AArch64 patch that adds support for builtin arithmetic > overflow operations. This update separates the patch into multiple pieces and > addresses comments made by Richard Earnshaw here: > > https://gcc.gnu

Re: backport fix for PR 82063 to GCC 7 and 8

2018-06-07 Thread Martin Sebor
On 06/07/2018 04:40 PM, Jakub Jelinek wrote: On Thu, Jun 07, 2018 at 04:11:25PM -0600, Martin Sebor wrote: Also, the option is not documented in doc/invoke.texi, it is just mentioned in description of the -Walloc-size-larger-than= option, that is not enough; it needs to be listed in the Warning

Re: [PATCH][Aarch64] v2: Arithmetic overflow subv patterns [Patch 3/4]

2018-06-07 Thread James Greenhalgh
On Wed, Jun 06, 2018 at 12:19:52PM -0500, Michael Collison wrote: > This is a respin of a AArch64 patch that adds support for builtin arithmetic > overflow operations. This update separates the patch into multiple pieces and > addresses comments made by Richard Earnshaw here: > > https://gcc.gnu

Re: [PATCH][Aarch64] v2: Arithmetic overflow addv patterns [Patch 2/4]

2018-06-07 Thread James Greenhalgh
On Wed, Jun 06, 2018 at 12:16:22PM -0500, Michael Collison wrote: > This is a respin of a AArch64 patch that adds support for builtin arithmetic > overflow operations. This update separates the patch into multiple pieces and > addresses comments made by Richard Earnshaw here: > > https://gcc.gnu

Re: [PATCH][Aarch64] v2: Arithmetic overflow common functions [Patch 1/4]

2018-06-07 Thread James Greenhalgh
On Wed, Jun 06, 2018 at 12:14:03PM -0500, Michael Collison wrote: > This is a respin of a AArch64 patch that adds support for builtin arithmetic > overflow operations. This update separates the patch into multiple pieces and > addresses comments made by Richard Earnshaw here: > > https://gcc.gnu

[PATCH] PR fortran/78571 -- Avoid ICE in invalid CHARACTER initialization

2018-06-07 Thread Steve Kargl
Regression tested on x86_64-*-freebsd. OK to commit? 2018-06-07 Steven G. Kargl PR fortran/78571 * data.c (create_character_initializer): Return early if type is incompatible with CHARACTER. 2018-06-07 Steven G. Kargl PR fortran/78571 * gfortran.dg

[PATCH] add missing @opindex to Warning Options

2018-06-07 Thread Martin Sebor
A bunch of warning options are missing an @opindex entry, usually for the negative form. I went through them all and added them where it made sense. Unless there are objections I will commit the patch to trunk next week. I think the patch is also appropriate for release branches (modulo options

[PATCH, rs6000] Cleanup vsx-vector-6 test files.

2018-06-07 Thread Carl Love
GCC Maintainers: The test files gcc/testsuite/gcc.target/powerpc/vsx-vector- 6[be|le].[p7|p8|p9].c cover testing for LE and BE for the various processors. These were setup before we had the le and be targets. Given that we now have the be and le targets the test files can be combined into a sing

Re: backport fix for PR 82063 to GCC 7 and 8

2018-06-07 Thread Jakub Jelinek
On Thu, Jun 07, 2018 at 04:11:25PM -0600, Martin Sebor wrote: > > Also, the option is not documented in doc/invoke.texi, it is just mentioned > > in description of the -Walloc-size-larger-than= option, that is not enough; > > it needs to be listed in the Warning Options list, and it should have > >

Re: backport fix for PR 82063 to GCC 7 and 8

2018-06-07 Thread Joseph Myers
On Thu, 7 Jun 2018, Martin Sebor wrote: > Though accepting -Wno-no- seems to a general bug in the driver > for all options that don't specify RejectNegative. It accepts > -Wno-no-all as well. In fact, it seems to accept anything that > starts with -Wno-, even if it's completely bogus. No, it's

[PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

2018-06-07 Thread Peter Bergner
The fix for PR83969 accidentally disallowed PRE_INC and PRE_DEC addresses from being matched for the Y constraint leading to poor code generation. The following patch resurrects the fix for PR84279 (early test for altivec addresses) and then moves the call to rs6000_offsettable_memref_p below the a

Re: backport fix for PR 82063 to GCC 7 and 8

2018-06-07 Thread Martin Sebor
On 06/07/2018 03:17 PM, Jakub Jelinek wrote: On Thu, Jun 07, 2018 at 02:56:13PM -0600, Martin Sebor wrote: As I mentioned in my reply to Jeff below, I'd like to backport the fix for PR 82063 to the two release branches, GCC 7 and 8. If there are no concerns/objections I'll go ahead and commit th

Re: [PATCH, rs6000] Add BE support to builtin vec_extract_fp32_from_shorth, vec_extract_fp32_from_shortl

2018-06-07 Thread Peter Bergner
On 6/7/18 10:09 AM, Carl Love wrote: > * gcc/config/rs6000/vsx.md (vextract_fp_from_shorth > vextract_fp_from_shortl): Add BE support. Missing comma at the end of the first line I think. Peter

Re: [PATCH, rs6000] Add BE support to builtin vec_extract_fp32_from_shorth, vec_extract_fp32_from_shortl

2018-06-07 Thread Segher Boessenkool
On Thu, Jun 07, 2018 at 08:09:56AM -0700, Carl Love wrote: > 2018-05-31 Carl Love > > * gcc/config/rs6000/vsx.md (vextract_fp_from_shorth , > vextract_fp_from_shortl): Add BE support. > > gcc/testsuite/ChangeLog: > > 2018-05-31 Carl Love > > * gcc.target/powerpc/builti

Re: backport fix for PR 82063 to GCC 7 and 8

2018-06-07 Thread Jakub Jelinek
On Thu, Jun 07, 2018 at 02:56:13PM -0600, Martin Sebor wrote: > As I mentioned in my reply to Jeff below, I'd like to backport > the fix for PR 82063 to the two release branches, GCC 7 and 8. > If there are no concerns/objections I'll go ahead and commit > the patch to both sometime next week. > >

backport fix for PR 82063 to GCC 7 and 8

2018-06-07 Thread Martin Sebor
As I mentioned in my reply to Jeff below, I'd like to backport the fix for PR 82063 to the two release branches, GCC 7 and 8. If there are no concerns/objections I'll go ahead and commit the patch to both sometime next week. https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01822.html Thanks Marti

Re: [PATCH, rs6000] Add missing test cases, fix arguments to match specifications.

2018-06-07 Thread Segher Boessenkool
Hi! On Wed, Jun 06, 2018 at 04:45:03PM -0700, Carl Love wrote: > * gcc.target/powerpc/vec-cmp.c: Add vec_cmple, vec_cmpge tests. Update, >vcmpgtsb, vcmpgtub, vcmpgtsh, vcmpgtuh, vcmpgtsw, vcmpgtsw, vcmpgtuw, > vcmpgtsd, > vcmpgtud. Put these last two on one line? :-) >

Re: [patch] add -nolibc option

2018-06-07 Thread Olivier Hainque
Hello Joseph, This is a follow up on an exchange you had with Tristan Gingold back in Aug. 2017, starting from https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01824.html with your answer on his proposal at: https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00166.html (Tristan has moved to other

Re: Warning about -Wmain for local variables

2018-06-07 Thread Prathamesh Kulkarni
On 30 May 2018 at 21:21, Prathamesh Kulkarni wrote: > On 30 May 2018 at 18:12, Jonathan Wakely wrote: >> On 30 May 2018 at 11:40, Prathamesh Kulkarni wrote: >>> gcc with -Wmain warns for local variables named main. >>> >>> int foo() >>> { >>> int main = 0; >>> return main; >>> } >>> >>> a.c:

Re: C PATCH for c/85318, missing -Wc90-c99-compat warning with for-init-loop

2018-06-07 Thread Joseph Myers
On Thu, 7 Jun 2018, Marek Polacek wrote: > This PR reports that we are not emitting a -Wc90-c99-compat warning > for a for loop with a declaration. This patch adds it; here we want > to use pedwarn_c90 which takes care of it. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? OK. (This

Merge from trunk to gccgo branch

2018-06-07 Thread Ian Lance Taylor
I've merged trunk revision 261284 to the gccgo branch. Ian

Re: [PATCH] Avoid optimizing memory references with side effects in compare-elim.c

2018-06-07 Thread Paul Koning
> On Jun 7, 2018, at 11:37 AM, Eric Botcazou wrote: > >> Here is a corrected version. Ok with this change? >> >> paul >> >> gcc/ChangeLog: >> >> 2018-06-06 Paul Koning >> >> * compare-elim.c (try_merge_compare): Don't merge compare if >> address contains a side effect. >

[AArch64][PATCH 1/2] Fix addressing printing of LDP/STP

2018-06-07 Thread Andre Simoes Dias Vieira
Hi, The address printing for LDP/STP patterns that don't use parallel was not working properly when dealing with a post-index addressing mode. The post-index address printing uses the mode's size to determine the post-index immediate. To fix an earlier issue with range checking of these instru

[AArch64][PATCH 2/2] PR target/83009: Relax strict address checking for store pair lanes

2018-06-07 Thread Andre Simoes Dias Vieira
Hi, See below a patch to address PR 83009. Tested with aarch64-linux-gnu bootstrap and regtests for c, c++ and fortran. Ran the adjusted testcase for -mabi=ilp32. Is this OK for trunk? Cheers, Andre PR target/83009: Relax strict address checking for store pair lanes The operand constraint for

C PATCH for c/85318, missing -Wc90-c99-compat warning with for-init-loop

2018-06-07 Thread Marek Polacek
This PR reports that we are not emitting a -Wc90-c99-compat warning for a for loop with a declaration. This patch adds it; here we want to use pedwarn_c90 which takes care of it. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2018-06-07 Marek Polacek PR c/85318 * c-dec

[AArch64][PATCH 0/2] PR target/83009: Relax strict address checking for store pair lanes

2018-06-07 Thread Andre Simoes Dias Vieira
Hi, This patch series is aimed at resolving PR83009 that identified a missing optimization opportunity for Store pair lanes. The second patch of these series was initially reverted because it lead to a wrong codegen. This codegen was a latent issue that was now being hit due to STP's being gene

Go patch committed: Speed up variable initializer sorting

2018-06-07 Thread Ian Lance Taylor
The Go frontend used to do variable initializer sorting by looping through all the initialized variables and, for each one, looping through all the initialized variables and checking for a dependency. For very large packages with thousands of initialized global variables, this quadratic loop could

Re: [PATCH 08/14] Convert IPA CP to symbol_summary.

2018-06-07 Thread Martin Jambor
Hi, On Thu, Jun 07 2018, Jan Hubicka wrote: >> >> gcc/ChangeLog: >> >> 2018-04-24 Martin Liska >> >> * ipa-cp.c (ipcp_store_bits_results): Use >> ipcp_transformation_sum. >> (ipcp_store_vr_results): Likewise. >> * ipa-prop.c (ipcp_grow_transformations_if_necessary): Renam

[PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-06-07 Thread Martin Sebor
The attached patch enhances the strlen pass to more consistently deal with MEM_REF assignments (PR 86042) and to track string lengths across calls to memcpy that overwrite parts of a string with sequences of non-nul characters (PR 86043). Fixes for both bugs rely on changes to the same code so I

Re: [PATCH] Avoid optimizing memory references with side effects in compare-elim.c

2018-06-07 Thread Eric Botcazou
> Here is a corrected version. Ok with this change? > > paul > > gcc/ChangeLog: > > 2018-06-06 Paul Koning > > * compare-elim.c (try_merge_compare): Don't merge compare if > address contains a side effect. > (try_eliminate_compare): Likewise. > * gcc.c-torture/

Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp

2018-06-07 Thread Eric Botcazou
> Sorry this fell off my radar. I have reg-tested it on x86 and tried it > on the sparc machine from the gcc farm but I think I couldn't finished > the run and now its showing to he unreachable. The patch is a no-op for SPARC because it defines the nonlocal_goto pattern. But I would nevertheless

[PATCH, rs6000] Add BE support to builtin vec_extract_fp32_from_shorth, vec_extract_fp32_from_shortl

2018-06-07 Thread Carl Love
GCC Maintainers: The Power 9 builtins vec_extract_fp32_from_shorth, and vec_extract_fp32_from_shortl only work on Power 9 LE. The following patch adds BE support. Since no Power 9 BE systems are currently available, the testing consisted of visually inspecting the code to make sure the desired c

Re: C++ PATCH for c++/86060, c++98 ICE with range for

2018-06-07 Thread Jason Merrill
Ok. On Thu, Jun 7, 2018, 3:14 PM Marek Polacek wrote: > On Thu, Jun 07, 2018 at 03:51:24AM -0700, H.J. Lu wrote: > > On Wed, Jun 6, 2018 at 10:47 AM, Jason Merrill wrote: > > > If we're going to allow it with a pedwarn, we shouldn't clobber the > > > decl with an error_mark_node. > > > > > > Te

Re: [PATCH, rs6000] Fix PR target/63177: Powerpc no-vfa-vect-depend-2.c and no-vfa-vect-depend-3.c failures

2018-06-07 Thread Peter Bergner
On 6/6/18 2:54 PM, Segher Boessenkool wrote: > On Tue, Jun 05, 2018 at 10:03:46PM -0500, Peter Bergner wrote: >> On 6/5/18 3:22 PM, Segher Boessenkool wrote: >>> Ah, that's the crux. Thanks. Add a comment to the code please? >> >> Like so? I tried placing it next to the mcpu=power8 clause, but i

Re: C++ PATCH for c++/86060, c++98 ICE with range for

2018-06-07 Thread Marek Polacek
On Thu, Jun 07, 2018 at 03:51:24AM -0700, H.J. Lu wrote: > On Wed, Jun 6, 2018 at 10:47 AM, Jason Merrill wrote: > > If we're going to allow it with a pedwarn, we shouldn't clobber the > > decl with an error_mark_node. > > > > Tested x86_64-pc-linux-gnu, applying to trunk and 8. > > I got > > /e

Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp

2018-06-07 Thread Sudakshina Das
On 02/05/18 18:28, Jeff Law wrote: On 03/14/2018 11:40 AM, Sudakshina Das wrote: Hi This patch is another partial fix for PR 84521. This is adding a definition to one of the target hooks used in the SJLJ implemetation so that AArch64 defines the hard_frame_pointer_rtx as the TARGET_BUILTIN_SETJ

Re: [PATCH 14/14] Come up with cgraph_node::get_uid and make cgraph_node::uid private.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * cgraph.c (function_version_hasher::hash): Use > cgraph_node::get_uid (). > (function_version_hasher::equal): > * cgraph.h (cgraph_node::get_uid): New method. > * ipa-inline.c (update_caller_keys): Use > c

Re: [PATCH 12/14] Port edge_growth_cache to call_summary.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * ipa-inline-analysis.c (inline_edge_removal_hook): Remove. > (initialize_growth_caches): Remove. > (free_growth_caches): Likewise. > (do_estimate_edge_time): Use edge_growth_cache. > (do_estimate_edge_size): Lik

Re: [PATCH 07/14] Covert ipa-pure-const.c to symbol_summary.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * ipa-pure-const.c (struct funct_state_d): Do it class instead > of struct. > (class funct_state_summary_t): New function_summary class. > (has_function_state): Remove. > (get_function_state): Likewise. > (

Re: [PATCH 11/14] Port IPA CP to edge_clone_summaries.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * ipa-cp.c (class edge_clone_summary): New summary. > (grow_edge_clone_vectors): Remove. > (ipcp_edge_duplication_hook): Remove. > (class edge_clone_summary_t): New call_summary class. > (ipcp_edge_removal_hook):

Re: [PATCH 08/14] Convert IPA CP to symbol_summary.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * ipa-cp.c (ipcp_store_bits_results): Use > ipcp_transformation_sum. > (ipcp_store_vr_results): Likewise. > * ipa-prop.c (ipcp_grow_transformations_if_necessary): Renamed > to ... > (ipcp_transformation_ini

Re: [PATCH 03/14] Rename get methods in symbol-summary.h to get_create.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * config/i386/i386.c (ix86_can_inline_p): Use get_create instead > of get. > * hsa-common.c (hsa_summary_t::link_functions): Likewise. > (hsa_register_kernel): Likewise. > * hsa-common.h (hsa_gpu_implementation_p

Re: [PATCH 13/14] Make cgraph_edge::uid really unique.

2018-06-07 Thread Richard Biener
On Thu, Jun 7, 2018 at 2:36 PM Jan Hubicka wrote: > > > On Thu, Jun 7, 2018 at 2:19 PM Jan Hubicka wrote: > > > > > > > > > > > gcc/ChangeLog: > > > > > > > > 2018-04-24 Martin Liska > > > > > > > > * cgraph.c (symbol_table::create_edge): Always assign a new > > > > unique number.

Re: [PATCH 04/14] Add {symbol,call}_summary::get method and use it in HSA.

2018-06-07 Thread Martin Jambor
On Thu, Jun 07 2018, Jan Hubicka wrote: >> >> gcc/ChangeLog: >> >> 2018-04-24 Martin Liska >> >> * hsa-common.h (enum hsa_function_kind): Rename HSA_NONE to >> HSA_INVALID. >> (hsa_function_summary::hsa_function_summary): Use the new enum >> value. >> (hsa_gpu_impleme

Re: [PATCH 13/14] Make cgraph_edge::uid really unique.

2018-06-07 Thread Jan Hubicka
> On Thu, Jun 7, 2018 at 2:19 PM Jan Hubicka wrote: > > > > > > > > gcc/ChangeLog: > > > > > > 2018-04-24 Martin Liska > > > > > > * cgraph.c (symbol_table::create_edge): Always assign a new > > > unique number. > > > (symbol_table::free_edge): Do not recycle numbers. > > >

Re: Extend tree code folds to IFN_COND_*

2018-06-07 Thread Richard Biener
On Wed, Jun 6, 2018 at 10:16 PM Richard Sandiford wrote: > > > On Thu, May 24, 2018 at 11:36 AM Richard Sandiford > > wrote: > >> > >> This patch adds match.pd support for applying normal folds to their > >> IFN_COND_* forms. E.g. the rule: > >> > >> (plus @0 (negate @1)) -> (minus @0 @1) > >>

Re: [PATCH 13/14] Make cgraph_edge::uid really unique.

2018-06-07 Thread Richard Biener
On Thu, Jun 7, 2018 at 2:19 PM Jan Hubicka wrote: > > > > > gcc/ChangeLog: > > > > 2018-04-24 Martin Liska > > > > * cgraph.c (symbol_table::create_edge): Always assign a new > > unique number. > > (symbol_table::free_edge): Do not recycle numbers. > > * cgraph.h (cgraph

Re: [PATCH 06/14] Use symtab_summary in ipa-reference.c.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * ipa-reference.c (remove_node_data): Remove. > (duplicate_node_data): Likewise. > (class ipa_ref_var_info_summary_t): New class. > (class ipa_ref_opt_summary_t): Likewise. > (get_reference_vars_info): Use ipa_re

Re: [PATCH 10/14] Add call_summary::get method and m_initialize_when_cloning.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * symbol-summary.h (get): New function. > (call_summary::m_initialize_when_cloning): New class member. > --- > gcc/symbol-summary.h | 66 > +++- > 1 file changed, 50 insertions(+),

Re: [PATCH 01/14] Code refactoring of symtab_summary.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * symbol-summary.h (function_summary): Move constructor > implementation out of class declaration. > (release): Likewise. > (symtab_insertion): Likewise. > (symtab_removal): Likewise. > (symtab_duplication)

Re: [PATCH 13/14] Make cgraph_edge::uid really unique.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * cgraph.c (symbol_table::create_edge): Always assign a new > unique number. > (symbol_table::free_edge): Do not recycle numbers. > * cgraph.h (cgraph_edge::get): New method. > * symbol-summary.h (symtab_removal)

Re: [PATCH 05/14] Use summaries->get where possible. Small refactoring of multiple calls.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * ipa-fnsummary.c (dump_ipa_call_summary): Use ::get method. > (analyze_function_body): Extract multiple calls of get_create. > * ipa-inline-analysis.c (simple_edge_hints): Likewise. > * ipa-inline.c (recursive_inlinin

Re: [PATCH 09/14] Remove cgraph_node::summary_uid and make cgraph_node::uid really unique.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-05-16 Martin Liska > > * cgraph.c (cgraph_node::remove): Do not recycle uid. > * cgraph.h (symbol_table::release_symbol): Do not pass uid. > (symbol_table::allocate_cgraph_symbol): Do not set uid. > * passes.c (uid_hash_t): Record removed_no

Re: [PATCH 02/14] Code refactoring for call_summary.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * symbol-summary.h (release): Move definition out of class > declaration. > (symtab_removal): Likewise. > (symtab_duplication): Likewise. OK, Honza

Re: [PATCH 04/14] Add {symbol,call}_summary::get method and use it in HSA.

2018-06-07 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2018-04-24 Martin Liska > > * hsa-common.h (enum hsa_function_kind): Rename HSA_NONE to > HSA_INVALID. > (hsa_function_summary::hsa_function_summary): Use the new enum > value. > (hsa_gpu_implementation_p): Use hsa_summaries::get. > *

[PATCH] Backport PR84761 to gcc 7

2018-06-07 Thread Richard Biener
This backports the glibc 2.27+ fix to ASAN to the GCC 7 branch. Probably some whitespace issue caused it not to apply 1:1 so I manually copy-pasted it. Bootstrapped and tested on x86_64-unknown-linux-gnu (with -m32 testing) on both a glibc 2.27 and glibc 2.22 host. Richard. 2018-06-07 Richard

Re: [PATCH] c/55976 -Werror=return-type should error on returning a value from a void function

2018-06-07 Thread Martin Liška
On 06/01/2018 11:08 PM, dave.pa...@oracle.com wrote: > Thanks for pointing this out. I'll check out what's going on and fix the issue > > --Dave Hi. Difference is in between C and C++ FEs: marxin@marxinbox:/dev/shm/objdir/gcc> ./xgcc -B. /home/marxin/Programming/gcc/gcc/testsuite/gcc.dg/noncom

Re: [PATCH][RFC] Drop GENERIC conds in [VEC_]COND_EXPRs

2018-06-07 Thread Richard Biener
On Wed, 6 Jun 2018, Richard Sandiford wrote: > Richard Biener writes: > > On Tue, 5 Jun 2018, Richard Biener wrote: > > > >> > >> This is a prototype enforcing is_gimple_val conditions in > >> [VEC_]COND_EXPRs. It shows quite some fallout - some likely > >> due to necessary testsuite adjustmen

Re: [PATCH][AArch64] Support for LDP/STP of Q-registers

2018-06-07 Thread Kyrill Tkachov
On 05/06/18 18:28, James Greenhalgh wrote: On Tue, Jun 05, 2018 at 11:32:06AM -0500, Kyrill Tkachov wrote: On 04/06/18 18:40, Kyrill Tkachov wrote: Hi all, This patch adds support for generating LDPs and STPs of Q-registers. This allows for more compact code generation and makes better use of

Re: C++ PATCH for c++/86060, c++98 ICE with range for

2018-06-07 Thread H.J. Lu
On Wed, Jun 6, 2018 at 10:47 AM, Jason Merrill wrote: > If we're going to allow it with a pedwarn, we shouldn't clobber the > decl with an error_mark_node. > > Tested x86_64-pc-linux-gnu, applying to trunk and 8. I got /export/gnu/import/git/gcc-test/src-8/gcc/testsuite/g++.dg/cpp0x/range-for9.C

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-07 Thread Jozef Lawrynowicz
On 06/06/18 23:38, DJ Delorie wrote: That's fine too, I was thinking of checking mcu_name[i] against NUL. Any of those solutions would work :-) Thanks, installed on trunk.

[PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

2018-06-07 Thread Rasmus Villemoes
The current "fix" for assert.h on vxworks is itself broken in a number of ways. First, assert.h is special in that it should _not_ have an include guard - the user is allowed to include it multiple times with different definedness of _NDEBUG to enable and disable assert() in parts of a TU. Second

[PATCH] Fixup some issues in extract_affine (graphite)

2018-06-07 Thread Richard Biener
I've noticed some wrong-code issues as well as missed optimizations (less 'wrap' stuff). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. >From 02d00158e8ec62f1c52a8191f6b15c446445a4da Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Thu, 7 Jun 2018 09:26:22 +0200 S

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-07 Thread Olivier Hainque
> On 07 Jun 2018, at 10:36, Jakub Jelinek wrote: > > No, this is just wrong. > The whole point of -gstrict-dwarf is that it doesn't allow any extensions, > and DW_LANG_Ada83/DW_LANG_Ada95 only appeared in DWARF3. Oh, I hadn't realized that. I see. > Perhaps don't use -gstrict-dwarf if you are

Re: [RFC] [aarch64] Add HiSilicon tsv110 CPU support

2018-06-07 Thread Zhangshaokun
Hi Kyrill, On 2018/6/6 22:51, Kyrill Tkachov wrote: > Hi Shaokun, > > On 01/06/18 10:56, Zhangshaokun wrote: >> Hi Ramana, >> >> Sorry to reply so later because of short leave. >> >> On 2018/5/23 18:41, Ramana Radhakrishnan wrote: >>> >>> On 23/05/2018 03:50, Zhangshaokun wrote: Hi Ramana, >

Re: [PATCH] libgcc/config/t-vxworks: remove -nostdinc from LIBGCC2_INCLUDES

2018-06-07 Thread Olivier Hainque
Hello Rasmus, > On 04 Jun 2018, at 11:02, Rasmus Villemoes wrote: >> Turns out we have encountered the canadian build problem as well and have >> an alternate resolution for it, which I was about to commit. >> >> Does the attached patch work for you ? > > It does seem to work for me, both for

[PATCH] Default special members of regex types and add noexcept

2018-06-07 Thread Jonathan Wakely
* include/bits/regex.h (sub_match): Add noexcept to default constructor and length observer. (match_results): Add noexcept to default constructor and observers with no preconditions. Define destructor as defaulted. (operator==, operator!=, swap): Add noexcep

[patch] refine -I flags for VxWorks libgcc

2018-06-07 Thread Olivier Hainque
Hello, This patch arranges to always have /gcc/include in the -I flags for libgcc on VxWorks. This directory contains user accessible header files provided by gcc so is legitimate and needed in many cases. This is implicitly achieved with -B when building a regular cross compiler, but there's no

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-07 Thread Jakub Jelinek
On Thu, Jun 07, 2018 at 10:31:29AM +0200, Olivier Hainque wrote: > Hello, > > dwarf2out currently prevents advertising DW_LANG_Ada if > version < 3 and strict_dwarf. There is no good reason for > this and it is detrimental to gdb on some VxWorks configurations. > > This patch just moves the DW_LA

[patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-07 Thread Olivier Hainque
Hello, dwarf2out currently prevents advertising DW_LANG_Ada if version < 3 and strict_dwarf. There is no good reason for this and it is detrimental to gdb on some VxWorks configurations. This patch just moves the DW_LANG_Ada language selection out of the section guarded by the special version che