On Thu, Jun 07, 2018 at 04:11:25PM -0600, Martin Sebor wrote:
> > Also, the option is not documented in doc/invoke.texi, it is just mentioned
> > in description of the -Walloc-size-larger-than= option, that is not enough;
> > it needs to be listed in the Warning Options list, and it should have
> > @itemx next to -Walloc-size-larger-than=.
>
> Adding @itemx will just add a index entry for it, right? That
> makes sense.
>
> I'm not sure I agree that the negative form should be listed
> in @gccoptlist{}. Only options that are on by default mention
> the -Wno- form there so including both forms would go against
> this convention.
If an option only has a no form, it should be listed too of course.
@item is not index, that is @opindex, which is missing for
Walloc-size-larger-than= too.
> > I'm not convinced backporting the addition of the new options to release
> > branches is desirable, fixing the bug in alloc_max_size is ok for the
> > branches.
>
> I agree. (Or did you mean to include -Wno-alloc-size-larger-than
> among the new options?)
I mean all these new -Wno-* options, including
-Wno-alloc-size-larger-than. That is not a bugfix, but a new feature.
Jakub
