Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

2014-09-22 22:51 GMT+04:00 Uros Bizjak : > On Mon, Sep 22, 2014 at 5:30 PM, Ilya Enkovich wrote: >> On 19 Sep 18:21, Uros Bizjak wrote: >>> On Fri, Sep 19, 2014 at 2:53 PM, Ilya Enkovich >>> wrote: >>> >>> >> > This patch adds i386 target hooks for Pointer Bounds Checker. >>> >>> > New version w

[Ping] [PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov

Ping? Patch is rebased and attached. Thanks! -Zhenqiang ChangeLog 2014-09-23 Zhenqiang Chen Andrew Pinski * ccmp.c (used_in_cond_stmt_p): Hande ? expr. * expr.c (expand_cond_expr_using_cmove): Handle CCmode. * ifcvt.c: #include "ccmp.h". (struct

[Ping] [PATCH, 9/10] aarch64: generate conditional compare instructions

Ping? Patch is attached for easy to apply. Bootstrap on AARCH64 qemu. Test cases: test_frame_*.c need update after the patch. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monda

[Ping] [PATCH, 7/10] aarch64: add function to output ccmp insn

Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 3:00 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 7/10] aarc

[Ping] [PATCH, 8/10] aarch64: ccmp insn patterns

Ping? Patch is attached for easy to apply. Move the cstorecc4 pattern from "[PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov" to this patch, since cmov optimization does not depend on that patch. Thanks! -Zhenqiang ChangeLog: 2014-09-23 Zhenqiang Chen * config/

[Ping] [PATCH, 6/10] aarch64: add ccmp CC mode

Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 3:00 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 6/10] aarc

[Ping] [PATCH, 5/10] aarch64: add ccmp operand predicate

Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 3:00 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 5/10] aarc

[Ping] [PATCH, 4/10] expand ccmp

Ping? Patch is rebased and regenerated since "[PATCH, 3/10] skip swapping operands used in ccmp" is discarded. Please find the updated patch in attachment. Bootstrap and no make check regression on X86-64. Thanks! -Zhenqiang ChangeLog: 2014-09-23 Zhenqiang Chen * ccmp.c: New file.

[Ping] [PATCH, 2/10] prepare ccmp

Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Tuesday, July 01, 2014 1:08 PM > To: Richard Earnshaw > Cc: gcc-patches@gcc.gnu.org > Sub

[Discard] [PATCH, 3/10] skip swapping operands used in ccmp

The patch is discarded since I can not reproduce the issue with the latest trunk. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Thursday, June 26, 2014 3:21 PM > To: Richard

[Ping] [PATCH, 1/10] two hooks for conditional compare (ccmp)

Ping? Patch is attached for easy to apply. Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Monday, June 23, 2014 2:57 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH, 1/10] two

Re: [PATCH, i386, Pointer Bounds Checker 33/x] MPX ABI

2014-09-22 22:22 GMT+04:00 Jeff Law : > On 09/21/14 06:34, Uros Bizjak wrote: >> >> On Fri, Sep 19, 2014 at 9:55 AM, Ilya Enkovich >> wrote: >> >>> Here is an updated version of this patch. >>> @@ -25000,10 +25082,32 @@ ix86_expand_call (rtx retval, rtx fnaddr, rtx >>> callarg1, >>> } >>> >>

Re: [Ping] Port of VTV for Cygwin and MinGW

Ok, your patch looks OK to me, but I can only approve the libvtv file changes. The changes in the other files also seem ok to me, but someone else will have to approve the modifications in them: gcc/config/i386/cygwin.h gcc/config/i386/mingw-w64.h gcc/config/i386/mingw32.h gcc/cp/vtable-class-hie

Re: RFA: another patch to fix PR61360

On Tue, Sep 23, 2014 at 3:26 AM, Vladimir Makarov wrote: > The previous patch to solve PR61360 fixed the problem in IRA (it was > easier for me to do as I know the code well) > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 > > Although imo it was an ok fix, Richard expressed concerns wi

Re: [gccgo/4.9] debug/elf: support arm64 relocations

On Mon, Sep 22, 2014 at 2:26 PM, Michael Hudson-Doyle wrote: > > I'm attaching the patch that will be in Go 1.4 that enables debug/elf to > parse aarch64 relocations, necessary for cgo. It will end up in gccgo > mainline soon enough but 4.9 is going to be the default compiler on > arm64 for a whi

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

Thanks a lot. I'm moving and I didn't have time to make a test case. Regards 2014-09-20 8:14 GMT-06:00 Tobias Burnus : > Hi Alessandro et al., > > I have now committed (Rev. 215421) the attached patch, which includes a test > case for it. > > Thanks for the report and the patch Alessandro! > > Tob

Re: [PATCH IRA] update_equiv_regs fails to set EQUIV reg-note for pseudo with more than one definition

> On 09/22/14 08:40, Felix Yang wrote: > > Hi, > > > > I find that update_equiv_regs in ira.c sets the wrong EQUIV > > reg-note for pseudo with more than one definiton in certain situation. > > Here is a simplified RTL snippet after this function finishs handling: > > > > (insn 77 37 78

Re: [PATCH] combine: Allow substituting the target reg of a clobber

On Fri, Sep 12, 2014 at 4:01 AM, Jeff Law wrote: > On 09/11/14 13:01, Segher Boessenkool wrote: >> >> Ping? > > Not forgotten. Still waiting to hear back from Bin on my recommendation > that we drop the bogus note on the floor and avoid combining pseudos with > multiple sets like that. Sorry tha

RFA: another patch to fix PR61360

The previous patch to solve PR61360 fixed the problem in IRA (it was easier for me to do as I know the code well) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 Although imo it was an ok fix, Richard expressed concerns with the patch and the practice to have different enable attribute

Re: Move dwarf2 frame tables to read-only section for AIX

Hi, On Tue, Sep 23, 2014 at 2:47 AM, Joseph S. Myers wrote: > If you rename a target macro, the old target macro name needs to be > poisoned in system.h. Fixed in patch below. > This ChangeLog entry seems very incomplete. It doesn't mention the > changes for other architectures, or to defaults.

Re: Remove LIBGCC2_LONG_DOUBLE_TYPE_SIZE target macro

On 09/22/14 17:12, Joseph S. Myers wrote: This patch removes the target macro LIBGCC2_LONG_DOUBLE_TYPE_SIZE. After recent changes, this macro was used in two ways in libgcc: to determine the mode of long double in dfp-bit.h, and to determine whether a particular mode has excess precision for use

Re: [PATCH] Fix whitespace in comments.

On 09/20/14 08:48, Tobias Burnus wrote: Hi Joost and Thomas, On 20.09.2014 12:02, Thomas Koenig wrote: A somewhat trivial patch to cleanup whitespace issues in comments: sed "s/\. \*\//\. \*\//g" Tested with a recompile only. Ok for trunk ? OK. (Obvious, really). I want to point a downside

Remove LIBGCC2_LONG_DOUBLE_TYPE_SIZE target macro

This patch removes the target macro LIBGCC2_LONG_DOUBLE_TYPE_SIZE. After recent changes, this macro was used in two ways in libgcc: to determine the mode of long double in dfp-bit.h, and to determine whether a particular mode has excess precision for use in complex multiplication. The former is c

Re: [PATCH] combine: Allow substituting the target reg of a clobber

On 09/03/14 07:51, Segher Boessenkool wrote: This came up when investigating PR62151. In that PR combine messes up a four-insn combination. It should really have done the combination of the first three insns in that. The second of those instructions sets a register; the third clobbers the same

Re: [patch] libstdc++/29988 Rb_Tree reuse allocated nodes

On 11/06/2014 14:02, Jonathan Wakely wrote: @@ -514,11 +651,11 @@ { return this->_M_impl._M_header._M_right; } _Link_type - _M_begin() _GLIBCXX_NOEXCEPT + _M_begin() const _GLIBCXX_NOEXCEPT { return static_cast<_Link_type>(this->_M_impl._M_header._M_parent); } What

[PATCH, rs6000] Cleanup movsf/movsd/movdf/movdd constraints; Cleanup TImode boolean

I was working to support enhancing addressing modes in the the compiler that is indended to better support load fusion in power8, and to finally allow DFmode/SFmode scalar values in the traditional altivec registers. I noticed that the floating point moves were still using constraints that could t

libgo patch committed: Mark runtime_goexit as noinline

This patch from Peter Collingbourne marks runtime_goexit as noinline. If we don't do that, it may be inlined into the kickoff function. That function refers to the TLS variable g, as does runtime_goexit. But by the time kickoff calls runtime_goexit, it may be running in a different thread. If th

Re: [PATCH 2/2] Add test cases for noreorder

> From: Andi Kleen > > Add some simple test cases for noreorder behaving like > -fno-toplevel-reorder and -fno-toplevel-reorder still working. > Unfortunately there's no easy way to check for output order in DG, > so we just check for existence. OK, thanks! Honza > > gcc/testsuite/: > > 2014-0

Re: [PATCH 1/2] Add an no_reorder attribute for LTO

> gcc/c-family/: > > 2014-09-15 Andi Kleen > > * c-common.c (handle_no_reorder_attribute): New function. > (c_common_attribute_table): Add no_reorder attribute. > > gcc/: > > 2014-09-14 Andi Kleen > > * cgraph.h (symtab_node): Add no_reorder attribute. > (symbol_t

Re: [PATCH 5/9] rs6000: Clean up bool3

On Mon, Sep 22, 2014 at 01:13:38PM -0700, Richard Henderson wrote: > On 09/20/2014 11:23 AM, Segher Boessenkool wrote: > > +(define_code_attr iorxor [(ior "ior") (xor "xor")]) > > +(define_code_attr IORXOR [(ior "IOR") (xor "XOR")]) > > You don't need these. They are and respectively. Ah nice,

Re: [PATCH 5/9] rs6000: Clean up bool3

On 09/20/2014 11:23 AM, Segher Boessenkool wrote: > +(define_code_attr iorxor [(ior "ior") (xor "xor")]) > +(define_code_attr IORXOR [(ior "IOR") (xor "XOR")]) You don't need these. They are and respectively. r~

Re: Updated no_reorder patchkit

> This version addresses earlier comments and has an updated testsuite > (still no LTO tests however). The assembler statements also > no stay in order with ordered statements. > > It doesn't disable sorting of paritions with ordered symbols. I think > that's an existing bug and is best addressed

[jit] Add notes on internals to documentation

Committed to branch dmalcolm/jit: gcc/jit/ChangeLog.jit: * docs/index.rst: Add internals/index.rst. * docs/internals/index.rst: New. * notes.txt: Update to reflect renaming of toplev_main to toplev::main. --- gcc/jit/ChangeLog.jit| 7 gcc/jit/docs

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

Le 22 sept. 2014 à 20:50, Dominique d'Humières a écrit : > > So, I’m wondering if the x86 maintainers want me to review and approve a > > patch, > > or if they want to. I was assuming they wanted to. > > Mike, > > From the information available, I think the only acceptable patch is > the one

RE: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

That's exactly correct. There are two ways to implement a work-stealing scheduler. We refer to them as: - Child Stealing - This is what TBB implements. The spawned call is bundled up with all the parameters and pushed onto a queue. The worker will continue executing the code after the spawne

Re: libsanitizer merge from upstream r218156

- one wrong e-mail On Mon, Sep 22, 2014 at 11:44 AM, Konstantin Serebryany wrote: > re-sending with the patch compressed: > > === gcc/testsuite/ChangeLog > 2014-09-22 Kostya Serebryany > > Update to match the changed asan API. > * asan.c (asan_global_struct): Update

C++ PATCH to tweak invalid non-static data member diagnostic

Adjusting this diagnostic to conform to our convention of having only one error message plus notes. Tested x86_64-pc-linux-gnu, applying to trunk. commit 99ef5c20fe8566fbfbe14e085f765d2c3f05b252 Author: Jason Merrill Date: Mon Sep 22 13:43:18 2014 -0400 * semantics.c (finish_non_static_

Re: Speedup int_bit_from_pos

Hi, it now seems to work, finaly :) Bootstrapped/regtested x86_64-linux, OK? * tree.c (int_bit_position): Move to... * tree.h (int_bit_position): ... here; implement using direct wide_int calculation instead of folding. Index: tree.c

C++ PATCH for c++/63320 (lambda in static member function)

The fix for 60463 didn't handle properly the case where we don't find a 'this' at all. Tested x86_64-pc-linux-gnu, applying to trunk. commit 7ef1880eec81f1c3914f6e018e709224a64fefc1 Author: Jason Merrill Date: Mon Sep 22 13:21:16 2014 -0400 PR c++/63320 PR c++/60463 PR c++/607

Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

On 09/19/14 10:21, Uros Bizjak wrote: +static tree +ix86_make_bounds_constant (HOST_WIDE_INT lb, HOST_WIDE_INT ub) +{ + tree low = lb ? build_minus_one_cst (pointer_sized_int_node) +: build_zero_cst (pointer_sized_int_node); + tree high = ub ? build_zero_cst (pointer_sized_int_node) +:

Re: Speedup int_bit_from_pos

> On Sep 22, 2014, at 11:22 AM, Jan Hubicka wrote: > >> Not quite: > >> > >> offset_int woffset > >>= (wi::to_offset (xoffset) > >> + wi::lrshift (wi::to_offset (DECL_FIELD_BIT_OFFSET (field)), > >> LOG2_BITS_PER_UNIT)); > >> > >> offset_int is the

Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

On Mon, Sep 22, 2014 at 5:30 PM, Ilya Enkovich wrote: > On 19 Sep 18:21, Uros Bizjak wrote: >> On Fri, Sep 19, 2014 at 2:53 PM, Ilya Enkovich >> wrote: >> >> >> > This patch adds i386 target hooks for Pointer Bounds Checker. >> >> > New version with fixes and better documentation for ix86_load_b

Re: [C++ Patch/RFC] PR 62219

OK for trunk and 4.9; I'd hold off on 4.8 unless someone asks for it there. Jason

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

On Sep 22, 2014, at 11:43 AM, Uros Bizjak wrote: > As far as I'm concerned, this is Darwin specific patch, so it needs > an approval from Darwin maintainer. The patch just happens to live in > i386 directory ;) Ok, thanks.

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

On Mon, Sep 22, 2014 at 8:24 PM, Mike Stump wrote: > On Sep 20, 2014, at 10:52 AM, Kai Tietz wrote: >> I missed that op points still on the memory here. So corrected patch >> is inlined below. > > So, I’m wondering if the x86 maintainers want me to review and approve a > patch, or if they want

[Patch AArch64] Fix extended register width

Hi The extended register width in add/adds/sub/subs/cmp instructions is not always the same as target register, it depends on both target register width and extension type. But in current implementation the extended register width is always the same as target register. We have noticed it can gener

Re: [PATCH IRA] update_equiv_regs fails to set EQUIV reg-note for pseudo with more than one definition

On 09/22/14 08:40, Felix Yang wrote: Hi, I find that update_equiv_regs in ira.c sets the wrong EQUIV reg-note for pseudo with more than one definiton in certain situation. Here is a simplified RTL snippet after this function finishs handling: (insn 77 37 78 2 (set (reg:SI 171)

Re: Speedup int_bit_from_pos

On Sep 22, 2014, at 11:22 AM, Jan Hubicka wrote: >> Not quite: >> >> offset_int woffset >>= (wi::to_offset (xoffset) >> + wi::lrshift (wi::to_offset (DECL_FIELD_BIT_OFFSET (field)), >> LOG2_BITS_PER_UNIT)); >> >> offset_int is the type that can hol

Re: [patch i386]: Sibcall tail-call improvement and partial fix PR/60104

On Sep 20, 2014, at 10:52 AM, Kai Tietz wrote: > I missed that op points still on the memory here. So corrected patch > is inlined below. So, I’m wondering if the x86 maintainers want me to review and approve a patch, or if they want to. I was assuming they wanted to.

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

On Mon, Sep 22, 2014 at 8:04 AM, Teresa Johnson wrote: > On Mon, Sep 22, 2014 at 1:36 AM, Nathan Sidwell wrote: >> On 09/21/14 18:58, Xinliang David Li wrote: >> the intent is that that points to the gcov_info object of the object file containing the live version of the function. I cou

Re: Speedup int_bit_from_pos

> Not quite: > > offset_int woffset > = (wi::to_offset (xoffset) >+ wi::lrshift (wi::to_offset (DECL_FIELD_BIT_OFFSET (field)), > LOG2_BITS_PER_UNIT)); > > offset_int is the type that can hold all bit positions, byte positions, byte > sizes and

Re: [PATCH, i386, Pointer Bounds Checker 33/x] MPX ABI

On 09/21/14 06:34, Uros Bizjak wrote: On Fri, Sep 19, 2014 at 9:55 AM, Ilya Enkovich wrote: Here is an updated version of this patch. @@ -25000,10 +25082,32 @@ ix86_expand_call (rtx retval, rtx fnaddr, rtx callarg1, } call = gen_rtx_CALL (VOIDmode, fnaddr, callarg1); + if (retv

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

On Mon, Sep 22, 2014 at 1:36 AM, Nathan Sidwell wrote: > On 09/21/14 18:58, Xinliang David Li wrote: > >>> the intent is that that points to the gcov_info object of the object file >>> containing the live version of the function. I couldn't quite get this >>> to >>> work though -- it involves emi

Re: Speedup int_bit_from_pos

On Sep 22, 2014, at 8:51 AM, Jan Hubicka wrote: >> On Sun, 21 Sep 2014, Jan Hubicka wrote: >> Please omit static from inline functions. >>> >>> Yep, I suppose we want to drop static in all inlines? I can make patch for >>> that. Also one notable difference with your patche

Re: [PATCH] Improve prepare_shrink_wrap to sink more instructions

On 09/22/14 04:29, Jiong Wang wrote: On 19/09/14 21:43, Jeff Law wrote: On 09/15/14 08:33, Jiong Wang wrote: Jeff, thanks, I partially understand your meaning here. take the function "ira_implicitly_set_insn_hard_regs" in ira-lives.c for example, when generating address rtl, gcc

Re: Speedup int_bit_from_pos

> > On Sun, 21 Sep 2014, Jan Hubicka wrote: > > > > > > > > > > Please omit static from inline functions. > > > > > > Yep, I suppose we want to drop static in all inlines? I can make patch > > > for that. > > > > > > > > Also one notable difference with your patches is that the fits hwi is >

Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

On 09/22/14 04:24, Jiong Wang wrote: Great. Can you send an updated patchkit for review. patch attached. please review, thanks. gcc/ * shrink-wrap.c (move_insn_for_shrink_wrap): Initialize the live-in of new created BB as the intersection of live-in from "old_dest" and live-out from "bb". L

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

On Mon, Sep 22, 2014 at 4:10 AM, Alan Lawrence wrote: > Well, I haven't looked into this in detail: I've gone only as far as > * swapping emit-rtl.o between 'good' compiles (svn r214042) and 'bad' > compiles (r214043), finding that the critical difference is in the > emit-rtl.o generated by r214

Re: [patch] moving macro definitions to defaults.h

On Mon, 22 Sep 2014, David Malcolm wrote: > There appears to be a particular implicit order in which headers must be > included. I notice that e.g. tm.h has: > > #ifndef GCC_TM_H > #define GCC_TM_H > > so if we're going with this "no header file includes any other header > file" model, woul

Re: [patch] moving macro definitions to defaults.h

On Mon, 22 Sep 2014, Andrew MacLeod wrote: > Josephs solution was to identify these and instead put a default definition in > default.h ... then change all the uses to #if instead.. ie, > #if BLAH > > This way we can ensure that the definition has been seen and it will be a > compile error if no

Re: [AArch64] Re: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

On 09/22/14 05:16, Alan Lawrence wrote: Ok thanks Jeff. In that case I think I should draw this to the attention of the AArch64 maintainers to check the testsuite updates are OK before I commit...? Can't hurt. Methinks it may be possible to get further, or at least increase our confidence, if

Re: [patch] moving macro definitions to defaults.h

On Mon, 2014-09-22 at 12:26 -0400, Andrew MacLeod wrote: > After being reminded of the tm.h issues brought up last november (here: > https://gcc.gnu.org/ml/gcc-patches/2013-11/msg01731.html ), I started > looking back into it. > > The general summary is the any header file which has a condition

[patch] Fix specializations of std::uses_allocator in and

Include missing header, and add tests. Tested x86_64-linux, committed to trunk. commit a0ffb1d4d0bf78be525c7546665ef7002b66b13e Author: Jonathan Wakely Date: Mon Sep 22 16:42:51 2014 +0100 Include in and . * include/bits/stl_queue.h: Include missing header. * include/bits

C++ PATCH for variable template diagnostics

This patch fixes two issues with variable templates: 1) -Wunused was warning about a variable template specialization when leaving the template specialization scope, and 2) The diagnostic referring to the specialization wasn't showing the template arguments. Tested x86_64-pc-linux-gnu, applyi

Re: [PATCH 4/5] Generalise invalid_mode_change_p

On 09/22/14 01:34, Richard Sandiford wrote: Jeff Law writes: On 09/18/14 04:25, Richard Sandiford wrote: This is the main patch for the bug. We should treat a register as invalid for a mode change if simplify_subreg_regno cannot provide a new register number for the result. We should treat a

Re: Fix ICE with ODR mering and variable sized types

On 09/22/2014 11:37 AM, Jan Hubicka wrote: Variadic types indeed can not appear in global declarations, so I think it is safe to ignore them. Agreed. Jason

[patch] moving macro definitions to defaults.h

After being reminded of the tm.h issues brought up last november (here: https://gcc.gnu.org/ml/gcc-patches/2013-11/msg01731.html ), I started looking back into it. The general summary is the any header file which has a conditional on a target macro could be affected by include file reorderin

Re: [PATCH] gcc parallel make check

On Mon, Sep 22, 2014 at 12:21:08PM -0400, Jason Merrill wrote: > On 09/22/2014 11:58 AM, Jakub Jelinek wrote: > >LGTM (though, supposedly we want similar change in > >libstdc++-v3/testsuite/Makefile.am). > >Or, if people would really like to see the commands, we could print them > >just once, using

Re: [PATCH] gcc parallel make check

On 09/22/2014 11:58 AM, Jakub Jelinek wrote: LGTM (though, supposedly we want similar change in libstdc++-v3/testsuite/Makefile.am). Or, if people would really like to see the commands, we could print them just once, using e.g. -$(if $(check_p_subno),@)(rootme= ... (then e.g. check-parall

Re: [PATCH] gcc parallel make check

On Mon, Sep 22, 2014 at 05:49:12PM +0200, Jakub Jelinek wrote: > On Mon, Sep 22, 2014 at 10:44:06AM -0500, Segher Boessenkool wrote: > > On Mon, Sep 22, 2014 at 05:26:04PM +0200, Jakub Jelinek wrote: > > > I've been considering that too, but not sure what info people find > > > valuable > > > and

Re: [AArch64] Auto-generate the "BUILTIN_" macros for aarch64-builtins.c

On 22/09/14 14:30, James Greenhalgh wrote: > > On Thu, Sep 18, 2014 at 11:12:15AM +0100, Richard Earnshaw wrote: >> On 18/09/14 10:53, James Greenhalgh wrote: >>> +$(srcdir)/config/aarch64/aarch64-builtin-iterators.h: >>> $(srcdir)/config/aarch64/geniterators.sh \ >>> + $(srcdir)/config/aarch

[jit] Improvements to documentation

Committed to branch dmalcolm/jit As before, an HTML version of the docs can be seen at: https://dmalcolm.fedorapeople.org/gcc/libgccjit-api-docs/index.html with the bulk of the changes occurring to: https://dmalcolm.fedorapeople.org/gcc/libgccjit-api-docs/intro/tutorial03.html gcc/jit/ChangeLo

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

On 09/22/2014 10:46 PM, Michael Eager wrote: > On 09/21/14 20:55, Chen Gang wrote: >> >> >> On 9/22/14 2:03, Michael Eager wrote: >>> On 09/20/14 23:24, Chen Gang wrote: And it seems, we also need 'LinkScr.ld' for ldscript, could you share it to me, thanks. set_board_info ld

Re: [PATCH][AArch64] LR register not used in leaf functions

On 22/09/14 16:43, Kugan wrote: AArch64 has the same issue ARM had where the LR register was not used in leaf functions. This was reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42017. In AArch64, this test-case need to be added with more live ranges for the need for the LR_REGNUM. i.e

Re: [PATCH] gcc parallel make check

On Mon, Sep 22, 2014 at 11:43:35AM -0400, Jason Merrill wrote: > On 09/22/2014 11:26 AM, Jakub Jelinek wrote: > >On Mon, Sep 22, 2014 at 11:21:14AM -0400, Jason Merrill wrote: > >>If I say 'rgt dg.exp=var-templ1.C' the actual test results are lost in the > >>explosion of shell verbosity. Could we

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

On 09/22/2014 10:45 PM, Michael Eager wrote: > On 09/21/14 21:10, Chen Gang wrote: >> On 9/22/14 2:09, Michael Eager wrote: >>> >>> Generally, you should use "gcc" to link programs, not "ld". gcc is >>> a driver which will select the appropriate libraries and support routines >>> (such as crt0.o,

Re: Speedup int_bit_from_pos

> On Sun, 21 Sep 2014, Jan Hubicka wrote: > > > > > > > Please omit static from inline functions. > > > > Yep, I suppose we want to drop static in all inlines? I can make patch for > > that. > > > > > > Also one notable difference with your patches is that the fits hwi is now > > > not tested

Re: [PATCH] gcc parallel make check

On Mon, Sep 22, 2014 at 10:44:06AM -0500, Segher Boessenkool wrote: > On Mon, Sep 22, 2014 at 05:26:04PM +0200, Jakub Jelinek wrote: > > I've been considering that too, but not sure what info people find valuable > > and what they don't. > > The ten million "Running blablablalba.exp ..." messages

[PATCH][AArch64] LR register not used in leaf functions

AArch64 has the same issue ARM had where the LR register was not used in leaf functions. This was reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42017. In AArch64, this test-case need to be added with more live ranges for the need for the LR_REGNUM. i.e test-case in the PR needs additiona

Re: [PATCH] msp430: inhibit automatic link of -lnosys in absence of -msim

Hi Peter, > gcc/ChangeLog > 2014-09-22 Peter A. Bigot > >* config/msp430/msp430.h: Remove automatic -lnosys when -msim absent. Approved and applied. Cheers Nick

Re: [PATCH] gcc parallel make check

On Mon, Sep 22, 2014 at 05:26:04PM +0200, Jakub Jelinek wrote: > I've been considering that too, but not sure what info people find valuable > and what they don't. The ten million "Running blablablalba.exp ..." messages on a very parallel run aren't helpful in my opinion. There might be more but

Re: [debug-early] Allow checking of DECL_ABSTRACT in decl_ultimate_origin

On 09/22/14 08:17, Michael Matz wrote: Hi, On Fri, 19 Sep 2014, Aldy Hernandez wrote: Michael, I really don't understand the need for this change in your original patch. I don't know if this was a temporary testing change or what. I'm pretty sure it was temporary testing, when I still was f

Re: [PATCH] gcc parallel make check

On 09/22/2014 11:26 AM, Jakub Jelinek wrote: On Mon, Sep 22, 2014 at 11:21:14AM -0400, Jason Merrill wrote: If I say 'rgt dg.exp=var-templ1.C' the actual test results are lost in the explosion of shell verbosity. Could we add some '@'s to more of the rules, perhaps? I've been considering that

Re: [PATCH, i386, Pointer Bounds Checker 2/x] Intel Memory Protection Extensions (MPX) instructions support

On 17 Sep 12:17, Ilya Enkovich wrote: > On 19 May 11:23, Jeff Law wrote: > > On 05/19/14 02:19, Ilya Enkovich wrote: > > >On 16 May 13:39, Jeff Law wrote: > > >>On 04/16/14 05:35, Ilya Enkovich wrote: > > >>>Hi, > > >>> > > >>>This patch introduces Intel MPX bound registers and instructions. It >

Re: Fix ICE with ODR mering and variable sized types

> On Fri, Sep 19, 2014 at 8:55 PM, Jan Hubicka wrote: > > Hi, > > this patch fixes ICE by avoiding mangling of types with variadic size > > (those are > > not really supported). Bootstrapped/regtested x86_64-linux, tested with > > libreoffice, > > comitted. > > Hmm, but how do global vars end

Re: [PATCH, i386, Pointer Bounds Checker 34/x] Vararg functions support

On 21 Sep 18:08, Uros Bizjak wrote: > Hello! > > > This patch introduces initialization of incoming bounds for vararg function > > on i386 target. > > > > Bootstrapped and tested on linux-x86_64. > > > > Thanks, > > Ilya > > -- > > gcc/ > > > > 2014-06-11 Ilya Enkovich > > > > * config

Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

On 19 Sep 18:21, Uros Bizjak wrote: > On Fri, Sep 19, 2014 at 2:53 PM, Ilya Enkovich wrote: > > >> > This patch adds i386 target hooks for Pointer Bounds Checker. > > > New version with fixes and better documentation for ix86_load_bounds and > > ix86_store_bounds is below. > > > +/* Expand pas

Re: [PATCH] gcc parallel make check

On Mon, Sep 22, 2014 at 11:21:14AM -0400, Jason Merrill wrote: > On 09/12/2014 08:04 PM, Jakub Jelinek wrote: > >I've been worried about the quick cases where > >parallelization is not beneficial, like make check-gcc \ > >RUNTESTFLAGS=dg.exp=pr60123.c or similar, but one doesn't usually pass -jN >

[patch] Update C++11 library status docs

This documents some more C++11 features as incomplete and notes that iostreams are movable now. Committed to trunk. commit 8de61687f31c20aec35c02393c4fbb44ddcc0cbb Author: Jonathan Wakely Date: Mon Sep 22 15:57:28 2014 +0100 * doc/xml/manual/status_cxx2011.xml: Update C++11 status.

Re: [PATCH] gcc parallel make check

On 09/12/2014 08:04 PM, Jakub Jelinek wrote: I've been worried about the quick cases where parallelization is not beneficial, like make check-gcc \ RUNTESTFLAGS=dg.exp=pr60123.c or similar, but one doesn't usually pass -jN in that case. I have -jN in my $MAKEFLAGS, so I've been running into thi

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

On Mon, Sep 22, 2014 at 1:36 AM, Nathan Sidwell wrote: > On 09/21/14 18:58, Xinliang David Li wrote: > >>> the intent is that that points to the gcov_info object of the object file >>> containing the live version of the function. I couldn't quite get this >>> to >>> work though -- it involves emi

[patch] Fix std::try_lock behaviour

When I fixed std::try_lock a few years ago I misread the spec, exceptions should not be caught and turned into a return value. Tested x86_64-linux, committed to trunk. commit 5effca670aa009c60e31b639604da4d00f388038 Author: Jonathan Wakely Date: Thu Sep 18 16:15:54 2014 +0100 * include/

[PING] [PATCH] Add direct support for Linux kernel __fentry__ patching

Andi Kleen writes: Ping! > Andi Kleen writes: > > Ping! > >> From: Andi Kleen >> >> The Linux kernel dynamically patches in __fentry__ calls in and >> out at runtime. This allows using function tracing for debugging >> in production kernels without (significant) performance penalty. >> >> For

Re: Move dwarf2 frame tables to read-only section for AIX

On Mon, 22 Sep 2014, Andrew Dixie wrote: > I altered the dwarf2 frame and exception table generation so the > decision on whether to use a read-only or read-write section is an > independent decision from how the frame tables are registered. > I renamed EH_FRAME_IN_DATA_SECTION to EH_FRAME_THROUGH

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

On 09/21/14 20:55, Chen Gang wrote: On 9/22/14 2:03, Michael Eager wrote: On 09/20/14 23:24, Chen Gang wrote: And it seems, we also need 'LinkScr.ld' for ldscript, could you share it to me, thanks. set_board_info ldscript "-T/home/eager/Xilinx/dg/microblaze_0/LinkScr.ld" Hi Chen -- Th

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

On 09/21/14 21:10, Chen Gang wrote: On 9/22/14 2:09, Michael Eager wrote: Generally, you should use "gcc" to link programs, not "ld". gcc is a driver which will select the appropriate libraries and support routines (such as crt0.o, which contains _start) and pass them to the linker. OK, tha

[PATCH IRA] update_equiv_regs fails to set EQUIV reg-note for pseudo with more than one definition

Hi, I find that update_equiv_regs in ira.c sets the wrong EQUIV reg-note for pseudo with more than one definiton in certain situation. Here is a simplified RTL snippet after this function finishs handling: (insn 77 37 78 2 (set (reg:SI 171) (const_int 0 [0])) ticket151.c:33 52 {

Re: [debug-early] Allow checking of DECL_ABSTRACT in decl_ultimate_origin

Hi, On Fri, 19 Sep 2014, Aldy Hernandez wrote: > Michael, I really don't understand the need for this change in your original > patch. I don't know if this was a temporary testing change or what. I'm pretty sure it was temporary testing, when I still was finding my way through dwarf2out limita

Re: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

Hi! On Tue, 27 Aug 2013 21:30:49 +, "Iyer, Balaji V" wrote: > --- /dev/null > +++ gcc/testsuite/c-c++-common/cilk-plus/CK/spawning_arg.c > @@ -0,0 +1,37 @@ > +/* { dg-do run { target { i?86-*-* x86_64-*-* arm*-*-* } } } */ > +/* { dg-options "-fcilkplus" } */ > +/* { dg-options "-lcilkrts"

Re: [PATCH 3/14] Add new optabs for reducing vectors to scalars

On Mon, Sep 22, 2014 at 3:26 PM, Alan Lawrence wrote: > Richard Biener wrote: >> >> >> scalar_reduc_to_vector misses a comment. > > > Ok to reuse the comment in optabs.h in optabs.c also? Sure. >> I wonder if at the end we wouldn't transition all backends and then >> renaming reduc_*_scal_optab

  1   2   >