Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2013 at 09:35:08PM +0200, Jakub Jelinek wrote: > On Wed, Jun 05, 2013 at 09:19:10PM +0200, Jakub Jelinek wrote: > > On Wed, Jun 05, 2013 at 07:57:28PM +0200, Marek Polacek wrote: > > > + tree t, tt; > > > + tree orig = build2 (code, TREE_TYPE (op0), op0, op1); > > > + tree prec =

[PING] Re: [PATCH 0/5] Submission of Altera Nios II port

2013-06-05 Thread Chung-Lin Tang
Pinging the nios2 port. On 13/5/15 1:04 AM, Chung-Lin Tang wrote: > On 2013/4/26 04:35 AM, Joseph S. Myers wrote: >> I should ask the following general standard new-port questions: >> >> * Does the port build cleanly when configured with --enable-werror-always >> and built using a native compiler

Re: [PATCH arm/embedded-4_7-branch]fix fialure of mtune option

2013-06-05 Thread Ye Joey
OK to embedded-4_7-branch. Thanks, Joey On Thu, Jun 6, 2013 at 9:43 AM, Bin Cheng wrote: > Hi, > This patch fixes failure of command "arm-none-eabi-gcc -O2 -mthumb > -mtune=cortex-m4 ..." on arm/embedded-4_7-branch by removing the assertion > in arm_cortex_v7m_branch_cost. > > Is it OK? > > Than

[PATCH arm/embedded-4_7-branch]fix fialure of mtune option

2013-06-05 Thread Bin Cheng
Hi, This patch fixes failure of command "arm-none-eabi-gcc -O2 -mthumb -mtune=cortex-m4 ..." on arm/embedded-4_7-branch by removing the assertion in arm_cortex_v7m_branch_cost. Is it OK? Thanks. 2013-06-06 Bin Cheng * config/arm/arm.c (arm_cortex_v7m_branch_cost): Remove assertion

Re: better gdb support for debugging gcc

2013-06-05 Thread Mike Stump
On Jun 5, 2013, at 10:17 AM, Tom Tromey wrote: > Arguably this should be done in gdb. __FUNCTION__ is a private detail of gcc and a user of another compiler is free to define it in a way differently than gcc, and gdb shouldn't impinge that use... > Could you file a bug for that? I'd rather so

Re: [google/gcc-4_7]Add new validator file for native ppc toolchain

2013-06-05 Thread Carrot Wei
OK for google/gcc-4_7. On Wed, Jun 5, 2013 at 2:45 PM, Jing Yu wrote: > Add new validator manifest xfail file for native powerpc64 toolchain. > Ok for google/gcc-4_7? > > Tested: > ./validate_failures.py > --manifest=powerpc64-grtev3-linux-gnu-native.xfail -- > results="gcc/gcc.sum g++/g++.sum gf

[google/gcc-4_7]Add new validator file for native ppc toolchain

2013-06-05 Thread Jing Yu
Add new validator manifest xfail file for native powerpc64 toolchain. Ok for google/gcc-4_7? Tested: ./validate_failures.py --manifest=powerpc64-grtev3-linux-gnu-native.xfail -- results="gcc/gcc.sum g++/g++.sum gfortran/gfortran.sum" 2013-06-05 * powerpc64-grtev3-linux-gnu-native.xf

Re: [PATCH] ARM: Don't clobber CC reg when it is live after the peephole window

2013-06-05 Thread Meador Inge
Ping. On 05/29/2013 12:15 PM, Meador Inge wrote: > Hi All, > > This patch fixes a bug in one of the ARM peephole2 optimizations. The > peephole2 optimization in question was changed to use the CC-updating > form for all of the instructions produced by the peephole so that the > encoding will be

Re: [PATCH, rs6000] power8 patches, patch #4 (revised), new power8 builtins

2013-06-05 Thread Michael Meissner
On Wed, Jun 05, 2013 at 10:06:08PM +0200, Segher Boessenkool wrote: > >I also wonder whether it would be useful to have 32-bit do the > >vector logical > >ops in gprs as well. At the moment, the patches don't allow it > >(vector types > >must be done in the altivec/vsx registers, an TImode is done

Re: [PATCH, rs6000] power8 patches, patch #4 (revised), new power8 builtins

2013-06-05 Thread Segher Boessenkool
I also wonder whether it would be useful to have 32-bit do the vector logical ops in gprs as well. At the moment, the patches don't allow it (vector types must be done in the altivec/vsx registers, an TImode is done by splitting the operation into 4 separate categories). On the 64-bit side,

Re: [libstdc++-v3][C++14] Implement N3654 - Quoted Strings

2013-06-05 Thread Jonathan Wakely
On 5 June 2013 20:18, Ed Smith-Rowland wrote: > Greetings, > This patch implements quoted string manipulators for C++14. > > 27.7.6 - Quoted manipulators[quoted.manip]. > > The idea is to allow round trip insert and extract of strings with spaces. > > std::stringstream ss; > std::string

Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Joseph S. Myers
On Wed, 5 Jun 2013, Jakub Jelinek wrote: > On Wed, Jun 05, 2013 at 11:44:07AM -0700, Andrew Pinski wrote: > > On Wed, Jun 5, 2013 at 10:57 AM, Marek Polacek wrote: > > > Comments, please? > > I think it might be better to do handle this while gimplification > > happens rather than while parsing.

Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Joseph S. Myers
On Wed, 5 Jun 2013, Marek Polacek wrote: > It works by creating a COMPOUND_EXPR around original expression, so e.g. > it creates: > > if (b < 0 || (b > 31 || a < 0)) > { > __builtin___ubsan_handle_shift_out_of_bounds (); > } > else > { > 0 > }, a << b; > > from original "a <<= b;

Re: [PATCH] pr57457

2013-06-05 Thread Jeff Law
On 06/05/13 09:18, Iyer, Balaji V wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Tuesday, June 04, 2013 11:49 PM To: Iyer, Balaji V Cc: gcc-patches@gcc.gnu.org; Steve Ellcey Subject: Re: [PATCH] pr57457 On 06/04/13 12:58, Iyer, Balaji V wrote: Actually, you

Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Andrew Pinski
On Wed, Jun 5, 2013 at 12:23 PM, Jakub Jelinek wrote: > On Wed, Jun 05, 2013 at 11:44:07AM -0700, Andrew Pinski wrote: >> On Wed, Jun 5, 2013 at 10:57 AM, Marek Polacek wrote: >> > Comments, please? >> I think it might be better to do handle this while gimplification >> happens rather than while

Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2013 at 09:19:10PM +0200, Jakub Jelinek wrote: > On Wed, Jun 05, 2013 at 07:57:28PM +0200, Marek Polacek wrote: > > + tree t, tt; > > + tree orig = build2 (code, TREE_TYPE (op0), op0, op1); > > + tree prec = build_int_cst (TREE_TYPE (op0), > > +TYPE_PRECIS

Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2013 at 11:44:07AM -0700, Andrew Pinski wrote: > On Wed, Jun 5, 2013 at 10:57 AM, Marek Polacek wrote: > > Comments, please? > I think it might be better to do handle this while gimplification > happens rather than while parsing. The main reason is that constexpr > might fail due

[libstdc++-v3][C++14] Implement N3654 - Quoted Strings

2013-06-05 Thread Ed Smith-Rowland
Greetings, This patch implements quoted string manipulators for C++14. 27.7.6 - Quoted manipulators[quoted.manip]. The idea is to allow round trip insert and extract of strings with spaces. std::stringstream ss; std::string original = "thing1 thing1"; std::string round_trip; ss

Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2013 at 07:57:28PM +0200, Marek Polacek wrote: > There is of course a lot of stuff that needs to be done, more > specifically: > 0) fix an ICE which I've noticed right now ;( > long a = 1; > int b = 3; > a <<= b; > (error: mismatching comparison opera

Re: [RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Andrew Pinski
On Wed, Jun 5, 2013 at 10:57 AM, Marek Polacek wrote: > Hi! > > This is an attempt to add the Undefined Behavior Sanitizer to GCC. > Note that it's very alpha version; so far it doesn't do that much, > at the moment it should handle division by zero cases, INT_MIN / -1, > and various shift cases (

Re: [patch] Fix parsing bug in validate_patches.py

2013-06-05 Thread Brooks Moses
On 06/04/2013 03:57 PM, Diego Novillo wrote: OK with this predicate factored into a predicate function (maybe SummaryLineHasAttributes?) Thanks! Once I dove into that, I ended up doing a bit more refactoring; it really makes sense to pull the whole line-splitting into a separate function alo

Re: [patch] gcov intermediate format

2013-06-05 Thread Sharad Singhai
Ping. Thanks, Sharad On Tue, May 28, 2013 at 11:35 AM, Sharad Singhai wrote: > Sorry, my patch had bad formatting in one of the functions > (output_gcov_file). Here is the corrected version. > > Thanks, > Sharad > > (2013-05-28 > > * gcov.c (print_usage): Handle new option. > (process_args)

[RFC] Implement Undefined Behavior Sanitizer

2013-06-05 Thread Marek Polacek
Hi! This is an attempt to add the Undefined Behavior Sanitizer to GCC. Note that it's very alpha version; so far it doesn't do that much, at the moment it should handle division by zero cases, INT_MIN / -1, and various shift cases (shifting by a negative value, shifting when second operand is >= t

Re: RFA: fix libstdc++ pretty-printer test

2013-06-05 Thread Jonathan Wakely
On 5 June 2013 17:59, Tom Tromey wrote: > The pretty-printer test "shared_ptr.cc" fails for me on x86-64 Fedora 18. > The local variable "esp" is optimized out. > > Since the purpose of this test is to test the pretty-printers, it seemed > simplest to me to just disable optimizations. The appended

Re: [PATCH, rs6000] power8 patches, patch #4 (revised), new power8 builtins

2013-06-05 Thread David Edelsohn
On Wed, Jun 5, 2013 at 12:13 PM, Michael Meissner wrote: > I thought I had deleted VSX_M2 from this patch. It will be needed in patch #8 > for the fusion peephole. The difference is VSX_L2 avoids TImode altogether, > and was used by the logical ops to prevent TImode operations in VSX registers

Re: better gdb support for debugging gcc

2013-06-05 Thread Tom Tromey
> "Mike" == Mike Stump writes: Mike> Here is a little one to add support for __FUNCTION__ to gdb so that we Mike> can debug gcc… Arguably this should be done in gdb. Could you file a bug for that? Tom

Re: [C++ Patch] PR 51908

2013-06-05 Thread Jason Merrill
On 06/05/2013 11:45 AM, Paolo Carlini wrote: Now, something else I noticed a few days ago is that for C-style casts things work fine in any case: the difference being that in that case we set parser->in_type_id_in_expr_p to true, something we don't do for static_cast (and the other C++ casts) in

RFA: fix libstdc++ pretty-printer test

2013-06-05 Thread Tom Tromey
The pretty-printer test "shared_ptr.cc" fails for me on x86-64 Fedora 18. The local variable "esp" is optimized out. Since the purpose of this test is to test the pretty-printers, it seemed simplest to me to just disable optimizations. The appended fixes the problem for me. Ok? Tom 2013-06-05

[PATCH][ARM][4/n] Partial IT block deprecation in ARMv8 AArch32 - load/store multiple patterns

2013-06-05 Thread Kyrylo Tkachov
Hi all, ARMv8-style IT blocks don't allow load/store multiple instructions (ldm, stm), so this patch disables the predicable forms of the corresponding patterns. The ldm/stm patterns are generated through an Ocaml script, which is updated to reflect the new rules. The ldmstm.md file is regenerated

Re: [PATCH] Improve folding of bitwise ops on booleans

2013-06-05 Thread Kai Tietz
2013/6/4 Jeff Law : > On 06/03/2013 08:23 AM, Kai Tietz wrote: >> >> >> Btw there is one optimization in this context which might be something >> worth here too. >> -X -> X for 1-bit typed X (signed doesn't matter here). > > I've had a hell of a time trying to trigger a case where this isn't alread

[PATCH][ARM][3/n] Partial IT block deprecation in ARMv8 AArch32 - atomics patterns

2013-06-05 Thread Kyrylo Tkachov
Hi all, This patch restricts predication for the various atomics patterns in sync.md by using the new predicable_short_it mechanism. The load/store exclusive and the acquire/release instructions cannot be contained inside IT blocks in ARMv8 so the logic behind disabling their predicable versions f

better gdb support for debugging gcc

2013-06-05 Thread Mike Stump
Here is a little one to add support for __FUNCTION__ to gdb so that we can debug gcc… Committed revision 199702. 2013-06-05 Mike Stump * gdbinit.in (__FUNCTION__): Add. Index: gdbinit.in === --- gdbinit.in (revision 1

Re: [2/n] Partial IT block deprecation in ARMv8 AArch32 - define_cond_exec machinery

2013-06-05 Thread Richard Earnshaw
On 05/06/13 15:41, Kyrylo Tkachov wrote: Hi all, This patch adds the attributes to arm.md that are used to control the conditions under which we can predicate an insn. We use the new attributes field for define_cond_exec that was defined in a recent patch. Whenever an insn is predicated through

Re: [PATCH, rs6000] power8 patches, patch #4 (revised), new power8 builtins

2013-06-05 Thread Michael Meissner
On Wed, Jun 05, 2013 at 10:28:02AM -0400, David Edelsohn wrote: > +;; The canonical form is to have the negated elment first, so we need to > +;; reverse arguments. > > Please fix the typo in the comment: "element". Ok. I need to proof-read the patches before sending them out. > +;; Like VSX_L,

Re: [GOOGLE] More strict checking for call args

2013-06-05 Thread Xinliang David Li
Right, except that in the context of FDO/autoFDO, where this happens the most (note in FDO case, it can happen with fresh profile too for multi-threaded programs), it is not that important to handle -- the mismatch path will never be executed, so why bother to inline and bloat the code for it? if

Re: [PATCH, rs6000] power8 patches, patch #4 (revised), new power8 builtins

2013-06-05 Thread Michael Meissner
On Wed, Jun 05, 2013 at 05:50:21PM +0200, Segher Boessenkool wrote: > >* config/rs6000/rs6000.md (eqv3): Add support for powerp eqv > >instruction. > > [Typo, "powerp". There are many more typos and non-grammatical > sentences.] > > >Why isn't this covered by boolean_operator and %q output opera

Re: [PATCH, rs6000] power8 patches, patch #4 (revised), new power8 builtins

2013-06-05 Thread Segher Boessenkool
* config/rs6000/rs6000.md (eqv3): Add support for powerp eqv instruction. [Typo, "powerp". There are many more typos and non-grammatical sentences.] Why isn't this covered by boolean_operator and %q output operand? The existing patterns (boolc3_...) do for eqv: (set reg (xor (not

Re: Symtab cleanups 4/17

2013-06-05 Thread Jan Hubicka
> Honza, > > Also, you did not remove the declaration of mark_decl_referenced() in tree.h Sorry for the breakage. It was change in final version of patch where I noticed that mark_decl_referenced is dead and I did not get into idea that targets may use it. Looking at the use cases, I think it ma

Re: [C++ Patch] PR 51908

2013-06-05 Thread Paolo Carlini
Hi, On 06/05/2013 04:19 PM, Jason Merrill wrote: On 06/05/2013 09:19 AM, Jason Merrill wrote: In any case, the commit doesn't seem like the problem. Oh, I see, of course it is. The problem is that it commits to all levels, so that if we happen to be in a nested tentative parse we can't com

Re: [PATCH] Change uint*_type_node definition to make_or_reuse_type

2013-06-05 Thread Joseph S. Myers
On Wed, 5 Jun 2013, Andreas Krebbel wrote: > 2013-06-05 Andreas Krebbel > > * tree.c (build_common_tree_nodes): Create uint*_t type nodes with > make_or_reuse_type. I don't think either version is really what's wanted. Ideally these should match stdint.h, and sometimes you may e

Re: Symtab cleanups 4/17

2013-06-05 Thread David Edelsohn
Honza, Also, you did not remove the declaration of mark_decl_referenced() in tree.h - David On Wed, Jun 5, 2013 at 11:15 AM, David Edelsohn wrote: > The removal of mark_decl_referenced() breaks bootstrap because some > target-specific code uses that function. > > I am trying with a change to D

RE: [PATCH] pr57457

2013-06-05 Thread Iyer, Balaji V
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Tuesday, June 04, 2013 11:49 PM > To: Iyer, Balaji V > Cc: gcc-patches@gcc.gnu.org; Steve Ellcey > Subject: Re: [PATCH] pr57457 > > On 06/04/13 12:58, Iyer, Balaji V wrote: > > > > > > Actually, you can eliminate the

Re: Symtab cleanups 4/17

2013-06-05 Thread David Edelsohn
The removal of mark_decl_referenced() breaks bootstrap because some target-specific code uses that function. I am trying with a change to DECL_PRESERVE_P to see if that will fix the problem in rs6000.c - David

[2/n] Partial IT block deprecation in ARMv8 AArch32 - define_cond_exec machinery

2013-06-05 Thread Kyrylo Tkachov
Hi all, This patch adds the attributes to arm.md that are used to control the conditions under which we can predicate an insn. We use the new attributes field for define_cond_exec that was defined in a recent patch. Whenever an insn is predicated through define_cond_exec, it has the attribute "pre

Re: [PATCH, rs6000] power8 patches, patch #4 (revised), new power8 builtins

2013-06-05 Thread David Edelsohn
On Tue, Jun 4, 2013 at 2:48 PM, Michael Meissner wrote: > I revised this patch for power8 to add new miscellaneous vector instructions > to > not turn off splitting wide moves. In doing the patch, I discovered that we > never supported the 'eqv' instruction, and I have added support for eqv in t

Re: [C++ Patch] PR 51908

2013-06-05 Thread Jason Merrill
On 06/05/2013 09:19 AM, Jason Merrill wrote: In any case, the commit doesn't seem like the problem. Oh, I see, of course it is. The problem is that it commits to all levels, so that if we happen to be in a nested tentative parse we can't commit to the inner one without committing to the oute

Symtab cleanups 4/17

2013-06-05 Thread Jan Hubicka
Hi, this patch deals with C++ keyed methods and explicit instantiations. Currently C++ calls mark_used that ultimately sets force_output on the functions. This is equivalent to attribute ((used)) on the function/variable and it is bit too strong. For example at LTO time we can ignore the C++ ABI

Re: [PATCH, x86] Use vector moves in memmove expanding

2013-06-05 Thread Michael Zolotukhin
I'll prepare some tests shortly, What about the rest questions? Thanks, Michael On 15 May 2013 19:45, H.J. Lu wrote: > On Wed, May 15, 2013 at 5:47 AM, Michael Zolotukhin > wrote: >> Hi HJ, >>> You use Pmode as the largest integer mode. Is word_mode better >>> than Pmode since word_mode is DI

Re: Fix PR 53743 and other -freorder-blocks-and-partition failures

2013-06-05 Thread Teresa Johnson
On Wed, May 29, 2013 at 7:57 AM, Teresa Johnson wrote: > On Thu, May 23, 2013 at 6:18 AM, Teresa Johnson wrote: >> On Wed, May 22, 2013 at 2:05 PM, Teresa Johnson wrote: >>> Revised patch included below. The spacing of my pasted in patch text >>> looks funky again, let me know if you want the pa

Re: RFA: Switching LRA on for s390

2013-06-05 Thread Andreas Krebbel
On Fri, May 31, 2013 at 02:11:38PM -0400, Vladimir Makarov wrote: > The patch was successfully bootstrapped and tested on s390x. > > Any comments? > Is it ok to commit the patch into trunk? > > Thanks. > > > 2013-05-31 Vladimir Makarov > > * config/s390/s390.opt (mlra): New opti

Re: [C++ Patch] PR 51908

2013-06-05 Thread Paolo Carlini
.. true that my first try didn't fix this non-variadic variant, because we have a declarator and again we hit the commit: struct foo { template operator decltype(static_cast(0)) () const; }; Paolo.

Re: [PATCH RX] Added target specific macros for macros for RX100, RX200, and RX600

2013-06-05 Thread Chung-Ju Wu
2013/6/5 Sandeep Kumar Singh : > Hi Chung-Ju Wu, > > Thanks for your help. Suggested changes has been committed. > > Regards, > Sandeep Kumar Singh, > KPIT Cummins InfoSystems Ltd. > Pune, India > > Oops~ I should have said that my suggested changes still require Gerald's approval. Gerald is web p

Re: [C++ Patch] PR 51908

2013-06-05 Thread Jason Merrill
On 06/05/2013 09:07 AM, Paolo Carlini wrote: Hi, On 06/05/2013 02:53 PM, Jason Merrill wrote: On 06/04/2013 08:34 PM, Paolo Carlini wrote: /* After seeing a decl-specifier-seq, if the next token is not a - "(", there is no possibility that the code is a valid + "(" nor '...', t

Re: [C++ Patch] PR 51908

2013-06-05 Thread Paolo Carlini
Hi, On 06/05/2013 02:53 PM, Jason Merrill wrote: On 06/04/2013 08:34 PM, Paolo Carlini wrote: /* After seeing a decl-specifier-seq, if the next token is not a - "(", there is no possibility that the code is a valid + "(" nor '...', there is no possibility that the code is a vali

RE: [PATCH RX] Added target specific macros for macros for RX100, RX200, and RX600

2013-06-05 Thread Sandeep Kumar Singh
Hi Chung-Ju Wu, Thanks for your help. Suggested changes has been committed. Regards, Sandeep Kumar Singh, KPIT Cummins InfoSystems Ltd. Pune, India > -Original Message- > From: Chung-Ju Wu [mailto:jasonw...@gmail.com] > Sent: Monday, June 03, 2013 8:02 PM > To: Sandeep Kumar Singh > C

Re: [C++ Patch] PR 51908

2013-06-05 Thread Jason Merrill
On 06/04/2013 08:34 PM, Paolo Carlini wrote: /* After seeing a decl-specifier-seq, if the next token is not a - "(", there is no possibility that the code is a valid + "(" nor '...', there is no possibility that the code is a valid expression. Therefore, if parsing tentati

Re: [Patch, Fortran] PR57530 - fix rejects valid with gfc_type_compatible

2013-06-05 Thread Tobias Burnus
Now with attached patch. Tobias Burnus wrote: I accidentally attached a slightly out-dated patch. The old patch permitted CLASS<->TYPE differences in cases where the characteristic had to match (e.g. dummy arguments in a proc-pointer assignment). - Sorry for the confusion. Build and regteste

Re: [Patch, Fortran] PR57530 - fix rejects valid with gfc_type_compatible

2013-06-05 Thread Tobias Burnus
I accidentally attached a slightly out-dated patch. The old patch permitted CLASS<->TYPE differences in cases where the characteristic had to match (e.g. dummy arguments in a proc-pointer assignment). - Sorry for the confusion. Build and regtested on x86-64-gnu-linux. OK for the trunk? Tobias

[PATCH] Change uint*_type_node definition to make_or_reuse_type

2013-06-05 Thread Andreas Krebbel
Hi, I'm trying to implement a builtin with a uint64_t* argument type as build_pointer_type (uint64_type_node). Unfortunately this fails for a simple case like: uint64_t a; __builtin_test (&a); t.c:7:3: warning: passing argument 1 of ‘__builtin_test’ from incompatible pointer type [enabled by d

[Patch, Fortran] PR57530 - fix rejects valid with gfc_type_compatible

2013-06-05 Thread Tobias Burnus
A TYPE is type compatible with a CLASS if both have the same declared type. Or in words of the standard (cf. PR): "A nonpolymorphic entity is type compatible only with entities of the same declared type. A polymorphic entity that is not an unlimited polymorphic entity is type compatible with en

Re: [PATCH] Improve folding of bitwise ops on booleans

2013-06-05 Thread Eric Botcazou
> Eventually we should force all BOOLEAN_TYPEs to have precision 1 but > as Kai remembers Ada uses alternate values for verification (true, false, > NaT or so). Eric may be able to explain. Correct, see: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01214.html A boolean type isn't a modular type o

Re: [testsuite] Adding target nonpic to certain tests part. 2

2013-06-05 Thread Patrick Marlier
Hi Alexander, At least for TM testcase, I would prefer to add 'transaction_safe' attribute on foobar as in the attached patch. Aldy and Richard H: What do you think? Thanks, -- Patrick On Wed, Jun 5, 2013 at 1:13 PM, Alexander Ivchenko wrote: > Hi, > > Another bunch of tests that fails with -fp

[testsuite] Adding target nonpic to certain tests part. 2

2013-06-05 Thread Alexander Ivchenko
Hi, Another bunch of tests that fails with -fpic. from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html "Since -fpic option is turned on by default in Android we have certain test fails. The reason for that is that those tests rely on the availability of functions, defined in them an

Re: [Testsuite] Fix arm triplets in some testcases.

2013-06-05 Thread Richard Earnshaw
On 05/06/13 11:32, James Greenhalgh wrote: Hi, Some ARM triplets are of the form armv7l-unknown-linux-gnueabihf. For these arm-*-* will not match, so fix this with arm*-*-*. Nor will arm*-*-*eabi, so fix this with arm*-*-*eabi*. Tested with a run of the affected tests on an armv7l-unknown-li

[Testsuite] Fix arm triplets in some testcases.

2013-06-05 Thread James Greenhalgh
Hi, Some ARM triplets are of the form armv7l-unknown-linux-gnueabihf. For these arm-*-* will not match, so fix this with arm*-*-*. Nor will arm*-*-*eabi, so fix this with arm*-*-*eabi*. Tested with a run of the affected tests on an armv7l-unknown-linux-gnueabihf target, showing FAIL->PASS. OK

Re: [PATCH][ARM][1/n] Partial IT block deprecation in ARMv8 AArch32

2013-06-05 Thread Richard Earnshaw
On 04/06/13 16:53, Kyrylo Tkachov wrote: Hi Joseph, It creates a command line option, -mrestrict-it, that can be used to Command-line options need documenting in invoke.texi. I've added some documentation in invoke.texi Confirmed that documentation builds ok. Thanks, Kyrill 2013-06-04

Re: [PATCH] tsan.c: mark tsan_atomic_table as constant

2013-06-05 Thread David Malcolm
On Wed, 2013-06-05 at 13:27 +0400, Konstantin Serebryany wrote: > On Wed, Jun 5, 2013 at 6:40 AM, David Malcolm wrote: > > The table of struct tsan_map_atomic within tsan.c is never modified, so > > it can be marked as const. > > > > Successfully bootstrapped on x86_64-unknown-linux-gnu (using > >

Re: [PATCH] Remove unused pass_update_address_taken

2013-06-05 Thread David Malcolm
On Wed, 2013-06-05 at 10:33 +0200, Richard Biener wrote: > On Wed, Jun 5, 2013 at 4:48 AM, David Malcolm wrote: > > If I'm reading things right, pass_update_address_taken is never actually > > used. > > > > Deleting it, I was able to still successfully bootstrap on > > x86_64-unknown-linux-gnu (us

Re: [PATCH] tsan.c: mark tsan_atomic_table as constant

2013-06-05 Thread Konstantin Serebryany
On Wed, Jun 5, 2013 at 6:40 AM, David Malcolm wrote: > The table of struct tsan_map_atomic within tsan.c is never modified, so > it can be marked as const. > > Successfully bootstrapped on x86_64-unknown-linux-gnu (using > gcc-4.7.2-2.fc17.x86_64). > > OK for trunk? Looks good, thanks. --kcc >

Re: [PATCH] Improve folding of bitwise ops on booleans

2013-06-05 Thread Richard Biener
On Tue, Jun 4, 2013 at 9:20 PM, Jeff Law wrote: > On 06/03/2013 08:23 AM, Kai Tietz wrote: >> >> >> Btw there is one optimization in this context which might be something >> worth here too. >> -X -> X for 1-bit typed X (signed doesn't matter here). > > I've had a hell of a time trying to trigger a

Re: [PATCH] Remove unused pass_update_address_taken

2013-06-05 Thread Richard Biener
On Wed, Jun 5, 2013 at 4:48 AM, David Malcolm wrote: > If I'm reading things right, pass_update_address_taken is never actually > used. > > Deleting it, I was able to still successfully bootstrap on > x86_64-unknown-linux-gnu (using gcc-4.7.2-2.fc17.x86_64). > > The use of the pass appears to have

[Fortran, committed] Re: testsuite directive dg-run, again

2013-06-05 Thread Tobias Burnus
Committed as Rev. 199684. Thanks for the patch! Tobias Manfred Schwarb wrote: I reran my script made in January to detect strange dg directives, and indeed, we grew a new one in the mean time: Index: string_length_2.f90 === --- st

Re: [GOOGLE] More strict checking for call args

2013-06-05 Thread Richard Biener
On Wed, Jun 5, 2013 at 2:19 AM, Dehao Chen wrote: > attached is a testcase that would cause problem when source has changed: > > $ g++ test.cc -O2 -fprofile-generate -DOLD > $ ./a.out > $ g++ test.cc -O2 -fprofile-use > test.cc:34:1: internal compiler error: in operator[], at vec.h:815 > } > ^ >

[PATCH] Fix some LTO streaming issues, report the number of merged types

2013-06-05 Thread Richard Biener
This prepares for the LTO type merging re-org by pushing bugfixes I noticed when implementing the rewrite to trunk. It also adds counting of the number of merged types so we can easily compare the results. LTO bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2013-06-05 R

Re: symtab cleanups 3/17: fix alias visibility logic

2013-06-05 Thread Andreas Schwab
Jan Hubicka writes: > * gcc.dg/tree-ssa/attr-alias.c: New testcase. I've removed the duplicated contents. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."