I'll prepare some tests shortly, What about the rest questions? Thanks, Michael
On 15 May 2013 19:45, H.J. Lu <hjl.to...@gmail.com> wrote: > On Wed, May 15, 2013 at 5:47 AM, Michael Zolotukhin > <michael.v.zolotuk...@gmail.com> wrote: >> Hi HJ, >>> You use Pmode as the largest integer mode. Is word_mode better >>> than Pmode since word_mode is DI and Pmode may be SI for x32. >> I updated the patch to use word_mode instead of Pmode. Bootstrap, >> make check and Specs2000 are ok. >> >> Thanks, Michael >> >> On 14 May 2013 19:55, H.J. Lu <hjl.to...@gmail.com> wrote: >>> On Tue, May 14, 2013 at 7:34 AM, Michael Zolotukhin >>> <michael.v.zolotuk...@gmail.com> wrote: >>>> Hi, >>>> I attached an updated version of the patch. Looks like the 64-bit issue is >>>> resolved in it (now a vector mode is explicitly chosen instead of TI- or >>>> another integer mode). Also, some of remarks are fixed in it - some >>>> others are still not changed, because I don't know what to do with them >>>> right >>>> now (see my questions in the previous letter). >>>> >>>> Could you take a look at the patch? >>>> >>>> I checked it on i386/x86_64 bootstrap and make check, and on Specs2000/2006 >>>> (I checked only stability). >>>> >>> >>> You use Pmode as the largest integer mode. Is word_mode better >>> than Pmode since word_mode is DI and Pmode may be SI for x32. >>> >>> > > You should include tests to verify that it works as > expected. > > > -- > H.J. -- --- Best regards, Michael V. Zolotukhin, Software Engineer Intel Corporation.
