Re: [Patch, PR 54128] ira.c change to fix mips bootstrap

2012-09-04 Thread Jakub Jelinek
On Fri, Aug 31, 2012 at 10:58:51AM -0700, Steve Ellcey wrote: > Here is my patch to fix the bootstrap comparision failure (PR 54128) on > MIPS. The reason for the comparision failure was a difference in > register usage and I tracked it down to build_insn_chain which checked > all instructions fo

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Georg-Johann Lay
Joern Rennecke: David Edelsohn: Oleg Endo: Hmm .. the ACK status so far is: Not sure if we are supposed to acknowledge all the straigtforward argument additions... at any rate, the epiphany hunk is OK. I think I'll make use of the new functionality eventually, but prefer to be able to test

Re: [PATCH] PR other/54411: libiberty: objalloc_alloc integer overflows (CVE-2012-3509)

2012-09-04 Thread Ian Lance Taylor
On Wed, Aug 29, 2012 at 10:32 AM, Florian Weimer wrote: > > This patches fixes an integer overflow in libiberty, which leads to > crashes in binutils. The long version of the objalloc_alloc macro > would have needed another conditional, so I removed that and replaced > it with a call to the actua

Re: [PATCH, M68K] Fix ICE from scheduler improvement

2012-09-04 Thread Maxim Kuvyrkov
On 4/09/2012, at 7:57 PM, Andreas Schwab wrote: > Maxim Kuvyrkov writes: > >> 2012-09-03 Maxim Kuvyrkov >> >> * config/m68k/m68k.c (m68k_sched_dfa_post_advance_cycle): Fix ICE >> caused by "save scheduler state" patch. > > The change log entry should describe what was changed. "S

C++ PATCH for c++/54441 (infinite loop on ill-formed designated initializer)

2012-09-04 Thread Jason Merrill
When reshaping the initializer for a class, if we come to a zero-length array member, we don't consume any actual elements. But if an initializer designates that field, that means we keep trying to initialize that field and loop forever. Fixed by checking for a designated initializer that doe

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Hans-Peter Nilsson
On Tue, 4 Sep 2012, Oleg Endo wrote: > On Mon, 2012-09-03 at 01:58 +0200, Oleg Endo wrote: > > OKOK -- I'll do it :) > > (within the next couple of days) > > > > And so I did. Attached is an updated patch that adds the address space > parameter to the address_cost function. I hope that this chan

C++ PATCH for c++/54420 (ICE with class named __lambda)

2012-09-04 Thread Jason Merrill
The name __lambda is reserved to the implementation, so G++ is allowed to reject it, but there's really no reason we need to treat it as special. Tested x86_64-pc-linux-gnu, applying to trunk. commit b02a71634ea7c193f0791f14500b74fcda98b85d Author: Jason Merrill Date: Tue Sep 4 17:58:05 2012

Re: [patch, mips] New mips triplet for multilib linux builds

2012-09-04 Thread Richard Sandiford
"Steve Ellcey " writes: > --- a/gcc/config/mips/mips.h > +++ b/gcc/config/mips/mips.h > @@ -748,6 +748,9 @@ struct mips_cpu_info { > specified. > --with-divide is ignored if -mdivide-traps or -mdivide-breaks are > specified. */ > +#ifndef SYNCI_SPEC > +#define SYNCI_SPEC "-m%(VALUE

Re: [PATCH] rs6000: Add a builtin to read the time base register on PowerPC

2012-09-04 Thread Segher Boessenkool
For things that do mftb with high frequency, maybe you should also add a builtin that does just an mftb, i.e. returns a 32-bit result on 32-bit implementations. Are you thinking in a function that returns only the TBL? On 32-bit, just TBL; on 64-bit, the whole TB (there is no machine instr

Re: [PATCH] Reduce memory usage for storing LTO decl resolutions

2012-09-04 Thread Steven Bosscher
On Tue, Sep 4, 2012 at 6:43 PM, Andi Kleen wrote: > +/* Compact representation of a index <-> resolution pair. Unpacked to an > + vector later. */ > +struct res_pair > +{ > + ld_plugin_symbol_resolution_t res; > + unsigned index; > +}; > +typedef struct res_pair res_pair; > + > +DEF_VEC_P(res_

Re: Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-04 Thread Richard Sandiford
"Bin Cheng" writes: >> Hi, >> For thumb1, arm-gcc rewrites move insn into subtract of ZERO in peephole2 > pass >> intentionally, then executes >> pass_if_after_reload/pass_regrename/pass_cprop_hardreg sequentially. >> >> In this scenario, copy propagation opportunities are missed because: >> 1.

Re: Fix bootstrap failure with clang++ (PR 54484)

2012-09-04 Thread Diego Novillo
On 2012-09-04 17:10 , Steven Bosscher wrote: On Tue, Sep 4, 2012 at 11:07 PM, Diego Novillo wrote: Fix bootstrap failure with clang++. This patch fixes a bootstrap failure when using clang as the host compiler. Default arguments for class template member functions should be added in the decla

Re: [patch,libgcc] fp-bit.c: filter-out LIB2FUNCS_EXCLUDE

2012-09-04 Thread Ian Lance Taylor
On Mon, Sep 3, 2012 at 8:30 AM, Georg-Johann Lay wrote: > > * Makefile.in (FPBIT_FUNCS): filter-out LIB2FUNCS_EXCLUDE. > (DPBIT_FUNCS): Ditto. > (TPBIT_FUNCS): Ditto. This is OK. Thanks. Ian

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-04 Thread Teresa Johnson
I just committed the patch (included below). I implemented the occupancy bit vector approach for recording non-zero histogram entries, and a few issues uncovered with the merging in a profiled bootstrap. Passes both bootstrap and profiledbootstrap builds and regression tests. Thanks, Teresa Enha

[patch, mips] New mips triplet for multilib linux builds

2012-09-04 Thread Steve Ellcey
I would like to create a new mips target triplet (mips-mti-linux-gnu). This target would be multilib by default and would have --enable-synci on by default. It would mainly be used for building mips cross compilers with glibc. I hope to extend this target to support the n32 and 64 bit ABIs in the

Re: Fix bootstrap failure with clang++ (PR 54484)

2012-09-04 Thread Diego Novillo
On 2012-09-04 17:10 , Steven Bosscher wrote: On Tue, Sep 4, 2012 at 11:07 PM, Diego Novillo wrote: Fix bootstrap failure with clang++. This patch fixes a bootstrap failure when using clang as the host compiler. Default arguments for class template member functions should be added in the decla

Re: Fix bootstrap failure with clang++ (PR 54484)

2012-09-04 Thread Steven Bosscher
On Tue, Sep 4, 2012 at 11:07 PM, Diego Novillo wrote: > Fix bootstrap failure with clang++. > > This patch fixes a bootstrap failure when using clang as the host > compiler. Default arguments for class template member functions > should be added in the declaration, not the definition. > > From Ja

Fix bootstrap failure with clang++ (PR 54484)

2012-09-04 Thread Diego Novillo
Fix bootstrap failure with clang++. This patch fixes a bootstrap failure when using clang as the host compiler. Default arguments for class template member functions should be added in the declaration, not the definition. >From Jason: > 8.3.6 says "Default arguments for a member function of a c

Re: [google/integration] Add a configure option to disable system header canonicalizations (issue6489063)

2012-09-04 Thread Ollie Wild
On Fri, Aug 31, 2012 at 10:30 AM, Simon Baldwin wrote: > > Yes. I meant --disable-canonical-prefixes. That is a gcc configure > flag that we use to control the default setting for > -[no-]canonical-prefixes where neither flag is supplied on the gcc > command line. --disable/enable-canonical-pre

Re: [PATCH] Combine location with block using block_locations

2012-09-04 Thread Dehao Chen
ping... Thanks, Dehao On Tue, Aug 21, 2012 at 4:54 PM, Dehao Chen wrote: > On Tue, Aug 21, 2012 at 6:25 AM, Richard Guenther > wrote: >> On Mon, Aug 20, 2012 at 3:18 AM, Dehao Chen wrote: >>> ping >> >> Conceptually I like the change. Can a libcpp maintainer please have a 2nd >> look? >>

Re: [PATCH][RFC] Add -Og

2012-09-04 Thread Hans-Peter Nilsson
On Mon, 3 Sep 2012, Richard Guenther wrote: > On Fri, Aug 10, 2012 at 1:30 PM, Richard Guenther wrote: > > > > This adds a new optimization level, -Og, as previously discussed. > > It aims at providing fast compilation, a superior debugging > > experience and reasonable runtime performance. Inste

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Dehao Chen
On Tue, Sep 4, 2012 at 9:22 AM, Andrew Haley wrote: > On 09/04/2012 05:07 PM, Dehao Chen wrote: >> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >>> On 08/30/2012 08:20 AM, Andrew Haley wrote: Is the problem simply that the logic to scan the assembly code isn't present in th

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Dehao Chen
Looks like even with addr2line properly installed, the gcj generated code cannot get the correct source file/lineno. Do I need to pass in anything to gcj to let it know where addr2line is? Thanks, Dehao #javac stacktrace.java #java stacktrace stacktrace.e(stacktrace.java:42) stacktrace.d(stacktra

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Joern Rennecke
Quoting David Edelsohn : On Tue, Sep 4, 2012 at 2:57 PM, Oleg Endo wrote: Hmm .. the ACK status so far is: Not sure if we are supposed to acknowledge all the straigtforward argument additions... at any rate, the epiphany hunk is OK. I think I'll make use of the new functionality eventually

Re: [PATCH] rs6000: Add a builtin to read the time base register on PowerPC

2012-09-04 Thread David Edelsohn
On Wed, Aug 29, 2012 at 3:09 PM, Segher Boessenkool wrote: >>> For things that do mftb with high frequency, maybe you should also add a >>> builtin that does just an mftb, i.e. returns a 32-bit result on 32-bit >>> implementations. >> >> Are you thinking in a function that returns only the TBL? >

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread David Edelsohn
On Tue, Sep 4, 2012 at 2:57 PM, Oleg Endo wrote: > Hmm .. the ACK status so far is: > > [x] target-independent bits > [ ] alpha [x] arm [ ] avr [ ] bfin > [ ] cr16 [ ] cris [ ] epiphany[ ] i386 > [ ] ia64 [x] iq2000[ ] lm32[ ] m32c > [x] m32r

C++ PATCH for c++/54198

2012-09-04 Thread Jason Merrill
My patch to change check_default_argument to call perform_implicit_conversion_flags in order to get the diagnostics we want there had the undesired side-effect of causing the instantiation of templates that would be used by that conversion, even though the conversion isn't really used. So this

[PATCH, libstdc++] Add proper OpenBSD support

2012-09-04 Thread Mark Kettenis
Fixes a few testcases. Mostly based on the existing NetBSD/FreeBSD/Darwin code. 2012-09-04 Mark Kettenis * configure.host (*-*-openbsd*) Set cpu_include_dir. * config/os/bsd/openbsd/ctype_base.h: New file. * config/os/bsd/openbsd/ctype_configure_char.cc: New file.

Minor reorganization in bb-reorder.c

2012-09-04 Thread Eric Botcazou
The file contains 3 RTL optimization passes, the gate and worker functions of which are strangely intertwined. Fixed thusly, tested on x86_64-suse-linux, applied on the mainline. 2012-09-04 Eric Botcazou * bb-reorder.c (gate_handle_reorder_blocks): Move around. (rest_of_hand

RE: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [] > Sent: Tuesday, September 04, 2012 1:03 PM > To: Weddington, Eric > Cc: Gabriel Dos Reis; Richard Guenther; gcc-patches@gcc.gnu.org; Denis > Chertykov; Joerg Wunsch > Subject: Re: [Patch,avr] PR54461: Better AVR-Libc integration > > > I wo

Fix PR rtl-optimization/54456

2012-09-04 Thread Eric Botcazou
This patch "fixes" PR rtl-optimization/54456 by running the first scheduling pass only when optimizing, as is already done for the second scheduling pass. Tested on x86_64-suse-linux, applied on the mainline. 2012-09-04 Eric Botcazou PR rtl-optimization/54456 * sched-rgn.c (

Re: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Georg-Johann Lay
Weddington, Eric wrote: > >> From: Georg-Johann Lay >> >> So here is an updated version of the patch. >> Instead of "with_avrlibc = yes" it does "with_avrlibc != no". >> >> Just like the first version, --with-avrlibc[=*] is only recognized >> if avr-gcc is not configured for RTEMS, i.e. RTEMS user

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Oleg Endo
On Tue, 2012-09-04 at 12:02 -0300, Alexandre Oliva wrote: > > Index: gcc/config/mn10300/mn10300.c > > > - total = mn10300_address_cost (XEXP (x, 0), speed); > > + total = mn10300_address_cost (XEXP (x, 0), GET_MODE (x), > > + ADDR_SPACE_GENERIC, speed); >

C++ PATCH for c++/54437 (firefox build failure)

2012-09-04 Thread Jason Merrill
Here, the problem was that we were resolving the address of an overloaded function in the context of the template being called (which doesn't have access to the function) rather than the caller (which does). We need to massage explicit template arguments before we enter the callee's context.

[PATCH] Further OpenBSD/amd64 and OpenBSD/i386 improvements

2012-09-04 Thread Mark Kettenis
Here are some additional fixes for OpenBSD that fix a fair number of failing testcases. I can split this up in smaller patches if that's preferred. I believe I submitted the openbsd-stdint.h bit before. We consistenly use "long long" types for the *max_t types, on both 32-bit and 64-bit platform

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Richard Sandiford
Oleg Endo writes: > On Mon, 2012-09-03 at 01:58 +0200, Oleg Endo wrote: >> OKOK -- I'll do it :) >> (within the next couple of days) >> > > And so I did. Attached is an updated patch that adds the address space > parameter to the address_cost function. I hope that this change does > not reset t

PATCH to configure.ac to fix --enable-languages=all

2012-09-04 Thread Jason Merrill
I configure GCC with --enable-languages=all,obj-c++ for testing, and this started breaking recently, because I ended up with 'c' twice in the list of languages, so reconfiguring breaks. This seems to be because r189080 didn't adjust the "all" case along with the language name case. Tested x86

Fix PR 54478 - Work around g++ 4.3 parsing bug

2012-09-04 Thread Diego Novillo
This patch works around a parsing problem with g++ 4.3. The parser is failing to lookup calls to the template function reserve when called from other member functions: vec_t::reserve (...) The parser thinks that the '<' in reserve is a less-than operation. This problem does not happen after 4.3.

Re: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Gabriel Dos Reis
On Tue, Sep 4, 2012 at 1:00 PM, Georg-Johann Lay wrote: > Weddington, Eric wrote: >> > Can you explain this? A typical build of avr tools goes like > > 1) configure, build and install binutils > 2) configure, build and install the compiler > 3) configure, build and install AVR

RE: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [] > Sent: Tuesday, September 04, 2012 12:00 PM > To: Weddington, Eric > Cc: Gabriel Dos Reis; Richard Guenther; gcc-patches@gcc.gnu.org; Denis > Chertykov; Joerg Wunsch > Subject: Re: [Patch,avr] PR54461: Better AVR-Libc integration > > So h

Re: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Georg-Johann Lay
Weddington, Eric wrote: > Can you explain this? A typical build of avr tools goes like 1) configure, build and install binutils 2) configure, build and install the compiler 3) configure, build and install AVR-Libc so that in step 2 no checking is possible becaus

[RFC] PowerPC / rs6000 call glue removal

2012-09-04 Thread David Edelsohn
Segher and I are planning to remove the machinery supporting RS6000_CALL_GLUE. In the AIX ABI, used by AIX, PowerOpen, PPC64 Linux and mcall-aixdesc, direct calls to named functions that may be external are followed by a special no-op instruction that the linker can replace with an instruction to

Re: [PATCH][RFC] Fixing instability of -fschedule-insns for x86

2012-09-04 Thread Uros Bizjak
On Mon, Aug 13, 2012 at 9:39 PM, Igor Zamyatin wrote: > Main idea of this activity is mostly to provide user a possibility to > safely turn on first scheduler for his codes. In some cases this could > positively affect performance, especially for in-order Atom. > > It would be great to hear some

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Andrew Haley
On 09/04/2012 06:17 PM, Bryce McKinlay wrote: > On Tue, Sep 4, 2012 at 6:12 PM, Andrew Haley wrote: > >>> He's also planning to use it for libgo, and other gcc runtime libs >>> have indicated interest. It doesn't have to work on all platforms, and >>> I can't see how it would be any less portable

re: [google/gcc-4_7] Fix GDB test suite regression with -fdebug-types-section patch

2012-09-04 Thread Sterling Augustine
On Sat, Sep 1, 2012 at 1:44 PM, wrote: > From: ccout...@google.com (Cary Coutant) > To: d...@google.com, gcc-patches@gcc.gnu.org > Cc: > Date: Fri, 31 Aug 2012 16:55:40 -0700 (PDT) > Subject: [google/gcc-4_7] Fix GDB test suite regression with > -fdebug-types-section patch > This patch is for th

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Bryce McKinlay
On Tue, Sep 4, 2012 at 6:12 PM, Andrew Haley wrote: >> He's also planning to use it for libgo, and other gcc runtime libs >> have indicated interest. It doesn't have to work on all platforms, and >> I can't see how it would be any less portable than addr2line! > > I certainly can. Maybe once it'

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Andrew Haley
On 09/04/2012 06:08 PM, Bryce McKinlay wrote: > On Tue, Sep 4, 2012 at 5:39 PM, Andrew Haley wrote: >> On 09/04/2012 05:32 PM, Bryce McKinlay wrote: >>> On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: > On 08/30/2012 08:20 AM,

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Bryce McKinlay
On Tue, Sep 4, 2012 at 5:39 PM, Andrew Haley wrote: > On 09/04/2012 05:32 PM, Bryce McKinlay wrote: >> On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: >>> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: On 08/30/2012 08:20 AM, Andrew Haley wrote: > Is the problem simply that

Re: [Ping]RE: [Patch, test] Enable to prune warnings for tests defined in one exp file

2012-09-04 Thread Mike Stump
On Sep 3, 2012, at 11:05 PM, Terry Guo wrote: > Is it ok to document this feature in README.gcc? Sure. I was almost hoping someone had a pointer to a wiki page that had new bits... > Is it ok to back port this feature to 4.7 branch? Ok.

[PATCH] Reduce memory usage for storing LTO decl resolutions

2012-09-04 Thread Andi Kleen
From: Andi Kleen With a LTO build of a large project (>11k subfiles incrementially linked) storing the LTO resolutions took over 0.5GB memory: lto/lto.c:1087 (lto_resolution_read) 0: 0.0% 540398500 15903: 0.0% The reason is that the declaration indexes are quite

[PATCH] Clarify gcc-{ar,nm,ranlib} usage in the documentation

2012-09-04 Thread Andi Kleen
From: Andi Kleen Make it clear in the documentation that with -fno-fat-lto-objects the gcc-* wrappers should be used to pass the linker plugin. gcc/: 2012-09-04 Andi Kleen * doc/invoke.texi (-ffat-lto-objects): Clarify that gcc-ar et.al. should be used. --- gcc/doc/invoke.te

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Andrew Haley
On 09/04/2012 05:32 PM, Bryce McKinlay wrote: > On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: >> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >>> On 08/30/2012 08:20 AM, Andrew Haley wrote: Is the problem simply that the logic to scan the assembly code isn't present in

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Bryce McKinlay
On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: > On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >> On 08/30/2012 08:20 AM, Andrew Haley wrote: >>> Is the problem simply that the logic to >>> scan the assembly code isn't present in the libgcj testsuite? >> >> Yes, exactly. > > For th

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Andrew Haley
On 09/04/2012 05:07 PM, Dehao Chen wrote: > On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >> On 08/30/2012 08:20 AM, Andrew Haley wrote: >>> Is the problem simply that the logic to >>> scan the assembly code isn't present in the libgcj testsuite? >> >> Yes, exactly. > > For this case,

Re: [PATCH] Set correct source location for deallocator calls

2012-09-04 Thread Dehao Chen
On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: > On 08/30/2012 08:20 AM, Andrew Haley wrote: >> Is the problem simply that the logic to >> scan the assembly code isn't present in the libgcj testsuite? > > Yes, exactly. For this case, I don't think that we want a testcase to rely on add

Re: Ping^2: [PATCH]Remove duplicate check on BRANCH_COST in fold-const.c

2012-09-04 Thread Bin.Cheng
Sorry, I mis-sent this offline. On Tue, Sep 4, 2012 at 11:00 PM, Bin.Cheng wrote: >>> >>> It's not ok (I btw fail to see the patch in this thread). The current >>> way LOGICAL_OP_NON_SHORT_CIRCUIT is implemented/used should instead >>> be changed to always match the pattern >>> >>> LOGICAL

Fix bootstrap with release checking

2012-09-04 Thread Diego Novillo
PR bootstrap/54479 * vec.h (vec_t::copy): Add cast in call to reserve_exact. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 3d20ebd..c605432 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2012-09-04 Diego Novillo + + PR bootstrap/54479 + * vec.h

[PATCH] Another PRE cleanup

2012-09-04 Thread Richard Guenther
This converts the global value-id to expression map to not be a bitmap set with both a value-set (with just one value, the index of the array ...) and a set of expression IDs but instead just contain a bitmap of expression IDs. That saves a little bit of memory and compile-time for FRE. Bootstra

RE: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Weddington, Eric
> -Original Message- > From: dosr...@gmail.com [] On Behalf Of Gabriel Dos > Reis > Sent: Tuesday, September 04, 2012 9:08 AM > To: Richard Guenther > Cc: Georg-Johann Lay; gcc-patches@gcc.gnu.org; Denis Chertykov; Weddington, > Eric; Joerg Wunsch > Subject: Re: [Patch,avr] PR54461: Bette

Re: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Gabriel Dos Reis
On Tue, Sep 4, 2012 at 9:17 AM, Richard Guenther wrote: >> Can you explain this? A typical build of avr tools goes like >> >> 1) configure, build and install binutils >> 2) configure, build and install the compiler >> 3) configure, build and install AVR-Libc >> >> so that in step 2 no checking i

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Alexandre Oliva
On Sep 4, 2012, Oleg Endo wrote: > * config/mn10300/mn10300.c (mn10300_address_cost): Add > machine_mode and address space arguments. Use GET_MODE (x) and > ADDR_SPACE_GENERIC in recursive invocation. Ok with a change, see below. > * config/sh/sh.c (sh_address_cost)

Re: Ping^2: [PATCH]Remove duplicate check on BRANCH_COST in fold-const.c

2012-09-04 Thread Richard Guenther
On Tue, Sep 4, 2012 at 4:33 PM, Richard Earnshaw wrote: > On 04/09/12 15:31, Richard Guenther wrote: >> On Tue, Sep 4, 2012 at 12:53 PM, Richard Earnshaw wrote: >>> On 04/09/12 11:11, Richard Guenther wrote: On Tue, Sep 4, 2012 at 11:56 AM, Bin Cheng wrote: >>> -Original Message

Re: Ping^2: [PATCH]Remove duplicate check on BRANCH_COST in fold-const.c

2012-09-04 Thread Richard Earnshaw
On 04/09/12 15:31, Richard Guenther wrote: > On Tue, Sep 4, 2012 at 12:53 PM, Richard Earnshaw wrote: >> On 04/09/12 11:11, Richard Guenther wrote: >>> On Tue, Sep 4, 2012 at 11:56 AM, Bin Cheng wrote: >> -Original Message- >> From: Richard Earnshaw >> Sent: Thursday, July 26,

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Richard Guenther
On Tue, Sep 4, 2012 at 12:38 PM, Paolo Bonzini wrote: > Il 04/09/2012 09:52, Oleg Endo ha scritto: >> [x] target-independent bits >> [ ] alpha [ ] arm [ ] avr [ ] bfin >> [ ] cr16 [ ] cris [ ] epiphany[ ] i386 >> [ ] ia64 [ ] iq2000[ ] lm32[ ] m32c

Re: Ping^2: [PATCH]Remove duplicate check on BRANCH_COST in fold-const.c

2012-09-04 Thread Richard Guenther
On Tue, Sep 4, 2012 at 12:53 PM, Richard Earnshaw wrote: > On 04/09/12 11:11, Richard Guenther wrote: >> On Tue, Sep 4, 2012 at 11:56 AM, Bin Cheng wrote: > -Original Message- > From: Richard Earnshaw > Sent: Thursday, July 26, 2012 9:19 PM > To: Andrew Pinski > Cc: Bi

Re: [PATCH] Simplify FRE parts of PRE, try to save some memory

2012-09-04 Thread Richard Guenther
On Tue, 4 Sep 2012, Steven Bosscher wrote: > On Tue, Sep 4, 2012 at 3:19 PM, Richard Guenther wrote: > > > > Currently computa_avail consumes an unreasonable amount of memory > > in the FRE case for PR46590. The following patch makes some > > obvious adjustments but does not cure the underlying

Re: [PATCH] Simplify FRE parts of PRE, try to save some memory

2012-09-04 Thread Steven Bosscher
On Tue, Sep 4, 2012 at 3:19 PM, Richard Guenther wrote: > > Currently computa_avail consumes an unreasonable amount of memory > in the FRE case for PR46590. The following patch makes some > obvious adjustments but does not cure the underlying issue. I don't think there's any way to cure the unde

Re: [PATCH] Fix bogus use of cfun in gen_subprogram_die and premark_used_types

2012-09-04 Thread Richard Guenther
On Tue, Sep 4, 2012 at 3:12 PM, Martin Jambor wrote: > Hi, > > while looking into how to remove push/pop_cfun from dwarf2out.c, I > have noticed the following wrong use of cfun in premark_used_types, > which is the first thing called by gen_subprogram_die. > > What happens is that: > > 1. early in

Re: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Richard Guenther
On Tue, Sep 4, 2012 at 1:01 PM, Georg-Johann Lay wrote: > Richard Guenther wrote: >> Georg-Johann Lay wrote: >>> Gabriel Dos Reis schrieb: Georg-Johann Lay wrote: > Gabriel Dos Reis schrieb: >> Georg-Johann Lay wrote: >>> Gabriel Dos Reis schrieb: Georg-Johann Lay wrote:

Fix bootstrap failure with Sun linker

2012-09-04 Thread Eric Botcazou
The generated libstdc++-symbols.ver-sun cannot be parsed by the linker anymore. Bootstrapped on SPARC64/Solaris 9 & SPARC/Solaris 10, applied on the mainline. 2012-09-04 Eric Botcazou * make_sunver.pl: Add missing newline at the end of extern "C++" block. -- Eric Botcazou Index: m

Re: Re-implement VEC_* to be member functions of vec_t

2012-09-04 Thread Diego Novillo
On Fri, Aug 24, 2012 at 2:32 PM, Diego Novillo wrote: > On 2012-08-23 23:08 , Diego Novillo wrote: > >> I've tested this patch on x86_64 and ppc64 with all languages plus >> ada, go and obj-c++. I am going to be offline for several days >> starting on Saturday, so I will not commit it until I ret

MAINTAINERS (Write After Approval): Add myself.

2012-09-04 Thread Christophe Lyon
Hi all, I have added my name in the Write After Approval section, with the attached patch. Christophe. Index: ChangeLog === --- ChangeLog (revision 190926) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2012-09-04 Christophe L

[PATCH] Simplify FRE parts of PRE, try to save some memory

2012-09-04 Thread Richard Guenther
Currently computa_avail consumes an unreasonable amount of memory in the FRE case for PR46590. The following patch makes some obvious adjustments but does not cure the underlying issue. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-09-04 Richard Guenther

[PATCH] Fix bogus use of cfun in gen_subprogram_die and premark_used_types

2012-09-04 Thread Martin Jambor
Hi, while looking into how to remove push/pop_cfun from dwarf2out.c, I have noticed the following wrong use of cfun in premark_used_types, which is the first thing called by gen_subprogram_die. What happens is that: 1. early inliner calls dwarf2out_abstract_function, cfun corresponds to the f

Re: [PATCH][RFC] Add -Og

2012-09-04 Thread H.J. Lu
On Tue, Sep 4, 2012 at 4:16 AM, Matthew Gretton-Dann wrote: > On 4 September 2012 10:45, Richard Guenther wrote: >> On Mon, 3 Sep 2012, H.J. Lu wrote: >> >>> On Mon, Sep 3, 2012 at 11:50 AM, wrote: >>> > "H.J. Lu" wrote: >>> > >>> >>On Mon, Sep 3, 2012 at 6:28 AM, Richard Guenther >>> >> wrote

Re: [wwwdocs] PATCH for Re: [PATCH] Remove matrix-reorg

2012-09-04 Thread Richard Guenther
On Tue, 4 Sep 2012, Gerald Pfeifer wrote: > On Mon, 3 Sep 2012, Richard Guenther wrote: > > I'd not mention the command-line flags. > > I was thinking to point out what to not use any longer, in case. > Doesn't that make sense for the release notes? > > > They were not working correctly and they

Re: [PATCH 3/3] Compute predicates for phi node results in ipa-inline-analysis.c

2012-09-04 Thread Martin Jambor
On Tue, Sep 04, 2012 at 11:27:47AM +0200, Richard Guenther wrote: > On Mon, Sep 3, 2012 at 5:52 PM, Jan Hubicka wrote: > >> On Fri, Aug 31, 2012 at 7:24 PM, Martin Jambor wrote: > >> > Hi, > >> > > >> > On Thu, Aug 30, 2012 at 05:11:35PM +0200, Martin Jambor wrote: > >> >> this is a new version o

Re: [PATCH][RFC] Add -Og

2012-09-04 Thread Matthew Gretton-Dann
On 4 September 2012 10:45, Richard Guenther wrote: > On Mon, 3 Sep 2012, H.J. Lu wrote: > >> On Mon, Sep 3, 2012 at 11:50 AM, wrote: >> > "H.J. Lu" wrote: >> > >> >>On Mon, Sep 3, 2012 at 6:28 AM, Richard Guenther >> >> wrote: >> >>> On Fri, Aug 10, 2012 at 1:30 PM, Richard Guenther >> >>wrote

Re: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Georg-Johann Lay
Richard Guenther wrote: > Georg-Johann Lay wrote: >> Gabriel Dos Reis schrieb: >>> Georg-Johann Lay wrote: Gabriel Dos Reis schrieb: > Georg-Johann Lay wrote: >> Gabriel Dos Reis schrieb: >>> Georg-Johann Lay wrote: AVR-Libc comes with hand-optimized float support function

Re: [wwwdocs] PATCH for Re: [PATCH] Remove matrix-reorg

2012-09-04 Thread Gerald Pfeifer
On Mon, 3 Sep 2012, Richard Guenther wrote: > I'd not mention the command-line flags. I was thinking to point out what to not use any longer, in case. Doesn't that make sense for the release notes? > They were not working correctly and they did not work with LTO > which made them useless apart fr

Re: Ping^2: [PATCH]Remove duplicate check on BRANCH_COST in fold-const.c

2012-09-04 Thread Richard Earnshaw
On 04/09/12 11:11, Richard Guenther wrote: > On Tue, Sep 4, 2012 at 11:56 AM, Bin Cheng wrote: -Original Message- From: Richard Earnshaw Sent: Thursday, July 26, 2012 9:19 PM To: Andrew Pinski Cc: Bin Cheng; gcc-patches@gcc.gnu.org Subject: Re: [PATCH]Remove d

Re: [PATCH][RFC] Add -Og

2012-09-04 Thread Richard Earnshaw
On 04/09/12 10:45, Richard Guenther wrote: > On Mon, 3 Sep 2012, H.J. Lu wrote: > >> On Mon, Sep 3, 2012 at 11:50 AM, wrote: >>> "H.J. Lu" wrote: >>> On Mon, Sep 3, 2012 at 6:28 AM, Richard Guenther wrote: > On Fri, Aug 10, 2012 at 1:30 PM, Richard Guenther wrote: >> >>

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:52, Oleg Endo ha scritto: > [x] target-independent bits > [ ] alpha [ ] arm [ ] avr [ ] bfin > [ ] cr16 [ ] cris [ ] epiphany[ ] i386 > [ ] ia64 [ ] iq2000[ ] lm32[ ] m32c > [ ] m32r [ ] mcore [ ] mep [x] microblaze

Re: Ping: [PATCH] Enable bbro for -Os

2012-09-04 Thread Richard Guenther
On Wed, Aug 29, 2012 at 10:42 AM, Zhenqiang Chen wrote: >> -Original Message- >> From: Steven Bosscher [mailto:stevenb@gmail.com] >> Sent: Friday, August 24, 2012 8:17 PM >> To: Zhenqiang Chen >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: Ping: [PATCH] Enable bbro for -Os >> >> On Wed

Re: combine vec_perm_expr with constructor

2012-09-04 Thread Richard Guenther
On Mon, Sep 3, 2012 at 5:50 PM, Marc Glisse wrote: > On Mon, 3 Sep 2012, Richard Guenther wrote: > >> On Mon, Sep 3, 2012 at 4:00 PM, Marc Glisse wrote: >>> >>> On Mon, 3 Sep 2012, Richard Guenther wrote: >>> You shouldn't need the VECTOR_CST handling - constant propagation should alrea

Re: Ping^2: [PATCH]Remove duplicate check on BRANCH_COST in fold-const.c

2012-09-04 Thread Richard Guenther
On Tue, Sep 4, 2012 at 11:56 AM, Bin Cheng wrote: >> > -Original Message- >> > From: Richard Earnshaw >> > Sent: Thursday, July 26, 2012 9:19 PM >> > To: Andrew Pinski >> > Cc: Bin Cheng; gcc-patches@gcc.gnu.org >> > Subject: Re: [PATCH]Remove duplicate check on BRANCH_COST in >> > fold-co

Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-04 Thread Bin Cheng
> Hi, > For thumb1, arm-gcc rewrites move insn into subtract of ZERO in peephole2 pass > intentionally, then executes > pass_if_after_reload/pass_regrename/pass_cprop_hardreg sequentially. > > In this scenario, copy propagation opportunities are missed because: > 1. the move insns are re-written

Re: [Patch,avr] PR54461: Better AVR-Libc integration

2012-09-04 Thread Richard Guenther
On Tue, Sep 4, 2012 at 8:55 AM, Georg-Johann Lay wrote: > Gabriel Dos Reis schrieb: >> >> Georg-Johann Lay wrote: >>> >>> Gabriel Dos Reis schrieb: Georg-Johann Lay wrote: > > Gabriel Dos Reis schrieb: >> >> Georg-Johann Lay wrote: >>> >>> AVR-Libc comes with hand

Ping^2: [PATCH]Remove duplicate check on BRANCH_COST in fold-const.c

2012-09-04 Thread Bin Cheng
> > -Original Message- > > From: Richard Earnshaw > > Sent: Thursday, July 26, 2012 9:19 PM > > To: Andrew Pinski > > Cc: Bin Cheng; gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH]Remove duplicate check on BRANCH_COST in > > fold-const.c > > > > On 26/07/12 11:27, Andrew Pinski wrote: > >

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Richard Earnshaw
On 04/09/12 08:52, Oleg Endo wrote: > On Mon, 2012-09-03 at 01:58 +0200, Oleg Endo wrote: >> OKOK -- I'll do it :) >> (within the next couple of days) >> > > And so I did. Attached is an updated patch that adds the address space > parameter to the address_cost function. I hope that this change d

[Patch,avr,committed] Fix PR54476

2012-09-04 Thread Georg-Johann Lay
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190920 http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190921 Applied these obvious fix for PR54476. Johann -- Index: config/avr/avr.c === --- config/avr/avr.c(revision 190914)

Re: [PATCH][RFC] Add -Og

2012-09-04 Thread Richard Guenther
On Mon, 3 Sep 2012, H.J. Lu wrote: > On Mon, Sep 3, 2012 at 11:50 AM, wrote: > > "H.J. Lu" wrote: > > > >>On Mon, Sep 3, 2012 at 6:28 AM, Richard Guenther > >> wrote: > >>> On Fri, Aug 10, 2012 at 1:30 PM, Richard Guenther > >>wrote: > > This adds a new optimization level, -Og, as pr

Re: combine BIT_FIELD_REF and VEC_PERM_EXPR

2012-09-04 Thread Richard Guenther
On Mon, Sep 3, 2012 at 6:12 PM, Marc Glisse wrote: > On Mon, 3 Sep 2012, Richard Guenther wrote: > > + if (code == VEC_PERM_EXPR) > +{ > + tree p, m, index, tem; > + unsigned nelts; > + m = gimple_assign_rhs3 (def_stmt); > + if (TREE_CODE (m) != VEC

Re: [PATCH, C] Mixed pointer types in call to streamer_tree_cache_lookup() in gcc/lto-streamer-out.c

2012-09-04 Thread Richard Guenther
On Mon, Sep 3, 2012 at 6:10 PM, Andris Pavenis wrote: > On 09/03/2012 03:27 PM, Richard Guenther wrote: >> >> On Sat, Sep 1, 2012 at 2:21 PM, Andris Pavenis >> wrote: >>> >>> uint32_t * is used as a 3rd parameter in call to >>> streamer_tree_cache_lookup() >>> in 2 places in gcc/lto-streamer-out.

Re: [PATCH 3/3] Compute predicates for phi node results in ipa-inline-analysis.c

2012-09-04 Thread Richard Guenther
On Mon, Sep 3, 2012 at 5:52 PM, Jan Hubicka wrote: >> On Fri, Aug 31, 2012 at 7:24 PM, Martin Jambor wrote: >> > Hi, >> > >> > On Thu, Aug 30, 2012 at 05:11:35PM +0200, Martin Jambor wrote: >> >> this is a new version of the patch which makes ipa analysis produce >> >> predicates for PHI node res

[PATCH] Fix PR54458

2012-09-04 Thread Richard Guenther
This fixes PR54458 where DOM jump threading turns a loop into one with multiple latches but does not mark it so. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-09-04 Richard Guenther PR tree-optimization/54458 * tree-ssa-threadupdate.c (

[Patch, Fortran, committed] PR 54435 & 54443

2012-09-04 Thread Janus Weil
Hi all, I have just committed to trunk a trivial fix for two recent OOP regressions (affecting 4.7 and trunk), both of which originate from the same problem: http://gcc.gnu.org/viewcvs?view=revision&revision=190910 I will commit this fix also to the 4.7 branch in a few days. Cheers, Janus

Re: [SH] PR 51244 - Add CANONICALIZE_COMPARISON macro

2012-09-04 Thread Oleg Endo
On Mon, 2012-09-03 at 19:37 +0900, Kaz Kojima wrote: > Oleg Endo wrote: > > In any case, I have no problem with changing the multi line comments > > to /* ... */. Just let me know. > > Other than that, the patch is OK. I've committed the attached version of the patch as rev 190909. Cheers, O

Re: [PATCH] PR45070: Fix wrong epilogue code for cortex-m0/Os

2012-09-04 Thread Ramana Radhakrishnan
I ran regression test with/without Os for cortex-m0 and everything is ok. Ok for trunk and 4.7/4.6 release branches? OK for trunk. Ok to backport if no release manager objects in 24 hours and if it tests without regressions there. Thanks, Ramana

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread nick clifton
Hi Oleg, And so I did. Attached is an updated patch that adds the address space parameter to the address_cost function. I hope that this change does not reset the ACKs so far: [x] target-independent bits [ ] alpha [ ] arm [ ] avr [ ] bfin [ ] cr16 [ ] cris [ ] epip

  1   2   >