On Wed, Aug 29, 2012 at 10:32 AM, Florian Weimer <f...@deneb.enyo.de> wrote: > > This patches fixes an integer overflow in libiberty, which leads to > crashes in binutils. The long version of the objalloc_alloc macro > would have needed another conditional, so I removed that and replaced > it with a call to the actual implementation.
I guess I don't see why removing the macro is desirable. In many uses of objalloc_alloc the conditional can be optimized out anyhow. It's true that it can't always be, but, so what? The macro is probably still a win. Or perhaps the macro is not a win, but that would be a decision to make separately from adding this conditional. Ian
