On 4/09/2012, at 7:57 PM, Andreas Schwab wrote:
> Maxim Kuvyrkov <maxim_kuvyr...@mentor.com> writes:
>
>> 2012-09-03 Maxim Kuvyrkov <ma...@codesourcery.com>
>>
>> * config/m68k/m68k.c (m68k_sched_dfa_post_advance_cycle): Fix ICE
>> caused by "save scheduler state" patch.
>
> The change log entry should describe what was changed. "Save scheduler
> state" doesn't say anything to me.
This should be "Support starting scheduling from a pre-existing state."
>
>> + {
>> + /* The instruction buffer appears to be more filled than we
>> + anticipated. We should have inheritted the state from
>
> s/inheritted/inherited/
OK.
>
>> + the previous basic block. Adjust buffer counter. */
>> + ++sched_ib.filled;
>> + }
>
> The comment appears to suggest that this is rather a workaround for a
> deficiency elsewhere. Is that true?
No. This hunk makes m68k scheduling support pick up the new state.
Thank you,
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics
