Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-25 Thread H.J. Lu
On Fri, May 25, 2012 at 8:38 PM, Sriraman Tallam wrote: > > On May 25, 2012 7:15 PM, "H.J. Lu" wrote: >> >> >> On May 25, 2012 6:54 PM, "Sriraman Tallam" wrote: >> > >> > >> > >> >> > >> On Fri, May 25, 2012 at 5:0 > > BTW, I noticed: >> >> > > >> > > [hjl@gnu-6 pr14170]$ readelf -sW libgcc.a |

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Miles Bader
NightStrike writes: > You wouldn't use the GNU C Coding conventions to write in tcl, and you > shouldn't use them to write in C++. You should just create the GNU > C++ Coding Standards new, and not base them off of the former. ... r, just use some common sense, and change things which need c

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-25 Thread Sriraman Tallam
On Fri, May 25, 2012 at 5:27 PM, H.J. Lu wrote: > On Fri, May 25, 2012 at 5:16 PM, Sriraman Tallam wrote: >> Hi H.J., >> >> On Fri, May 25, 2012 at 5:07 PM, H.J. Lu wrote: >>> On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam >>> wrote: Hi H.J,   Attaching new patch with 2 test

Re: [PATCH 2/2] Better system header location detection for built-in macro tokens

2012-05-25 Thread Hans-Peter Nilsson
> From: Dodji Seketeli > Date: Mon, 21 May 2012 15:55:19 +0200 > The location for a built-in macro token is BUILTIN_LOCATION. When we > see that location value, we cannot know if that token was used in a > system header or not. And that can trigger some unwanted warnings on > e.g, the use of __

[C++ Patch] PR 53491

2012-05-25 Thread Paolo Carlini
Hi, an ICE on invalid, regression in 4.7 and 4.8. In 4.7 (vs 4.6) we started using stabilize_expr in one more place in cp_build_modify_expr without also adding a preliminary check that the expr isn't of void type, thus we can easily end up calling build_type_target_expr_with_type on it and cr

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-25 Thread H.J. Lu
On Fri, May 25, 2012 at 5:16 PM, Sriraman Tallam wrote: > Hi H.J., > > On Fri, May 25, 2012 at 5:07 PM, H.J. Lu wrote: >> On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam >> wrote: >>> Hi H.J, >>> >>>   Attaching new patch with 2 test cases, mv2.C checks ISAs only and >>> mv1.C checks ISAs and

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-25 Thread Sriraman Tallam
Hi H.J., On Fri, May 25, 2012 at 5:07 PM, H.J. Lu wrote: > On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam wrote: >> Hi H.J, >> >>   Attaching new patch with 2 test cases, mv2.C checks ISAs only and >> mv1.C checks ISAs and arches mixed. Right now, checking only arches is >> not needed as they

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-05-25 Thread H.J. Lu
On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam wrote: > Hi H.J, > >   Attaching new patch with 2 test cases, mv2.C checks ISAs only and > mv1.C checks ISAs and arches mixed. Right now, checking only arches is > not needed as they are mutually exclusive, any order should be fine. > > Patch also

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread NightStrike
On Fri, May 25, 2012 at 12:42 PM, Gabriel Dos Reis wrote: > with the current implementation language.  Consequently, I think > we should retain the binding suggested by the C++ standard. > I realize that the existing GNU C convention says the opposite -- but > then it is written for C. This point

[patch] Fixes to make check_makefile_deps.sh work again

2012-05-25 Thread Steven Bosscher
Hello, The following patch was necessary to make check_makefile_deps.sh work on powerpc64-unknown-linux-gnu. Is this OK? Ciao! Steven Index: contrib/ChangeLog === --- contrib/ChangeLog (revision 187901) +++ contrib/ChangeLog (wo

Re: [C++ Patch] PR 32054

2012-05-25 Thread Jason Merrill
OK. Jason

Merge from gcc-4_7-branch to gccgo branch

2012-05-25 Thread Ian Lance Taylor
I've merged gcc-4_7-branch revision 187900 to the gccgo branch. Ian

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 4:52 PM, Lawrence Crowl wrote: > Personally, I would rather see if we can take advantage of C++ > features to reduce garbage and then use the Boehm collector. > There is too much manual management with GTY, and I'd rather the > compiler leverage mainstream practice rather

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 4:16 PM, Lawrence Crowl wrote: > On 5/25/12, Jakub Jelinek wrote: >> On Fri, May 25, 2012 at 10:15:54AM -0400, Diego Novillo wrote: >> > Lawrence, Ian and Gaby have been working on the proposed coding >> > guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). >> >>

Re: [C++ Patch] PR 32054

2012-05-25 Thread Paolo Carlini
Hi, On 05/25/2012 06:25 PM, Jason Merrill wrote: On 05/24/2012 10:57 PM, Paolo Carlini wrote: +error_at (decl_spec_token_start->location, + "a storage class is not allowed"); Let's give more explanation here so that the user knows that the problem is a storage class on a

[google/gcc-4_6] Fix -gfission ICEs with pubnames and .debug_addr table (issue6254054)

2012-05-25 Thread Cary Coutant
This patch is for the google/gcc-4_6 branch. It fixes a problem where we were still trying to output entries in the .debug_addr table for location lists that were removed, and fixes a problem where we were getting an ICE while trying to output a pubname for a member function of a struct. Tested w

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Mike Stump wrote: > On May 25, 2012, at 10:50 AM, Lawrence Crowl wrote: > > Diego and I looked long and hard at this issue. It all came > > down to a sequence of problems. First, libstdc++ isn't rigged > > for GTY, > > If portability to other C++ compilers wasn't a concern, we could

libgo patch committed: More efficient trampoline allocation

2012-05-25 Thread Ian Lance Taylor
This patch to libgo makes the implementation of function trampolines, used for nested functions that refer to variables in an enclosing function scope, much more efficient. Previously we were allocating a separate page for each trampoline. This patch packs them on a single page as much as possibl

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/24/12, Jakub Jelinek wrote: > On Thu, May 24, 2012 at 09:43:42AM -0700, Lawrence Crowl wrote: > > Add a type-safe hash table, typed_htab. Uses of this table > > replace uses of libiberty's htab_t. The benefits include less > > boiler-plate code, full type safety, and improved performance. >

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Jakub Jelinek wrote: > On Fri, May 25, 2012 at 10:15:54AM -0400, Diego Novillo wrote: > > Lawrence, Ian and Gaby have been working on the proposed coding > > guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). > > That page is quite inconsistent. E.g. it first talks about > r

Go patch committed: Don't create a closure if not needed

2012-05-25 Thread Ian Lance Taylor
This patch to the Go frontend changes it to not produce a closure for an embedded function if one is not needed. Earlier, when Go permitted comparisons of function types, it was necessary to always create a closure for an embedded function, so that each embedded function would be reliably distinct

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Michael Matz wrote: > On Fri, 25 May 2012, Jakub Jelinek wrote: > > > + /* Return the current size of this hash table. */ > > > + > > > + size_t size() > > > + { > > > +return htab->size; > > > + } > > > > (and various other places) - formatting is wrong, missing space > > bet

libgcc patch committed: Fix for -fsplit-stack when using gold

2012-05-25 Thread Ian Lance Taylor
When using the gold linker, the linker will adjust the split-stack prologue to call __morestack_non_split if it sees that the function calls a different function compiled without -fsplit-stack. The __morestack_non_split function has an optimization I committed 2011-12-20 to avoid splitting the sta

Re: [patch] Fix PR lto/52178 (continued)

2012-05-25 Thread Eric Botcazou
> Ok. Please make sure to verify LTO bootstrap on the branch still > works after this. Thanks. I already verified it with --enable-checking=yes,rtl. -- Eric Botcazou

Re: [cxx-conversion] Convert vec.[ch] to C++ [1/3] (issue6233044)

2012-05-25 Thread Diego Novillo
On 12-05-25 14:27 , Tom Tromey wrote: "Diego" == Diego Novillo writes: Diego> +struct GTY(()) vec_prefix Diego> +{ Diego> + unsigned num; Diego> + unsigned alloc; Diego> +}; Diego> + Diego> +/* Vector type, user visible. */ Diego> +template Diego> +struct GTY(()) vec_t Diego> +{ D

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Joseph S. Myers
On Fri, 25 May 2012, Marcus Shawcroft wrote: > We have a long list of intrinsics which we want to move into RTL, only some of > these have been moved so far. However, that said, point noted that we can > usefully exploit TARGET_FOLD_BUILTIN in preference to RTL. I think the order of preference i

Re: [PATCH][revised] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jason Merrill
OK. Jason

Re: [PATCH] Add powerpc64-linux configuration options

2012-05-25 Thread David Edelsohn
On Fri, May 25, 2012 at 10:22 AM, Michael Meissner wrote: > Yes, the second patch just does not build the library or use the > -mstrict-align > option.  It is much simpler, but there may be somebody out there that depends > on the functionality.  I really don't know, one way or the other. Mike,

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
On 25/05/12 15:18, Joseph S. Myers wrote: General question: I suppose you expect to submit patches soon for other toolchain components (such as binutils, GDB, glibc) and the Linux kernel, if you haven't done so yet? There is work going on to get other components ready for community review. I

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Pedro Alves
On 05/25/2012 05:27 PM, Jason Merrill wrote: > On 05/25/2012 08:46 AM, Dominique Dhumieres wrote: >> I certainly prefer this alternative (the use of extern for that purpose >> being extremely confusing for a fortraner;-). However, if my test is valid, >> if N is not equal to 2 or 4, one gets the f

Re: [PATCH] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Mike Stump
On May 25, 2012, at 6:03 AM, Jack Howarth wrote: > The attached patch solves PR53453. Darwin bits are Ok.

Re: [PATCH] omit -lcrt1.10.6.o and pass -no_new_main with -pg on darwin >= 10.8

2012-05-25 Thread Mike Stump
On May 25, 2012, at 6:06 AM, Jack Howarth wrote: > The attached patch limits the linkage of -lcrt1.10.6.o to darwin10 and > darwin11 > since its usage is deprecated in the 10.8sdk. Ok.

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Mike Stump
On May 25, 2012, at 7:29 AM, Bernd Schmidt wrote: > Can emacs handle the indentation rules automatically? I hope that any style picked, will have a no local mods required for emacs as the corner stone. One thing I hate about .md files, is they don't (last I checked) fulfill this requirement.

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Mike Stump
On May 25, 2012, at 10:50 AM, Lawrence Crowl wrote: > Diego and I looked long and hard at this issue. It all came down > to a sequence of problems. First, libstdc++ isn't rigged for GTY, If portability to other C++ compilers wasn't a concern, we could extend out g++ to make supporting GTY bette

Re: [cxx-conversion] Convert vec.[ch] to C++ [1/3] (issue6233044)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 1:27 PM, Tom Tromey wrote: >> "Diego" == Diego Novillo writes: > > Diego> +struct GTY(()) vec_prefix > Diego> +{ > Diego> +  unsigned num; > Diego> +  unsigned alloc; > Diego> +}; > Diego> + > Diego> +/* Vector type, user visible.  */ > Diego> +template > Diego> +struc

Re: [cxx-conversion] Convert vec.[ch] to C++ [1/3] (issue6233044)

2012-05-25 Thread Tom Tromey
> "Diego" == Diego Novillo writes: Diego> +struct GTY(()) vec_prefix Diego> +{ Diego> + unsigned num; Diego> + unsigned alloc; Diego> +}; Diego> + Diego> +/* Vector type, user visible. */ Diego> +template Diego> +struct GTY(()) vec_t Diego> +{ Diego> + vec_prefix prefix; Diego> + T GTY((

libgo patch committed: Fix cast error

2012-05-25 Thread Ian Lance Taylor
This patch to libgo fixes a cast error in the new file print.c that shows up on 32-bit systems. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian diff -r ae91b408310f libgo/runtime/print.c --- a/libgo/runtime/print.c Thu May 24 14:06:08 201

Re: Turn check macros into functions. (issue6188088)

2012-05-25 Thread Tom Tromey
> "Mike" == Mike Stump writes: Mike> Yeah, I kinda think the gdb people are wimping out by not just Mike> implementing __extension__ and ({}), which, I think get us most of the Mike> way there. Shh, don't tell them I said that. We eagerly await your patch. Tom

Re: Turn check macros into functions. (issue6188088)

2012-05-25 Thread Tom Tromey
> "Lawrence" == Lawrence Crowl writes: Lawrence> Should I add that to my patch to gdbinit.in? I think it would be helpful. Tom

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 12:27:23PM -0400, Jason Merrill wrote: > On 05/25/2012 08:46 AM, Dominique Dhumieres wrote: > >I certainly prefer this alternative (the use of extern for that purpose > >being extremely confusing for a fortraner;-). However, if my test is valid, > >if N is not equal to 2 or

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Paweł Sikora wrote: > On Friday 25 of May 2012 10:15:54 Diego Novillo wrote: > > Lawrence, Ian and Gaby have been working on the proposed coding > > guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). > > on this page we can read: > > "The following features of the C++ languag

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Lawrence Crowl
On 5/25/12, Diego Novillo wrote: > Lawrence, Ian and Gaby have been working on the proposed coding > guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). > Lawrence, have you had a chance to update them with your latest > edits? Not yet; they're on the desk in front of me. I'll do that A

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Paweł Sikora
On Friday 25 of May 2012 11:50:13 Gabriel Dos Reis wrote: > On Fri, May 25, 2012 at 11:44 AM, Paweł Sikora wrote: > > > so, why you just don't use the hash table implementation from libstdc++? > > we have agreed on C++03 as a bootstrap compiler. > There is unfortunately no hash table in C++03.

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread NightStrike
On Fri, May 25, 2012 at 12:50 PM, Gabriel Dos Reis wrote: > On Fri, May 25, 2012 at 11:44 AM, Paweł Sikora wrote: > >> so, why you just don't use the hash table implementation from libstdc++? > > we have agreed on C++03 as a bootstrap compiler. > There is unfortunately no hash table in C++03. Th

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 11:44 AM, Paweł Sikora wrote: > so, why you just don't use the hash table implementation from libstdc++? we have agreed on C++03 as a bootstrap compiler. There is unfortunately no hash table in C++03. The page about "not defining a new template" was just when we were ga

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Paweł Sikora
On Friday 25 of May 2012 10:15:54 Diego Novillo wrote: > On 12-05-25 09:56 , Jakub Jelinek wrote: > > On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote: > >> On Fri, 25 May 2012, Gabriel Dos Reis wrote: > >> That's one of my fears, namely that those used to the libstdc++ style > >> impos

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Jason Merrill
On 05/25/2012 08:46 AM, Dominique Dhumieres wrote: I certainly prefer this alternative (the use of extern for that purpose being extremely confusing for a fortraner;-). However, if my test is valid, if N is not equal to 2 or 4, one gets the following error error: size of array 'l' is negative W

Re: [C++ Patch] PR 32054

2012-05-25 Thread Jason Merrill
On 05/24/2012 10:57 PM, Paolo Carlini wrote: + error_at (decl_spec_token_start->location, + "a storage class is not allowed"); Let's give more explanation here so that the user knows that the problem is a storage class on an anonymous union/struct in class

Re: [PATCH, c++]: Fix PR 53441, [4.8 Regression] obj-c++.dg/ivar-invalid-type-1.mm ICE

2012-05-25 Thread Jason Merrill
OK. Jason

Re: [PATCH, c++]: Fix PR 53441, [4.8 Regression] obj-c++.dg/ivar-invalid-type-1.mm ICE

2012-05-25 Thread Dodji Seketeli
Uros Bizjak a écrit: > As shown in the PR, ivar-invalid-type-1 ICEs in constructor_name_p, > due to accessor on NULL "type" argument. > > The one-liner patch fixes the ICE by adding a guard that checks that > current_class_type is non-NULL before calling constructor_name_p. > > 2012-05-21 Uros B

Re: PR middle-end/53008 (trans-mem): output clone if function accessed indirectly

2012-05-25 Thread Richard Henderson
On 05/25/2012 06:25 AM, Aldy Hernandez wrote: OK? Would this be acceptable for the 4.7 branch as well? curr PR middle-end/53008 * trans-mem.c (ipa_tm_create_version_alias): Output new_node if accessed indirectly. (ipa_tm_create_version): Same. Ok everywhere.

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 9:33 AM, Paolo Carlini wrote: > Hi, > >> On Fri, May 25, 2012 at 7:17 AM, Michael Matz wrote: >>> Hi, >>> >>> On Fri, 25 May 2012, Jakub Jelinek wrote: >>> > +  /* Return the current size of this hash table.  */ > + > +  size_t size() > +  { > +    retu

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread NightStrike
On Fri, May 25, 2012 at 11:07 AM, Diego Novillo wrote: > On 12-05-25 11:06 , Michael Matz wrote: >> >> Hi, >> >> On Fri, 25 May 2012, Diego Novillo wrote: >> > That's one of my fears, namely that those used to the libstdc++ > style impose that on the compiler source base.  Because IMHO the

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Olivier Hainque
On May 25, 2012, at 17:17 , Michael Matz wrote: >> This should have been fixed by rev 187839 ... > Super, yes, that works. Great :) > Though I still wonder if the whole copy-over-to-gcc business shouldn't be > dependend on anything newly built. I can't see the use in copying > over the same u

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Olivier Hainque wrote: > > I've noticed that libitm is always rebuild with a non-bootstrap tree even > > with merely a sequence of two makes. The reason turns out to be that > > installation of unwind.h from libgcc, which is always done with a simple > > make: > > Th

[PATCH, i386]: Fix PR 53474, Solaris/x86 bootstrap with Sun as broken: j.e

2012-05-25 Thread Uros Bizjak
Hello! 2012-05-25 Uros Bizjak PR target/53474 * config/i386/i386.c (ix86_print_operand) : Print '.' here. : Print '.' only for C and c. Tested on i386-pc-solaris2.10 by Rainer, and on x86_64-pc-linux-gnu {,-m32}. Committed to mainline SVN. Uros. Index: config/i386/i38

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Diego Novillo
On 12-05-25 11:06 , Michael Matz wrote: Hi, On Fri, 25 May 2012, Diego Novillo wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base. Because IMHO the libstdc++ style isn't very appealing. Seconded. I don't care how ugly codin

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Diego Novillo wrote: > > > That's one of my fears, namely that those used to the libstdc++ > > > style impose that on the compiler source base. Because IMHO the > > > libstdc++ style isn't very appealing. > > > > Seconded. > > I don't care how ugly coding conventions

[gimplefe] Fix parsing of assign_stmt (issue6247046)

2012-05-25 Thread Diego Novillo
e/ChangeLog.gimplefe: * gimple.dg/20120523-1.gimple: Add expected error. * gimple.dg/20120525-1.gimple: New. diff --git a/gcc/gimple/parser.c b/gcc/gimple/parser.c index 4b29333..3f3eb96 100644 --- a/gcc/gimple/parser.c +++ b/gcc/gimple/parser.c @@ -152,10 +152,10 @@ gl_token_as_text (const gimple_t

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Olivier Hainque
Hello Michael, On May 25, 2012, at 16:30 , Michael Matz wrote: > I've noticed that libitm is always rebuild with a non-bootstrap tree even > with merely a sequence of two makes. The reason turns out to be that > installation of unwind.h from libgcc, which is always done with a simple > make:

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-25 Thread Christophe Lyon
On 21.05.2012 11:16, Christophe Lyon wrote: I tried applying your patch but ran into trouble with patch not liking this . My suspicion is mailer munging white spaces in some form - Could you send the patch as an attachment please rather than inline in your mail ? regards, Ramana Here it is, as

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Paolo Carlini
Hi, > On Fri, May 25, 2012 at 7:17 AM, Michael Matz wrote: >> Hi, >> >> On Fri, 25 May 2012, Jakub Jelinek wrote: >> + /* Return the current size of this hash table. */ + + size_t size() + { +return htab->size; + } >>> >>> (and various other places) - for

unwind.h installation causes rebuilds

2012-05-25 Thread Michael Matz
Hi, I've noticed that libitm is always rebuild with a non-bootstrap tree even with merely a sequence of two makes. The reason turns out to be that installation of unwind.h from libgcc, which is always done with a simple make: # make # make -d ... dest=../.././gcc/include/tmp$$-unwind.h; \

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Bernd Schmidt
On 05/25/2012 04:15 PM, Diego Novillo wrote: On 12-05-25 09:56 , Jakub Jelinek wrote: On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote: On Fri, 25 May 2012, Gabriel Dos Reis wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler sour

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Joseph S. Myers
On Fri, 25 May 2012, Diego Novillo wrote: > I don't care how ugly coding conventions look. I've dealt with many and they > all have their ugly spots. I mostly care about consistency. > > I don't think we should deviate much from the established GNU standards (which > are hideous, btw). Mostly

Re: [PATCH] pr51020 Fix invalid options validation for ARM target

2012-05-25 Thread Alexey Kravets
Hi guys, This issue has not been fixed in latest Linaro release (4.6.2012.04) yet. Can you suggest whether this patch is a correct fix for the pr51020. If so, should it be applied to the corresponding gcc branch? On Tue, May 01, 2012 at 11:21:28PM +0400, Alexey Kravets wrote: > On Mon, Apr 30, 201

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 10:15:54AM -0400, Diego Novillo wrote: > Lawrence, Ian and Gaby have been working on the proposed coding > guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions). That page is quite inconsistent. E.g. it first talks about retaining space before ( (which I really hope

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 9:15 AM, Diego Novillo wrote: > I don't care how ugly coding conventions look.  I've dealt with many and > they all have their ugly spots.  I mostly care about consistency. Agreed that consistency is very important. (At at single time in a week, I deal with 3 different st

Re: [AARCH64] [PATCH 2/3] AArch64 Port

2012-05-25 Thread Joseph S. Myers
On Fri, 25 May 2012, Marcus Shawcroft wrote: > Index: gcc/testsuite/gcc.target/aarch64/aapcs64/func-ret-4.x > === > --- gcc/testsuite/gcc.target/aarch64/aapcs64/func-ret-4.x (revision 0) > +++ gcc/testsuite/gcc.target/aarch64/aapc

Re: [PATCH] Add powerpc64-linux configuration options

2012-05-25 Thread Michael Meissner
On Thu, May 24, 2012 at 07:11:53PM -0400, David Edelsohn wrote: > On Wed, May 23, 2012 at 6:36 PM, Michael Meissner > wrote: > > On powerpc64-linux systems that run on IBM servers, the 32-bit software > > emulation library is not built with the Red Hat and SUSE distributions, but > > the > > FSF

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 8:57 AM, Michael Matz wrote: > Hi, > > On Fri, 25 May 2012, Steven Bosscher wrote: > >> >> Note also the almost 2 decades of C++ style practice in our libstdc++ >> >> implementation. >> > >> > That's one of my fears, namely that those used to the libstdc++ style >> > impose

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Joseph S. Myers
General question: I suppose you expect to submit patches soon for other toolchain components (such as binutils, GDB, glibc) and the Linux kernel, if you haven't done so yet? > Index: config.guess > === > --- config.guess (revisio

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Diego Novillo
On 12-05-25 09:56 , Jakub Jelinek wrote: On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote: On Fri, 25 May 2012, Gabriel Dos Reis wrote: That's one of my fears, namely that those used to the libstdc++ style impose that on the compiler source base. Because IMHO the libstdc++ style isn

Re: [RFA PATCH, i386]: Fix gcc.target/i386/pr53249.c on Sun targets

2012-05-25 Thread Rainer Orth
Hi Uros, > Currently gcc fails to compile following test from the testsuite [1]: > > FAIL: gcc.target/i386/pr53249.c (test for excess errors) > > We are trying to compile X32 specific test, but the special pattern > that was introduced to handle certain sun assembler limitation, is not > prepared

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Steven Bosscher wrote: > >> Note also the almost 2 decades of C++ style practice in our libstdc++ > >> implementation. > > > > That's one of my fears, namely that those used to the libstdc++ style > > impose that on the compiler source base.  Because IMHO the libstdc++

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote: > On Fri, 25 May 2012, Gabriel Dos Reis wrote: > That's one of my fears, namely that those used to the libstdc++ style > impose that on the compiler source base. Because IMHO the libstdc++ style > isn't very appealing. Seconded.

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Steven Bosscher
On Fri, May 25, 2012 at 3:51 PM, Michael Matz wrote: > Hi, > > On Fri, 25 May 2012, Gabriel Dos Reis wrote: > >> >> (and various other places) - formatting is wrong, missing space >> >> between (. >> > >> > And it doesn't start at the first column, and type isn't on a separate >> > line.  I realiz

Re: PATCH: PR target/53383: Allow -mpreferred-stack-boundary=3 on x86-64

2012-05-25 Thread H.J. Lu
On Sun, May 20, 2012 at 7:47 AM, H.J. Lu wrote: > Hi, > > This patch allows -mpreferred-stack-boundary=3 on x86-64 when SSE is > disabled.  Since this option changes ABI, I also added a warning for > -mpreferred-stack-boundary=3.  OK for trunk? > > Thanks. > > > H.J. > >        PR target/5338

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Gabriel Dos Reis wrote: > >> (and various other places) - formatting is wrong, missing space > >> between (. > > > > And it doesn't start at the first column, and type isn't on a separate > > line.  I realize that this is a member method, hence indenting and C > > GNU

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 7:17 AM, Michael Matz wrote: > Hi, > > On Fri, 25 May 2012, Jakub Jelinek wrote: > >> > +  /* Return the current size of this hash table.  */ >> > + >> > +  size_t size() >> > +  { >> > +    return htab->size; >> > +  } >> >> (and various other places) - formatting is wrong

PR middle-end/53008 (trans-mem): output clone if function accessed indirectly

2012-05-25 Thread Aldy Hernandez
This is a patch from Patrick, based on an earlier patch by Dave Boutcher. Thanks folks. In the failing testcase below we have a transaction_safe function being accessed indirectly, but for -O1 and above, the corresponding clone is not generated because we think it is unused. Fixed by forcing

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Steven Bosscher
On Fri, May 25, 2012 at 1:19 PM, Marcus Shawcroft wrote: >        * config/aarch64/aarch64.md: New file. > Index: gcc/config/aarch64/aarch64.md > === > --- gcc/config/aarch64/aarch64.md (revision 0) > +++ gcc/config/aarch64/aar

[PATCH][revised] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jack Howarth
The attached patch solves PR53453. The upcoming dsymutil release will now issue a warning when no debug notes are emitted for an object file on linkage. This causes several thousand failures in the FSF gcc testsuite. The origin of this problem is that the darwin linker requires the presence o

Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-25 Thread Steven Bosscher
On Fri, May 25, 2012 at 1:19 PM, Marcus Shawcroft wrote: > This patch adds an implementation of integer iterators. > > Index: gcc/ChangeLog.aarch64 > >        * read-rtl.c (rtx_list): New data structure. >        (int_iterator_mapping): New data structure. >        (int_iterator_data): New. List o

Re: [PATCH] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 09:03:02AM -0400, Jack Howarth wrote: > DEFHOOKPOD > +(force_at_comp_dir, > + "True if the @code{AT_comp_dir} attribute should be emitted for each \ It is DW_AT_comp_dir, so at least the comment should get it right. Jakub

[PATCH] omit -lcrt1.10.6.o and pass -no_new_main with -pg on darwin >= 10.8

2012-05-25 Thread Jack Howarth
The attached patch limits the linkage of -lcrt1.10.6.o to darwin10 and darwin11 since its usage is deprecated in the 10.8sdk. The patch also solves radr://11491405, "-pg broken for -mmacosx-version-min=10.8"... 19-May-2012 11:10 PM Jack Howarth: Summary: The default -mmacosx-version-min=10.8

[PATCH] PR debug/53453 ensure debug notes linked on darwin

2012-05-25 Thread Jack Howarth
The attached patch solves PR53453. The upcoming dsymutil release will now issue a warning when no debug notes are emitted for an object file on linkage. This causes several thousand failures in the FSF gcc testsuite. The origin of this problem is that the darwin linker requires the presence o

Re: [PATCH] PR bootstrap/53459 - unused local typedef when building on altivec

2012-05-25 Thread Dominique Dhumieres
> Alternatively you could put the static assertion with the comment > into the l field, i.e. > /* Statically assert that N is 2 or 4. */ > unsigned long l[(N == 2 || N == 4) ? N : -1]; I certainly prefer this alternative (the use of extern for that purpose being extremely confusin

Re: RFC: PATCH to correct the scopes of various types

2012-05-25 Thread H.J. Lu
On Wed, May 2, 2012 at 1:08 PM, Jason Merrill wrote: > I've been working on a patch to split out the DWARF debug info for COMDAT > functions into COMDAT CUs to go in the same group.  One problem I ran into > was that modified versions of function-local types (pointers, cv-qualified > variants, etc

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Michael Matz
Hi, On Fri, 25 May 2012, Jakub Jelinek wrote: > > + /* Return the current size of this hash table. */ > > + > > + size_t size() > > + { > > +return htab->size; > > + } > > (and various other places) - formatting is wrong, missing space between (. And it doesn't start at the first colum

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Thu, May 24, 2012 at 4:55 PM, Diego Novillo wrote: > On 12-05-24 17:52 , Lawrence Crowl wrote: > >> That said, I'll let y'all decide how much to put in any one piece. > > > I favour the approach we are taking now.  Each patch to cxx-conversion is a > small incremental step. > > When we merge in

Re: [cxx-conversion] New Hash Table (issue6244048)

2012-05-25 Thread Gabriel Dos Reis
On Fri, May 25, 2012 at 1:25 AM, Jakub Jelinek wrote: >> Static functions are also not acceptable as template arguments, so >> this patch externalizes the functions.  To avoid potential name >> conflicts, the function names have been prefixed. > > Ugh.  I guess the C++ way around this would be to

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
On 25/05/12 12:27, Jakub Jelinek wrote: On Fri, May 25, 2012 at 12:19:01PM +0100, Marcus Shawcroft wrote: ... * config/aarch64/aarch64-simd.md: New file. ... * config/aarch64/iterators.md: New file. With the above in the same ChangeLog entry * config/aarch64/aarch64

Re: [libgo] Fix IRIX bootstrap failure

2012-05-25 Thread Rainer Orth
Hi Ian, > Thanks. I committed the patch to mainline and 4.7 branch. Thanks. >> Testsuite results are still >> terrible since many tests timeout (with timeout doubled to 600s to >> account for the slow 250 MHz MIPS R10k CPUs on my test machine), and >> others not even hitting the timeout at all:

Re: [AARCH64] [PATCH 1/3] AArch64 Port

2012-05-25 Thread Jakub Jelinek
On Fri, May 25, 2012 at 12:19:01PM +0100, Marcus Shawcroft wrote: ... > * config/aarch64/aarch64-simd.md: New file. ... > * config/aarch64/iterators.md: New file. With the above in the same ChangeLog entry > * config/aarch64/aarch64-simd.md > (reduc_smax_v4sf, reduc_smin_v

[AARCH64] [PATCH 3/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
This patch adds an implementation of integer iterators. Index: gcc/ChangeLog.aarch64 * read-rtl.c (rtx_list): New data structure. (int_iterator_mapping): New data structure. (int_iterator_data): New. List of int iterator details. (num_int_iterator_data): New.

[AARCH64] [PATCH 0/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
ARM is pleased to announce a port of GCC to its AArch64 architecture. Please note that while the compiler has been used to build a large body of software, it cannot yet be considered complete. We expect there to be a number of as yet undiscovered bugs and other issues that will need to be resolv

Re: [patch] Fix PR lto/52178 (continued)

2012-05-25 Thread Richard Guenther
On Fri, May 25, 2012 at 12:27 PM, Eric Botcazou wrote: > This is a follow-up to PR lto/52178: there are more "type mismatch in > component > reference" issues related to variably_modified_type_p when you try to build > the gnattools with -flto: > >  1. Instances of a record type with fixed size a

[patch] Fix PR lto/52178 (continued)

2012-05-25 Thread Eric Botcazou
This is a follow-up to PR lto/52178: there are more "type mismatch in component reference" issues related to variably_modified_type_p when you try to build the gnattools with -flto: 1. Instances of a record type with fixed size at top level aren't merged if it has a field with self-refere

Re: divide 64-bit by constant for 32-bit target machines

2012-05-25 Thread Dinar Temirbulatov
Hi, I have replaced "expand_mult" to "expand_widening_mult" and removed all direct references to DImode, SImode modes in the expand_mult_highpart_optab funtion. The attached patch was tested on arm-7l, mips-32r2 (74k), i686 without new regressions. Richard, do you think it is ready now?

  1   2   >