On Fri, May 25, 2012 at 3:51 PM, Michael Matz <m...@suse.de> wrote: > Hi, > > On Fri, 25 May 2012, Gabriel Dos Reis wrote: > >> >> (and various other places) - formatting is wrong, missing space >> >> between (. >> > >> > And it doesn't start at the first column, and type isn't on a separate >> > line. I realize that this is a member method, hence indenting and C >> > GNU coding standards conflict, but the latter do have some nice >> > properties (for instance that 'grep ^func_name *.c' finds only the >> > definition, not all the calls to func_name). >> > >> > I think we need a discussion about style, now that actually people are >> > working on this. >> >> Note also the almost 2 decades of C++ style practice in our libstdc++ >> implementation. > > That's one of my fears, namely that those used to the libstdc++ style > impose that on the compiler source base. Because IMHO the libstdc++ style > isn't very appealing.
Neither is the GNU C style, but we use it anyway. IMHO it'd be very strange to use one style in gcc itself, and another in libstdc++. Ciao! Steven