Re: [patch, fortran] [4.6/4.7 Regression] Fix PR 48955

2011-05-25 Thread Thomas Koenig
Dear Paul, Following some comments from Thomas, the attached is the version that I wound up with. Tell us which one you prefer and Thomas and I will do the honours. Bootstrapped and regtested on FC9/x86_64 - OK for trunk and 4.6? Your patch is does the job and is less intrusive than mine -

Patches ping

2011-05-25 Thread Revital Eres
Hello, [PATCH, SMS 1/4] Fix calculation of row_rest_count http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01339.html [PATCH, SMS 2/4] Move the creation of anti-dep edge http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01340.html [PATCH, SMS 3/4] Optimize stage count http://gcc.gnu.org/ml/gcc-patches/20

Re: [Patch, Fortran] -fcoarray=lib - add registering calls for nonallocatable coarrays

2011-05-25 Thread Tobias Burnus
ping**0.3 http://gcc.gnu.org/ml/fortran/2011-05/msg00176.html Tobias Burnus wrote: Instead of a ping, an updated patch. This one additionally supports registering of nonallocatable coarrays also in MODULE and in BLOCK plus a test case. (Changes to gfc_generate_module_vars and gfc_process_blo

Re: Go patch committed: Update to current Go library

2011-05-25 Thread Ian Lance Taylor
Rainer Orth writes: >has > > typedef union { > long double _q; > uint32_t_l[4]; > } upad128_t; > > I already have to provide a _upad128_t replacement for other uses, but > it would really help to support this directly. I think I have fixed this problem with th

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-25 Thread Jing Yu
Actually I don't know why in gcc-4.6 libiberty is built for target when --disable-stdc++-v3 is given. Is libiberty used by other target libraries now? If not, we can skip libiberty for general Android toolchain. But, I still think it would be nice to make libiberty work, in case it is needed in som

Re: RFC/RFA: MN10300: Fix handling of protected functions in shared libraries.

2011-05-25 Thread Alan Modra
On Mon, May 23, 2011 at 04:21:38PM +0100, Nick Clifton wrote: > The problem here is that GCC has decided that since "g" is protected > it does not need a PLT entry. Right. > But the linker has decided that since > "g" is a function it does need a PLT entry (even though it is > protected)

Re: [PATCH PING] unreviewed tree-slimming patches

2011-05-25 Thread Nathan Froyd
On 05/25/2011 10:18 AM, Jason Merrill wrote: > On 05/25/2011 10:00 AM, Nathan Froyd wrote: >> Jason commented on the TS_STATEMENT_LIST patch, but >> the discussion didn't come to a resolution. > > Right, from your last mail I thought that you were investigating my question > about add_stmt and you

Re: RFA: another patch to solve PR49154

2011-05-25 Thread Vladimir Makarov
On 11-05-25 6:58 PM, Hans-Peter Nilsson wrote: On Wed, 25 May 2011, Vladimir Makarov wrote: This patch solves http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49154 for CRIS. The problem was in that the pressure classes did not contain SRP register and the assert failed. I'm not sure I understand t

Re: [PATCH][4.6] detect C++ errors to fix 2288 and 18770

2011-05-25 Thread Nathan Froyd
On Wed, May 25, 2011 at 03:22:07PM -0400, Nathan Froyd wrote: > The patch just requires some shuffling of logic to catch issues now; > below is a version that works for me on the trunk. > > This new checking does require modifying g++.dg/cpp0x/range-for5.C. > > Tested with g++ testsuite on x86_64

[v3] Use noexcept in the container adaptors

2011-05-25 Thread Paolo Carlini
Hi, tested x86_64-linux, committed. Paolo. / 2011-05-25 Paolo Carlini * include/bits/stl_queue.h: Use noexcept per the FDIS. * include/bits/stl_stack.h: Likewise. Index: include/bits/stl_queue.h ===

Re: Go patch committed: Update to current Go library

2011-05-25 Thread Ian Lance Taylor
Rainer Orth writes: > * While I get > > // var ___iob [59+1]___FILE > > now, there's still > > var __lastbuf *_FILE > > left, with commented > > // type _FILE struct { _cnt int32; _ptr *uint8; _base *uint8; _flag uint8; > _file > uint8; __orientation INVALID-bit-field; __ionolock INVALID-bi

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-25 Thread 關振德
Jing Can't we just skip libiberty in top-level configure.ac? Look for the comment "Disable target libiberty for some systems." -Doug On Wed, May 25, 2011 at 5:17 PM, Jing Yu wrote: > Hi Joseph, > > We notice that gcc starts to build libiberty for target as a multilib > since gcc-4.6, even if w

C++ PATCH for c++/48536 (type of enumerators with no explicit initializer)

2011-05-25 Thread Jason Merrill
I haven't checked the ARM, but as far back as C++98 it was specified that the type of an enumerator with no initializer is the type of the previous enumerator, unless the new value won't fit in that type, in which case it's an unspecified integral type. We weren't implementing that latter part

C++ PATCH for c++/48599 (prohibit array of auto)

2011-05-25 Thread Jason Merrill
I argued against this restriction when it was introduced, but we should enforce it in pedantic mode. Tested x86_64-pc-linux-gnu, applying to trunk. commit 9474a87e99bfacf0b8dfc9dc4c1218d39666a850 Author: Jason Merrill Date: Wed May 25 16:53:25 2011 -0400 PR c++/48599 * decl.c (crea

C++ PATCH for c++/44944 and c++/49156 (ICE re-entering error reporting routines)

2011-05-25 Thread Jason Merrill
Another case where we were hitting errors while trying to print template argument/typename bindings. In this case, the problem was that we were printing a partially instantiated template and processing_template_decl wasn't set. Tested x86_64-pc-linux-gnu, applying to trunk. commit b01a76f5f66

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-25 Thread Jing Yu
Hi Joseph, We notice that gcc starts to build libiberty for target as a multilib since gcc-4.6, even if we give --disable-stdc++-v3. Since then, we run into the incompatible getpagesize() error. I am wondering how to disable build of libiberty for target? I searched mailing list. One guy said --d

Re: Template instantiation results in a link failure

2011-05-25 Thread Paolo Carlini
... oops, no need to open a new minor version, we already bumped post 4.6.0. Committed mainline and 4_6-branch. Paolo. // 2011-05-25 Paolo Carlini * config/abi/pre/gnu.ver: Correct last change, export instead at the existing @3.4.16. * configure.a

C++ PATCH for c++/45401 (losing __restrict on reference squashing)

2011-05-25 Thread Jason Merrill
There are no standardized semantics for __restrict on references, but it seems reasonable to do as the submitter requests and return the original reference type unchanged when adding &&. Tested x86_64-pc-linux-gnu, applying to trunk. commit abb9429bb160d33b268bb45b9538ba83d920b0f2 Author: Jason

[v3] minor doc corrections

2011-05-25 Thread Jonathan Wakely
2011-05-26 Jonathan Wakely * doc/xml/manual/documentation_hacking.xml: Minor corrections. Tested with 'make doc-xml-validate-docbook' and committed to trunk Index: doc/xml/manual/documentation_hacking.xml === --- doc/xml/m

Re: Template instantiation results in a link failure

2011-05-25 Thread Paolo Carlini
On 05/26/2011 01:04 AM, Paolo Carlini wrote: On 05/26/2011 12:57 AM, Sam Varshavchik wrote: #include #include #include int main() { std::find(std::istreambuf_iterator(std::cin), std::istreambuf_iterator(), '\n'); return 0; } The symbols are in the .so but unexported. Likely

[v3] add doxygen comments to deleted functions

2011-05-25 Thread Jonathan Wakely
As discussed recently on the libstdc++ list ... 2011-05-26 Jonathan Wakely * include/std/mutex: Add doxygen comments. Tested x86_64-linux and committed to trunk Index: include/std/mutex === --- include/std/mutex (revis

Re: Patch committed: Fix erasing with reference in old hashtable code

2011-05-25 Thread Paolo Carlini
On 05/26/2011 01:09 AM, Ian Lance Taylor wrote: This patch fixes a problem with the old hashtable::erase code when the caller passes a reference to an element in the table, the element is not the first in the bucket, but it is equal to the first in the bucket. This is PR 49060, and the patch and

[v3] fix comments

2011-05-25 Thread Jonathan Wakely
This patch fixes a load of spelling mistakes in comments, so my inner pedant can sleep at night ;) 2011-05-26 Jonathan Wakely * libsupc++/guard.cc: Fix comments. No code changes, but tested anyway on x86_64-linux, committed to trunk Index: libsupc++/guard.cc =

Re: Create common hooks structure shared between driver and cc1

2011-05-25 Thread Mike Stump
On May 25, 2011, at 3:37 PM, Joseph S. Myers wrote: > On Wed, 25 May 2011, Mike Stump wrote: > >> On May 25, 2011, at 12:21 PM, Joseph S. Myers wrote: >>> Here is a revised version of my patch >> >> So, don't know why, but g++'s link line doesn't have libcommon-target.a >> on it for me, which re

Patch committed: Fix erasing with reference in old hashtable code

2011-05-25 Thread Ian Lance Taylor
This patch fixes a problem with the old hashtable::erase code when the caller passes a reference to an element in the table, the element is not the first in the bucket, but it is equal to the first in the bucket. This is PR 49060, and the patch and test case are from that PR with minor tweaks. Boo

Re: RFA: another patch to solve PR49154

2011-05-25 Thread Hans-Peter Nilsson
On Wed, 25 May 2011, Vladimir Makarov wrote: > This patch solves http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49154 for CRIS. > The problem was in that the pressure classes did not contain SRP register and > the assert failed. I'm not sure I understand the basic requirement. > OK to commit? > > 2

Re: PING: PATCH: PR rtl-optimization/48575: RTL vector patterns are limited to 26 elements

2011-05-25 Thread Bernd Schmidt
On 05/25/2011 08:33 PM, Richard Sandiford wrote: > + subpos2_ptr = &pos->xvecexp0s; > for (j = 0; j < XVECLEN (pattern, i); j++) > { > + subpos2 = next_position (subpos2_ptr, pos, POS_XVECEXP0, j); > sub = add_to_sequence (XVECEXP (pattern, i,

Re: Create common hooks structure shared between driver and cc1

2011-05-25 Thread Joseph S. Myers
On Wed, 25 May 2011, Mike Stump wrote: > On May 25, 2011, at 12:21 PM, Joseph S. Myers wrote: > > Here is a revised version of my patch > > So, don't know why, but g++'s link line doesn't have libcommon-target.a > on it for me, which results in a build failure. I've tried removing > files, rec

Re: Create common hooks structure shared between driver and cc1

2011-05-25 Thread Mike Stump
On May 25, 2011, at 12:21 PM, Joseph S. Myers wrote: > Here is a revised version of my patch So, don't know why, but g++'s link line doesn't have libcommon-target.a on it for me, which results in a build failure. I've tried removing files, reconfiguring and haven't figured it out. Any ideas?

Re: Cgraph thunk reorg

2011-05-25 Thread Jan Hubicka
> Honza, > > After we debugged this offline, I assume that you applied a version of > the patch to trunk? Hi, sorry, there was a miscommunication. I was still waiting for a confirmation that the patch works and I do not recall receiving any. I was not waiting very actively, I must admit, since I

Re: PING: PATCH: PR rtl-optimization/48575: RTL vector patterns are limited to 26 elements

2011-05-25 Thread Mike Stump
On May 25, 2011, at 1:33 PM, Richard Sandiford wrote: > OK, I suppose I should back my objection up with a patch. I like that... :-) > Is it OK to remove the static forward declarations too? I like reordering and removing static forwards in general, maybe I'm just weird. Thanks for work, here'

Re: [PATCH] Fix TBAA disambiguation in ptr-vs-decl

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 8:19 AM, Richard Guenther wrote: > > The code uses bogus offsets which shows when applying a patch > to fix PR48702.  This patch also includes some cleanup that I > had pending locally which failed to bootstrap at some point > probably because of exactly that issue ... > >

RFA: another patch to solve PR49154

2011-05-25 Thread Vladimir Makarov
This patch solves http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49154 for CRIS. The problem was in that the pressure classes did not contain SRP register and the assert failed. OK to commit? 2011-05-25 Vladimir Makarov PR rtl-optimization/49154 * config/cris/cris.h (reg_class

RFA: a patch for PR49154

2011-05-25 Thread Vladimir Makarov
The following patch solves problem http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49154 for SPARC. SPARC FPCC registers were excluded from pressure classes because the movement between them is costly. Therefore the assert was triggered again. Common logic says that it should be a pressure class

Re: PING: PATCH: PR rtl-optimization/48575: RTL vector patterns are limited to 26 elements

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 1:33 PM, Richard Sandiford wrote: > "H.J. Lu" writes: >> On Wed, May 25, 2011 at 7:47 AM, Richard Sandiford >> wrote: >>> "H.J. Lu" writes: No one is listed to review genrecog.c.  Could global reviewers comment on my patch? >>> >>> FWIW, one argument against th

Re: Patch for libobjc/38307

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 11:54 AM, Nicola Pero wrote: > I committed to trunk this libobjc patch by Richard Frith-Macdonald and David > Ayers. > The patch fixes some rare (but serious) problems with +initialize in > multithreading > programs.  It's complicated and I refer to > >  http://gcc.gnu.or

[trans-mem] Beginning of refactoring

2011-05-25 Thread Torvald Riegel
Here's the beginning of a refactoring aimed at being able to merge more TM algorithms later on. Patch 1: Just a straightfoward rename to make it clear that we're dispatching on the level of ABI calls, not internals. Patch 2: _ITM_dropReferences is not sufficiently defined in the ABI. It seems to

Re: Create common hooks structure shared between driver and cc1

2011-05-25 Thread Joseph S. Myers
On Wed, 25 May 2011, Tom Tromey wrote: > I believe the bugs referenced here were the problem: > > http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01680.html > > Both these bugs use .INTERMEDIATE in their test cases, but it isn't > clear to me that this is a sufficient condition. The problem is

Re: PING: PATCH: PR rtl-optimization/48575: RTL vector patterns are limited to 26 elements

2011-05-25 Thread Richard Sandiford
"H.J. Lu" writes: > On Wed, May 25, 2011 at 7:47 AM, Richard Sandiford > wrote: >> "H.J. Lu" writes: >>> No one is listed to review genrecog.c.  Could global reviewers comment >>> on my patch? >> >> FWIW, one argument against this form of the change: >> >> http://gcc.gnu.org/ml/gcc-patches/2011-

Re: RFA: patch to fix PR48971

2011-05-25 Thread Vladimir Makarov
On 05/25/2011 04:26 PM, Eric Botcazou wrote: Thanks for reporting this. It was a very sensitive change therefore I checked so many targets (about 10) but apparently not all of them. I'll look at the CRIS problem tomorrow. This broke SPARC (in default mode) as well: eric@atlantis:~/build/gcc/s

Re: RFA: patch to fix PR48971

2011-05-25 Thread Eric Botcazou
> Thanks for reporting this. It was a very sensitive change therefore I > checked so many targets (about 10) but apparently not all of them. I'll > look at the CRIS problem tomorrow. This broke SPARC (in default mode) as well: eric@atlantis:~/build/gcc/sparc-sun-solaris2.9> cat t.c int main (vo

Re: Create common hooks structure shared between driver and cc1

2011-05-25 Thread Tom Tromey
> "Joseph" == Joseph S Myers writes: Joseph> dependencies. For the latter, I looked again at Tom's reverted patch Joseph> from March 2008 to use automatic dependency generation. Although Joseph> there is now a fixed GNU make release (since last July), and although Joseph> I'd like to see au

C++ PATCH for c++/44311 (scoped enum and switch)

2011-05-25 Thread Jason Merrill
The C++ standard specifies that case values are implicitly converted to the type of the switch condition, but we weren't doing that. As a result, we weren't getting the appropriate errors about converting to/from scoped enum. This patch also fixes use of constexpr conversion operators in case

Re: C++ PATCH for c++/45698 (crash with variadics)

2011-05-25 Thread Jason Merrill
On 05/25/2011 03:56 PM, Nathan Froyd wrote: * cp-tree.h (struct tree_argument_pack_select): Inherit from tree_base. OK if it passes testing. Jason

Re: C++ PATCH for c++/45698 (crash with variadics)

2011-05-25 Thread Nathan Froyd
On 05/25/2011 03:45 PM, Jason Merrill wrote: > While looking at this, I also noticed that print_node expects everything to > have TREE_TYPE, which is no longer correct. Technically, I think this is not true; everything inherits from tree_common; or at least tree_typed. (I had the bit of print_nod

[PATCH, i386]: Introduce *_maskcmp3_comm to handle commutative compares

2011-05-25 Thread Uros Bizjak
Hello! Some SSE "maskcmp" compares are commutative, so we can use % operand modifier in these cases. The patched gcc generates one movaps less for the testcase of PR49133. 2011-05-25 Uros Bizjak * config/i386/sse.md (*_maskcmp3_comm): New pattern. Tested on x86_64-pc-linux-gnu {, -m

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Basile Starynkevitch
On Wed, 25 May 2011 12:31:17 -0700 "H.J. Lu" wrote: > On Wed, May 25, 2011 at 12:17 PM, Basile Starynkevitch > wrote: > > Perhaps the doc might explain why is it necessary to have a builtin for > > two independent roles: first, the full compiler memory barrier (which > > probably means to spill

[PATCH, testsuite] Additional tests for PR46728 (PR46728 patch 4)

2011-05-25 Thread William J. Schmidt
Since I'm in process of moving the lowering of pow and powi calls from expand into gimple, I wrote some tests to improve coverage in this area. Most of these look for specific code generation patterns in PowerPC assembly where the existence of a hardware floating square root can be guaranteed. Thi

C++ PATCH for c++/45698 (crash with variadics)

2011-05-25 Thread Jason Merrill
45698 was actually fixed in 4.5.0, but before I closed it I checked to see how the testcase was doing with the current compiler, and found that it was crashing again. This turned out to be because of Nathan's recent tree-slimming work; ARGUMENT_PACK_SELECT doesn't have TREE_TYPE, so we crash w

C++ PATCHes for c++/46245 and c++/46145 (auto issues)

2011-05-25 Thread Jason Merrill
In 46245, we were complaining too soon about an auto parameter; we need to wait until after we splice in a late-specified return type. In 46145, we were failing to complain about an auto typedef. Tested x86_64-pc-linux-gnu, applying to trunk. commit 0ca632627d749d168b602675ca48df9e88a1eac5 Aut

C++ PATCH for c++/47184 (list-initialized temporary in parenthesized initializer)

2011-05-25 Thread Jason Merrill
cp_parser_parameter_declaration is clever enough to tell that when we see Type1 id(Type2 if the next token doesn't indicate a cast, we're dealing with a function declarator. But it was only checking for '('; now it needs to check for '{' as well. After making that fix, I needed to change cp

C++ PATCH for c++/46696 (error with defaulted op= and arrays)

2011-05-25 Thread Jason Merrill
Another case where we now need to check DECL_DEFAULTED_FN rather than DECL_ARTIFICIAL. Tested x86_64-pc-linux-gnu, applying to trunk. commit 3ac89bd9f5f81b4d3ff293b337e7e9163d3402dd Author: Jason Merrill Date: Wed May 25 12:05:03 2011 -0400 PR c++/46696 * typeck.c (cp_build_modify_

Re: PATCH: Add pause intrinsic

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 12:17 PM, Basile Starynkevitch wrote: > On Wed, 25 May 2011 11:26:51 +0100 > Andrew Haley wrote: > >> On 05/24/2011 07:28 PM, H.J. Lu wrote: >> >> > This patch implements pause intrinsic suggested by Andi.  OK >> > for trunk? >> >> What does "full memory barrier" here mean

Re: PATCH: PR target/49142: Invalid 8bit register operand

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 12:11 PM, Uros Bizjak wrote: > On Wed, May 25, 2011 at 6:20 PM, H.J. Lu wrote: > >> We are working on a new optimization, which turns off TARGET_MOVX. >> GCC generates: >> >> movb %ah, %dil >> >> But %ah can only be used with %[abcd][hl].  This patc

Re: [PATCH][4.6] detect C++ errors to fix 2288 and 18770

2011-05-25 Thread Nathan Froyd
On Sun, May 22, 2011 at 03:25:41PM -0700, H.J. Lu wrote: > FWIW, I tried Janis's patch on 4.6 branch and I got > > /export/gnu/import/git/gcc/gcc/testsuite/g++.dg/parse/pr18770.C: In > function 'void e1()':^M > /export/gnu/import/git/gcc/gcc/testsuite/g++.dg/parse/pr18770.C:29:11: > error: redecla

Re: Create common hooks structure shared between driver and cc1

2011-05-25 Thread Joseph S. Myers
Here is a revised version of my patch to create the common hooks structure. Tested in the same way as the original patch. OK to commit? In the course of working on moving hooks to the new structure, I found that every target architecture

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Basile Starynkevitch
On Wed, 25 May 2011 11:26:51 +0100 Andrew Haley wrote: > On 05/24/2011 07:28 PM, H.J. Lu wrote: > > > This patch implements pause intrinsic suggested by Andi. OK > > for trunk? > > What does "full memory barrier" here mean? > > +@table @code > +@item void __builtin_ia32_pause (void) > +Genera

Re: PATCH: PR target/49142: Invalid 8bit register operand

2011-05-25 Thread Uros Bizjak
On Wed, May 25, 2011 at 6:20 PM, H.J. Lu wrote: > We are working on a new optimization, which turns off TARGET_MOVX. > GCC generates: > > movb %ah, %dil > > But %ah can only be used with %[abcd][hl].  This patch adds QIreg_operand > and uses it in *movqi_extv_1_rex64/*

[PATCH, rs6000] Tidy up dumping of register/memory move cost

2011-05-25 Thread Pat Haugen
The following fixes a problem when dumping register costs, where the incorrect 'from' value was being written out because the code modified the incoming parameter value. It also changes things so that register/memory costs are only dumped on the outermost call, eliminating intermediate output wh

Patch for libobjc/38307

2011-05-25 Thread Nicola Pero
I committed to trunk this libobjc patch by Richard Frith-Macdonald and David Ayers. The patch fixes some rare (but serious) problems with +initialize in multithreading programs. It's complicated and I refer to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38307 for more information. I approve

Re: [PATCH PING] unreviewed tree-slimming patches

2011-05-25 Thread Nathan Froyd
On 05/25/2011 02:06 PM, Tom Tromey wrote: >> "Nathan" == Nathan Froyd writes: > > Nathan> (C, Java, middle-end) > Nathan> [PATCH 18/18] make TS_BLOCK a substructure of TS_BASE > Nathan> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00564.html > > The Java parts are ok. > > I think thes

Re: [PATCH PING] unreviewed tree-slimming patches

2011-05-25 Thread Tom Tromey
> "Nathan" == Nathan Froyd writes: Nathan> (C, Java, middle-end) Nathan> [PATCH 18/18] make TS_BLOCK a substructure of TS_BASE Nathan> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00564.html The Java parts are ok. I think these sorts of changes should be obvious once approved from a m

Re: [testsuite] remove XFAIL for all but ia64 for g++.dg/tree-ssa/pr43411.C

2011-05-25 Thread Mike Stump
On May 25, 2011, at 1:38 AM, Rainer Orth wrote: > Janis Johnson writes: > >> Archived test results for 4.7.0 for most processors with C++ results have: >> >> XPASS: g++.dg/tree-ssa/pr43411.C scan-tree-dump-not optimized "OBJ_TYPE_REF" >> >> The only failures I could find were for ia64-linux and

[v3] Small tweak to std::random_device

2011-05-25 Thread Paolo Carlini
Hi, committed to mainline. Thanks, Paolo. / 2011-05-25 Paolo Carlini * include/bits/random.h (random_device::min, max): Specify constexpr. Index: include/bits/random.h === --- include/bits/random.h

[pph] Reformat (issue4515140)

2011-05-25 Thread Lawrence Crowl
In pph_stream_read_tree and pph_stream_write_tree, reformat for style. This step was skipped in the last patch to make diffs more sensible. Index: gcc/cp/ChangeLog.pph 2011-05-25 Lawrence Crowl * pph-streamer-in.c (pph_stream_read_tree): Reformat for style. * pph-streamer-out.

[PATCH] More pow(x,c) expansions in cse_sincos pass (PR46728, patch 3)

2011-05-25 Thread William J. Schmidt
This patch adds logic to gimple_expand_builtin_pow () to optimize pow(x,y), where y is one of 0.5, 0.25, 0.75, 1./3., or 1./6. I noticed that there were two missing calls to gimple_set_location () in my previous patch, so I've corrected those here as well. There's one TODO comment in this patch.

Re: Go patch committed: Update to current Go library

2011-05-25 Thread Rainer Orth
Ian Lance Taylor writes: > I just committed a patch to godump.c which I think should fix this > issue. Let me know if it doesn't. There are several issues now: * While I get // var ___iob [59+1]___FILE now, there's still var __lastbuf *_FILE left, with commented // type _FILE struct {

Re: [patch, ARM] Fix PR42017, LR not used in leaf functions

2011-05-25 Thread Chung-Lin Tang
On 2011/5/20 07:46 PM, Chung-Lin Tang wrote: > On 2011/5/20 下午 07:41, Ramana Radhakrishnan wrote: >> On 17/05/11 14:10, Chung-Lin Tang wrote: >>> On 2011/5/13 04:26 PM, Richard Sandiford wrote: Richard Sandiford writes: > Chung-Lin Tang writes: >> My fix here simply adds 'reload_comp

Re: More fixes from static analysis checkers

2011-05-25 Thread Jakub Jelinek
On Thu, Mar 24, 2011 at 03:52:57PM -0600, Jeff Law wrote: > We had a variety of functions which would fail to call va_end prior to > returning. I'm not aware of a host were this could cause a problem, but > it's easy enough to fix and keeps the checkers quiet. In case of def_fn_type, this added a

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Andrew Haley
On 05/25/2011 06:26 PM, Andrew Pinski wrote: > On Wed, May 25, 2011 at 10:19 AM, H.J. Lu wrote: >> -- >> H.J. >> --- >> Index: doc/extend.texi >> === >> --- doc/extend.texi (revision 174216) >> +++ doc/extend.texi (working cop

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Andrew Pinski
On Wed, May 25, 2011 at 10:19 AM, H.J. Lu wrote: > -- > H.J. > --- > Index: doc/extend.texi > === > --- doc/extend.texi     (revision 174216) > +++ doc/extend.texi     (working copy) > @@ -8699,7 +8699,8 @@ The following built-in func

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-25 Thread Xinliang David Li
Fair enough. Richard? Thanks, David On Wed, May 25, 2011 at 9:53 AM, Joseph S. Myers wrote: > On Wed, 25 May 2011, Xinliang David Li wrote: > >> Ping. The link to the message: >> >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01303.html > > I don't consider this an option handling patch.  Pat

[PATCH] Fix VRP switch handling (PR tree-optimization/49161)

2011-05-25 Thread Jakub Jelinek
Hi! The following testcase is miscompiled, because there are multiple CASE_LABELs for the same target bb in a switch: : switch (x_1(D)) , case 3: l4, case 4: l1, case 6: l3> l3: bar (-1); l2: l1: l4: bar (0); find_switch_asserts sorts by uids of CASE_LABELs and adds x_1(D) == 4 as well as

Re: PATCH: Add pause intrinsic

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 9:43 AM, Andrew Haley wrote: > On 05/25/2011 04:32 PM, H.J. Lu wrote: >> On Wed, May 25, 2011 at 8:27 AM, Richard Guenther >> wrote: >>> On Wed, May 25, 2011 at 5:20 PM, Michael Matz wrote: Hi, On Wed, 25 May 2011, Richard Guenther wrote: >>> asm v

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-25 Thread Joseph S. Myers
On Wed, 25 May 2011, Xinliang David Li wrote: > Ping. The link to the message: > > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01303.html I don't consider this an option handling patch. Patches adding whole new features involving new options should be reviewed by maintainers for the part of

Re: [PATCH PING] unreviewed tree-slimming patches

2011-05-25 Thread Joseph S. Myers
On Wed, 25 May 2011, Nathan Froyd wrote: > These patches: > > (C, C++, middle-end) > [PATCH 14/18] move TS_STATEMENT_LIST to be a substructure of TS_TYPED > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00560.html > > (C, Java, middle-end) > [PATCH 18/18] make TS_BLOCK a substructure of

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Andrew Haley
On 05/25/2011 04:32 PM, H.J. Lu wrote: > On Wed, May 25, 2011 at 8:27 AM, Richard Guenther > wrote: >> On Wed, May 25, 2011 at 5:20 PM, Michael Matz wrote: >>> Hi, >>> >>> On Wed, 25 May 2011, Richard Guenther wrote: >>> >> asm volatile ("" : : : "memory") in fact will work as a full memory >

Re: Prefixes for libgcc symbols (C6X 9.5/11)

2011-05-25 Thread Bernd Schmidt
On 05/25/2011 04:38 PM, H.J. Lu wrote: > On Wed, May 25, 2011 at 6:52 AM, Bernd Schmidt > wrote: >> Anyhow, below is one possible way of fixing it. > > It fixed the libgcc failure. Can you check it in? I suppose it is reasonably obvious. Done. Bernd

Re: Prefixes for libgcc symbols (C6X 9.5/11)

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 6:52 AM, Bernd Schmidt wrote: > On 05/25/2011 01:45 PM, H.J. Lu wrote: >> On Wed, May 25, 2011 at 6:42 AM, Bernd Schmidt >> wrote: >>> On 05/25/2011 01:37 PM, H.J. Lu wrote: >>> I think it may have caused: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49160 >

Re: RFA PR 48770

2011-05-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/25/11 06:40, Bernd Schmidt wrote: > I've looked at code generation; it appears unchanged on i686-linux, > which I think is the expected result. There are minor differences in > assembly output on mips64-linux. If you want to look at it, I'm > at

Re: PATCH: PR target/49142: Invalid 8bit register operand

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 8:30 AM, Uros Bizjak wrote: > On Wed, May 25, 2011 at 4:42 PM, H.J. Lu wrote: >> On Wed, May 25, 2011 at 7:00 AM, Uros Bizjak wrote: >>> On Tue, May 24, 2011 at 5:54 PM, H.J. Lu wrote: Hi, We are working on a new optimization, which turns off TARGET_MOVX.

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-25 Thread Xinliang David Li
Ping. The link to the message: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01303.html Thanks, David On Sun, May 22, 2011 at 4:17 PM, Xinliang David Li wrote: > Ping. > > David > > > On Fri, May 20, 2011 at 9:06 AM, Xinliang David Li wrote: >> Ok to check in this one? >> >> Thanks, >> >> Davi

Re: RFA PR 48770

2011-05-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/25/11 06:40, Bernd Schmidt wrote: > >> >> The code in question is literally 20 years old and predates running any >> real dead code elimination after reload. ISTM the right thing to do is >> stop using delete_dead_insn in this code and let the p

Re: [SPARC] Disable -fira-share-save-slots by default

2011-05-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/24/11 16:30, Eric Botcazou wrote: > The new save slot sharing algorithm has a documented limitation: > >Future work: > > In the fallback case we should iterate backwards across all possible > modes for the save, choosing the large

Re: PATCH: Add pause intrinsic

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 8:27 AM, Richard Guenther wrote: > On Wed, May 25, 2011 at 5:20 PM, Michael Matz wrote: >> Hi, >> >> On Wed, 25 May 2011, Richard Guenther wrote: >> >>> >> asm volatile ("" : : : "memory") in fact will work as a full memory >>> >> barrier >>> > >>> > How?  You surely need

Re: Fix PR 49014

2011-05-25 Thread Bernd Schmidt
On 05/25/2011 03:29 PM, Andrey Belevantsev wrote: > I think the hook is a better idea than the attribute because nobody will > care to mark all offending insns with an attribute. I don't know. IIRC when I looked at sh or whatever the broken port was, it was only two insns - there would still be so

Re: PATCH: PR target/49142: Invalid 8bit register operand

2011-05-25 Thread Uros Bizjak
On Wed, May 25, 2011 at 4:42 PM, H.J. Lu wrote: > On Wed, May 25, 2011 at 7:00 AM, Uros Bizjak wrote: >> On Tue, May 24, 2011 at 5:54 PM, H.J. Lu wrote: >>> Hi, >>> >>> We are working on a new optimization, which turns off TARGET_MOVX. >>> GCC generates: >>> >>> movb %ah, %dil >>> >>> But %ah ca

Re: Fix PR 49014

2011-05-25 Thread Andrey Belevantsev
On 25.05.2011 18:41, Bernd Schmidt wrote: On 05/25/2011 08:21 AM, Andrey Belevantsev wrote: Vlad, Bernd, I wonder if we can avoid having recog_memoized>=0 insns that do not have proper DFA reservations (that is, they do not change the DFA state). I see that existing practice allows this as sho

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Richard Guenther
On Wed, May 25, 2011 at 5:20 PM, Michael Matz wrote: > Hi, > > On Wed, 25 May 2011, Richard Guenther wrote: > >> >> asm volatile ("" : : : "memory") in fact will work as a full memory >> >> barrier >> > >> > How?  You surely need MFENCE or somesuch, unless all you care about is >> > a compiler bar

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Michael Matz
Hi, On Wed, 25 May 2011, Richard Guenther wrote: > >> asm volatile ("" : : : "memory") in fact will work as a full memory > >> barrier > > > > How?  You surely need MFENCE or somesuch, unless all you care about is > > a compiler barrier.  That's what I think needs to be clarified. > > Well, ye

[PATCH] Fix TBAA disambiguation in ptr-vs-decl

2011-05-25 Thread Richard Guenther
The code uses bogus offsets which shows when applying a patch to fix PR48702. This patch also includes some cleanup that I had pending locally which failed to bootstrap at some point probably because of exactly that issue ... Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.

Re: [testsuite] ignore irrelevant warning in two ARM tests

2011-05-25 Thread Janis Johnson
On 05/24/2011 05:49 PM, Mike Stump wrote: > On May 24, 2011, at 3:42 PM, Janis Johnson wrote: Is this one OK for trunk and 4.6? The failure occurs for arm-none-eabi and for arm-none-linux-gnueabi. >>> >>> You should repeat all the original options from the main dg-options line, >>> with

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Richard Guenther
On Wed, May 25, 2011 at 5:09 PM, Andrew Haley wrote: > On 05/25/2011 03:57 PM, Richard Guenther wrote: >> >> asm volatile ("" : : : "memory") in fact will work as a full memory barrier > > How?  You surely need MFENCE or somesuch, unless all you > care about is a compiler barrier.  That's what I t

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Andrew Haley
On 05/25/2011 03:57 PM, Richard Guenther wrote: > > asm volatile ("" : : : "memory") in fact will work as a full memory barrier How? You surely need MFENCE or somesuch, unless all you care about is a compiler barrier. That's what I think needs to be clarified. Andrew.

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Richard Guenther
On Wed, May 25, 2011 at 4:54 PM, Andrew Haley wrote: > On 05/25/2011 03:47 PM, H.J. Lu wrote: >> On Wed, May 25, 2011 at 7:36 AM, Andrew Haley wrote: >>> On 05/25/2011 01:34 PM, H.J. Lu wrote: On Wed, May 25, 2011 at 3:26 AM, Andrew Haley wrote: > On 05/24/2011 07:28 PM, H.J. Lu wrote:

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Andrew Haley
On 05/25/2011 03:47 PM, H.J. Lu wrote: > On Wed, May 25, 2011 at 7:36 AM, Andrew Haley wrote: >> On 05/25/2011 01:34 PM, H.J. Lu wrote: >>> On Wed, May 25, 2011 at 3:26 AM, Andrew Haley wrote: On 05/24/2011 07:28 PM, H.J. Lu wrote: > This patch implements pause intrinsic suggested b

Re: PATCH: Add pause intrinsic

2011-05-25 Thread Richard Guenther
On Wed, May 25, 2011 at 4:47 PM, H.J. Lu wrote: > On Wed, May 25, 2011 at 7:36 AM, Andrew Haley wrote: >> On 05/25/2011 01:34 PM, H.J. Lu wrote: >>> On Wed, May 25, 2011 at 3:26 AM, Andrew Haley wrote: On 05/24/2011 07:28 PM, H.J. Lu wrote: > This patch implements pause intrinsic s

Re: PING: PATCH: PR rtl-optimization/48575: RTL vector patterns are limited to 26 elements

2011-05-25 Thread H.J. Lu
On Wed, May 25, 2011 at 7:47 AM, Richard Sandiford wrote: > "H.J. Lu" writes: >> No one is listed to review genrecog.c.  Could global reviewers comment >> on my patch? > > FWIW, one argument against this form of the change: > > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02159.html > What you s

[Patch ARM] Actually generate vorn and vbic instructions.

2011-05-25 Thread Ramana Radhakrishnan
Hi, A co-worker pointed out that we weren't generating vorn and vbic instructions for Neon and I had a look. Tests are still running and will commit to trunk if there are no regressions. cheers Ramana 2011-05-25 Ramana Radhakrishnan * config/arm/neon.md ("orn3_neon"): Canonical

Re: PING: PATCH: PR rtl-optimization/48575: RTL vector patterns are limited to 26 elements

2011-05-25 Thread Richard Sandiford
"H.J. Lu" writes: > No one is listed to review genrecog.c. Could global reviewers comment > on my patch? FWIW, one argument against this form of the change: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02159.html Richard

  1   2   >