Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 17:
Thanks everyone!
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/setting
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/9183/
: SUCCES
Vojtech Szocs has submitted this change and it was merged.
Change subject: engine: root.war cleanup
..
engine: root.war cleanup
- Fixed minor text issue in message, replaced 'pack'
with the word documentation to be more consi
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 17: Verified+1 Code-Review+2
Merging based on previous acks.
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscri
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 17:
Rebased (no changes since last time).
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://ge
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 16: Code-Review+1
Thank you! and sorry /me/ delaying...
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, vi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/9158/
: SUCCES
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 16: Verified+1
Renamed
- applicationType to obrandApplicationName
- branding-path to obrandThemePath
- branding-resource-p
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15:
I think that branding prefix has value for branding module interface.
--
To view, visit http://gerrit.ovirt.org/19848
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15:
I vote for applicationName or applicationId :-)
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15:
applicationName, applicationId, brandingId, brandingPrefix, brandingApplication?
--
To view, visit http://gerrit.ovirt
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15:
Well search and replace is simple to do, if you have a better name, I am not
married to application type.
--
To vie
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15:
Thank you all!
Alexander... one minor note... I think application type is not good name for
the application name or ap
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13:
(3 comments)
File
backend/manager/modules/root/src/main/java/org
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15:
(1 comment)
File
frontend/webadmin/modules/frontend/src/test/jav
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15: Verified+1
applicationType is now only looked up in the branding filter (the only place
that should really care). Als
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/9121/
: SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/9120/
: SUCCES
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13:
(9 comments)
File
backend/manager/modules/branding/src/main/jav
Vojtech Szocs has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13:
(12 comments)
Quite a big patch, there are some very nice ideas, comments inline.
...
Greg Sheremeta has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13: Code-Review+1
(1 comment)
+1, very nice patch.
File backend/man
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13: Verified+1
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13:
we will handle the module in different patch, most probably best method is to
pre-compile jsps.
--
To view, visit htt
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 14: Verified-1
draft so you can delete of initial work of converting this to module.
apearantally, jboss does not support t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8954/
: SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8953/
: SUCCES
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 13:
fixup for resetapi to work
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8952/
: SUCCES
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 11: Verified+1
Juan,
I added a new module in this patch 'branding' and I am wondering what I need to
do to make this a '
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 10:
(1 comment)
File backend/manager/modules/root/src/main/webapp/WE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8950/
: SUCCES
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 10:
(1 comment)
File backend/manager/modules/root/src/main/webapp/WEB-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8949/
: SUCCES
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 10: Verified+1
Fixed last issues noted by Alon.
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 9:
(3 comments)
BEAUTIFUL!
Some minor questions...
And you need also to update the spec file, find:
# Move jars to dest
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 9: Verified+1
Moved all branding logic into a branding package.
Added applicationType to the web.xml so it is based on the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8941/
: SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 8:
(1 comment)
it is much better than what we have, and I continue to push a little to may
have something that is more reu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8767/
: SUCCESS
Alexander Wels has posted comments on this change.
Change subject: engine: root.war cleanup
..
Patch Set 7:
(3 comments)
File backend/manager/modules/root/src/main/webapp/40
43 matches
Mail list logo
