Vojtech Szocs has posted comments on this change.

Change subject: engine: root.war cleanup
......................................................................


Patch Set 15:

(1 comment)

....................................................
File 
frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java
Line 90:         when(mockSession.getId()).thenReturn("sessionId"); 
//$NON-NLS-1$
Line 91:         when(mockUser.getId()).thenReturn(Guid.newGuid());
Line 92:         when(mockUser.getLoginName()).thenReturn("admin"); 
//$NON-NLS-1$
Line 93:         when(mockUser.getDomain()).thenReturn("internal"); 
//$NON-NLS-1$
Line 94:         when(mockBrandingManager.getBrandingThemes()).thenReturn(new 
ArrayList<BrandingTheme>()); //$NON-NLS-1$
This NON-NLS flag isn't needed anymore, I'll remove it before merging.
Line 95:         stubGetUserBySessionIdQuery();
Line 96:         stubGetConfigurationValuePublicQuery();
Line 97:         setUpTestServlet();
Line 98:     }


-- 
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to