Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
......................................................................
Patch Set 8:
(1 comment)
it is much better than what we have, and I continue to push a little to may
have something that is more reusable.
we do not need the application hardcoded within java, see the comment in
BradningTheme.java, and remove the application set at *HostPageServlet.java
also, I would like to be able to use the tags in other wars, can we pack it
somehow within common?
I could not find where... but the /theme should also be extracted from
application context.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java
Line 36: WEBADMIN("webadmin", "web_admin_css"), //$NON-NLS-1$
//$NON-NLS-2$
Line 37: /** User portal application. */
Line 38: USER_PORTAL("userportal", "user_portal_css"), //$NON-NLS-1$
//$NON-NLS-2$
Line 39: /** Welcome page. */
Line 40: ROOT("welcome", "welcome_css"); //$NON-NLS-1 //$NON-NLS-2$
any reason why we not transparently move the name of the application?
you always have @NAME@ as prefix for messages and @NAME@_css for the css.
always extract @NAME@ from context, and set this @NAME@ in web.xml within the
webadmin and user portal, along with the branding path context parameter.
Line 41:
Line 42: /**
Line 43: * Prefix associated with application type.
Line 44: */
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
