Alon Bar-Lev has posted comments on this change.

Change subject: engine: root.war cleanup
......................................................................


Patch Set 14: Verified-1

draft so you can delete of initial work of converting this to module.

apearantally, jboss does not support tld file within a module, or at least this 
what I understood. putting obrand.tld into WEB-INF does make a progress, but 
then the tags within the jars are not found.

I tried several combinations, but failed.

I believe that pre-compiling the jsps will solve all these issues in much 
cleaner way, as we do not need runtime jsp compilation nor runtime tag 
libraries.

-- 
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to