[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-22 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/8502/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: VdsManager - cleanup .. core: VdsManager - cleanup * separate fields from methods * encapsulate important parts into methods * extract interface from

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16605/ : SUCCESS htt

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 13: @Oved @Pioter I've removed the change for the Transport Factory and the rest of unrelated stuff @Omer I think this coul

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16583/ : SUCCESS htt

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-11 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27374/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-10 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27374/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/cor

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/15857/ : SUCCESS htt

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-08 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 10: since creating the xmlRpc connection is not part of vds manager anymore, i think you can remove that part -- To vie

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32570/ : SUC

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32544/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-08 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: (4 comments) http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vd

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-09-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-24 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: looks ok, except comments from other reviewers -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-24 Thread lzelkha
Liran Zelkha has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-24 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: (3 comments) Overall looks good to me. I'd use the opportunity to make code more standard. http://gerrit.ovirt.org/#/

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-13 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vds

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-09 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11844/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-07 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11737/ : SUCCESS http://j

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-07 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11721/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-07-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-21 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8515/ : FAILURE http://j

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Che

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8351/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8345/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Che

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Che

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8332/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Che

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-14 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27374/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/7

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-05 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: VdsManager - cleanup .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Che

[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - cleanup

2014-05-05 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: VdsManager - cleanup .. core: VdsManager - cleanup * seperate fields from methods * encapsulate important parts into methods * extract interface from importan