Roy Golan has posted comments on this change. Change subject: core: VdsManager - cleanup ......................................................................
Patch Set 8: (4 comments) http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 65: import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSRecoveringException; Line 66: import org.ovirt.engine.core.vdsbroker.vdsbroker.VdsServerWrapper; Line 67: import org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcUtils; Line 68: Line 69: public class VdsManager { > general comment: how about renaming the vds to host in this context ? I am changing VURTI to HostMonitoring and create a new VmsMonitoring I'm in for renaming but for the sake of minimizing the change's scope I'll definitely do it in a separate patch-set Line 70: private static Log log = LogFactory.getLog(VdsManager.class); Line 71: private static Map<Guid, String> recoveringJobIdMap = new ConcurrentHashMap<Guid, String>(); Line 72: private final int _numberRefreshesBeforeSave = Config.<Integer> getValue(ConfigValues.NumberVmRefreshesBeforeSave); Line 73: private final Object _lockObj = new Object(); Line 68: Line 69: public class VdsManager { Line 70: private static Log log = LogFactory.getLog(VdsManager.class); Line 71: private static Map<Guid, String> recoveringJobIdMap = new ConcurrentHashMap<Guid, String>(); Line 72: private final int _numberRefreshesBeforeSave = Config.<Integer> getValue(ConfigValues.NumberVmRefreshesBeforeSave); > Since the IoC is merged - why not inject the Config? can do with Injector.java altough VdsManager.java isn't a managed bean. since not critic for this change-set I'll defer it for now. Line 73: private final Object _lockObj = new Object(); Line 74: private final AtomicInteger mFailedToRunVmAttempts; Line 75: private final AtomicInteger mUnrespondedAttempts; Line 76: private final AtomicBoolean sshSoftFencingExecuted; Line 87: private MonitoringStrategy monitoringStrategy; Line 88: private EngineLock monitoringLock; Line 89: private int VDS_DURING_FAILURE_TIMEOUT_IN_MINUTES = Config Line 90: .<Integer> getValue(ConfigValues.TimeToReduceFailedRunOnVdsInMinutes); Line 91: private boolean privateInitialized; > remove 'private' prefix from privateInitialized will do next patch Line 92: private IVdsServer _vdsProxy; Line 93: private boolean mBeforeFirstRefresh = true; Line 94: private VdsUpdateRunTimeInfo _vdsUpdater; Line 95: Line 105: new Pair<String, String>(LockingGroup.VDS_INIT.name(), "")), null); Line 106: Line 107: handlePreviousStatus(); Line 108: handleSecureSetup(); Line 109: InitVdsBroker(); > also this one, to start with lower case. will do next patch Line 110: _vds = null; Line 111: } Line 112: Line 113: public void handleSecureSetup() { -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4062bc376d22253b045ad022c67f3f10da0b100 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
