Piotr Kliczewski has posted comments on this change. Change subject: core: VdsManager - cleanup ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java: Line 32: Line 33: public static IVdsServer createVdsServer(VdsProtocol vdsProtocol, String hostname, int port) { Line 34: IVdsServer vdsServer = null; Line 35: // Get the values of the timeouts: Line 36: int clientTimeOut = Config.<Integer> getValue(ConfigValues.vdsTimeout) * 1000; Why we want to get connection configuration in both places? Line 37: int connectionTimeOut = Config.<Integer> getValue(ConfigValues.vdsConnectionTimeout) * 1000; Line 38: int clientRetries = Config.<Integer> getValue(ConfigValues.vdsRetries); Line 39: if (VdsProtocol.STOMP == vdsProtocol) { Line 40: vdsServer = new JsonRpcVdsServer(JsonRpcUtils.createStompClient(hostname, http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java: Line 34: private final HttpClient httpClient; Line 35: Line 36: public VdsServerWrapper(String hostname, int port) { Line 37: // Get the values of the timeouts: Line 38: int clientTimeOut = Config.<Integer> getValue(ConfigValues.vdsTimeout) * 1000; Why do we want to get connection configuration in both places? Line 39: int connectionTimeOut = Config.<Integer>getValue(ConfigValues.vdsConnectionTimeout) * 1000; Line 40: int clientRetries = Config.<Integer>getValue(ConfigValues.vdsRetries); Line 41: Line 42: Pair<VdsServerConnector, HttpClient> returnValue = -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4062bc376d22253b045ad022c67f3f10da0b100 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
