Oved Ourfali has posted comments on this change. Change subject: core: VdsManager - cleanup ......................................................................
Patch Set 8: (3 comments) Overall looks good to me. I'd use the opportunity to make code more standard. http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 68: Line 69: public class VdsManager { Line 70: private static Log log = LogFactory.getLog(VdsManager.class); Line 71: private static Map<Guid, String> recoveringJobIdMap = new ConcurrentHashMap<Guid, String>(); Line 72: private final int _numberRefreshesBeforeSave = Config.<Integer> getValue(ConfigValues.NumberVmRefreshesBeforeSave); I'd also use this opportunity to remove the "_" and the mXXX and make the names here more standard. Line 73: private final Object _lockObj = new Object(); Line 74: private final AtomicInteger mFailedToRunVmAttempts; Line 75: private final AtomicInteger mUnrespondedAttempts; Line 76: private final AtomicBoolean sshSoftFencingExecuted; Line 105: new Pair<String, String>(LockingGroup.VDS_INIT.name(), "")), null); Line 106: Line 107: handlePreviousStatus(); Line 108: handleSecureSetup(); Line 109: InitVdsBroker(); also this one, to start with lower case. Line 110: _vds = null; Line 111: } Line 112: Line 113: public void handleSecureSetup() { http://gerrit.ovirt.org/#/c/27374/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java: Line 33: public static IVdsServer createVdsServer(VdsProtocol vdsProtocol, String hostname, int port) { Line 34: IVdsServer vdsServer = null; Line 35: // Get the values of the timeouts: Line 36: int clientTimeOut = Config.<Integer> getValue(ConfigValues.vdsTimeout) * 1000; Line 37: int connectionTimeOut = Config.<Integer> getValue(ConfigValues.vdsConnectionTimeout) * 1000; I'd leave the signature as is. Line 38: int clientRetries = Config.<Integer> getValue(ConfigValues.vdsRetries); Line 39: if (VdsProtocol.STOMP == vdsProtocol) { Line 40: vdsServer = new JsonRpcVdsServer(JsonRpcUtils.createStompClient(hostname, Line 41: port, connectionTimeOut, clientTimeOut, clientRetries, -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4062bc376d22253b045ad022c67f3f10da0b100 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
