Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerr
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Add console reconnect permission
..
core: Add console reconnect permission
Add an permission that allows the reconnection to the console of
virtual
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 15: Verified
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerrit.ovirt.org/set
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Add console reconnect
..
core: Add console reconnect
This patch adds the functionality to allow an user to connect to
the console of a virtual mach
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 17: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/816
To unsubscribe, visit http://gerrit.ovirt.or
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 17: Verified
--
To view, visit http://gerrit.ovirt.org/816
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 15: Looks good to me, approved
please verify it works well and nothing else breaks, then i'll merge it
--
To view, visit
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 12:
Rebased
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerrit.ovirt.org/set
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 15:
Rebased.
--
To view, visit http://gerrit.ovirt.org/816
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/816
To unsubscribe, visit http://gerrit.ovirt.or
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 11:
Rebased.
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerrit.ovirt.org/se
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 14:
Rebased and added setActionMessageParameters.
--
To view, visit http://gerrit.ovirt.org/816
To unsubscribe, visit
Livnat Peer has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 10: Looks good to me, but someone else must approve
not giving +2 just to make sure Livnat has no further comm
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 13:
yes, it wasn't there because there was no canDoAction at all, which is a bug,
but if you already added it, i would p
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageT
Livnat Peer has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/bll/sr
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 9:
Applied the changes suggested by Omer and Livnat in patch set 7.
--
To view, visit http://gerrit.ovirt.o
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 12:
Omer, do you mean adding something like this to the logon and logoff commands?
protected void setActionMessage
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 7: (4 inline comments)
File
backend/manager/modules/bl
Livnat Peer has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 7: (2 inline comments)
This change looks very close, I agree with Omer's comments and added a small
one of my
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 7: (2 inline comments)
File
backend/manager/modules/bll/
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 11:
still missing set for vm type and action in the canDoAction of VmLogoffCommand
and VmLogonCommand
--
To view, visi
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 7:
Added the database upgrade script.
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit h
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 6:
Reverted the change from private to protected in the checkUserAuthorization
method, as it is not needed
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 11:
Applied the simplification suggested by Omer.
--
To view, visit http://gerrit.ovirt.org/816
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 10: (3 inline comments)
looks good few minor comments
File
backend
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 4:
Changed the permission check according to Livnat's suggestions.
--
To view, visit http://gerrit.ovirt.or
Livnat Peer has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 2:
IIUC the requirement is that userA needs connect_to_VM permission for
connecting to VM and in addition if t
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 2:
I am adding the RESTAPI changes.
I see that in change 2689 Maor changed the "checkUserAuthorization" to
Maor Lipchuk has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 2:
Rest test BackendPermitResourceTest will fail if will merge it.
since action group RECONNECT_TO_VM should b
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 2:
I know that the permission check should be done in a different way now. Just
wanted to have everything a
Livnat Peer has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 2:
Hi Juan,
The changes Maor did enable adding a custom permissions validations.
For using it you need to overr
Juan Hernandez has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 2:
Rebased.
--
To view, visit http://gerrit.ovirt.org/995
To unsubscribe, visit http://gerrit.ovirt.org/set
35 matches
Mail list logo
