Omer Frenkel has posted comments on this change. Change subject: core: Add console reconnect ......................................................................
Patch Set 10: (3 inline comments) looks good few minor comments .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java Line 70: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM_TICKET); you can extract the above 2 lines to override a method setActionMessageParameters instead of doing this few times .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogoffCommand.java Line 27: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_EXIST); missing set to action and type vars (setActionMessageParameters) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java Line 25: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_EXIST); missing set to action and type vars (setActionMessageParameters) -- To view, visit http://gerrit.ovirt.org/816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b4725e51c9fb7070920c77e4f8ae54c5af4377b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
