Juan Hernandez has posted comments on this change. Change subject: core: Add console reconnect permission ......................................................................
Patch Set 2: I am adding the RESTAPI changes. I see that in change 2689 Maor changed the "checkUserAuthorization" to private (and it has already been merged). I understood from your previous comment that "IsUserAutorizedToRunAction" was to be changed, not "checkUserAuthorization". I can implement this functionality without overriding "IsUserAutorizedToRunAction" by moving the "canConnectToConsole" call to "canDoAction", but I can't implement it without the "checkUserAuthorization" method. Overriding "getPermissionCheckSubjects" is not an option because the logic is *or*, I mean, the user has to be able to connect to the console of a VM if the VM has the "allow_reconnect" flag *or* the user has the "reconnect_to_vm" permission. -- To view, visit http://gerrit.ovirt.org/995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I027b5ff23589b712917c78b7b799b7a3f965e61a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
