Juan Hernandez has posted comments on this change.

Change subject: core: Add console reconnect
......................................................................


Patch Set 12:

Omer, do you mean adding something like this to the logon and logoff commands?

    protected void setActionMessageParameters () {
        addCanDoActionMessage(VdcBllMessages.VAR__ACTION__...);
        addCanDoActionMessage(VdcBllMessages.VAR__TYPE__...);
    }

That was not there before the change, and apparently it worked without it. If 
this needs to be added what should be the action and the type? I can't find 
anything appropriate in the current VdcBllMessages class. Do I need to add 
something there?

--
To view, visit http://gerrit.ovirt.org/816
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b4725e51c9fb7070920c77e4f8ae54c5af4377b
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to