Keith Robertson has posted comments on this change.
Change subject: webadmin: Enable RESTAPI CSRF protection
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29850
To unsubscribe, visit http://gerrit.ovi
Keith Robertson has posted comments on this change.
Change subject: ovirt-log-collector:Fix: Ask password before engine log
collection.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28065
To unsubscr
Keith Robertson has posted comments on this change.
Change subject: ovirt-log-collector:Fix: Ask password before engine log
collection.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/28065/2/src/__main__.py
File src/
Keith Robertson has posted comments on this change.
Change subject: storage: detect localfs storage
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27391
To unsubscribe, visit http://gerrit.ovirt.org/se
Keith Robertson has posted comments on this change.
Change subject: packaging: spec: depends on python-lxml
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20609
To unsubscribe, visit http://gerrit.ovir
Keith Robertson has posted comments on this change.
Change subject: conf: use ovirt-engine-lib configfile
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20532
To unsubscribe, visit http://gerrit.ovirt.
Keith Robertson has posted comments on this change.
Change subject: Use the max=-1 option return unlimited results when calling the
oVirt API.
..
Patch Set 2: Code-Review+1
I think this is a good first step but the optimal sol
Keith Robertson has posted comments on this change.
Change subject: webadmin: Expose additional AuditLog fields so they are visible
in the plugin API.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19
Keith Robertson has posted comments on this change.
Change subject: supporting OVF directory structure
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18462
To unsubscribe, visit http://gerrit.ovirt.org
Keith Robertson has submitted this change and it was merged.
Change subject: supporting OVF directory structure
..
supporting OVF directory structure
Adding support for OVF directories as exported from the oVirt engine, in
add
Keith Robertson has posted comments on this change.
Change subject: WIP supporting OVF directory structure
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18462
To unsubscribe, visit http://gerrit.ovirt
Keith Robertson has posted comments on this change.
Change subject: WIP supporting OVF directory structure
..
Patch Set 1:
Core functionality looks fine. I think you'll need to modify the help and the
manpages such that it sa
Keith Robertson has posted comments on this change.
Change subject: core: AuditLogDirector.log(*) methods now update engine.log
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16188
To unsu
Keith Robertson has submitted this change and it was merged.
Change subject: core: AuditLogDirector.log(*) methods now update engine.log
..
core: AuditLogDirector.log(*) methods now update engine.log
Every event that appears in
Keith Robertson has posted comments on this change.
Change subject: core: AuditLogDirector.log(*) methods now update engine.log
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16188
To unsu
Keith Robertson has posted comments on this change.
Change subject: core: AuditLogDirector.log(*) methods now update engine.log
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16188
To unsu
Keith Robertson has posted comments on this change.
Change subject: core: AuditLogDirector.log(*) methods now update engine.log
..
Patch Set 2: (2 inline comments)
File
back
Keith Robertson has posted comments on this change.
Change subject: sos: postgresql: changed dump format to sql
..
Patch Set 2:
Eli, can you elaborate on why pg_restore doesn't like .tar format?
--
To view, visit http://gerri
Keith Robertson has posted comments on this change.
Change subject: sos: postgresql: changed dump format to sql
..
Patch Set 1: I would prefer that you didn't submit this
Please explain why .sql is easier than .tar? pg_restore
Keith Robertson has posted comments on this change.
Change subject: config: avoid to change existing configuration files
..
Patch Set 2: (1 inline comment)
File src/__main__.
Keith Robertson has posted comments on this change.
Change subject: core: modify copyright of base po
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15294
To unsubscrib
Keith Robertson has posted comments on this change.
Change subject: core: modify copyright of base po
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15295
To unsubscrib
Keith Robertson has posted comments on this change.
Change subject: core: modify copyright of base po
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15293
To unsubscrib
Keith Robertson has posted comments on this change.
Change subject: core: modify copyright of base po
..
Patch Set 1: (1 inline comment)
File po/Makevars
Line 17: # expected
Keith Robertson has posted comments on this change.
Change subject: db: drop the obfuscation of database password
..
Patch Set 3: (1 inline comment)
File src/__main__.py
Line
Keith Robertson has posted comments on this change.
Change subject: db: drop the obfuscation of database password
..
Patch Set 3: (1 inline comment)
File src/__main__.py
Line
Keith Robertson has submitted this change and it was merged.
Change subject: packaging: Fixed creating objects in an insecure way
..
packaging: Fixed creating objects in an insecure way
This patch is using a 'validate_cert_chai
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10815
To un
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 6:
argh... one more rebase please. Gerrit can't figure it out.
--
To view, visit http://ger
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 6: Verified; Looks good to me, approved
Alex,
The same logic for 'insecure' needs to be appli
Keith Robertson has submitted this change and it was merged.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files withi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13142
To unsub
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13142
To unsubscribe, vi
Keith Robertson has submitted this change and it was merged.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files withi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13141
To unsub
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13141
To unsubscribe, vi
Keith Robertson has submitted this change and it was merged.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files withi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13140
To unsubscribe, visit http://gerrit.
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13140
To unsubscribe, vi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13140
To unsubscribe, vi
Keith Robertson has posted comments on this change.
Change subject: cleanup: update .gitignore
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13083
To unsubscribe, visit http://gerrit.ovirt
Keith Robertson has submitted this change and it was merged.
Change subject: cleanup: update .gitignore
..
cleanup: update .gitignore
Change-Id: If42ce8d6e2106c529576aa6171a0f57364e14869
Signed-off-by: Alon Bar-Lev
---
M .giti
Keith Robertson has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13082
To unsubscribe, visit http://gerrit.ovir
Keith Robertson has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it
Keith Robertson has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it
Keith Robertson has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13081
To unsubscribe, visit http://gerrit.ovir
Keith Robertson has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it
Keith Robertson has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13078
To unsubscribe, visit http://gerrit.ovir
Keith Robertson has submitted this change and it was merged.
Change subject: Fixing format_ssh_command
..
Fixing format_ssh_command
format_ssh_command failed setting the Identity file
causing an error like no such file or direc
Keith Robertson has posted comments on this change.
Change subject: Fixing format_ssh_command
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13055
To unsubscribe, visit http://gerrit.ovirt.
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 5:
Verify it and I'll push it.
--
To view, visit http://gerrit.ovirt.org/10815
To unsubscrib
Keith Robertson has submitted this change and it was merged.
Change subject: tools: fixed --version output
..
tools: fixed --version output
--version previously showed 1.0.0. Now it shows the package name and
version as set in
Keith Robertson has posted comments on this change.
Change subject: tools: fixed --version output
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12735
To unsubscribe, visit http://gerrit.ov
Keith Robertson has posted comments on this change.
Change subject: tools: fixed --version output
..
Patch Set 6:
You've got to rebase again. Gerrit is complaining about conflicts. Sorry.
cheers,
Keith
--
To view, visit htt
Keith Robertson has posted comments on this change.
Change subject: Added example to man page for -N option.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12965
To unsubscribe, visit http://gerrit.ovirt.org
Keith Robertson has submitted this change and it was merged.
Change subject: Added example to man page for -N option.
..
Added example to man page for -N option.
Change-Id: I02d0a4defb248decf8464256befd94fcd3151e48
Bug-Url: htt
Keith Robertson has posted comments on this change.
Change subject: Added example to man page for -N option.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12965
To unsubscribe, visit http:
Keith Robertson has posted comments on this change.
Change subject: tools: fixed --version output
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12735
To unsubscribe, visit http://gerrit.ov
Keith Robertson has submitted this change and it was merged.
Change subject: cleanup: pep8 and pyflakes compliant
..
cleanup: pep8 and pyflakes compliant
Change-Id: I00d02ac9cddb9d3314a458fdc118cb3b63fb1774
Signed-off-by: Sandr
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 and pyflakes compliant
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12708
To unsubscribe, visit http://ge
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 compliant
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12314
To unsubscribe, visit http://gerrit.ovirt.or
Keith Robertson has submitted this change and it was merged.
Change subject: cleanup: pep8 compliant
..
cleanup: pep8 compliant
Change-Id: Ic1c47d19ba75c7b681c132d6a5738448d9a5d5b8
Signed-off-by: Sandro Bonazzola
---
M src/__m
Keith Robertson has submitted this change and it was merged.
Change subject: man page: fixed a word repetition
..
man page: fixed a word repetition
Change-Id: I97ed210a016eb04f2b9c865a4aa75ec5c402800f
Signed-off-by: Sandro Bona
Keith Robertson has posted comments on this change.
Change subject: man page: fixed a word repetition
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12750
To unsubscribe, visit http://gerrit.ovirt.org/settin
Keith Robertson has posted comments on this change.
Change subject: man page: fixed a word repetition
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12750
To unsubscribe, visit http://gerri
Keith Robertson has posted comments on this change.
Change subject: man page: fixed a word repetition
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12750
To unsubscribe, visit http://gerri
Keith Robertson has posted comments on this change.
Change subject: tools: fixed --version output
..
Patch Set 5:
Rebase to fix the conflicts and I'll push.
Cheers,
Keith
--
To view, visit http://gerrit.ovirt.org/12735
To uns
Keith Robertson has posted comments on this change.
Change subject: tools: fixed --version output
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12735
To unsubscribe, visit http://gerrit.ov
Keith Robertson has submitted this change and it was merged.
Change subject: tools: fixed command line parser setup
..
tools: fixed command line parser setup
The previous command line parser setup caused the rewrite of the
data
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://gerrit.ovirt.org/s
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 2:
Please rebase and I'll push. Cheers.
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, v
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 and pyflakes compliant
..
Patch Set 1:
Please rebase and I'll push it. Cheers.
--
To view, visit http://gerrit.ovirt.org/12708
To unsubscribe,
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 and pyflakes compliant
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12708
To unsubscribe, visit http://ge
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 compliant
..
Patch Set 1:
You need to rebase it. Unfortunately, gerrit can't do it automagically this
time.
--
To view, visit http://gerrit.ov
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 compliant
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12314
To unsubscribe, visit http://gerrit.ovirt.or
Keith Robertson has submitted this change and it was merged.
Change subject: Added logging of insufficient local space
..
Added logging of insufficient local space
When checking for space availability for decompressing the ovf
Keith Robertson has posted comments on this change.
Change subject: Added logging of insufficient local space
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12688
To unsubscribe, visit http
Keith Robertson has posted comments on this change.
Change subject: engine-log-collector - fix exit value on wrong password
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12403
To
Keith Robertson has submitted this change and it was merged.
Change subject: engine-log-collector - fix exit value on wrong password
..
engine-log-collector - fix exit value on wrong password
Removed too early exception handlin
Keith Robertson has submitted this change and it was merged.
Change subject: engine-iso-uploader - notify the user for started upload process
..
engine-iso-uploader - notify the user for started upload process
In upload_to_stor
Keith Robertson has posted comments on this change.
Change subject: engine-iso-uploader - notify the user for started upload process
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Keith Robertson has posted comments on this change.
Change subject: engine-iso-uploader - small usage's output change
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12288
To unsub
Keith Robertson has submitted this change and it was merged.
Change subject: engine-iso-uploader - small usage's output change
..
engine-iso-uploader - small usage's output change
The usage printed to the screen now says that u
Keith Robertson has submitted this change and it was merged.
Change subject: build: post ovirt-log-collector-3.2.0
..
build: post ovirt-log-collector-3.2.0
Change-Id: Ib2b3ecaab10b203f63aacf66f3fd1f9d77bb57cc
Signed-off-by: Kir
Keith Robertson has posted comments on this change.
Change subject: build: post ovirt-log-collector-3.2.0
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12069
To unsubscribe, visi
Keith Robertson has posted comments on this change.
Change subject: build: post ovirt-image-uploader-3.2.0
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12068
To unsubscribe, vis
Keith Robertson has submitted this change and it was merged.
Change subject: build: post ovirt-image-uploader-3.2.0
..
build: post ovirt-image-uploader-3.2.0
Change-Id: I69589cbd720c3c61f7b2dbe20cd8179ed6d37558
Signed-off-by: K
Keith Robertson has submitted this change and it was merged.
Change subject: build: post ovirt-iso-uploader-3.2.0
..
build: post ovirt-iso-uploader-3.2.0
Change-Id: I4b13b07e8606f1fc318c35bd597686a5f8ba562b
Signed-off-by: Kiril
Keith Robertson has posted comments on this change.
Change subject: build: post ovirt-iso-uploader-3.2.0
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12066
To unsubscribe, visit http://gerrit.ovirt.org/set
Keith Robertson has posted comments on this change.
Change subject: build: post ovirt-iso-uploader-3.2.0
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12066
To unsubscribe, visit http://ge
Keith Robertson has posted comments on this change.
Change subject: build: ovirt-log-collector-3.2.0
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12057
To unsubscribe, visit htt
Keith Robertson has submitted this change and it was merged.
Change subject: build: ovirt-log-collector-3.2.0
..
build: ovirt-log-collector-3.2.0
Change-Id: I5d136eed851c711c493fe14061050cf5f4336c35
Signed-off-by: Kiril Nesenko
Keith Robertson has posted comments on this change.
Change subject: build: ovirt-image-uploader-3.2.0
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12056
To unsubscribe, visit ht
Keith Robertson has submitted this change and it was merged.
Change subject: build: ovirt-image-uploader-3.2.0
..
build: ovirt-image-uploader-3.2.0
Change-Id: I4f320713549f1965e2d2e51f6e63f2ba820c8f8f
Signed-off-by: Kiril Nesen
Keith Robertson has posted comments on this change.
Change subject: build: ovirt-iso-uploader-3.2.0
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12054
To unsubscribe, visit http
Keith Robertson has submitted this change and it was merged.
Change subject: build: ovirt-iso-uploader-3.2.0
..
build: ovirt-iso-uploader-3.2.0
Change-Id: Ic29c76b4fa13c6588f07e01447da21e4a2736f73
Signed-off-by: Kiril Nesenko
Keith Robertson has submitted this change and it was merged.
Change subject: packaging: Updated fetching db params from pgpass
..
packaging: Updated fetching db params from pgpass
Change-Id: Ic28e0d1da86bc1a8c7ba909aad3cd541bab
Keith Robertson has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11826
To unsub
1 - 100 of 304 matches
Mail list logo
