Keith Robertson has posted comments on this change.

Change subject: Use the max=-1 option return unlimited results when calling the 
oVirt API.
......................................................................


Patch Set 2: Code-Review+1

I think this is a good first step but the optimal solution is to use 
pagination.  This solution will break down if (and it is possible) if the 
Engine is incapable of returning all results.  In those instances you need 
pagination to page through the results.

-- 
To view, visit http://gerrit.ovirt.org/19759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarw...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to