Keith Robertson has posted comments on this change.
Change subject: core: AuditLogDirector.log(*) methods now update engine.log
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
Line 478: this.callStack = callStack;
Line 479: }
Line 480:
Line 481: public String toStringForLogging() {
Line 482: StringBuilder sb = new StringBuilder();
I think that knowing certain values are Null is important. I would remove the
Null checks and just print the value (eg. Correlation ID: Null, blah: Null,).
Line 483: if(correlationId != null){
Line 484: sb.append("Corrolation ID: ");
Line 485: sb.append(correlationId);
Line 486: sb.append(", ");
Line 480:
Line 481: public String toStringForLogging() {
Line 482: StringBuilder sb = new StringBuilder();
Line 483: if(correlationId != null){
Line 484: sb.append("Corrolation ID: ");
You misspelled correlation. :)
Line 485: sb.append(correlationId);
Line 486: sb.append(", ");
Line 487: }
Line 488: if(jobId != null){
--
To view, visit http://gerrit.ovirt.org/16188
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I006229291b9a265d7fc6e1d822d2c64b2839aaff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Spenser Shumaker <sshum...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
