[Engine-patches] Change in ovirt-engine[master]: core: Use correct validation for SD selection

2014-08-30 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 11: Code-Review+1 ok, the checkstyle failed because the import+export commands should be updated as well

[Engine-patches] Change in ovirt-engine[master]: core: Use correct validation for SD selection

2014-08-30 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31488 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Use correct validation for SD selection

2014-08-30 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 11: Code-Review+1 Looks good to me, pending approval from a virt stakeholder. -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Remove BusinessEntityGuidComparator class

2014-08-30 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Remove BusinessEntityGuidComparator class .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32134 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Webadmin read reports.xml from remote repo...

2014-08-30 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: engine, webadmin: Webadmin read reports.xml from remote reports app .. Patch Set 27: Please merge this once you fix CI issue, ASAP -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: support for adding network qos for rest-api

2014-08-30 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: engine: support for adding network qos for rest-api .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/31868/6/backend/manager/modules/vdsbroker/src/test/java

[Engine-patches] Change in ovirt-engine[master]: core: fixing missing (English) AuditLog values

2014-08-30 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: fixing missing (English) AuditLog values .. Patch Set 1: Code-Review-1 (3 comments) In addition to the inline comments, i think that from user perspective w

[Engine-patches] Change in ovirt-engine[master]: engine: Add an AuditLog message when VM cannot be prestarted

2014-08-30 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Add an AuditLog message when VM cannot be prestarted .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32029/3/backend/manager/modules/bll/src/main

[Engine-patches] Change in ovirt-engine[master]: core: Use correct validation for SD selection

2014-08-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 11: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Use correct validation for SD selection

2014-08-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/91

[Engine-patches] Change in ovirt-engine[master]: core: Use correct validation for SD selection

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 11: * Update tracker::#1119022::OK * Check Bug-Url::OK * Check Public Bug::#1119022::OK, public

[Engine-patches] Change in ovirt-engine[master]: engine:slave's mac in Broker, to lower case

2014-08-30 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine:slave's mac in Broker, to lower case .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31872/2/backend/manager/modules/vdsbroker/src/ma

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Use correct validation for SD selection

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 1: * Update tracker::#1119022::OK -- To view, visit http://gerrit.ovirt.org/32171 To unsubscr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Use correct validation for SD selection

2014-08-30 Thread vvolansk
Vered Volansky has abandoned this change. Change subject: core: Use correct validation for SD selection .. Abandoned too soon -- To view, visit http://gerrit.ovirt.org/32171 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Use correct validation for SD selection

2014-08-30 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32171 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Use correct validation for SD selection

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 1: Verified-1 * Update tracker::#1119022::OK * Check Bug-Url::OK * Check Public Bug::#1119022::

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Use correct validation for SD selection

2014-08-30 Thread vvolansk
Vered Volansky has uploaded a new change for review. Change subject: core: Use correct validation for SD selection .. core: Use correct validation for SD selection When creating a snapshot, use new storage allocation validations

[Engine-patches] Change in ovirt-engine[master]: core: Use correct validation for SD selection

2014-08-30 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Use correct validation for SD selection .. Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/31488/10/backend/manager/modules/bll/src/main/java/org/

[Engine-patches] Change in ovirt-engine[master]: ui: validate field fix in add Provider form

2014-08-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ui: validate field fix in add Provider form .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: ui: Adding fields validation in addHost form

2014-08-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ui: Adding fields validation in addHost form .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: ui: validate field fix in add Provider form

2014-08-30 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: ui: validate field fix in add Provider form .. ui: validate field fix in add Provider form 1. On test fail if authentication parameters are missing 2. Don't ac

[Engine-patches] Change in ovirt-engine[master]: ui: validate field fix in add Provider form

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: ui: validate field fix in add Provider form .. Patch Set 1: * Update tracker::#1125961::OK * Check Bug-Url::OK * Check Public Bug::#1125961::OK, public bu

[Engine-patches] Change in ovirt-engine[master]: ui: Adding fields validation in addHost form

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: ui: Adding fields validation in addHost form .. Patch Set 8: * Update tracker::#1127606::OK * Check Bug-Url::OK * Check Public Bug::#1127606::OK, public b

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Initialize internal lists in IscsiBond

2014-08-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Initialize internal lists in IscsiBond .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-from-3.3_merged/361/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi:Fix CRUD operations for iSCSI Storage connection.

2014-08-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi:Fix CRUD operations for iSCSI Storage connection. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-from-3.3

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi:Fix CRUD operations for iSCSI Storage connection.

2014-08-30 Thread oourfali
Oved Ourfali has submitted this change and it was merged. Change subject: restapi:Fix CRUD operations for iSCSI Storage connection. .. restapi:Fix CRUD operations for iSCSI Storage connection. 1) renaming class BackendIscsiBond

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Initialize internal lists in IscsiBond

2014-08-30 Thread oourfali
Oved Ourfali has submitted this change and it was merged. Change subject: core: Initialize internal lists in IscsiBond .. core: Initialize internal lists in IscsiBond Initialize the storage domains and the networks when fectchi

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Initialize internal lists in IscsiBond

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Initialize internal lists in IscsiBond .. Patch Set 1: * Update tracker::#1133279::OK * Check TR::#1133279::OK * Set MODIFIED::bug 1133279#11332

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi:Fix CRUD operations for iSCSI Storage connection.

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi:Fix CRUD operations for iSCSI Storage connection. .. Patch Set 1: * Update tracker::#1133896::OK * Check TR::#1133896::OK * Set MODIFIED::bug 1133

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Initialize internal lists in IscsiBond

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Initialize internal lists in IscsiBond .. Patch Set 1: -Verified * Update tracker::#1133279::OK * Check Bug-Url::OK * Check Public Bug::#1133279::OK

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Initialize internal lists in IscsiBond

2014-08-30 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: Initialize internal lists in IscsiBond .. Patch Set 1: Rerun-Hooks: all -- To view, visit http://gerrit.ovirt.org/32128 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi:Fix CRUD operations for iSCSI Storage connection.

2014-08-30 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: restapi:Fix CRUD operations for iSCSI Storage connection. .. Patch Set 1: Rerun-Hooks: all -- To view, visit http://gerrit.ovirt.org/32129 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi:Fix CRUD operations for iSCSI Storage connection.

2014-08-30 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi:Fix CRUD operations for iSCSI Storage connection. .. Patch Set 1: -Verified * Update tracker::#1133896::OK * Check Bug-Url::OK * Check Public Bug: