Moti Asayag has posted comments on this change. Change subject: core: fixing missing (English) AuditLog values ......................................................................
Patch Set 1: Code-Review-1 (3 comments) In addition to the inline comments, i think that from user perspective we should name the "audit log" as "event log" since the audit-log is an internal implementation details and from UI/API pov, the user refers to them as "Events". http://gerrit.ovirt.org/#/c/31898/1/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 865: MAC_POOL_REMOVE_FAILED=Failed to remove MAC Pool '${MacPoolName}' (id=${MacPoolId}). (User: ${UserName}) Line 866: DWH_STOPPED=History Service stopped. Line 867: DWH_STARTED=History Service started. Line 868: DWH_ERROR=Error in History Service. Line 869: USER_REMOVE_AUDIT_LOG=Audit log message was removed by User ${UserName}. please add the audit log id to the message. Line 870: USER_REMOVE_AUDIT_LOG_FAILED=User ${UserName} failed to remove audit log message. Line 871: USER_CLEAR_ALL_DISMISSED_AUDIT_LOG=User ${UserName} had restored all deleted audit log messages. Line 866: DWH_STOPPED=History Service stopped. Line 867: DWH_STARTED=History Service started. Line 868: DWH_ERROR=Error in History Service. Line 869: USER_REMOVE_AUDIT_LOG=Audit log message was removed by User ${UserName}. Line 870: USER_REMOVE_AUDIT_LOG_FAILED=User ${UserName} failed to remove audit log message. please add the audit log id to the message, so the admin will be able to handle this issue, else the message is too vague. Line 871: USER_CLEAR_ALL_DISMISSED_AUDIT_LOG=User ${UserName} had restored all deleted audit log messages. Line 872: i please add a space between $(UserName) to "failed" -- To view, visit http://gerrit.ovirt.org/31898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74a08a8c7d5f18707bf8cbcac5d9d169c5556def Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
