Moti Asayag has posted comments on this change. Change subject: engine:slave's mac in Broker, to lower case ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31872/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1435: iface.setSubnet((String) nic.get("netmask")); Line 1436: iface.setMacAddress((String) nic.get("hwaddr")); Line 1437: // if we get "permhwaddr", we are a part of a bond and we use that as the mac address Line 1438: if (nic.get("permhwaddr") != null) { Line 1439: // in older VDSM version, slave's Mac is in upper case do we know since when it is always reported in upper-case, so we can remove this block when is no longer required ? Line 1440: String macUpperCase = (String) nic.get("permhwaddr"); Line 1441: iface.setMacAddress(macUpperCase.toLowerCase()); Line 1442: } Line 1443: if (StringUtils.isNotBlank((String) nic.get(VdsProperties.MTU))) { -- To view, visit http://gerrit.ovirt.org/31872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ec2c04bca879c97835d95330c130f2a4ca16587 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
