Oved Ourfali has submitted this change and it was merged.
Change subject: restapi:Fix CRUD operations for iSCSI Storage connection.
......................................................................
restapi:Fix CRUD operations for iSCSI Storage connection.
1) renaming class BackendIscsiBondStorageServerConnection to
BackendIscsiBondStorageConnectionResource to be compatible with the
plural resource name
2) Fix remove and get operations for Storage Connection in IscsiBond
3) Adding appropriate tests for resource commands in REST.
Usages:
Get a list of Storage Connections contained in the iSCSI bond:
Get
/api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/
Get a specific Storage Connection in the iSCSI bond:
Get
/api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/{storage_id}/
Adding a new Storage Connection to an existing iSCSI Bond:
POST /api/datacenters/{datacenter_id}/iscsibonds HTTP/1.1
Accept: application/xml
<storage_connection id="{connection_id}"></storage_connection>
Remove a Storage Connection from the existing iSCSi Bond:
DELETE
/api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}/storageconnections/{storage_id}/
HTTP/1.1
Change-Id: I2424067b4371b6a99f61ea687155c4082855aff5
Bug-Url: https://bugzilla.redhat.com/1133896
Signed-off-by: Maor Lipchuk <[email protected]>
---
A
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java
D
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageServerConnection.java
A
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionResourceTest.java
A
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResourceTest.java
5 files changed, 288 insertions(+), 30 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/32129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2424067b4371b6a99f61ea687155c4082855aff5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
